diff --git a/clang/lib/Sema/SemaCast.cpp b/clang/lib/Sema/SemaCast.cpp index f184eda2f273..7a1d52ad4ea8 100644 --- a/clang/lib/Sema/SemaCast.cpp +++ b/clang/lib/Sema/SemaCast.cpp @@ -2803,6 +2803,14 @@ void CastOperation::CheckBuiltinBitCast() { SrcExpr = Self.CreateMaterializeTemporaryExpr(SrcType, SrcExpr.get(), /*IsLValueReference=*/false); + if (Self.RequireCompleteType(OpRange.getBegin(), DestType, + diag::err_typecheck_cast_to_incomplete) || + Self.RequireCompleteType(OpRange.getBegin(), SrcType, + diag::err_incomplete_type)) { + SrcExpr = ExprError(); + return; + } + CharUnits DestSize = Self.Context.getTypeSizeInChars(DestType); CharUnits SourceSize = Self.Context.getTypeSizeInChars(SrcType); if (DestSize != SourceSize) { diff --git a/clang/test/SemaCXX/builtin-bit-cast.cpp b/clang/test/SemaCXX/builtin-bit-cast.cpp index 3dddadc5617f..87919d9d9d28 100644 --- a/clang/test/SemaCXX/builtin-bit-cast.cpp +++ b/clang/test/SemaCXX/builtin-bit-cast.cpp @@ -37,3 +37,12 @@ constexpr unsigned long ul = __builtin_bit_cast(unsigned long, not_trivially_cop // expected-error@+1 {{__builtin_bit_cast destination type must be trivially copyable}} constexpr long us = __builtin_bit_cast(unsigned long &, 0L); + +namespace PR42936 { +template struct S { int m; }; + +extern S extern_decl; + +int x = __builtin_bit_cast(int, extern_decl); +S y = __builtin_bit_cast(S, 0); +}