Skip the asm prefix when storing the name in block info.

- Otherwise we emit internal names with embedded '\01' characters,
   which confuses some tools.

 - Ideally all the code which wants to get a "display name" for the
   given function should follow one code path, but this should be a
   monotonic improvement for now.

llvm-svn: 71774
This commit is contained in:
Daniel Dunbar 2009-05-14 16:42:16 +00:00
parent d9034f0b89
commit 0a2171ccd5
2 changed files with 16 additions and 3 deletions

View File

@ -140,7 +140,7 @@ public:
/// BlockLiteralTy - The type of the block literal. /// BlockLiteralTy - The type of the block literal.
const llvm::Type *BlockLiteralTy; const llvm::Type *BlockLiteralTy;
/// Name - the name of the function this block was created for, if any /// Name - the name of the function this block was created for, if any.
const char *Name; const char *Name;
/// ByCopyDeclRefs - Variables from parent scopes that have been imported /// ByCopyDeclRefs - Variables from parent scopes that have been imported
@ -152,7 +152,11 @@ public:
llvm::SmallVector<const BlockDeclRefExpr *, 8> ByRefDeclRefs; llvm::SmallVector<const BlockDeclRefExpr *, 8> ByRefDeclRefs;
BlockInfo(const llvm::Type *blt, const char *n) BlockInfo(const llvm::Type *blt, const char *n)
: BlockLiteralTy(blt), Name(n) {} : BlockLiteralTy(blt), Name(n) {
// Skip asm prefix, if any.
if (Name && Name[0] == '\01')
++Name;
}
}; };
CGBuilderTy &Builder; CGBuilderTy &Builder;

View File

@ -1,4 +1,4 @@
// RUN: clang-cc -emit-llvm -fblocks -S -o - %s // RUN: clang-cc -triple i386-apple-darwin9 -emit-llvm -fblocks -o %t %s &&
// rdar://6676764 // rdar://6676764
struct S { struct S {
@ -19,9 +19,18 @@ void foo(T *P) {
-(void) im0; -(void) im0;
@end @end
// RUN: grep 'define internal i32 @"__-\[A im0\]_block_invoke_"' %t &&
@implementation A
-(void) im0 {
(void) ^{ return 1; }();
}
@end
@interface B : A @end @interface B : A @end
@implementation B @implementation B
-(void) im1 { -(void) im1 {
^(void) { [super im0]; }(); ^(void) { [super im0]; }();
} }
@end @end
// RUN: true