diff --git a/mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td b/mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td index 8b16fcd77be1..3334995cc9fe 100644 --- a/mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td +++ b/mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td @@ -262,9 +262,13 @@ def SPV_LoadOp : SPV_Op<"Load", []> { SPV_Type:$value ); - let builders = [OpBuilder<[{Builder *builder, OperationState &state, - Value basePtr, /*optional*/IntegerAttr memory_access, - /*optional*/IntegerAttr alignment}]>]; + let builders = [ + OpBuilder<[{ + Builder *builder, OperationState &state, + Value basePtr, IntegerAttr memory_access = {}, + IntegerAttr alignment = {} + }]> + ]; } // ----- @@ -358,7 +362,7 @@ def SPV_StoreOp : SPV_Op<"Store", []> { let builders = [ OpBuilder<"Builder *builder, OperationState &state, " - "Value ptr, Value value, ArrayRef namedAttrs", [{ + "Value ptr, Value value, ArrayRef namedAttrs = {}", [{ state.addOperands(ptr); state.addOperands(value); state.addAttributes(namedAttrs); diff --git a/mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp b/mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp index d1011dcae0dd..0eefa02abf7d 100644 --- a/mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp +++ b/mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp @@ -334,9 +334,7 @@ LoadOpConversion::matchAndRewrite(LoadOp loadOp, ArrayRef operands, auto loadPtr = getElementPtr(rewriter, typeConverter, loadOp.getLoc(), loadOp.memref().getType().cast(), loadOperands.memref(), loadOperands.indices()); - rewriter.replaceOpWithNewOp(loadOp, loadPtr, - /*memory_access =*/nullptr, - /*alignment =*/nullptr); + rewriter.replaceOpWithNewOp(loadOp, loadPtr); return matchSuccess(); } @@ -381,9 +379,7 @@ StoreOpConversion::matchAndRewrite(StoreOp storeOp, ArrayRef operands, storeOp.memref().getType().cast(), storeOperands.memref(), storeOperands.indices()); rewriter.replaceOpWithNewOp(storeOp, storePtr, - storeOperands.value(), - /*memory_access =*/nullptr, - /*alignment =*/nullptr); + storeOperands.value()); return matchSuccess(); } diff --git a/mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp b/mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp index 100d4c95fcb3..35eb7e1e00a2 100644 --- a/mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp +++ b/mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp @@ -288,9 +288,7 @@ Value mlir::spirv::getBuiltinVariableValue(Operation *op, spirv::GlobalVariableOp varOp = getOrInsertBuiltinVariable(moduleOp, op->getLoc(), builtin, builder); Value ptr = builder.create(op->getLoc(), varOp); - return builder.create(op->getLoc(), ptr, - /*memory_access =*/nullptr, - /*alignment =*/nullptr); + return builder.create(op->getLoc(), ptr); } //===----------------------------------------------------------------------===// diff --git a/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp b/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp index d8163a7a934c..a4234faf863c 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp @@ -191,9 +191,7 @@ FuncOpLowering::matchAndRewrite(FuncOp funcOp, ArrayRef operands, spirv::ConstantOp::getZero(indexType, funcOp.getLoc(), &rewriter); auto loadPtr = rewriter.create( funcOp.getLoc(), replacement, zero.constant()); - replacement = rewriter.create(funcOp.getLoc(), loadPtr, - /*memory_access=*/nullptr, - /*alignment=*/nullptr); + replacement = rewriter.create(funcOp.getLoc(), loadPtr); } signatureConverter.remapInput(argType.index(), replacement); }