maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Only apply the devirtualization bonus once instead of per-call site in the 

target function.

Fixes part of rdar://8546196

llvm-svn: 124044
This commit is contained in:
Eric Christopher 2011-01-22 21:17:33 +00:00
parent 703d6e62d0
commit 08e8b3b629
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/Analysis/InlineCost.cpp
View File

@ -146,17 +146,18 @@ void CodeMetrics::analyzeBasicBlock(const BasicBlock *BB) {
// performance boost we can expect if the specified value is constant. // performance boost we can expect if the specified value is constant.
unsigned CodeMetrics::CountBonusForConstant(Value *V) { unsigned CodeMetrics::CountBonusForConstant(Value *V) {
unsigned Bonus = 0; unsigned Bonus = 0;
bool indirectCallBonus = false;
for (Value::use_iterator UI = V->use_begin(), E = V->use_end(); UI != E;++UI){ for (Value::use_iterator UI = V->use_begin(), E = V->use_end(); UI != E;++UI){
User *U = *UI; User *U = *UI;
if (CallInst *CI = dyn_cast<CallInst>(U)) { if (CallInst *CI = dyn_cast<CallInst>(U)) {
// Turning an indirect call into a direct call is a BIG win // Turning an indirect call into a direct call is a BIG win
if (CI->getCalledValue() == V) if (CI->getCalledValue() == V)
Bonus += InlineConstants::IndirectCallBonus; indirectCallBonus = true;
} }
else if (InvokeInst *II = dyn_cast<InvokeInst>(U)) { else if (InvokeInst *II = dyn_cast<InvokeInst>(U)) {
// Turning an indirect call into a direct call is a BIG win // Turning an indirect call into a direct call is a BIG win
if (II->getCalledValue() == V) if (II->getCalledValue() == V)
Bonus += InlineConstants::IndirectCallBonus; indirectCallBonus = true;
} }
// FIXME: Eliminating conditional branches and switches should // FIXME: Eliminating conditional branches and switches should
// also yield a per-call performance boost. // also yield a per-call performance boost.
@ -187,6 +188,9 @@ unsigned CodeMetrics::CountBonusForConstant(Value *V) {
Bonus += CountBonusForConstant(&Inst); Bonus += CountBonusForConstant(&Inst);
} }
} }
if (indirectCallBonus) Bonus += InlineConstants::IndirectCallBonus;
return Bonus; return Bonus;
} }