maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Cleanup the parameter naming style. 

llvm-svn: 133120
This commit is contained in:
Chandler Carruth 2011-06-16 01:05:08 +00:00
parent 6e4ef20baf
commit 08dc2ba4df
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang/lib/Sema/SemaExpr.cpp
View File

@ -6364,13 +6364,13 @@ static bool ExprLooksBoolean(Expr *E) {
/// "int x = a + someBinaryCondition ? 1 : 2".
static void DiagnoseConditionalPrecedence(Sema &Self,
SourceLocation OpLoc,
Expr *cond,
Expr *lhs,
Expr *rhs) {
Expr *Condition,
Expr *LHS,
Expr *RHS) {
BinaryOperatorKind CondOpcode;
Expr *CondRHS;
if (!IsArithmeticBinaryExpr(cond, &CondOpcode, &CondRHS))
if (!IsArithmeticBinaryExpr(Condition, &CondOpcode, &CondRHS))
return;
if (!ExprLooksBoolean(CondRHS))
return;
@ -6379,21 +6379,21 @@ static void DiagnoseConditionalPrecedence(Sema &Self,
// hand side that looks boolean, so warn.
PartialDiagnostic Warn = Self.PDiag(diag::warn_precedence_conditional)
<< cond->getSourceRange()
<< Condition->getSourceRange()
<< BinaryOperator::getOpcodeStr(CondOpcode);
PartialDiagnostic FirstNote =
Self.PDiag(diag::note_precedence_conditional_silence)
<< BinaryOperator::getOpcodeStr(CondOpcode);
SourceRange FirstParenRange(cond->getLocStart(),
cond->getLocEnd());
SourceRange FirstParenRange(Condition->getLocStart(),
Condition->getLocEnd());
PartialDiagnostic SecondNote =
Self.PDiag(diag::note_precedence_conditional_first);
SourceRange SecondParenRange(CondRHS->getLocStart(),
rhs->getLocEnd());
RHS->getLocEnd());
SuggestParentheses(Self, OpLoc, Warn, FirstNote, FirstParenRange,
SecondNote, SecondParenRange);