maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[asan] Fix GlobalAddressDescription::Print() 

Summary: Check bug_type for nullptr before calling internal_strcmp

Reviewers: kcc, vitalybuka, eugenis

Subscribers: kubabrecka, llvm-commits

Differential Revision: https://reviews.llvm.org/D24773

llvm-svn: 282012
This commit is contained in:
Filipe Cabecinhas 2016-09-20 20:33:18 +00:00
parent c154f7bc37
commit 08c1eb9b63
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compiler-rt/lib/asan/asan_descriptions.cc
View File

@ -323,7 +323,8 @@ void ShadowAddressDescription::Print() const {
void GlobalAddressDescription::Print(const char *bug_type) const {
for (int i = 0; i < size; i++) {
DescribeAddressRelativeToGlobal(addr, access_size, globals[i]);
if (0 == internal_strcmp(bug_type, "initialization-order-fiasco") &&
if (bug_type &&
0 == internal_strcmp(bug_type, "initialization-order-fiasco") &&
reg_sites[i]) {
Printf(" registered at:\n");
StackDepotGet(reg_sites[i]).Print();

12
compiler-rt/test/asan/TestCases/global-address.cpp Normal file
View File

@ -0,0 +1,12 @@
// RUN: %clangxx_asan -o %t %s
// RUN: not %run %t 2>&1 | FileCheck %s
#include <sanitizer/allocator_interface.h>
int g_i = 42;
int main() {
// CHECK: AddressSanitizer: attempting to call __sanitizer_get_allocated_size() for pointer which is not owned
// CHECK-NOT: ASAN:DEADLYSIGNAL
// CHECK: SUMMARY: AddressSanitizer: bad-__sanitizer_get_allocated_size
// CHECK-NOT: ASAN:DEADLYSIGNAL
return (int)__sanitizer_get_allocated_size(&g_i);
}