maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NFC] [stack-safety] remove unused return value.

This commit is contained in:
Florian Mayer 2021-09-09 10:04:06 +01:00
parent c31a202233
commit 08b4dd8b24
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
llvm/lib/Analysis/StackSafetyAnalysis.cpp
View File

@ -242,7 +242,7 @@ class StackSafetyLocalAnalysis {
ConstantRange getMemIntrinsicAccessRange(const MemIntrinsic *MI, const Use &U, ConstantRange getMemIntrinsicAccessRange(const MemIntrinsic *MI, const Use &U,
Value *Base); Value *Base);
bool analyzeAllUses(Value *Ptr, UseInfo<GlobalValue> &AS, void analyzeAllUses(Value *Ptr, UseInfo<GlobalValue> &AS,
const StackLifetime &SL); const StackLifetime &SL);
public: public:
@ -328,7 +328,7 @@ ConstantRange StackSafetyLocalAnalysis::getMemIntrinsicAccessRange(
/// The function analyzes all local uses of Ptr (alloca or argument) and /// The function analyzes all local uses of Ptr (alloca or argument) and
/// calculates local access range and all function calls where it was used. /// calculates local access range and all function calls where it was used.
bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr, void StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
UseInfo<GlobalValue> &US, UseInfo<GlobalValue> &US,
const StackLifetime &SL) { const StackLifetime &SL) {
SmallPtrSet<const Value *, 16> Visited; SmallPtrSet<const Value *, 16> Visited;
@ -350,7 +350,7 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
case Instruction::Load: { case Instruction::Load: {
if (AI && !SL.isAliveAfter(AI, I)) { if (AI && !SL.isAliveAfter(AI, I)) {
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
US.updateRange( US.updateRange(
getAccessRange(UI, Ptr, DL.getTypeStoreSize(I->getType()))); getAccessRange(UI, Ptr, DL.getTypeStoreSize(I->getType())));
@ -364,11 +364,11 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
if (V == I->getOperand(0)) { if (V == I->getOperand(0)) {
// Stored the pointer - conservatively assume it may be unsafe. // Stored the pointer - conservatively assume it may be unsafe.
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
if (AI && !SL.isAliveAfter(AI, I)) { if (AI && !SL.isAliveAfter(AI, I)) {
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
US.updateRange(getAccessRange( US.updateRange(getAccessRange(
UI, Ptr, DL.getTypeStoreSize(I->getOperand(0)->getType()))); UI, Ptr, DL.getTypeStoreSize(I->getOperand(0)->getType())));
@ -380,7 +380,7 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
// FIXME: Process parameters correctly. This is a leak only if we return // FIXME: Process parameters correctly. This is a leak only if we return
// alloca. // alloca.
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
case Instruction::Call: case Instruction::Call:
case Instruction::Invoke: { case Instruction::Invoke: {
@ -389,7 +389,7 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
if (AI && !SL.isAliveAfter(AI, I)) { if (AI && !SL.isAliveAfter(AI, I)) {
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
if (const MemIntrinsic *MI = dyn_cast<MemIntrinsic>(I)) { if (const MemIntrinsic *MI = dyn_cast<MemIntrinsic>(I)) {
@ -400,7 +400,7 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
const auto &CB = cast<CallBase>(*I); const auto &CB = cast<CallBase>(*I);
if (!CB.isArgOperand(&UI)) { if (!CB.isArgOperand(&UI)) {
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
unsigned ArgNo = CB.getArgOperandNo(&UI); unsigned ArgNo = CB.getArgOperandNo(&UI);
@ -417,7 +417,7 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
dyn_cast<GlobalValue>(CB.getCalledOperand()->stripPointerCasts()); dyn_cast<GlobalValue>(CB.getCalledOperand()->stripPointerCasts());
if (!Callee) { if (!Callee) {
US.updateRange(UnknownRange); US.updateRange(UnknownRange);
return false; return;
} }
assert(isa<Function>(Callee) || isa<GlobalAlias>(Callee)); assert(isa<Function>(Callee) || isa<GlobalAlias>(Callee));
@ -435,8 +435,6 @@ bool StackSafetyLocalAnalysis::analyzeAllUses(Value *Ptr,
} }
} }
} }
return true;
} }
FunctionInfo<GlobalValue> StackSafetyLocalAnalysis::run() { FunctionInfo<GlobalValue> StackSafetyLocalAnalysis::run() {