Removed option "-parse-ast-check" from clang driver. This is now implemented

using "-parse-ast -verify".

Updated all test cases (using a sed script) that invoked -parse-ast-check to
now use -parse-ast -verify.

Fixed a bug where using "-verify" instead of "-parse-ast-check" would not
correctly create the DiagClient needed to accumulate diagnostics.

llvm-svn: 42365

clang/Driver/clang.cpp

@@ -53,7 +53,6 @@ enum ProgActions {
   ParseASTPrint,                // Parse ASTs and print them.
   ParseASTDump,                 // Parse ASTs and dump them.
   ParseASTView,                 // Parse ASTs and view them in Graphviz.
-  ParseASTCheck,                // Parse ASTs and check diagnostics.
   BuildAST,                     // Parse ASTs.  
   ParseCFGDump,                 // Parse ASTS. Build CFGs. Print CFGs.
   ParseCFGView,                 // Parse ASTS. Build CFGs. View CFGs.
@@ -93,8 +92,6 @@ ProgAction(llvm::cl::desc("Choose output type:"), llvm::cl::ZeroOrMore,
                         "Run parser, build ASTs, then dump them"),
              clEnumValN(ParseASTView, "parse-ast-view",
                         "Run parser, build ASTs, and view them with GraphViz."),
-             clEnumValN(ParseASTCheck, "parse-ast-check",
-                        "Run parser, build ASTs, then check diagnostics"),
              clEnumValN(ParseCFGDump, "dump-cfg",
                         "Run parser, then build and print CFGs."),
              clEnumValN(ParseCFGView, "view-cfg",
@@ -809,7 +806,6 @@ static void ProcessInputFile(Preprocessor &PP, unsigned MainFileID,
 
   ASTConsumer* Consumer = NULL;
   bool ClearSourceMgr = false;
-  bool PerformDiagnosticsCheck = VerifyDiagnostics;
   
   switch (ProgAction) {
   default:
@@ -853,8 +849,6 @@ static void ProcessInputFile(Preprocessor &PP, unsigned MainFileID,
     ClearSourceMgr = true;
     break;
       
-  case ParseASTCheck:
-    PerformDiagnosticsCheck = true;
   case ParseSyntaxOnly:              // -fsyntax-only
   case BuildAST:
     Consumer = new ASTConsumer();
@@ -895,7 +889,7 @@ static void ProcessInputFile(Preprocessor &PP, unsigned MainFileID,
   }
   
   if (Consumer) {
-    if (PerformDiagnosticsCheck)
+    if (VerifyDiagnostics)
       exit (CheckASTConsumer(PP, MainFileID, Consumer));
     else
       ParseAST(PP, MainFileID, *Consumer, Stats);
@@ -948,7 +942,7 @@ int main(int argc, char **argv) {
   InitializeLanguageStandard(LangInfo);
 
   std::auto_ptr<TextDiagnostics> DiagClient;
-  if (ProgAction != ParseASTCheck) {
+  if (!VerifyDiagnostics) {
     // Print diagnostics to stderr by default.
     DiagClient.reset(new TextDiagnosticPrinter(SourceMgr));
   } else {
@@ -957,7 +951,7 @@ int main(int argc, char **argv) {
    
     if (InputFilenames.size() != 1) {
       fprintf(stderr,
-              "parse-ast-check only works on single input files for now.\n");
+              "-verify only works on single input files for now.\n");
       return 1;
     }
   }

clang/test/Lexer/block_cmt_end.c

@@ -3,7 +3,7 @@
   RUN: clang -E %s | grep foo &&
   RUN: clang -E %s | not grep abc &&
   RUN: clang -E %s | not grep xyz &&
-  RUN: clang -parse-ast-check %s
+  RUN: clang -parse-ast -verify %s
  */
 
 // This is a simple comment, /*/ does not end a comment, the trailing */ does.

clang/test/Lexer/constants.c

@@ -1,4 +1,4 @@
-/* RUN: clang -parse-ast-check %s
+/* RUN: clang -parse-ast -verify %s
  */
 
 int x = 000000080;  /* expected-error {{invalid digit}} */

clang/test/Lexer/cxx0x_keyword.cpp

@@ -1,2 +1,2 @@
-// RUN: clang -parse-ast-check -std=c++0x %s 2>&1
+// RUN: clang -parse-ast -verify -std=c++0x %s 2>&1
 int static_assert; /* expected-error {{expected identifier or '('}}} */

clang/test/Misc/diag-checker.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 #include <stdio.h>
 

clang/test/Parser/CompoundStmtScope.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int foo() {
   {

clang/test/Parser/argument_redef.c

@@ -1,4 +1,4 @@
-/* RUN: clang -parse-ast-check %s
+/* RUN: clang -parse-ast -verify %s
 */
 
 int foo(int A) { /* expected-error {{previous definition is here}} */

clang/test/Parser/attributes.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s -pedantic
+// RUN: clang -parse-ast -verify %s -pedantic
 
 static __inline void __attribute__((__always_inline__, __nodebug__)) // expected-warning {{extension used}}
 foo (void)

clang/test/Parser/bad-control.c

@@ -1,4 +1,4 @@
-/* RUN: clang -parse-ast-check %s
+/* RUN: clang -parse-ast -verify %s
 */
 int foo() { 
   break; /* expected-error {{'break' statement not in loop or switch statement}} */

clang/test/Parser/builtin_classify_type.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 struct foo { int a; };
 

clang/test/Parser/builtin_types_compatible.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 extern int funcInt(int);
 extern float funcFloat(float);

clang/test/Parser/check_cast.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 struct foo {
   int a;
 };

clang/test/Parser/compound_literal.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 int main() {
   char *s;
   s = (char []){"whatever"}; 

clang/test/Parser/cxx-reference.cpp

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 extern char *bork;
 char *& bar = bork;

clang/test/Parser/goto-ident.c

@@ -1,4 +1,4 @@
-/* RUN: clang -parse-ast-check %s
+/* RUN: clang -parse-ast -verify %s
 */
 
 void foo() { 

clang/test/Parser/if-scope-c90.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check --std=c90 %s
+// RUN: clang -parse-ast -verify --std=c90 %s
 
 int f (int z)
 { 

clang/test/Parser/if-scope-c99.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check --std=c99 %s
+// RUN: clang -parse-ast -verify --std=c99 %s
 
 int f (int z)
 { 

clang/test/Parser/implicit-casts.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 _Complex double X;
 void test1(int c) {
   X = 5;

clang/test/Parser/ocu_vector_components.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 typedef __attribute__(( ocu_vector_type(2) )) float float2;
 typedef __attribute__(( ocu_vector_type(3) )) float float3;

clang/test/Parser/parmvardecl_conversion.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 void f (int p[]) { p++; }
 

clang/test/Parser/pointer-arithmetic.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int *test1(int *a)         { return a + 1; }
 int *test2(int *a)         { return 1 + a; }

clang/test/Parser/pointer_promotion.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int test() {
   void *vp;

clang/test/Parser/recovery-1.c

@@ -1,5 +1,5 @@
 // RUN: clang -fsyntax-only -fno-caret-diagnostics -pedantic %s 2>&1 | grep warning | wc -l | grep 1
-// RUN: clang -parse-ast-check -pedantic %s
+// RUN: clang -parse-ast -verify -pedantic %s
 
 char ((((                       /* expected-error {{to match this '('}} */
 *X x ] ))));                    /* expected-error {{expected ')'}} */

clang/test/Parser/typeof.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 typedef int TInt;
 

clang/test/Sema/arg-duplicate.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 typedef int x; 
 int f3(y, x, 

clang/test/Sema/arg-invalid.c

@@ -1,4 +1,4 @@
-// RUN: clang %s -parse-ast-check
+// RUN: clang %s -parse-ast -verify
 
 void bar (void *); 
 void f11 (z)       // expected-error {{may not have 'void' type}}

clang/test/Sema/array-constraint.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check -pedantic %s
+// RUN: clang -parse-ast -verify -pedantic %s
 
 struct s; 
 struct s* t (struct s z[]) {   // expected-error {{array has incomplete element type}}

clang/test/Sema/array-init.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check -pedantic %s
+// RUN: clang -parse-ast -verify -pedantic %s
 
 extern int foof() = 1; // expected-error{{illegal initializer (only variables can be initialized)}}
 

clang/test/Sema/assign.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 void *test1(void) { return 0; }
 

clang/test/Sema/c89.c

@@ -1,4 +1,4 @@
-/* RUN: clang %s -std=c89 -pedantic -parse-ast-check
+/* RUN: clang %s -std=c89 -pedantic -parse-ast -verify
  */
 void test1() {
   {

clang/test/Sema/cfstring.c

@@ -1,6 +1,6 @@
 #define CFSTR __builtin___CFStringMakeConstantString
 
-// RUN: clang %s -parse-ast-check
+// RUN: clang %s -parse-ast -verify
 void f() {
   CFSTR("\242"); // expected-warning { CFString literal contains non-ASCII character }
   CFSTR("\0"); // expected-warning { CFString literal contains NUL character }

clang/test/Sema/compare.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int test(char *C) { // nothing here should warn.
   return C != ((void*)0);

clang/test/Sema/decl-invalid.c

@@ -1,3 +1,3 @@
-// RUN: clang %s -parse-ast-check
+// RUN: clang %s -parse-ast -verify
 
 typedef union <anonymous> __mbstate_t;  // expected-error: {{expected identifier or}}

clang/test/Sema/default.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 void f5 (int z) { 
   if (z) 

clang/test/Sema/enum.c

@@ -1,4 +1,4 @@
-// RUN: clang %s -parse-ast-check -pedantic
+// RUN: clang %s -parse-ast -verify -pedantic
 
 enum e {A, 
         B = 42LL << 32,        // expected-warning {{ISO C restricts enumerator values to range of 'int'}}

clang/test/Sema/floating-point-compare.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int foo(float x, float y) {
   return x == y; // expected-warning {{comparing floating point with ==}}
@@ -6,4 +6,4 @@ int foo(float x, float y) {
 
 int bar(float x, float y) {
   return x != y; // expected-warning {{comparing floating point with ==}}
-}
+}

clang/test/Sema/for.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 // Check C99 6.8.5p3
 void b1 (void) { for (void (*f) (void);;); }

clang/test/Sema/format-strings.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 #include <stdio.h>
 #include <stdarg.h>

clang/test/Sema/offsetof.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER)
 

clang/test/Sema/return-stack-addr.cpp

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 
 int* ret_local() {
@@ -110,4 +110,4 @@ int* ret_cpp_const_cast(const x) {
 }
 
 // TODO: test case for dynamic_cast.  clang does not yet have
-// support for C++ classes to write such a test case.
+// support for C++ classes to write such a test case.

clang/test/Sema/switch-duplicate-defaults.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 void f (int z) { 
   switch(z) {

clang/test/Sema/switch.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 void f (int z) { 
   while (z) { 

clang/test/Sema/typedef-retain.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 typedef float float4 __attribute__((vector_size(16)));
 typedef int int4 __attribute__((vector_size(16)));

clang/test/Sema/unused-expr.c

@@ -1,4 +1,4 @@
-// RUN: clang -parse-ast-check %s
+// RUN: clang -parse-ast -verify %s
 
 int foo(int X, int Y);