maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

AMDGPUPrintfRuntimeBinding - don't dereference a dyn_cast<> pointer. NFCI. 

We dereference the dyn_cast<> in all paths - use cast<> to silence the clang static analyzer warning.
This commit is contained in:
Simon Pilgrim 2021-01-28 12:38:30 +00:00
parent c571b16834
commit 0805e40a94
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
View File

@ -356,8 +356,7 @@ bool AMDGPUPrintfRuntimeBindingImpl::lowerPrintfForGpu(Module &M) {
//
ConstantPointerNull *zeroIntPtr =
ConstantPointerNull::get(PointerType::get(Type::getInt8Ty(Ctx), 1));
ICmpInst *cmp =
dyn_cast<ICmpInst>(Builder.CreateICmpNE(pcall, zeroIntPtr, ""));
auto *cmp = cast<ICmpInst>(Builder.CreateICmpNE(pcall, zeroIntPtr, ""));
if (!CI->use_empty()) {
Value *result =
Builder.CreateSExt(Builder.CreateNot(cmp), I32Ty, "printf_res");