From 080241b75dcffddc07ea77151895fe2c6822aa9b Mon Sep 17 00:00:00 2001 From: Alina Sbirlea Date: Thu, 9 Jun 2016 00:08:15 +0000 Subject: [PATCH] [cpu-detection] Add missing break statements in outer switches Summary: Break on all switch cases for outer and inner switches. No functionality changed. Reviewers: llvm-commits, sanjoy Differential Revision: http://reviews.llvm.org/D21158 llvm-svn: 272228 --- llvm/lib/Support/Host.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/llvm/lib/Support/Host.cpp b/llvm/lib/Support/Host.cpp index 09ce12a19764..7c6447b74b18 100644 --- a/llvm/lib/Support/Host.cpp +++ b/llvm/lib/Support/Host.cpp @@ -320,6 +320,7 @@ getIntelProcessorTypeAndSubtype(unsigned int Family, unsigned int Model, *Type = INTEL_i486; break; } + break; case 5: switch (Model) { case 1: // Pentium OverDrive processor for Pentium processor (60, 66), @@ -341,6 +342,7 @@ getIntelProcessorTypeAndSubtype(unsigned int Family, unsigned int Model, *Type = INTEL_PENTIUM; break; } + break; case 6: switch (Model) { case 0x01: // Pentium Pro processor @@ -537,6 +539,7 @@ getIntelProcessorTypeAndSubtype(unsigned int Family, unsigned int Model, *Type = INTEL_PENTIUM_PRO; break; } + break; case 15: { switch (Model) { case 0: // Pentium 4 processor, Intel Xeon processor. All processors are @@ -572,6 +575,7 @@ getIntelProcessorTypeAndSubtype(unsigned int Family, unsigned int Model, ((Features & (1 << FEATURE_EM64T)) ? INTEL_X86_64 : INTEL_PENTIUM_IV); break; } + break; } default: break; /*"generic"*/ @@ -589,6 +593,7 @@ static void getAMDProcessorTypeAndSubtype(unsigned int Family, switch (Family) { case 4: *Type = AMD_i486; + break; case 5: *Type = AMDPENTIUM; switch (Model) { @@ -606,9 +611,8 @@ static void getAMDProcessorTypeAndSubtype(unsigned int Family, case 10: *Subtype = AMDPENTIUM_GEODE; break; // "geode" - default: - break; } + break; case 6: *Type = AMDATHLON; switch (Model) { @@ -623,9 +627,8 @@ static void getAMDProcessorTypeAndSubtype(unsigned int Family, case 10: *Subtype = AMDATHLON_XP; break; // "athlon-xp" - default: - break; } + break; case 15: *Type = AMDATHLON; if (Features & (1 << FEATURE_SSE3)) { @@ -643,6 +646,7 @@ static void getAMDProcessorTypeAndSubtype(unsigned int Family, *Subtype = AMDATHLON_64; break; // "athlon64" } + break; case 16: *Type = AMDFAM10H; // "amdfam10" switch (Model) { @@ -655,9 +659,8 @@ static void getAMDProcessorTypeAndSubtype(unsigned int Family, case 8: *Subtype = AMDFAM10H_ISTANBUL; break; - default: - break; } + break; case 20: *Type = AMDFAM14H; *Subtype = AMD_BTVER1;