maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Fix logic of assertion

This commit is contained in:
Sam McCall 2022-05-19 08:13:02 +02:00
parent 03ea140b3a
commit 07c6635901
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp
View File

@ -108,10 +108,8 @@ void ContainerContainsCheck::check(const MatchFinder::MatchResult &Result) {
Result.Nodes.getNodeAs<Expr>("positiveComparison"); Result.Nodes.getNodeAs<Expr>("positiveComparison");
const auto *NegativeComparison = const auto *NegativeComparison =
Result.Nodes.getNodeAs<Expr>("negativeComparison"); Result.Nodes.getNodeAs<Expr>("negativeComparison");
assert( assert((!PositiveComparison || !NegativeComparison) &&
!PositiveComparison || "only one of PositiveComparison or NegativeComparison should be set");
!NegativeComparison &&
"only one of PositiveComparison or NegativeComparison should be set");
bool Negated = NegativeComparison != nullptr; bool Negated = NegativeComparison != nullptr;
const auto *Comparison = Negated ? NegativeComparison : PositiveComparison; const auto *Comparison = Negated ? NegativeComparison : PositiveComparison;