diff --git a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/KaleidoscopeJIT.h index 0b8bb381d08a..8c1af40be153 100644 --- a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/KaleidoscopeJIT.h @@ -42,8 +42,8 @@ private: std::shared_ptr Resolver; std::unique_ptr TM; const DataLayout DL; - RTDyldObjectLinkingLayer ObjectLayer; - IRCompileLayer CompileLayer; + LegacyRTDyldObjectLinkingLayer ObjectLayer; + LegacyIRCompileLayer CompileLayer; public: KaleidoscopeJIT() @@ -63,7 +63,7 @@ public: TM(EngineBuilder().selectTarget()), DL(TM->createDataLayout()), ObjectLayer(ES, [this](VModuleKey) { - return RTDyldObjectLinkingLayer::Resources{ + return LegacyRTDyldObjectLinkingLayer::Resources{ std::make_shared(), Resolver}; }), CompileLayer(ObjectLayer, SimpleCompiler(*TM)) { diff --git a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/KaleidoscopeJIT.h index 9ea84d1a8581..7c803b138c06 100644 --- a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/KaleidoscopeJIT.h @@ -47,13 +47,13 @@ private: std::shared_ptr Resolver; std::unique_ptr TM; const DataLayout DL; - RTDyldObjectLinkingLayer ObjectLayer; - IRCompileLayer CompileLayer; + LegacyRTDyldObjectLinkingLayer ObjectLayer; + LegacyIRCompileLayer CompileLayer; using OptimizeFunction = std::function(std::unique_ptr)>; - IRTransformLayer OptimizeLayer; + LegacyIRTransformLayer OptimizeLayer; public: KaleidoscopeJIT() @@ -73,7 +73,7 @@ public: TM(EngineBuilder().selectTarget()), DL(TM->createDataLayout()), ObjectLayer(ES, [this](VModuleKey) { - return RTDyldObjectLinkingLayer::Resources{ + return LegacyRTDyldObjectLinkingLayer::Resources{ std::make_shared(), Resolver}; }), CompileLayer(ObjectLayer, SimpleCompiler(*TM)), diff --git a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/KaleidoscopeJIT.h index 80c39bd70f72..ce0111d2f6b8 100644 --- a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/KaleidoscopeJIT.h @@ -51,23 +51,23 @@ private: std::map> Resolvers; std::unique_ptr TM; const DataLayout DL; - RTDyldObjectLinkingLayer ObjectLayer; - IRCompileLayer CompileLayer; + LegacyRTDyldObjectLinkingLayer ObjectLayer; + LegacyIRCompileLayer CompileLayer; using OptimizeFunction = std::function(std::unique_ptr)>; - IRTransformLayer OptimizeLayer; + LegacyIRTransformLayer OptimizeLayer; std::unique_ptr CompileCallbackManager; - CompileOnDemandLayer CODLayer; + LegacyCompileOnDemandLayer CODLayer; public: KaleidoscopeJIT() : TM(EngineBuilder().selectTarget()), DL(TM->createDataLayout()), ObjectLayer(ES, [this](VModuleKey K) { - return RTDyldObjectLinkingLayer::Resources{ + return LegacyRTDyldObjectLinkingLayer::Resources{ std::make_shared(), Resolvers[K]}; }), diff --git a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/KaleidoscopeJIT.h index 04ad86e34bfb..ffca65fbcd4f 100644 --- a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/KaleidoscopeJIT.h @@ -77,13 +77,13 @@ private: std::shared_ptr Resolver; std::unique_ptr TM; const DataLayout DL; - RTDyldObjectLinkingLayer ObjectLayer; - IRCompileLayer CompileLayer; + LegacyRTDyldObjectLinkingLayer ObjectLayer; + LegacyIRCompileLayer CompileLayer; using OptimizeFunction = std::function(std::unique_ptr)>; - IRTransformLayer OptimizeLayer; + LegacyIRTransformLayer OptimizeLayer; std::unique_ptr CompileCallbackMgr; std::unique_ptr IndirectStubsMgr; @@ -108,7 +108,7 @@ public: TM(EngineBuilder().selectTarget()), DL(TM->createDataLayout()), ObjectLayer(ES, [this](VModuleKey K) { - return RTDyldObjectLinkingLayer::Resources{ + return LegacyRTDyldObjectLinkingLayer::Resources{ std::make_shared(), Resolver}; }), CompileLayer(ObjectLayer, SimpleCompiler(*TM)), diff --git a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter5/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter5/KaleidoscopeJIT.h index 010f54363778..f1ae5b022895 100644 --- a/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter5/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/BuildingAJIT/Chapter5/KaleidoscopeJIT.h @@ -82,13 +82,13 @@ private: std::shared_ptr Resolver; std::unique_ptr TM; const DataLayout DL; - RTDyldObjectLinkingLayer ObjectLayer; - IRCompileLayer CompileLayer; + LegacyRTDyldObjectLinkingLayer ObjectLayer; + LegacyIRCompileLayer CompileLayer; using OptimizeFunction = std::function(std::unique_ptr)>; - IRTransformLayer OptimizeLayer; + LegacyIRTransformLayer OptimizeLayer; JITCompileCallbackManager *CompileCallbackMgr; std::unique_ptr IndirectStubsMgr; @@ -116,7 +116,7 @@ public: DL(TM->createDataLayout()), ObjectLayer(ES, [this](VModuleKey K) { - return RTDyldObjectLinkingLayer::Resources{ + return LegacyRTDyldObjectLinkingLayer::Resources{ cantFail(this->Remote.createRemoteMemoryManager()), Resolver}; }), diff --git a/llvm/examples/Kaleidoscope/include/KaleidoscopeJIT.h b/llvm/examples/Kaleidoscope/include/KaleidoscopeJIT.h index 7239aea7ba1b..972773a64f7e 100644 --- a/llvm/examples/Kaleidoscope/include/KaleidoscopeJIT.h +++ b/llvm/examples/Kaleidoscope/include/KaleidoscopeJIT.h @@ -40,8 +40,8 @@ namespace orc { class KaleidoscopeJIT { public: - using ObjLayerT = RTDyldObjectLinkingLayer; - using CompileLayerT = IRCompileLayer; + using ObjLayerT = LegacyRTDyldObjectLinkingLayer; + using CompileLayerT = LegacyIRCompileLayer; KaleidoscopeJIT() : Resolver(createLegacyLookupResolver( diff --git a/llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h index 2003f8e43b88..7721f74fe0c9 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h @@ -62,7 +62,7 @@ namespace orc { class ExtractingIRMaterializationUnit; -class CompileOnDemandLayer2 : public IRLayer { +class CompileOnDemandLayer : public IRLayer { friend class PartitioningIRMaterializationUnit; public: @@ -84,8 +84,8 @@ public: /// symbol in them is requested. static Optional compileWholeModule(GlobalValueSet Requested); - /// Construct a CompileOnDemandLayer2. - CompileOnDemandLayer2(ExecutionSession &ES, IRLayer &BaseLayer, + /// Construct a CompileOnDemandLayer. + CompileOnDemandLayer(ExecutionSession &ES, IRLayer &BaseLayer, LazyCallThroughManager &LCTMgr, IndirectStubsManagerBuilder BuildIndirectStubsManager); @@ -142,7 +142,7 @@ private: template -class CompileOnDemandLayer { +class LegacyCompileOnDemandLayer { private: template class LambdaMaterializer final : public ValueMaterializer { @@ -266,13 +266,13 @@ public: std::function R)>; /// Construct a compile-on-demand layer instance. - CompileOnDemandLayer(ExecutionSession &ES, BaseLayerT &BaseLayer, - SymbolResolverGetter GetSymbolResolver, - SymbolResolverSetter SetSymbolResolver, - PartitioningFtor Partition, - CompileCallbackMgrT &CallbackMgr, - IndirectStubsManagerBuilderT CreateIndirectStubsManager, - bool CloneStubsIntoPartitions = true) + LegacyCompileOnDemandLayer(ExecutionSession &ES, BaseLayerT &BaseLayer, + SymbolResolverGetter GetSymbolResolver, + SymbolResolverSetter SetSymbolResolver, + PartitioningFtor Partition, + CompileCallbackMgrT &CallbackMgr, + IndirectStubsManagerBuilderT CreateIndirectStubsManager, + bool CloneStubsIntoPartitions = true) : ES(ES), BaseLayer(BaseLayer), GetSymbolResolver(std::move(GetSymbolResolver)), SetSymbolResolver(std::move(SetSymbolResolver)), @@ -280,7 +280,7 @@ public: CreateIndirectStubsManager(std::move(CreateIndirectStubsManager)), CloneStubsIntoPartitions(CloneStubsIntoPartitions) {} - ~CompileOnDemandLayer() { + ~LegacyCompileOnDemandLayer() { // FIXME: Report error on log. while (!LogicalDylibs.empty()) consumeError(removeModule(LogicalDylibs.begin()->first)); diff --git a/llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h b/llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h index 662ed7b78e4c..88559f822e5d 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h @@ -94,11 +94,11 @@ iterator_range getDestructors(const Module &M); /// Convenience class for recording constructor/destructor names for /// later execution. template -class CtorDtorRunner { +class LegacyCtorDtorRunner { public: /// Construct a CtorDtorRunner for the given range using the given /// name mangling function. - CtorDtorRunner(std::vector CtorDtorNames, VModuleKey K) + LegacyCtorDtorRunner(std::vector CtorDtorNames, VModuleKey K) : CtorDtorNames(std::move(CtorDtorNames)), K(K) {} /// Run the recorded constructors/destructors through the given JIT @@ -129,9 +129,9 @@ private: orc::VModuleKey K; }; -class CtorDtorRunner2 { +class CtorDtorRunner { public: - CtorDtorRunner2(JITDylib &JD) : JD(JD) {} + CtorDtorRunner(JITDylib &JD) : JD(JD) {} void add(iterator_range CtorDtors); Error run(); @@ -177,11 +177,11 @@ protected: void *DSOHandle); }; -class LocalCXXRuntimeOverrides : public LocalCXXRuntimeOverridesBase { +class LegacyLocalCXXRuntimeOverrides : public LocalCXXRuntimeOverridesBase { public: /// Create a runtime-overrides class. template - LocalCXXRuntimeOverrides(const MangleFtorT &Mangle) { + LegacyLocalCXXRuntimeOverrides(const MangleFtorT &Mangle) { addOverride(Mangle("__dso_handle"), toTargetAddress(&DSOHandleOverride)); addOverride(Mangle("__cxa_atexit"), toTargetAddress(&CXAAtExitOverride)); } @@ -202,7 +202,7 @@ private: StringMap CXXRuntimeOverrides; }; -class LocalCXXRuntimeOverrides2 : public LocalCXXRuntimeOverridesBase { +class LocalCXXRuntimeOverrides : public LocalCXXRuntimeOverridesBase { public: Error enable(JITDylib &JD, MangleAndInterner &Mangler); }; diff --git a/llvm/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h index cb8df26bfdc3..a62d8be2fa66 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h @@ -28,7 +28,7 @@ class Module; namespace orc { -class IRCompileLayer2 : public IRLayer { +class IRCompileLayer : public IRLayer { public: using CompileFunction = std::function>(Module &)>; @@ -36,8 +36,8 @@ public: using NotifyCompiledFunction = std::function; - IRCompileLayer2(ExecutionSession &ES, ObjectLayer &BaseLayer, - CompileFunction Compile); + IRCompileLayer(ExecutionSession &ES, ObjectLayer &BaseLayer, + CompileFunction Compile); void setNotifyCompiled(NotifyCompiledFunction NotifyCompiled); @@ -57,15 +57,15 @@ private: /// object file and adds this module file to the layer below, which must /// implement the object layer concept. template -class IRCompileLayer { +class LegacyIRCompileLayer { public: /// Callback type for notifications when modules are compiled. using NotifyCompiledCallback = std::function)>; - /// Construct an IRCompileLayer with the given BaseLayer, which must + /// Construct an LegacyIRCompileLayer with the given BaseLayer, which must /// implement the ObjectLayer concept. - IRCompileLayer( + LegacyIRCompileLayer( BaseLayerT &BaseLayer, CompileFtor Compile, NotifyCompiledCallback NotifyCompiled = NotifyCompiledCallback()) : BaseLayer(BaseLayer), Compile(std::move(Compile)), diff --git a/llvm/include/llvm/ExecutionEngine/Orc/IRTransformLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/IRTransformLayer.h index d5f91cef359d..55a1ce4c930f 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/IRTransformLayer.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/IRTransformLayer.h @@ -23,13 +23,13 @@ namespace llvm { class Module; namespace orc { -class IRTransformLayer2 : public IRLayer { +class IRTransformLayer : public IRLayer { public: using TransformFunction = std::function( ThreadSafeModule, const MaterializationResponsibility &R)>; - IRTransformLayer2(ExecutionSession &ES, IRLayer &BaseLayer, - TransformFunction Transform = identityTransform); + IRTransformLayer(ExecutionSession &ES, IRLayer &BaseLayer, + TransformFunction Transform = identityTransform); void setTransform(TransformFunction Transform) { this->Transform = std::move(Transform); @@ -54,11 +54,11 @@ private: /// This layer applies a user supplied transform to each module that is added, /// then adds the transformed module to the layer below. template -class IRTransformLayer { +class LegacyIRTransformLayer { public: - /// Construct an IRTransformLayer with the given BaseLayer - IRTransformLayer(BaseLayerT &BaseLayer, + /// Construct an LegacyIRTransformLayer with the given BaseLayer + LegacyIRTransformLayer(BaseLayerT &BaseLayer, TransformFtor Transform = TransformFtor()) : BaseLayer(BaseLayer), Transform(std::move(Transform)) {} diff --git a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h index 400d4cbe7f09..05a566fedb60 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h @@ -99,7 +99,7 @@ public: Error runDestructors() { return DtorRunner.run(); } /// Returns a reference to the ObjLinkingLayer - RTDyldObjectLinkingLayer2 &getObjLinkingLayer() { return ObjLinkingLayer; } + RTDyldObjectLinkingLayer &getObjLinkingLayer() { return ObjLinkingLayer; } protected: @@ -125,10 +125,10 @@ protected: DataLayout DL; std::unique_ptr CompileThreads; - RTDyldObjectLinkingLayer2 ObjLinkingLayer; - IRCompileLayer2 CompileLayer; + RTDyldObjectLinkingLayer ObjLinkingLayer; + IRCompileLayer CompileLayer; - CtorDtorRunner2 CtorRunner, DtorRunner; + CtorDtorRunner CtorRunner, DtorRunner; }; /// An extended version of LLJIT that supports lazy function-at-a-time @@ -145,13 +145,13 @@ public: /// Set an IR transform (e.g. pass manager pipeline) to run on each function /// when it is compiled. - void setLazyCompileTransform(IRTransformLayer2::TransformFunction Transform) { + void setLazyCompileTransform(IRTransformLayer::TransformFunction Transform) { TransformLayer.setTransform(std::move(Transform)); } /// Sets the partition function. void - setPartitionFunction(CompileOnDemandLayer2::PartitionFunction Partition) { + setPartitionFunction(CompileOnDemandLayer::PartitionFunction Partition) { CODLayer.setPartitionFunction(std::move(Partition)); } @@ -180,8 +180,8 @@ private: std::unique_ptr LCTMgr; std::function()> ISMBuilder; - IRTransformLayer2 TransformLayer; - CompileOnDemandLayer2 CODLayer; + IRTransformLayer TransformLayer; + CompileOnDemandLayer CODLayer; }; } // End namespace orc diff --git a/llvm/include/llvm/ExecutionEngine/Orc/ObjectTransformLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/ObjectTransformLayer.h index c6b43a9c8ed6..6cd688ad58a5 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/ObjectTransformLayer.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/ObjectTransformLayer.h @@ -23,14 +23,14 @@ namespace llvm { namespace orc { -class ObjectTransformLayer2 : public ObjectLayer { +class ObjectTransformLayer : public ObjectLayer { public: using TransformFunction = std::function>( std::unique_ptr)>; - ObjectTransformLayer2(ExecutionSession &ES, ObjectLayer &BaseLayer, - TransformFunction Transform); + ObjectTransformLayer(ExecutionSession &ES, ObjectLayer &BaseLayer, + TransformFunction Transform); void emit(MaterializationResponsibility R, VModuleKey K, std::unique_ptr O) override; @@ -46,11 +46,11 @@ private: /// immediately applies the user supplied functor to each object, then adds /// the set of transformed objects to the layer below. template -class ObjectTransformLayer { +class LegacyObjectTransformLayer { public: /// Construct an ObjectTransformLayer with the given BaseLayer - ObjectTransformLayer(BaseLayerT &BaseLayer, - TransformFtor Transform = TransformFtor()) + LegacyObjectTransformLayer(BaseLayerT &BaseLayer, + TransformFtor Transform = TransformFtor()) : BaseLayer(BaseLayer), Transform(std::move(Transform)) {} /// Apply the transform functor to each object in the object set, then diff --git a/llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h index 0c30520a21bb..bbd782fdeceb 100644 --- a/llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h +++ b/llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h @@ -36,7 +36,7 @@ namespace llvm { namespace orc { -class RTDyldObjectLinkingLayer2 : public ObjectLayer { +class RTDyldObjectLinkingLayer : public ObjectLayer { public: /// Functor for receiving object-loaded notifications. using NotifyLoadedFunction = @@ -51,7 +51,7 @@ public: /// Construct an ObjectLinkingLayer with the given NotifyLoaded, /// and NotifyEmitted functors. - RTDyldObjectLinkingLayer2( + RTDyldObjectLinkingLayer( ExecutionSession &ES, GetMemoryManagerFunction GetMemoryManager, NotifyLoadedFunction NotifyLoaded = NotifyLoadedFunction(), NotifyEmittedFunction NotifyEmitted = NotifyEmittedFunction()); @@ -66,7 +66,7 @@ public: /// the memory manager, rather than just the sections required for execution. /// /// This is kludgy, and may be removed in the future. - RTDyldObjectLinkingLayer2 &setProcessAllSections(bool ProcessAllSections) { + RTDyldObjectLinkingLayer &setProcessAllSections(bool ProcessAllSections) { this->ProcessAllSections = ProcessAllSections; return *this; } @@ -79,13 +79,13 @@ public: /// /// FIXME: We should be able to remove this if/when COFF properly tracks /// exported symbols. - RTDyldObjectLinkingLayer2 & + RTDyldObjectLinkingLayer & setOverrideObjectFlagsWithResponsibilityFlags(bool OverrideObjectFlags) { this->OverrideObjectFlags = OverrideObjectFlags; return *this; } - /// If set, this RTDyldObjectLinkingLayer2 instance will claim responsibility + /// If set, this RTDyldObjectLinkingLayer instance will claim responsibility /// for any symbols provided by a given object file that were not already in /// the MaterializationResponsibility instance. Setting this flag allows /// higher-level program representations (e.g. LLVM IR) to be added based on @@ -96,7 +96,7 @@ public: /// deterministically). If this option is set, clashes for the additional /// symbols may not be detected until late, and detection may depend on /// the flow of control through JIT'd code. Use with care. - RTDyldObjectLinkingLayer2 & + RTDyldObjectLinkingLayer & setAutoClaimResponsibilityForObjectSymbols(bool AutoClaimObjectSymbols) { this->AutoClaimObjectSymbols = AutoClaimObjectSymbols; return *this; @@ -121,7 +121,7 @@ private: std::map> MemMgrs; }; -class RTDyldObjectLinkingLayerBase { +class LegacyRTDyldObjectLinkingLayerBase { public: using ObjectPtr = std::unique_ptr; @@ -173,10 +173,10 @@ protected: /// object files to be loaded into memory, linked, and the addresses of their /// symbols queried. All objects added to this layer can see each other's /// symbols. -class RTDyldObjectLinkingLayer : public RTDyldObjectLinkingLayerBase { +class LegacyRTDyldObjectLinkingLayer : public LegacyRTDyldObjectLinkingLayerBase { public: - using RTDyldObjectLinkingLayerBase::ObjectPtr; + using LegacyRTDyldObjectLinkingLayerBase::ObjectPtr; /// Functor for receiving object-loaded notifications. using NotifyLoadedFtor = @@ -197,7 +197,7 @@ private: template class ConcreteLinkedObject : public LinkedObject { public: - ConcreteLinkedObject(RTDyldObjectLinkingLayer &Parent, VModuleKey K, + ConcreteLinkedObject(LegacyRTDyldObjectLinkingLayer &Parent, VModuleKey K, OwnedObject Obj, MemoryManagerPtrT MemMgr, std::shared_ptr Resolver, bool ProcessAllSections) @@ -313,7 +313,7 @@ private: }; VModuleKey K; - RTDyldObjectLinkingLayer &Parent; + LegacyRTDyldObjectLinkingLayer &Parent; MemoryManagerPtrT MemMgr; OwnedObject ObjForNotify; std::unique_ptr PFC; @@ -321,7 +321,7 @@ private: template std::unique_ptr> - createLinkedObject(RTDyldObjectLinkingLayer &Parent, VModuleKey K, + createLinkedObject(LegacyRTDyldObjectLinkingLayer &Parent, VModuleKey K, OwnedObject Obj, MemoryManagerPtrT MemMgr, std::shared_ptr Resolver, bool ProcessAllSections) { @@ -341,7 +341,7 @@ public: /// Construct an ObjectLinkingLayer with the given NotifyLoaded, /// and NotifyFinalized functors. - RTDyldObjectLinkingLayer( + LegacyRTDyldObjectLinkingLayer( ExecutionSession &ES, ResourcesGetter GetResources, NotifyLoadedFtor NotifyLoaded = NotifyLoadedFtor(), NotifyFinalizedFtor NotifyFinalized = NotifyFinalizedFtor(), diff --git a/llvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp b/llvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp index ae1c7e842597..f27a814f33f8 100644 --- a/llvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp @@ -68,13 +68,13 @@ namespace orc { class PartitioningIRMaterializationUnit : public IRMaterializationUnit { public: PartitioningIRMaterializationUnit(ExecutionSession &ES, ThreadSafeModule TSM, - CompileOnDemandLayer2 &Parent) + CompileOnDemandLayer &Parent) : IRMaterializationUnit(ES, std::move(TSM)), Parent(Parent) {} PartitioningIRMaterializationUnit( ThreadSafeModule TSM, SymbolFlagsMap SymbolFlags, SymbolNameToDefinitionMap SymbolToDefinition, - CompileOnDemandLayer2 &Parent) + CompileOnDemandLayer &Parent) : IRMaterializationUnit(std::move(TSM), std::move(SymbolFlags), std::move(SymbolToDefinition)), Parent(Parent) {} @@ -93,30 +93,30 @@ private: } mutable std::mutex SourceModuleMutex; - CompileOnDemandLayer2 &Parent; + CompileOnDemandLayer &Parent; }; -Optional -CompileOnDemandLayer2::compileRequested(GlobalValueSet Requested) { +Optional +CompileOnDemandLayer::compileRequested(GlobalValueSet Requested) { return std::move(Requested); } -Optional -CompileOnDemandLayer2::compileWholeModule(GlobalValueSet Requested) { +Optional +CompileOnDemandLayer::compileWholeModule(GlobalValueSet Requested) { return None; } -CompileOnDemandLayer2::CompileOnDemandLayer2( +CompileOnDemandLayer::CompileOnDemandLayer( ExecutionSession &ES, IRLayer &BaseLayer, LazyCallThroughManager &LCTMgr, IndirectStubsManagerBuilder BuildIndirectStubsManager) : IRLayer(ES), BaseLayer(BaseLayer), LCTMgr(LCTMgr), BuildIndirectStubsManager(std::move(BuildIndirectStubsManager)) {} -void CompileOnDemandLayer2::setPartitionFunction(PartitionFunction Partition) { +void CompileOnDemandLayer::setPartitionFunction(PartitionFunction Partition) { this->Partition = std::move(Partition); } -void CompileOnDemandLayer2::emit(MaterializationResponsibility R, VModuleKey K, +void CompileOnDemandLayer::emit(MaterializationResponsibility R, VModuleKey K, ThreadSafeModule TSM) { assert(TSM.getModule() && "Null module"); @@ -160,8 +160,8 @@ void CompileOnDemandLayer2::emit(MaterializationResponsibility R, VModuleKey K, std::move(Callables))); } -CompileOnDemandLayer2::PerDylibResources & -CompileOnDemandLayer2::getPerDylibResources(JITDylib &TargetD) { +CompileOnDemandLayer::PerDylibResources & +CompileOnDemandLayer::getPerDylibResources(JITDylib &TargetD) { auto I = DylibResources.find(&TargetD); if (I == DylibResources.end()) { auto &ImplD = @@ -176,7 +176,7 @@ CompileOnDemandLayer2::getPerDylibResources(JITDylib &TargetD) { return I->second; } -void CompileOnDemandLayer2::cleanUpModule(Module &M) { +void CompileOnDemandLayer::cleanUpModule(Module &M) { for (auto &F : M.functions()) { if (F.isDeclaration()) continue; @@ -189,7 +189,7 @@ void CompileOnDemandLayer2::cleanUpModule(Module &M) { } } -void CompileOnDemandLayer2::expandPartition(GlobalValueSet &Partition) { +void CompileOnDemandLayer::expandPartition(GlobalValueSet &Partition) { // Expands the partition to ensure the following rules hold: // (1) If any alias is in the partition, its aliasee is also in the partition. // (2) If any aliasee is in the partition, its aliases are also in the @@ -221,7 +221,7 @@ void CompileOnDemandLayer2::expandPartition(GlobalValueSet &Partition) { Partition.insert(GV); } -void CompileOnDemandLayer2::emitPartition( +void CompileOnDemandLayer::emitPartition( MaterializationResponsibility R, ThreadSafeModule TSM, IRMaterializationUnit::SymbolNameToDefinitionMap Defs) { diff --git a/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp b/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp index 4c8f725df543..21a604f71ca2 100644 --- a/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp +++ b/llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp @@ -87,7 +87,7 @@ iterator_range getDestructors(const Module &M) { CtorDtorIterator(DtorsList, true)); } -void CtorDtorRunner2::add(iterator_range CtorDtors) { +void CtorDtorRunner::add(iterator_range CtorDtors) { if (CtorDtors.begin() == CtorDtors.end()) return; @@ -115,7 +115,7 @@ void CtorDtorRunner2::add(iterator_range CtorDtors) { } } -Error CtorDtorRunner2::run() { +Error CtorDtorRunner::run() { using CtorDtorTy = void (*)(); SymbolNameSet Names; @@ -165,7 +165,7 @@ int LocalCXXRuntimeOverridesBase::CXAAtExitOverride(DestructorPtr Destructor, return 0; } -Error LocalCXXRuntimeOverrides2::enable(JITDylib &JD, +Error LocalCXXRuntimeOverrides::enable(JITDylib &JD, MangleAndInterner &Mangle) { SymbolMap RuntimeInterposes; RuntimeInterposes[Mangle("__dso_handle")] = diff --git a/llvm/lib/ExecutionEngine/Orc/IRCompileLayer.cpp b/llvm/lib/ExecutionEngine/Orc/IRCompileLayer.cpp index 5dee1c80e0b3..6d029e16ba95 100644 --- a/llvm/lib/ExecutionEngine/Orc/IRCompileLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/IRCompileLayer.cpp @@ -12,16 +12,16 @@ namespace llvm { namespace orc { -IRCompileLayer2::IRCompileLayer2(ExecutionSession &ES, ObjectLayer &BaseLayer, +IRCompileLayer::IRCompileLayer(ExecutionSession &ES, ObjectLayer &BaseLayer, CompileFunction Compile) : IRLayer(ES), BaseLayer(BaseLayer), Compile(std::move(Compile)) {} -void IRCompileLayer2::setNotifyCompiled(NotifyCompiledFunction NotifyCompiled) { +void IRCompileLayer::setNotifyCompiled(NotifyCompiledFunction NotifyCompiled) { std::lock_guard Lock(IRLayerMutex); this->NotifyCompiled = std::move(NotifyCompiled); } -void IRCompileLayer2::emit(MaterializationResponsibility R, VModuleKey K, +void IRCompileLayer::emit(MaterializationResponsibility R, VModuleKey K, ThreadSafeModule TSM) { assert(TSM.getModule() && "Module must not be null"); diff --git a/llvm/lib/ExecutionEngine/Orc/IRTransformLayer.cpp b/llvm/lib/ExecutionEngine/Orc/IRTransformLayer.cpp index 7a79a382d8d8..acba7916d400 100644 --- a/llvm/lib/ExecutionEngine/Orc/IRTransformLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/IRTransformLayer.cpp @@ -13,12 +13,12 @@ namespace llvm { namespace orc { -IRTransformLayer2::IRTransformLayer2(ExecutionSession &ES, +IRTransformLayer::IRTransformLayer(ExecutionSession &ES, IRLayer &BaseLayer, TransformFunction Transform) : IRLayer(ES), BaseLayer(BaseLayer), Transform(std::move(Transform)) {} -void IRTransformLayer2::emit(MaterializationResponsibility R, VModuleKey K, +void IRTransformLayer::emit(MaterializationResponsibility R, VModuleKey K, ThreadSafeModule TSM) { assert(TSM.getModule() && "Module must not be null"); diff --git a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp index 478ac2e21483..e464da267ae2 100644 --- a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp +++ b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp @@ -21,7 +21,7 @@ namespace { : llvm::orc::SimpleCompiler(*TM), TM(std::move(TM)) {} private: // FIXME: shared because std::functions (and thus - // IRCompileLayer2::CompileFunction) are not moveable. + // IRCompileLayer::CompileFunction) are not moveable. std::shared_ptr TM; }; diff --git a/llvm/lib/ExecutionEngine/Orc/ObjectTransformLayer.cpp b/llvm/lib/ExecutionEngine/Orc/ObjectTransformLayer.cpp index 6980c8140fd0..0be23f2e1a4a 100644 --- a/llvm/lib/ExecutionEngine/Orc/ObjectTransformLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/ObjectTransformLayer.cpp @@ -13,13 +13,13 @@ namespace llvm { namespace orc { -ObjectTransformLayer2::ObjectTransformLayer2(ExecutionSession &ES, - ObjectLayer &BaseLayer, - TransformFunction Transform) +ObjectTransformLayer::ObjectTransformLayer(ExecutionSession &ES, + ObjectLayer &BaseLayer, + TransformFunction Transform) : ObjectLayer(ES), BaseLayer(BaseLayer), Transform(std::move(Transform)) {} -void ObjectTransformLayer2::emit(MaterializationResponsibility R, VModuleKey K, - std::unique_ptr O) { +void ObjectTransformLayer::emit(MaterializationResponsibility R, VModuleKey K, + std::unique_ptr O) { assert(O && "Module must not be null"); if (auto TransformedObj = Transform(std::move(O))) diff --git a/llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h b/llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h index 3fedba1caa6a..deddfcb10e12 100644 --- a/llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h +++ b/llvm/lib/ExecutionEngine/Orc/OrcCBindingsStack.h @@ -77,9 +77,9 @@ public: }; template <> - class GenericLayerImpl : public GenericLayer { + class GenericLayerImpl : public GenericLayer { private: - using LayerT = orc::RTDyldObjectLinkingLayer; + using LayerT = orc::LegacyRTDyldObjectLinkingLayer; public: GenericLayerImpl(LayerT &Layer) : Layer(Layer) {} @@ -107,10 +107,10 @@ class OrcCBindingsStack { public: using CompileCallbackMgr = orc::JITCompileCallbackManager; - using ObjLayerT = orc::RTDyldObjectLinkingLayer; - using CompileLayerT = orc::IRCompileLayer; + using ObjLayerT = orc::LegacyRTDyldObjectLinkingLayer; + using CompileLayerT = orc::LegacyIRCompileLayer; using CODLayerT = - orc::CompileOnDemandLayer; + orc::LegacyCompileOnDemandLayer; using CallbackManagerBuilder = std::function()>; @@ -312,7 +312,7 @@ public: // Run the static constructors, and save the static destructor runner for // execution when the JIT is torn down. - orc::CtorDtorRunner CtorRunner(std::move(CtorNames), K); + orc::LegacyCtorDtorRunner CtorRunner(std::move(CtorNames), K); if (auto Err = CtorRunner.runViaLayer(*this)) return std::move(Err); @@ -517,8 +517,8 @@ private: std::map> KeyLayers; - orc::LocalCXXRuntimeOverrides CXXRuntimeOverrides; - std::vector> IRStaticDestructorRunners; + orc::LegacyLocalCXXRuntimeOverrides CXXRuntimeOverrides; + std::vector> IRStaticDestructorRunners; std::string ErrMsg; ResolverMap Resolvers; diff --git a/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.cpp b/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.cpp index 4def579e7097..617bc2fc64b5 100644 --- a/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.cpp +++ b/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.cpp @@ -128,7 +128,7 @@ void OrcMCJITReplacement::runStaticConstructorsDestructors(bool isDtors) { auto &CtorDtorsMap = isDtors ? UnexecutedDestructors : UnexecutedConstructors; for (auto &KV : CtorDtorsMap) - cantFail(CtorDtorRunner(std::move(KV.second), KV.first) + cantFail(LegacyCtorDtorRunner(std::move(KV.second), KV.first) .runViaLayer(LazyEmitLayer)); CtorDtorsMap.clear(); diff --git a/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h b/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h index 1195d39561d0..36e7e83a8bab 100644 --- a/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h +++ b/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h @@ -461,8 +461,8 @@ private: return MangledName; } - using ObjectLayerT = RTDyldObjectLinkingLayer; - using CompileLayerT = IRCompileLayer; + using ObjectLayerT = LegacyRTDyldObjectLinkingLayer; + using CompileLayerT = LegacyIRCompileLayer; using LazyEmitLayerT = LazyEmittingLayer; ExecutionSession ES; diff --git a/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp b/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp index e84295ca2159..fa574140d480 100644 --- a/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp +++ b/llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp @@ -76,14 +76,14 @@ private: namespace llvm { namespace orc { -RTDyldObjectLinkingLayer2::RTDyldObjectLinkingLayer2( +RTDyldObjectLinkingLayer::RTDyldObjectLinkingLayer( ExecutionSession &ES, GetMemoryManagerFunction GetMemoryManager, NotifyLoadedFunction NotifyLoaded, NotifyEmittedFunction NotifyEmitted) : ObjectLayer(ES), GetMemoryManager(GetMemoryManager), NotifyLoaded(std::move(NotifyLoaded)), NotifyEmitted(std::move(NotifyEmitted)) {} -void RTDyldObjectLinkingLayer2::emit(MaterializationResponsibility R, +void RTDyldObjectLinkingLayer::emit(MaterializationResponsibility R, VModuleKey K, std::unique_ptr O) { assert(O && "Object must not be null"); @@ -153,7 +153,7 @@ void RTDyldObjectLinkingLayer2::emit(MaterializationResponsibility R, }); } -Error RTDyldObjectLinkingLayer2::onObjLoad( +Error RTDyldObjectLinkingLayer::onObjLoad( VModuleKey K, MaterializationResponsibility &R, object::ObjectFile &Obj, std::unique_ptr LoadedObjInfo, std::map Resolved, @@ -196,7 +196,7 @@ Error RTDyldObjectLinkingLayer2::onObjLoad( return Error::success(); } -void RTDyldObjectLinkingLayer2::onObjEmit(VModuleKey K, +void RTDyldObjectLinkingLayer::onObjEmit(VModuleKey K, MaterializationResponsibility &R, Error Err) { if (Err) { diff --git a/llvm/tools/lli/lli.cpp b/llvm/tools/lli/lli.cpp index d633fe6f8009..f4585dc080db 100644 --- a/llvm/tools/lli/lli.cpp +++ b/llvm/tools/lli/lli.cpp @@ -696,7 +696,7 @@ int main(int argc, char **argv, char * const *envp) { return Result; } -static orc::IRTransformLayer2::TransformFunction createDebugDumper() { +static orc::IRTransformLayer::TransformFunction createDebugDumper() { switch (OrcDumpKind) { case DumpKind::NoDump: return [](orc::ThreadSafeModule TSM, @@ -781,7 +781,7 @@ int runOrcLazyJIT(const char *ProgName) { auto J = ExitOnErr(orc::LLLazyJIT::Create(std::move(JTMB), DL, LazyJITCompileThreads)); if (PerModuleLazy) - J->setPartitionFunction(orc::CompileOnDemandLayer2::compileWholeModule); + J->setPartitionFunction(orc::CompileOnDemandLayer::compileWholeModule); auto Dump = createDebugDumper(); @@ -797,7 +797,7 @@ int runOrcLazyJIT(const char *ProgName) { ExitOnErr(orc::DynamicLibrarySearchGenerator::GetForCurrentProcess(DL))); orc::MangleAndInterner Mangle(J->getExecutionSession(), DL); - orc::LocalCXXRuntimeOverrides2 CXXRuntimeOverrides; + orc::LocalCXXRuntimeOverrides CXXRuntimeOverrides; ExitOnErr(CXXRuntimeOverrides.enable(J->getMainJITDylib(), Mangle)); // Add the main module. diff --git a/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt b/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt index 8b0d5fc24354..019437d4ad5e 100644 --- a/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt +++ b/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt @@ -10,7 +10,6 @@ set(LLVM_LINK_COMPONENTS ) add_llvm_unittest(OrcJITTests - CompileOnDemandLayerTest.cpp CoreAPIsTest.cpp IndirectionUtilsTest.cpp GlobalMappingLayerTest.cpp @@ -18,6 +17,8 @@ add_llvm_unittest(OrcJITTests LazyCallThroughAndReexportsTest.cpp LazyEmittingLayerTest.cpp LegacyAPIInteropTest.cpp + LegacyCompileOnDemandLayerTest.cpp + LegacyRTDyldObjectLinkingLayerTest.cpp ObjectTransformLayerTest.cpp OrcCAPITest.cpp OrcTestCommon.cpp @@ -25,7 +26,6 @@ add_llvm_unittest(OrcJITTests RemoteObjectLayerTest.cpp RPCUtilsTest.cpp RTDyldObjectLinkingLayerTest.cpp - RTDyldObjectLinkingLayer2Test.cpp SymbolStringPoolTest.cpp ThreadSafeModuleTest.cpp ) diff --git a/llvm/unittests/ExecutionEngine/Orc/CompileOnDemandLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/LegacyCompileOnDemandLayerTest.cpp similarity index 95% rename from llvm/unittests/ExecutionEngine/Orc/CompileOnDemandLayerTest.cpp rename to llvm/unittests/ExecutionEngine/Orc/LegacyCompileOnDemandLayerTest.cpp index 9aa4437550b2..38f7a654571e 100644 --- a/llvm/unittests/ExecutionEngine/Orc/CompileOnDemandLayerTest.cpp +++ b/llvm/unittests/ExecutionEngine/Orc/LegacyCompileOnDemandLayerTest.cpp @@ -54,7 +54,7 @@ public: } }; -TEST(CompileOnDemandLayerTest, FindSymbol) { +TEST(LegacyCompileOnDemandLayerTest, FindSymbol) { MockBaseLayer> TestBaseLayer; TestBaseLayer.findSymbolImpl = [](const std::string &Name, bool) { @@ -76,7 +76,7 @@ TEST(CompileOnDemandLayerTest, FindSymbol) { llvm_unreachable("Should never be called"); }; - llvm::orc::CompileOnDemandLayer COD( + llvm::orc::LegacyCompileOnDemandLayer COD( ES, TestBaseLayer, GetResolver, SetResolver, [](Function &F) { return std::set{&F}; }, CallbackMgr, [] { return llvm::make_unique(); }, true); diff --git a/llvm/unittests/ExecutionEngine/Orc/LegacyRTDyldObjectLinkingLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/LegacyRTDyldObjectLinkingLayerTest.cpp new file mode 100644 index 000000000000..8c9c958cc42a --- /dev/null +++ b/llvm/unittests/ExecutionEngine/Orc/LegacyRTDyldObjectLinkingLayerTest.cpp @@ -0,0 +1,282 @@ +//===- RTDyldObjectLinkingLayerTest.cpp - RTDyld linking layer unit tests -===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h" +#include "OrcTestCommon.h" +#include "llvm/ExecutionEngine/ExecutionEngine.h" +#include "llvm/ExecutionEngine/Orc/CompileUtils.h" +#include "llvm/ExecutionEngine/Orc/LambdaResolver.h" +#include "llvm/ExecutionEngine/Orc/Legacy.h" +#include "llvm/ExecutionEngine/Orc/NullResolver.h" +#include "llvm/ExecutionEngine/SectionMemoryManager.h" +#include "llvm/IR/Constants.h" +#include "llvm/IR/LLVMContext.h" +#include "gtest/gtest.h" + +using namespace llvm; +using namespace llvm::orc; + +namespace { + +class LegacyRTDyldObjectLinkingLayerExecutionTest : public testing::Test, + public OrcExecutionTest { + +}; + +class SectionMemoryManagerWrapper : public SectionMemoryManager { +public: + int FinalizationCount = 0; + int NeedsToReserveAllocationSpaceCount = 0; + + bool needsToReserveAllocationSpace() override { + ++NeedsToReserveAllocationSpaceCount; + return SectionMemoryManager::needsToReserveAllocationSpace(); + } + + bool finalizeMemory(std::string *ErrMsg = nullptr) override { + ++FinalizationCount; + return SectionMemoryManager::finalizeMemory(ErrMsg); + } +}; + +TEST(LegacyRTDyldObjectLinkingLayerTest, TestSetProcessAllSections) { + class MemoryManagerWrapper : public SectionMemoryManager { + public: + MemoryManagerWrapper(bool &DebugSeen) : DebugSeen(DebugSeen) {} + uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment, + unsigned SectionID, + StringRef SectionName, + bool IsReadOnly) override { + if (SectionName == ".debug_str") + DebugSeen = true; + return SectionMemoryManager::allocateDataSection(Size, Alignment, + SectionID, + SectionName, + IsReadOnly); + } + private: + bool &DebugSeen; + }; + + bool DebugSectionSeen = false; + auto MM = std::make_shared(DebugSectionSeen); + + ExecutionSession ES; + + LegacyRTDyldObjectLinkingLayer ObjLayer(ES, [&MM](VModuleKey) { + return LegacyRTDyldObjectLinkingLayer::Resources{ + MM, std::make_shared()}; + }); + + LLVMContext Context; + auto M = llvm::make_unique("", Context); + M->setTargetTriple("x86_64-unknown-linux-gnu"); + Type *Int32Ty = IntegerType::get(Context, 32); + GlobalVariable *GV = + new GlobalVariable(*M, Int32Ty, false, GlobalValue::ExternalLinkage, + ConstantInt::get(Int32Ty, 42), "foo"); + + GV->setSection(".debug_str"); + + + // Initialize the native target in case this is the first unit test + // to try to build a TM. + OrcNativeTarget::initialize(); + std::unique_ptr TM( + EngineBuilder().selectTarget(Triple(M->getTargetTriple()), "", "", + SmallVector())); + if (!TM) + return; + + auto Obj = SimpleCompiler(*TM)(*M); + + { + // Test with ProcessAllSections = false (the default). + auto K = ES.allocateVModule(); + cantFail(ObjLayer.addObject( + K, MemoryBuffer::getMemBufferCopy(Obj->getBuffer()))); + cantFail(ObjLayer.emitAndFinalize(K)); + EXPECT_EQ(DebugSectionSeen, false) + << "Unexpected debug info section"; + cantFail(ObjLayer.removeObject(K)); + } + + { + // Test with ProcessAllSections = true. + ObjLayer.setProcessAllSections(true); + auto K = ES.allocateVModule(); + cantFail(ObjLayer.addObject(K, std::move(Obj))); + cantFail(ObjLayer.emitAndFinalize(K)); + EXPECT_EQ(DebugSectionSeen, true) + << "Expected debug info section not seen"; + cantFail(ObjLayer.removeObject(K)); + } +} + +TEST_F(LegacyRTDyldObjectLinkingLayerExecutionTest, NoDuplicateFinalization) { + if (!SupportsJIT) + return; + + ExecutionSession ES; + + auto MM = std::make_shared(); + + std::map> Resolvers; + + LegacyRTDyldObjectLinkingLayer ObjLayer(ES, [&](VModuleKey K) { + auto I = Resolvers.find(K); + assert(I != Resolvers.end() && "Missing resolver"); + auto R = std::move(I->second); + Resolvers.erase(I); + return LegacyRTDyldObjectLinkingLayer::Resources{MM, std::move(R)}; + }); + SimpleCompiler Compile(*TM); + + // Create a pair of modules that will trigger recursive finalization: + // Module 1: + // int bar() { return 42; } + // Module 2: + // int bar(); + // int foo() { return bar(); } + // + // Verify that the memory manager is only finalized once (for Module 2). + // Failure suggests that finalize is being called on the inner RTDyld + // instance (for Module 1) which is unsafe, as it will prevent relocation of + // Module 2. + + ModuleBuilder MB1(Context, "", "dummy"); + { + MB1.getModule()->setDataLayout(TM->createDataLayout()); + Function *BarImpl = MB1.createFunctionDecl("bar"); + BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); + IRBuilder<> Builder(BarEntry); + IntegerType *Int32Ty = IntegerType::get(Context, 32); + Value *FourtyTwo = ConstantInt::getSigned(Int32Ty, 42); + Builder.CreateRet(FourtyTwo); + } + + auto Obj1 = Compile(*MB1.getModule()); + + ModuleBuilder MB2(Context, "", "dummy"); + { + MB2.getModule()->setDataLayout(TM->createDataLayout()); + Function *BarDecl = MB2.createFunctionDecl("bar"); + Function *FooImpl = MB2.createFunctionDecl("foo"); + BasicBlock *FooEntry = BasicBlock::Create(Context, "entry", FooImpl); + IRBuilder<> Builder(FooEntry); + Builder.CreateRet(Builder.CreateCall(BarDecl)); + } + auto Obj2 = Compile(*MB2.getModule()); + + auto K1 = ES.allocateVModule(); + Resolvers[K1] = std::make_shared(); + cantFail(ObjLayer.addObject(K1, std::move(Obj1))); + + auto K2 = ES.allocateVModule(); + auto LegacyLookup = [&](const std::string &Name) { + return ObjLayer.findSymbol(Name, true); + }; + + Resolvers[K2] = createSymbolResolver( + [&](const SymbolNameSet &Symbols) { + return cantFail( + getResponsibilitySetWithLegacyFn(Symbols, LegacyLookup)); + }, + [&](std::shared_ptr Query, + const SymbolNameSet &Symbols) { + return lookupWithLegacyFn(ES, *Query, Symbols, LegacyLookup); + }); + + cantFail(ObjLayer.addObject(K2, std::move(Obj2))); + cantFail(ObjLayer.emitAndFinalize(K2)); + cantFail(ObjLayer.removeObject(K2)); + + // Finalization of module 2 should trigger finalization of module 1. + // Verify that finalize on SMMW is only called once. + EXPECT_EQ(MM->FinalizationCount, 1) + << "Extra call to finalize"; +} + +TEST_F(LegacyRTDyldObjectLinkingLayerExecutionTest, NoPrematureAllocation) { + if (!SupportsJIT) + return; + + ExecutionSession ES; + + auto MM = std::make_shared(); + + LegacyRTDyldObjectLinkingLayer ObjLayer(ES, [&MM](VModuleKey K) { + return LegacyRTDyldObjectLinkingLayer::Resources{ + MM, std::make_shared()}; + }); + SimpleCompiler Compile(*TM); + + // Create a pair of unrelated modules: + // + // Module 1: + // int foo() { return 42; } + // Module 2: + // int bar() { return 7; } + // + // Both modules will share a memory manager. We want to verify that the + // second object is not loaded before the first one is finalized. To do this + // in a portable way, we abuse the + // RuntimeDyld::MemoryManager::needsToReserveAllocationSpace hook, which is + // called once per object before any sections are allocated. + + ModuleBuilder MB1(Context, "", "dummy"); + { + MB1.getModule()->setDataLayout(TM->createDataLayout()); + Function *BarImpl = MB1.createFunctionDecl("foo"); + BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); + IRBuilder<> Builder(BarEntry); + IntegerType *Int32Ty = IntegerType::get(Context, 32); + Value *FourtyTwo = ConstantInt::getSigned(Int32Ty, 42); + Builder.CreateRet(FourtyTwo); + } + + auto Obj1 = Compile(*MB1.getModule()); + + ModuleBuilder MB2(Context, "", "dummy"); + { + MB2.getModule()->setDataLayout(TM->createDataLayout()); + Function *BarImpl = MB2.createFunctionDecl("bar"); + BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); + IRBuilder<> Builder(BarEntry); + IntegerType *Int32Ty = IntegerType::get(Context, 32); + Value *Seven = ConstantInt::getSigned(Int32Ty, 7); + Builder.CreateRet(Seven); + } + auto Obj2 = Compile(*MB2.getModule()); + + auto K = ES.allocateVModule(); + cantFail(ObjLayer.addObject(K, std::move(Obj1))); + cantFail(ObjLayer.addObject(ES.allocateVModule(), std::move(Obj2))); + cantFail(ObjLayer.emitAndFinalize(K)); + cantFail(ObjLayer.removeObject(K)); + + // Only one call to needsToReserveAllocationSpace should have been made. + EXPECT_EQ(MM->NeedsToReserveAllocationSpaceCount, 1) + << "More than one call to needsToReserveAllocationSpace " + "(multiple unrelated objects loaded prior to finalization)"; +} + +TEST_F(LegacyRTDyldObjectLinkingLayerExecutionTest, TestNotifyLoadedSignature) { + ExecutionSession ES; + LegacyRTDyldObjectLinkingLayer ObjLayer( + ES, + [](VModuleKey) { + return LegacyRTDyldObjectLinkingLayer::Resources{ + nullptr, std::make_shared()}; + }, + [](VModuleKey, const object::ObjectFile &obj, + const RuntimeDyld::LoadedObjectInfo &info) {}); +} + +} // end anonymous namespace diff --git a/llvm/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp index 6ad3c19ada95..1c530247a7c0 100644 --- a/llvm/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp +++ b/llvm/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp @@ -175,19 +175,19 @@ private: } }; -// Test each operation on ObjectTransformLayer. -TEST(ObjectTransformLayerTest, Main) { +// Test each operation on LegacyObjectTransformLayer. +TEST(LegacyObjectTransformLayerTest, Main) { MockBaseLayer M; ExecutionSession ES(std::make_shared()); // Create one object transform layer using a transform (as a functor) // that allocates new objects, and deals in unique pointers. - ObjectTransformLayer T1(M); + LegacyObjectTransformLayer T1(M); // Create a second object transform layer using a transform (as a lambda) // that mutates objects in place, and deals in naked pointers - ObjectTransformLayer( std::shared_ptr)>> T2(M, [](std::shared_ptr Obj) { @@ -257,9 +257,9 @@ TEST(ObjectTransformLayerTest, Main) { if (!RunStaticChecks) return; - // Make sure that ObjectTransformLayer implements the object layer concept + // Make sure that LegacyObjectTransformLayer implements the object layer concept // correctly by sandwitching one between an ObjectLinkingLayer and an - // IRCompileLayer, verifying that it compiles if we have a call to the + // LegacyIRCompileLayer, verifying that it compiles if we have a call to the // IRComileLayer's addModule that should call the transform layer's // addObject, and also calling the other public transform layer methods // directly to make sure the methods they intend to forward to exist on @@ -282,8 +282,8 @@ TEST(ObjectTransformLayerTest, Main) { }; // Construct the jit layers. - RTDyldObjectLinkingLayer BaseLayer(ES, [](VModuleKey) { - return RTDyldObjectLinkingLayer::Resources{ + LegacyRTDyldObjectLinkingLayer BaseLayer(ES, [](VModuleKey) { + return LegacyRTDyldObjectLinkingLayer::Resources{ std::make_shared(), std::make_shared()}; }); @@ -291,20 +291,20 @@ TEST(ObjectTransformLayerTest, Main) { auto IdentityTransform = [](std::unique_ptr Obj) { return Obj; }; - ObjectTransformLayer + LegacyObjectTransformLayer TransformLayer(BaseLayer, IdentityTransform); auto NullCompiler = [](llvm::Module &) { return std::unique_ptr(nullptr); }; - IRCompileLayer + LegacyIRCompileLayer CompileLayer(TransformLayer, NullCompiler); - // Make sure that the calls from IRCompileLayer to ObjectTransformLayer + // Make sure that the calls from LegacyIRCompileLayer to LegacyObjectTransformLayer // compile. cantFail(CompileLayer.addModule(ES.allocateVModule(), std::unique_ptr())); - // Make sure that the calls from ObjectTransformLayer to ObjectLinkingLayer + // Make sure that the calls from LegacyObjectTransformLayer to ObjectLinkingLayer // compile. VModuleKey DummyKey = ES.allocateVModule(); cantFail(TransformLayer.emitAndFinalize(DummyKey)); diff --git a/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayer2Test.cpp b/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayer2Test.cpp deleted file mode 100644 index 1dbd48b59725..000000000000 --- a/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayer2Test.cpp +++ /dev/null @@ -1,228 +0,0 @@ -//===--- RTDyldObjectLinkingLayer2Test.cpp - RTDyld linking layer tests ---===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===----------------------------------------------------------------------===// - -#include "OrcTestCommon.h" -#include "llvm/ExecutionEngine/ExecutionEngine.h" -#include "llvm/ExecutionEngine/Orc/CompileUtils.h" -#include "llvm/ExecutionEngine/Orc/IRCompileLayer.h" -#include "llvm/ExecutionEngine/Orc/LambdaResolver.h" -#include "llvm/ExecutionEngine/Orc/Legacy.h" -#include "llvm/ExecutionEngine/Orc/NullResolver.h" -#include "llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h" -#include "llvm/ExecutionEngine/SectionMemoryManager.h" -#include "llvm/IR/Constants.h" -#include "llvm/IR/LLVMContext.h" -#include "gtest/gtest.h" - -using namespace llvm; -using namespace llvm::orc; - -namespace { - -class RTDyldObjectLinkingLayer2ExecutionTest : public testing::Test, - public OrcExecutionTest {}; - -// Adds an object with a debug section to RuntimeDyld and then returns whether -// the debug section was passed to the memory manager. -static bool testSetProcessAllSections(std::unique_ptr Obj, - bool ProcessAllSections) { - class MemoryManagerWrapper : public SectionMemoryManager { - public: - MemoryManagerWrapper(bool &DebugSeen) : DebugSeen(DebugSeen) {} - uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment, - unsigned SectionID, StringRef SectionName, - bool IsReadOnly) override { - if (SectionName == ".debug_str") - DebugSeen = true; - return SectionMemoryManager::allocateDataSection( - Size, Alignment, SectionID, SectionName, IsReadOnly); - } - - private: - bool &DebugSeen; - }; - - bool DebugSectionSeen = false; - - ExecutionSession ES; - auto &JD = ES.createJITDylib("main"); - auto Foo = ES.intern("foo"); - - RTDyldObjectLinkingLayer2 ObjLayer(ES, [&DebugSectionSeen](VModuleKey) { - return llvm::make_unique(DebugSectionSeen); - }); - - auto OnResolveDoNothing = [](Expected R) { - cantFail(std::move(R)); - }; - - auto OnReadyDoNothing = [](Error Err) { cantFail(std::move(Err)); }; - - ObjLayer.setProcessAllSections(ProcessAllSections); - auto K = ES.allocateVModule(); - cantFail(ObjLayer.add(JD, K, std::move(Obj))); - ES.lookup({&JD}, {Foo}, OnResolveDoNothing, OnReadyDoNothing, - NoDependenciesToRegister); - return DebugSectionSeen; -} - -TEST(RTDyldObjectLinkingLayer2Test, TestSetProcessAllSections) { - LLVMContext Context; - auto M = llvm::make_unique("", Context); - M->setTargetTriple("x86_64-unknown-linux-gnu"); - Type *Int32Ty = IntegerType::get(Context, 32); - GlobalVariable *GV = - new GlobalVariable(*M, Int32Ty, false, GlobalValue::ExternalLinkage, - ConstantInt::get(Int32Ty, 42), "foo"); - - GV->setSection(".debug_str"); - - // Initialize the native target in case this is the first unit test - // to try to build a TM. - OrcNativeTarget::initialize(); - std::unique_ptr TM(EngineBuilder().selectTarget( - Triple(M->getTargetTriple()), "", "", SmallVector())); - if (!TM) - return; - - auto Obj = SimpleCompiler(*TM)(*M); - - EXPECT_FALSE(testSetProcessAllSections( - MemoryBuffer::getMemBufferCopy(Obj->getBuffer()), false)) - << "Debug section seen despite ProcessAllSections being false"; - EXPECT_TRUE(testSetProcessAllSections(std::move(Obj), true)) - << "Expected to see debug section when ProcessAllSections is true"; -} - -TEST(RTDyldObjectLinkingLayer2Test, TestOverrideObjectFlags) { - - OrcNativeTarget::initialize(); - - std::unique_ptr TM( - EngineBuilder().selectTarget(Triple("x86_64-unknown-linux-gnu"), "", "", - SmallVector())); - - if (!TM) - return; - - // Our compiler is going to modify symbol visibility settings without telling - // ORC. This will test our ability to override the flags later. - class FunkySimpleCompiler : public SimpleCompiler { - public: - FunkySimpleCompiler(TargetMachine &TM) : SimpleCompiler(TM) {} - - CompileResult operator()(Module &M) { - auto *Foo = M.getFunction("foo"); - assert(Foo && "Expected function Foo not found"); - Foo->setVisibility(GlobalValue::HiddenVisibility); - return SimpleCompiler::operator()(M); - } - }; - - // Create a module with two void() functions: foo and bar. - ThreadSafeContext TSCtx(llvm::make_unique()); - ThreadSafeModule M; - { - ModuleBuilder MB(*TSCtx.getContext(), TM->getTargetTriple().str(), "dummy"); - MB.getModule()->setDataLayout(TM->createDataLayout()); - - Function *FooImpl = MB.createFunctionDecl("foo"); - BasicBlock *FooEntry = - BasicBlock::Create(*TSCtx.getContext(), "entry", FooImpl); - IRBuilder<> B1(FooEntry); - B1.CreateRetVoid(); - - Function *BarImpl = MB.createFunctionDecl("bar"); - BasicBlock *BarEntry = - BasicBlock::Create(*TSCtx.getContext(), "entry", BarImpl); - IRBuilder<> B2(BarEntry); - B2.CreateRetVoid(); - - M = ThreadSafeModule(MB.takeModule(), std::move(TSCtx)); - } - - // Create a simple stack and set the override flags option. - ExecutionSession ES; - auto &JD = ES.createJITDylib("main"); - auto Foo = ES.intern("foo"); - RTDyldObjectLinkingLayer2 ObjLayer( - ES, [](VModuleKey) { return llvm::make_unique(); }); - IRCompileLayer2 CompileLayer(ES, ObjLayer, FunkySimpleCompiler(*TM)); - - ObjLayer.setOverrideObjectFlagsWithResponsibilityFlags(true); - - cantFail(CompileLayer.add(JD, ES.allocateVModule(), std::move(M))); - ES.lookup({&JD}, {Foo}, [](Expected R) { cantFail(std::move(R)); }, - [](Error Err) { cantFail(std::move(Err)); }, - NoDependenciesToRegister); -} - -TEST(RTDyldObjectLinkingLayer2Test, TestAutoClaimResponsibilityForSymbols) { - - OrcNativeTarget::initialize(); - - std::unique_ptr TM( - EngineBuilder().selectTarget(Triple("x86_64-unknown-linux-gnu"), "", "", - SmallVector())); - - if (!TM) - return; - - // Our compiler is going to add a new symbol without telling ORC. - // This will test our ability to auto-claim responsibility later. - class FunkySimpleCompiler : public SimpleCompiler { - public: - FunkySimpleCompiler(TargetMachine &TM) : SimpleCompiler(TM) {} - - CompileResult operator()(Module &M) { - Function *BarImpl = - Function::Create(TypeBuilder::get(M.getContext()), - GlobalValue::ExternalLinkage, "bar", &M); - BasicBlock *BarEntry = - BasicBlock::Create(M.getContext(), "entry", BarImpl); - IRBuilder<> B(BarEntry); - B.CreateRetVoid(); - - return SimpleCompiler::operator()(M); - } - }; - - // Create a module with two void() functions: foo and bar. - ThreadSafeContext TSCtx(llvm::make_unique()); - ThreadSafeModule M; - { - ModuleBuilder MB(*TSCtx.getContext(), TM->getTargetTriple().str(), "dummy"); - MB.getModule()->setDataLayout(TM->createDataLayout()); - - Function *FooImpl = MB.createFunctionDecl("foo"); - BasicBlock *FooEntry = - BasicBlock::Create(*TSCtx.getContext(), "entry", FooImpl); - IRBuilder<> B(FooEntry); - B.CreateRetVoid(); - - M = ThreadSafeModule(MB.takeModule(), std::move(TSCtx)); - } - - // Create a simple stack and set the override flags option. - ExecutionSession ES; - auto &JD = ES.createJITDylib("main"); - auto Foo = ES.intern("foo"); - RTDyldObjectLinkingLayer2 ObjLayer( - ES, [](VModuleKey) { return llvm::make_unique(); }); - IRCompileLayer2 CompileLayer(ES, ObjLayer, FunkySimpleCompiler(*TM)); - - ObjLayer.setAutoClaimResponsibilityForObjectSymbols(true); - - cantFail(CompileLayer.add(JD, ES.allocateVModule(), std::move(M))); - ES.lookup({&JD}, {Foo}, [](Expected R) { cantFail(std::move(R)); }, - [](Error Err) { cantFail(std::move(Err)); }, - NoDependenciesToRegister); -} - -} // end anonymous namespace diff --git a/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp index 62c6b7dfa311..75ccfc9ab0d0 100644 --- a/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp +++ b/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp @@ -1,4 +1,4 @@ -//===- RTDyldObjectLinkingLayerTest.cpp - RTDyld linking layer unit tests -===// +//===--- RTDyldObjectLinkingLayerTest.cpp - RTDyld linking layer tests ---===// // // The LLVM Compiler Infrastructure // @@ -7,13 +7,14 @@ // //===----------------------------------------------------------------------===// -#include "llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h" #include "OrcTestCommon.h" #include "llvm/ExecutionEngine/ExecutionEngine.h" #include "llvm/ExecutionEngine/Orc/CompileUtils.h" +#include "llvm/ExecutionEngine/Orc/IRCompileLayer.h" #include "llvm/ExecutionEngine/Orc/LambdaResolver.h" #include "llvm/ExecutionEngine/Orc/Legacy.h" #include "llvm/ExecutionEngine/Orc/NullResolver.h" +#include "llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h" #include "llvm/ExecutionEngine/SectionMemoryManager.h" #include "llvm/IR/Constants.h" #include "llvm/IR/LLVMContext.h" @@ -25,258 +26,203 @@ using namespace llvm::orc; namespace { class RTDyldObjectLinkingLayerExecutionTest : public testing::Test, - public OrcExecutionTest { + public OrcExecutionTest {}; -}; - -class SectionMemoryManagerWrapper : public SectionMemoryManager { -public: - int FinalizationCount = 0; - int NeedsToReserveAllocationSpaceCount = 0; - - bool needsToReserveAllocationSpace() override { - ++NeedsToReserveAllocationSpaceCount; - return SectionMemoryManager::needsToReserveAllocationSpace(); - } - - bool finalizeMemory(std::string *ErrMsg = nullptr) override { - ++FinalizationCount; - return SectionMemoryManager::finalizeMemory(ErrMsg); - } -}; - -TEST(RTDyldObjectLinkingLayerTest, TestSetProcessAllSections) { +// Adds an object with a debug section to RuntimeDyld and then returns whether +// the debug section was passed to the memory manager. +static bool testSetProcessAllSections(std::unique_ptr Obj, + bool ProcessAllSections) { class MemoryManagerWrapper : public SectionMemoryManager { public: MemoryManagerWrapper(bool &DebugSeen) : DebugSeen(DebugSeen) {} uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment, - unsigned SectionID, - StringRef SectionName, + unsigned SectionID, StringRef SectionName, bool IsReadOnly) override { if (SectionName == ".debug_str") DebugSeen = true; - return SectionMemoryManager::allocateDataSection(Size, Alignment, - SectionID, - SectionName, - IsReadOnly); + return SectionMemoryManager::allocateDataSection( + Size, Alignment, SectionID, SectionName, IsReadOnly); } + private: bool &DebugSeen; }; bool DebugSectionSeen = false; - auto MM = std::make_shared(DebugSectionSeen); ExecutionSession ES; + auto &JD = ES.createJITDylib("main"); + auto Foo = ES.intern("foo"); - RTDyldObjectLinkingLayer ObjLayer(ES, [&MM](VModuleKey) { - return RTDyldObjectLinkingLayer::Resources{ - MM, std::make_shared()}; + RTDyldObjectLinkingLayer ObjLayer(ES, [&DebugSectionSeen](VModuleKey) { + return llvm::make_unique(DebugSectionSeen); }); + auto OnResolveDoNothing = [](Expected R) { + cantFail(std::move(R)); + }; + + auto OnReadyDoNothing = [](Error Err) { cantFail(std::move(Err)); }; + + ObjLayer.setProcessAllSections(ProcessAllSections); + auto K = ES.allocateVModule(); + cantFail(ObjLayer.add(JD, K, std::move(Obj))); + ES.lookup({&JD}, {Foo}, OnResolveDoNothing, OnReadyDoNothing, + NoDependenciesToRegister); + return DebugSectionSeen; +} + +TEST(RTDyldObjectLinkingLayerTest, TestSetProcessAllSections) { LLVMContext Context; auto M = llvm::make_unique("", Context); M->setTargetTriple("x86_64-unknown-linux-gnu"); Type *Int32Ty = IntegerType::get(Context, 32); GlobalVariable *GV = - new GlobalVariable(*M, Int32Ty, false, GlobalValue::ExternalLinkage, + new GlobalVariable(*M, Int32Ty, false, GlobalValue::ExternalLinkage, ConstantInt::get(Int32Ty, 42), "foo"); GV->setSection(".debug_str"); - // Initialize the native target in case this is the first unit test // to try to build a TM. OrcNativeTarget::initialize(); - std::unique_ptr TM( - EngineBuilder().selectTarget(Triple(M->getTargetTriple()), "", "", - SmallVector())); + std::unique_ptr TM(EngineBuilder().selectTarget( + Triple(M->getTargetTriple()), "", "", SmallVector())); if (!TM) return; auto Obj = SimpleCompiler(*TM)(*M); - { - // Test with ProcessAllSections = false (the default). - auto K = ES.allocateVModule(); - cantFail(ObjLayer.addObject( - K, MemoryBuffer::getMemBufferCopy(Obj->getBuffer()))); - cantFail(ObjLayer.emitAndFinalize(K)); - EXPECT_EQ(DebugSectionSeen, false) - << "Unexpected debug info section"; - cantFail(ObjLayer.removeObject(K)); - } - - { - // Test with ProcessAllSections = true. - ObjLayer.setProcessAllSections(true); - auto K = ES.allocateVModule(); - cantFail(ObjLayer.addObject(K, std::move(Obj))); - cantFail(ObjLayer.emitAndFinalize(K)); - EXPECT_EQ(DebugSectionSeen, true) - << "Expected debug info section not seen"; - cantFail(ObjLayer.removeObject(K)); - } + EXPECT_FALSE(testSetProcessAllSections( + MemoryBuffer::getMemBufferCopy(Obj->getBuffer()), false)) + << "Debug section seen despite ProcessAllSections being false"; + EXPECT_TRUE(testSetProcessAllSections(std::move(Obj), true)) + << "Expected to see debug section when ProcessAllSections is true"; } -TEST_F(RTDyldObjectLinkingLayerExecutionTest, NoDuplicateFinalization) { - if (!SupportsJIT) +TEST(RTDyldObjectLinkingLayerTest, TestOverrideObjectFlags) { + + OrcNativeTarget::initialize(); + + std::unique_ptr TM( + EngineBuilder().selectTarget(Triple("x86_64-unknown-linux-gnu"), "", "", + SmallVector())); + + if (!TM) return; - ExecutionSession ES; + // Our compiler is going to modify symbol visibility settings without telling + // ORC. This will test our ability to override the flags later. + class FunkySimpleCompiler : public SimpleCompiler { + public: + FunkySimpleCompiler(TargetMachine &TM) : SimpleCompiler(TM) {} - auto MM = std::make_shared(); - - std::map> Resolvers; - - RTDyldObjectLinkingLayer ObjLayer(ES, [&](VModuleKey K) { - auto I = Resolvers.find(K); - assert(I != Resolvers.end() && "Missing resolver"); - auto R = std::move(I->second); - Resolvers.erase(I); - return RTDyldObjectLinkingLayer::Resources{MM, std::move(R)}; - }); - SimpleCompiler Compile(*TM); - - // Create a pair of modules that will trigger recursive finalization: - // Module 1: - // int bar() { return 42; } - // Module 2: - // int bar(); - // int foo() { return bar(); } - // - // Verify that the memory manager is only finalized once (for Module 2). - // Failure suggests that finalize is being called on the inner RTDyld - // instance (for Module 1) which is unsafe, as it will prevent relocation of - // Module 2. - - ModuleBuilder MB1(Context, "", "dummy"); - { - MB1.getModule()->setDataLayout(TM->createDataLayout()); - Function *BarImpl = MB1.createFunctionDecl("bar"); - BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); - IRBuilder<> Builder(BarEntry); - IntegerType *Int32Ty = IntegerType::get(Context, 32); - Value *FourtyTwo = ConstantInt::getSigned(Int32Ty, 42); - Builder.CreateRet(FourtyTwo); - } - - auto Obj1 = Compile(*MB1.getModule()); - - ModuleBuilder MB2(Context, "", "dummy"); - { - MB2.getModule()->setDataLayout(TM->createDataLayout()); - Function *BarDecl = MB2.createFunctionDecl("bar"); - Function *FooImpl = MB2.createFunctionDecl("foo"); - BasicBlock *FooEntry = BasicBlock::Create(Context, "entry", FooImpl); - IRBuilder<> Builder(FooEntry); - Builder.CreateRet(Builder.CreateCall(BarDecl)); - } - auto Obj2 = Compile(*MB2.getModule()); - - auto K1 = ES.allocateVModule(); - Resolvers[K1] = std::make_shared(); - cantFail(ObjLayer.addObject(K1, std::move(Obj1))); - - auto K2 = ES.allocateVModule(); - auto LegacyLookup = [&](const std::string &Name) { - return ObjLayer.findSymbol(Name, true); + CompileResult operator()(Module &M) { + auto *Foo = M.getFunction("foo"); + assert(Foo && "Expected function Foo not found"); + Foo->setVisibility(GlobalValue::HiddenVisibility); + return SimpleCompiler::operator()(M); + } }; - Resolvers[K2] = createSymbolResolver( - [&](const SymbolNameSet &Symbols) { - return cantFail( - getResponsibilitySetWithLegacyFn(Symbols, LegacyLookup)); - }, - [&](std::shared_ptr Query, - const SymbolNameSet &Symbols) { - return lookupWithLegacyFn(ES, *Query, Symbols, LegacyLookup); - }); + // Create a module with two void() functions: foo and bar. + ThreadSafeContext TSCtx(llvm::make_unique()); + ThreadSafeModule M; + { + ModuleBuilder MB(*TSCtx.getContext(), TM->getTargetTriple().str(), "dummy"); + MB.getModule()->setDataLayout(TM->createDataLayout()); - cantFail(ObjLayer.addObject(K2, std::move(Obj2))); - cantFail(ObjLayer.emitAndFinalize(K2)); - cantFail(ObjLayer.removeObject(K2)); + Function *FooImpl = MB.createFunctionDecl("foo"); + BasicBlock *FooEntry = + BasicBlock::Create(*TSCtx.getContext(), "entry", FooImpl); + IRBuilder<> B1(FooEntry); + B1.CreateRetVoid(); - // Finalization of module 2 should trigger finalization of module 1. - // Verify that finalize on SMMW is only called once. - EXPECT_EQ(MM->FinalizationCount, 1) - << "Extra call to finalize"; + Function *BarImpl = MB.createFunctionDecl("bar"); + BasicBlock *BarEntry = + BasicBlock::Create(*TSCtx.getContext(), "entry", BarImpl); + IRBuilder<> B2(BarEntry); + B2.CreateRetVoid(); + + M = ThreadSafeModule(MB.takeModule(), std::move(TSCtx)); + } + + // Create a simple stack and set the override flags option. + ExecutionSession ES; + auto &JD = ES.createJITDylib("main"); + auto Foo = ES.intern("foo"); + RTDyldObjectLinkingLayer ObjLayer( + ES, [](VModuleKey) { return llvm::make_unique(); }); + IRCompileLayer CompileLayer(ES, ObjLayer, FunkySimpleCompiler(*TM)); + + ObjLayer.setOverrideObjectFlagsWithResponsibilityFlags(true); + + cantFail(CompileLayer.add(JD, ES.allocateVModule(), std::move(M))); + ES.lookup({&JD}, {Foo}, [](Expected R) { cantFail(std::move(R)); }, + [](Error Err) { cantFail(std::move(Err)); }, + NoDependenciesToRegister); } -TEST_F(RTDyldObjectLinkingLayerExecutionTest, NoPrematureAllocation) { - if (!SupportsJIT) +TEST(RTDyldObjectLinkingLayerTest, TestAutoClaimResponsibilityForSymbols) { + + OrcNativeTarget::initialize(); + + std::unique_ptr TM( + EngineBuilder().selectTarget(Triple("x86_64-unknown-linux-gnu"), "", "", + SmallVector())); + + if (!TM) return; - ExecutionSession ES; + // Our compiler is going to add a new symbol without telling ORC. + // This will test our ability to auto-claim responsibility later. + class FunkySimpleCompiler : public SimpleCompiler { + public: + FunkySimpleCompiler(TargetMachine &TM) : SimpleCompiler(TM) {} - auto MM = std::make_shared(); + CompileResult operator()(Module &M) { + Function *BarImpl = + Function::Create(TypeBuilder::get(M.getContext()), + GlobalValue::ExternalLinkage, "bar", &M); + BasicBlock *BarEntry = + BasicBlock::Create(M.getContext(), "entry", BarImpl); + IRBuilder<> B(BarEntry); + B.CreateRetVoid(); - RTDyldObjectLinkingLayer ObjLayer(ES, [&MM](VModuleKey K) { - return RTDyldObjectLinkingLayer::Resources{ - MM, std::make_shared()}; - }); - SimpleCompiler Compile(*TM); + return SimpleCompiler::operator()(M); + } + }; - // Create a pair of unrelated modules: - // - // Module 1: - // int foo() { return 42; } - // Module 2: - // int bar() { return 7; } - // - // Both modules will share a memory manager. We want to verify that the - // second object is not loaded before the first one is finalized. To do this - // in a portable way, we abuse the - // RuntimeDyld::MemoryManager::needsToReserveAllocationSpace hook, which is - // called once per object before any sections are allocated. - - ModuleBuilder MB1(Context, "", "dummy"); + // Create a module with two void() functions: foo and bar. + ThreadSafeContext TSCtx(llvm::make_unique()); + ThreadSafeModule M; { - MB1.getModule()->setDataLayout(TM->createDataLayout()); - Function *BarImpl = MB1.createFunctionDecl("foo"); - BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); - IRBuilder<> Builder(BarEntry); - IntegerType *Int32Ty = IntegerType::get(Context, 32); - Value *FourtyTwo = ConstantInt::getSigned(Int32Ty, 42); - Builder.CreateRet(FourtyTwo); + ModuleBuilder MB(*TSCtx.getContext(), TM->getTargetTriple().str(), "dummy"); + MB.getModule()->setDataLayout(TM->createDataLayout()); + + Function *FooImpl = MB.createFunctionDecl("foo"); + BasicBlock *FooEntry = + BasicBlock::Create(*TSCtx.getContext(), "entry", FooImpl); + IRBuilder<> B(FooEntry); + B.CreateRetVoid(); + + M = ThreadSafeModule(MB.takeModule(), std::move(TSCtx)); } - auto Obj1 = Compile(*MB1.getModule()); - - ModuleBuilder MB2(Context, "", "dummy"); - { - MB2.getModule()->setDataLayout(TM->createDataLayout()); - Function *BarImpl = MB2.createFunctionDecl("bar"); - BasicBlock *BarEntry = BasicBlock::Create(Context, "entry", BarImpl); - IRBuilder<> Builder(BarEntry); - IntegerType *Int32Ty = IntegerType::get(Context, 32); - Value *Seven = ConstantInt::getSigned(Int32Ty, 7); - Builder.CreateRet(Seven); - } - auto Obj2 = Compile(*MB2.getModule()); - - auto K = ES.allocateVModule(); - cantFail(ObjLayer.addObject(K, std::move(Obj1))); - cantFail(ObjLayer.addObject(ES.allocateVModule(), std::move(Obj2))); - cantFail(ObjLayer.emitAndFinalize(K)); - cantFail(ObjLayer.removeObject(K)); - - // Only one call to needsToReserveAllocationSpace should have been made. - EXPECT_EQ(MM->NeedsToReserveAllocationSpaceCount, 1) - << "More than one call to needsToReserveAllocationSpace " - "(multiple unrelated objects loaded prior to finalization)"; -} - -TEST_F(RTDyldObjectLinkingLayerExecutionTest, TestNotifyLoadedSignature) { + // Create a simple stack and set the override flags option. ExecutionSession ES; + auto &JD = ES.createJITDylib("main"); + auto Foo = ES.intern("foo"); RTDyldObjectLinkingLayer ObjLayer( - ES, - [](VModuleKey) { - return RTDyldObjectLinkingLayer::Resources{ - nullptr, std::make_shared()}; - }, - [](VModuleKey, const object::ObjectFile &obj, - const RuntimeDyld::LoadedObjectInfo &info) {}); + ES, [](VModuleKey) { return llvm::make_unique(); }); + IRCompileLayer CompileLayer(ES, ObjLayer, FunkySimpleCompiler(*TM)); + + ObjLayer.setAutoClaimResponsibilityForObjectSymbols(true); + + cantFail(CompileLayer.add(JD, ES.allocateVModule(), std::move(M))); + ES.lookup({&JD}, {Foo}, [](Expected R) { cantFail(std::move(R)); }, + [](Error Err) { cantFail(std::move(Err)); }, + NoDependenciesToRegister); } } // end anonymous namespace