maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] check C1002 

Original-commit: flang-compiler/f18@6a2fd760b4
Reviewed-on: https://github.com/flang-compiler/f18/pull/195
Tree-same-pre-rewrite: false
This commit is contained in:
peter klausler 2018-09-18 11:59:25 -07:00
parent 1322e6090f
commit 0787d7f2df
2 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
flang/lib/semantics/expression.cc
View File

@ -245,10 +245,23 @@ MaybeExpr AnalyzeHelper(ExprAnalyzer &ea, const parser::Designator &d) {
if (std::optional<DataRef> dataRef{ExtractDataRef(std::move(result))}) {
if (Component * component{std::get_if<Component>(&dataRef->u)}) {
ea.ComponentRankCheck(*component);
} else if (const Symbol **symbol{
} else if (const Symbol **symbolPointer{
std::get_if<const Symbol *>(&dataRef->u)}) {
// TODO: Whole array reference: append : subscripts, enforce C1002
// Possibly use EA::Subscripts() below.
const Symbol &symbol{**symbolPointer};
if (const auto *details{
symbol.detailsIf<semantics::ObjectEntityDetails>()}) {
if (details->isArray()) {
if (details->isAssumedSize()) { // C1002
// TODO: it's okay to forward an assumed-size array as an argument
// to many functions and all subroutines, though
ea.context.messages.Say(
"assumed-size array '%s' must have subscripts in expression"_err_en_US,
symbol.name().ToString().data());
}
// TODO: Whole array reference: append : subscripts, enforce C1002
// Possibly use EA::Subscripts() below.
}
}
}
}
return result;
@ -642,7 +655,6 @@ MaybeExpr ExprAnalyzer::Subscripts(const Symbol &symbol, ArrayRef &&ref) {
symbolRank, symbol.name().ToString().data(), subscripts);
}
// TODO: fill in bounds of triplets?
// TODO: subtract lowers bounds?
// TODO: enforce constraints, like lack of uppermost bound on assumed-size
if (Component * component{std::get_if<Component>(&ref.u)}) {
int baseRank{component->Rank()};

4
flang/lib/semantics/symbol.h
View File

@ -120,6 +120,10 @@ public:
void set_shape(const ArraySpec &shape);
bool isDummy() const { return isDummy_; }
bool isArray() const { return !shape_.empty(); }
bool isAssumedSize() const {
return isDummy() && isArray() && shape_.back().ubound().isAssumed() &&
!shape_.back().lbound().isAssumed();
}
private:
bool isDummy_;