maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PDB] Fix -Wunused-private-field in DIA 

llvm-svn: 345054
This commit is contained in:
Reid Kleckner 2018-10-23 17:20:16 +00:00
parent 927e8bf316
commit 075897292f
5 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h
View File

@ -17,12 +17,9 @@
namespace llvm {
namespace pdb {
class DIASession;
class DIAEnumFrameData : public IPDBEnumChildren<IPDBFrameData> {
public:
explicit DIAEnumFrameData(const DIASession &PDBSession,
CComPtr<IDiaEnumFrameData> DiaEnumerator);
explicit DIAEnumFrameData(CComPtr<IDiaEnumFrameData> DiaEnumerator);
uint32_t getChildCount() const override;
ChildTypePtr getChildAtIndex(uint32_t Index) const override;
@ -30,7 +27,6 @@ public:
void reset() override;
private:
const DIASession &Session;
CComPtr<IDiaEnumFrameData> Enumerator;
};

4
llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h
View File

@ -20,8 +20,7 @@ class DIASession;
class DIAFrameData : public IPDBFrameData {
public:
explicit DIAFrameData(const DIASession &PDBSession,
CComPtr<IDiaFrameData> DiaFrameData);
explicit DIAFrameData(CComPtr<IDiaFrameData> DiaFrameData);
uint32_t getAddressOffset() const override;
uint32_t getAddressSection() const override;
@ -31,7 +30,6 @@ public:
uint64_t getVirtualAddress() const override;
private:
const DIASession &Session;
CComPtr<IDiaFrameData> FrameData;
};

9
llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp
View File

@ -13,9 +13,8 @@
using namespace llvm::pdb;
DIAEnumFrameData::DIAEnumFrameData(const DIASession &PDBSession,
CComPtr<IDiaEnumFrameData> DiaEnumerator)
: Session(PDBSession), Enumerator(DiaEnumerator) {}
DIAEnumFrameData::DIAEnumFrameData(CComPtr<IDiaEnumFrameData> DiaEnumerator)
: Enumerator(DiaEnumerator) {}
uint32_t DIAEnumFrameData::getChildCount() const {
LONG Count = 0;
@ -28,7 +27,7 @@ DIAEnumFrameData::getChildAtIndex(uint32_t Index) const {
if (S_OK != Enumerator->Item(Index, &Item))
return nullptr;
return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Session, Item));
return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Item));
}
std::unique_ptr<IPDBFrameData> DIAEnumFrameData::getNext() {
@ -37,7 +36,7 @@ std::unique_ptr<IPDBFrameData> DIAEnumFrameData::getNext() {
if (S_OK != Enumerator->Next(1, &Item, &NumFetched))
return nullptr;
return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Session, Item));
return std::unique_ptr<IPDBFrameData>(new DIAFrameData(Item));
}
void DIAEnumFrameData::reset() { Enumerator->Reset(); }

5
llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp
View File

@ -13,9 +13,8 @@
using namespace llvm::pdb;
DIAFrameData::DIAFrameData(const DIASession &PDBSession,
CComPtr<IDiaFrameData> DiaFrameData)
: Session(PDBSession), FrameData(DiaFrameData) {}
DIAFrameData::DIAFrameData(CComPtr<IDiaFrameData> DiaFrameData)
: FrameData(DiaFrameData) {}
template <typename ArgType>
ArgType

2
llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp
View File

@ -428,5 +428,5 @@ DIASession::getFrameData() const {
if (!FD)
return nullptr;
return llvm::make_unique<DIAEnumFrameData>(*this, FD);
return llvm::make_unique<DIAEnumFrameData>(FD);
}