maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

BugReporter (extensive diagnostic algorithm): The initial control-flow edge now 

starts from the first character of the first statement.

llvm-svn: 69813
This commit is contained in:
Ted Kremenek 2009-04-22 18:16:20 +00:00
parent 22579c4c8f
commit 0752a5dff3
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
clang/lib/Analysis/BugReporter.cpp
View File

@ -796,8 +796,9 @@ class VISIBILITY_HIDDEN EdgeBuilder {
public:
EdgeBuilder(PathDiagnostic &pd, PathDiagnosticBuilder &pdb)
: PD(pd), PDB(pdb) {
CLocs.push_back(PathDiagnosticLocation(&PDB.getCodeDecl(),
PDB.getSourceManager()));
// If the PathDiagnostic already has pieces, add the enclosing statement
// of the first piece as a context as well.
if (!PD.empty()) {
PrevLoc = PD.begin()->getLocation();
@ -808,6 +809,15 @@ public:
~EdgeBuilder() {
while (!CLocs.empty()) popLocation();
// Finally, add an initial edge from the start location of the first
// statement (if it doesn't already exist).
if (const CompoundStmt *CS = PDB.getCodeDecl().getBody(PDB.getContext()))
if (!CS->body_empty()) {
SourceLocation Loc = (*CS->body_begin())->getLocStart();
rawAddEdge(PathDiagnosticLocation(Loc, PDB.getSourceManager()));
}
}
void addEdge(PathDiagnosticLocation NewLoc, bool alwaysAdd = false);
@ -907,6 +917,10 @@ void EdgeBuilder::rawAddEdge(PathDiagnosticLocation NewLoc) {
}
void EdgeBuilder::addEdge(PathDiagnosticLocation NewLoc, bool alwaysAdd) {
if (!alwaysAdd && NewLoc.asLocation().isMacroID())
return;
const PathDiagnosticLocation &CLoc = getContextLocation(NewLoc);
while (!CLocs.empty()) {