From 0747a60377397241d856299b5554cc3bce5bad2d Mon Sep 17 00:00:00 2001 From: Matthijs Kooijman Date: Tue, 10 Jun 2008 12:28:43 +0000 Subject: [PATCH] Change llvm.exp so it no longer ignores some errors when executing dejagnu tests. This breaks 80 tests in the tree. The interesting part here is that this no longer ignores syntax errors in RUN command lines. Some tests have not been working all the time because of this. The tricky part is that it now also views any stderr output as an error. This can be suppressed in tcl 8.5, but let's not add this dependency. Instead, all testcases should be changed to redirect stderr if they expect stderr output. This holds in particular for lines like: ; RUN: not llvm-as < %s where an error is expected (but I think I can solve this by modifying the not script). Also, compilations resulting in warnings will now also fail (so the warnings should be fixed, disabled or redirected...). I'll continue with fixing the testcases that are broken now. llvm-svn: 52172 --- llvm/test/lib/llvm.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/llvm/test/lib/llvm.exp b/llvm/test/lib/llvm.exp index b59f341d72b1..409342215b0b 100644 --- a/llvm/test/lib/llvm.exp +++ b/llvm/test/lib/llvm.exp @@ -31,8 +31,12 @@ proc execOneLine { test PRS outcome lineno line } { set resultmsg "$test$PRS\nFailed with posix($posixNum,$posixMsg)$errmsg" } NONE { + # Any other error such as stderr output of a program, or syntax error in + # the RUN line. + set resultmsg "$test$PRS\nFailed with unknown error (or has stderr output)$errmsg" } default { + set resultmsg "$test$PRS\nFailed with unknown error$errmsg" } } }