maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix a "memset clearing an object of non-trivial type" warning in EmulateInstruction 

This is a new warning which started appearing as of gcc-8. The Opcode
class has a non-trivial constructor, so the idea of the warning is that
code should use that to initialize the object instead of using memset
(which can perturb class invariants set up by the constructor). In this
case, the Opcode default constructor was already clearing the object's
fields so we can just drop the memset call.

While I'm touching the EmulateInstruction constructor, I also move the
initialization of other members into the class declaration.

llvm-svn: 356459
This commit is contained in:
Pavel Labath 2019-03-19 15:05:55 +00:00
parent 165435ffa0
commit 06453b0619
2 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lldb/include/lldb/Core/EmulateInstruction.h
View File

@ -511,12 +511,12 @@ public:
protected:
ArchSpec m_arch;
void *m_baton;
ReadMemoryCallback m_read_mem_callback;
WriteMemoryCallback m_write_mem_callback;
ReadRegisterCallback m_read_reg_callback;
WriteRegisterCallback m_write_reg_callback;
lldb::addr_t m_addr;
void *m_baton = nullptr;
ReadMemoryCallback m_read_mem_callback = &ReadMemoryDefault;
WriteMemoryCallback m_write_mem_callback = &WriteMemoryDefault;
ReadRegisterCallback m_read_reg_callback = &ReadRegisterDefault;
WriteRegisterCallback m_write_reg_callback = &WriteRegisterDefault;
lldb::addr_t m_addr = LLDB_INVALID_ADDRESS;
Opcode m_opcode;
private:

9
lldb/source/Core/EmulateInstruction.cpp
View File

@ -71,14 +71,7 @@ EmulateInstruction::FindPlugin(const ArchSpec &arch,
return nullptr;
}
EmulateInstruction::EmulateInstruction(const ArchSpec &arch)
: m_arch(arch), m_baton(nullptr), m_read_mem_callback(&ReadMemoryDefault),
m_write_mem_callback(&WriteMemoryDefault),
m_read_reg_callback(&ReadRegisterDefault),
m_write_reg_callback(&WriteRegisterDefault),
m_addr(LLDB_INVALID_ADDRESS) {
::memset(&m_opcode, 0, sizeof(m_opcode));
}
EmulateInstruction::EmulateInstruction(const ArchSpec &arch) : m_arch(arch) {}
bool EmulateInstruction::ReadRegister(const RegisterInfo *reg_info,
RegisterValue &reg_value) {