maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Delete copy operations on PluginInterface class 

This is a polymorphic class, copying it is a bad idea.

This was not a problem because most classes inheriting from it were
deleting their copy operations themselves. However, this enables us to
delete those explicit deletions, and ensure noone forgets to add them in
the future.
This commit is contained in:
Pavel Labath 2020-10-09 10:35:02 +02:00
parent dd3014f3dc
commit 0610a25a85
46 changed files with 6 additions and 206 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/include/lldb/Core/Architecture.h
View File

@ -15,9 +15,6 @@ namespace lldb_private {
class Architecture : public PluginInterface {
public:
Architecture() = default;
~Architecture() override = default;
/// This is currently intended to handle cases where a
/// program stops at an instruction that won't get executed and it
/// allows the stop reason, like "breakpoint hit", to be replaced
@ -100,10 +97,6 @@ public:
Target &target) const {
return addr;
}
private:
Architecture(const Architecture &) = delete;
void operator=(const Architecture &) = delete;
};
} // namespace lldb_private

6
lldb/include/lldb/Core/PluginInterface.h
View File

@ -15,11 +15,15 @@ namespace lldb_private {
class PluginInterface {
public:
virtual ~PluginInterface() {}
PluginInterface() = default;
virtual ~PluginInterface() = default;
virtual ConstString GetPluginName() = 0;
virtual uint32_t GetPluginVersion() = 0;
PluginInterface(const PluginInterface &) = delete;
PluginInterface &operator=(const PluginInterface &) = delete;
};
} // namespace lldb_private

8
lldb/include/lldb/Symbol/SymbolVendor.h
View File

@ -14,6 +14,7 @@
#include "lldb/Core/ModuleChild.h"
#include "lldb/Core/PluginInterface.h"
#include "lldb/Symbol/SourceModule.h"
#include "lldb/Symbol/SymbolFile.h"
#include "lldb/Symbol/TypeMap.h"
#include "lldb/lldb-private.h"
#include "llvm/ADT/DenseSet.h"
@ -35,8 +36,6 @@ public:
// Constructors and Destructors
SymbolVendor(const lldb::ModuleSP &module_sp);
~SymbolVendor() override;
void AddSymbolFileRepresentation(const lldb::ObjectFileSP &objfile_sp);
SymbolFile *GetSymbolFile() { return m_sym_file_up.get(); }
@ -49,11 +48,6 @@ public:
protected:
std::unique_ptr<SymbolFile> m_sym_file_up; // A single symbol file. Subclasses
// can add more of these if needed.
private:
// For SymbolVendor only
SymbolVendor(const SymbolVendor &) = delete;
const SymbolVendor &operator=(const SymbolVendor &) = delete;
};
} // namespace lldb_private

10
lldb/include/lldb/Target/DynamicLoader.h
View File

@ -68,12 +68,6 @@ public:
/// Construct with a process.
DynamicLoader(Process *process);
/// Destructor.
///
/// The destructor is virtual since this class is designed to be inherited
/// from by the plug-in instance.
~DynamicLoader() override;
/// Called after attaching a process.
///
/// Allow DynamicLoader plug-ins to execute some code after attaching to a
@ -308,10 +302,6 @@ protected:
// Member variables.
Process
*m_process; ///< The process that this dynamic loader plug-in is tracking.
private:
DynamicLoader(const DynamicLoader &) = delete;
const DynamicLoader &operator=(const DynamicLoader &) = delete;
};
} // namespace lldb_private

6
lldb/include/lldb/Target/LanguageRuntime.h
View File

@ -59,8 +59,6 @@ protected:
class LanguageRuntime : public Runtime, public PluginInterface {
public:
~LanguageRuntime() override;
static LanguageRuntime *FindPlugin(Process *process,
lldb::LanguageType language);
@ -177,10 +175,6 @@ public:
protected:
LanguageRuntime(Process *process);
private:
LanguageRuntime(const LanguageRuntime &) = delete;
const LanguageRuntime &operator=(const LanguageRuntime &) = delete;
};
} // namespace lldb_private

6
lldb/include/lldb/Target/OperatingSystem.h
View File

@ -40,11 +40,8 @@ public:
/// should be used. If NULL, pick the best plug-in.
static OperatingSystem *FindPlugin(Process *process, const char *plugin_name);
// Class Methods
OperatingSystem(Process *process);
~OperatingSystem() override;
// Plug-in Methods
virtual bool UpdateThreadList(ThreadList &old_thread_list,
ThreadList &real_thread_list,
@ -68,9 +65,6 @@ protected:
// Member variables.
Process
*m_process; ///< The process that this dynamic loader plug-in is tracking.
private:
OperatingSystem(const OperatingSystem &) = delete;
const OperatingSystem &operator=(const OperatingSystem &) = delete;
};
} // namespace lldb_private

3
lldb/include/lldb/Target/Platform.h
View File

@ -951,9 +951,6 @@ private:
Platform &remote_platform);
FileSpec GetModuleCacheRoot();
Platform(const Platform &) = delete;
const Platform &operator=(const Platform &) = delete;
};
class PlatformList {

7
lldb/include/lldb/Target/UnwindAssembly.h
View File

@ -20,8 +20,6 @@ class UnwindAssembly : public std::enable_shared_from_this<UnwindAssembly>,
public:
static lldb::UnwindAssemblySP FindPlugin(const ArchSpec &arch);
~UnwindAssembly() override;
virtual bool
GetNonCallSiteUnwindPlanFromAssembly(AddressRange &func, Thread &thread,
UnwindPlan &unwind_plan) = 0;
@ -42,11 +40,6 @@ public:
protected:
UnwindAssembly(const ArchSpec &arch);
ArchSpec m_arch;
private:
UnwindAssembly() = delete;
UnwindAssembly(const UnwindAssembly &) = delete;
const UnwindAssembly &operator=(const UnwindAssembly &) = delete;
};
} // namespace lldb_private

2
lldb/source/Core/DynamicLoader.cpp
View File

@ -60,8 +60,6 @@ DynamicLoader *DynamicLoader::FindPlugin(Process *process,
DynamicLoader::DynamicLoader(Process *process) : m_process(process) {}
DynamicLoader::~DynamicLoader() = default;
// Accessosors to the global setting as to whether to stop at image (shared
// library) loading/unloading.

4
lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
View File

@ -131,10 +131,6 @@ protected:
private:
const lldb_private::SectionList *
GetSectionListFromModule(const lldb::ModuleSP module) const;
DynamicLoaderHexagonDYLD(const DynamicLoaderHexagonDYLD &) = delete;
const DynamicLoaderHexagonDYLD &
operator=(const DynamicLoaderHexagonDYLD &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_DYNAMICLOADER_HEXAGON_DYLD_DYNAMICLOADERHEXAGONDYLD_H

4
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
View File

@ -103,10 +103,6 @@ protected:
// exec's when talking to
// debugservers that don't support
// the "reason:exec" annotation.
private:
DynamicLoaderMacOS(const DynamicLoaderMacOS &) = delete;
const DynamicLoaderMacOS &operator=(const DynamicLoaderMacOS &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_DYNAMICLOADER_MACOSX_DYLD_DYNAMICLOADERMACOS_H

3
lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp
View File

@ -63,9 +63,6 @@ DynamicLoader *DynamicLoaderStatic::CreateInstance(Process *process,
DynamicLoaderStatic::DynamicLoaderStatic(Process *process)
: DynamicLoader(process) {}
// Destructor
DynamicLoaderStatic::~DynamicLoaderStatic() {}
/// Called after attaching a process.
///
/// Allow DynamicLoader plug-ins to execute some code after

5
lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.h
View File

@ -18,8 +18,6 @@ class DynamicLoaderStatic : public lldb_private::DynamicLoader {
public:
DynamicLoaderStatic(lldb_private::Process *process);
~DynamicLoaderStatic() override;
// Static Functions
static void Initialize();
@ -52,9 +50,6 @@ public:
private:
void LoadAllImagesAtFileAddresses();
DynamicLoaderStatic(const DynamicLoaderStatic &) = delete;
const DynamicLoaderStatic &operator=(const DynamicLoaderStatic &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_DYNAMICLOADER_STATIC_DYNAMICLOADERSTATIC_H

3
lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
View File

@ -37,9 +37,6 @@ static ConstString g_this = ConstString("this");
char CPPLanguageRuntime::ID = 0;
// Destructor
CPPLanguageRuntime::~CPPLanguageRuntime() {}
CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}

5
lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h
View File

@ -40,8 +40,6 @@ public:
LibCppStdFunctionCallableInfo
FindLibCppStdFunctionCallableInfo(lldb::ValueObjectSP &valobj_sp);
~CPPLanguageRuntime() override;
static char ID;
bool isA(const void *ClassID) const override {
@ -89,9 +87,6 @@ private:
llvm::StringMap<CPPLanguageRuntime::LibCppStdFunctionCallableInfo>;
OperatorStringToCallableInfoMap CallableLookupCache;
CPPLanguageRuntime(const CPPLanguageRuntime &) = delete;
const CPPLanguageRuntime &operator=(const CPPLanguageRuntime &) = delete;
};
} // namespace lldb_private

2
lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
View File

@ -130,8 +130,6 @@ PlatformSP PlatformAndroid::CreateInstance(bool force, const ArchSpec *arch) {
PlatformAndroid::PlatformAndroid(bool is_host)
: PlatformLinux(is_host), m_sdk_version(0) {}
PlatformAndroid::~PlatformAndroid() {}
ConstString PlatformAndroid::GetPluginNameStatic(bool is_host) {
if (is_host) {
static ConstString g_host_name(Platform::GetHostPlatformName());

5
lldb/source/Plugins/Platform/Android/PlatformAndroid.h
View File

@ -23,8 +23,6 @@ class PlatformAndroid : public platform_linux::PlatformLinux {
public:
PlatformAndroid(bool is_host);
~PlatformAndroid() override;
static void Initialize();
static void Terminate();
@ -76,9 +74,6 @@ private:
std::unique_ptr<AdbClient::SyncService> m_adb_sync_svc;
std::string m_device_id;
uint32_t m_sdk_version;
PlatformAndroid(const PlatformAndroid &) = delete;
const PlatformAndroid &operator=(const PlatformAndroid &) = delete;
};
} // namespace platofor_android

2
lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
View File

@ -125,8 +125,6 @@ PlatformFreeBSD::PlatformFreeBSD(bool is_host)
: PlatformPOSIX(is_host) // This is the local host platform
{}
PlatformFreeBSD::~PlatformFreeBSD() = default;
bool PlatformFreeBSD::GetSupportedArchitectureAtIndex(uint32_t idx,
ArchSpec &arch) {
if (IsHost()) {

6
lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.h
View File

@ -18,8 +18,6 @@ class PlatformFreeBSD : public PlatformPOSIX {
public:
PlatformFreeBSD(bool is_host);
~PlatformFreeBSD() override;
static void Initialize();
static void Terminate();
@ -55,10 +53,6 @@ public:
lldb::addr_t length, unsigned prot,
unsigned flags, lldb::addr_t fd,
lldb::addr_t offset) override;
private:
PlatformFreeBSD(const PlatformFreeBSD &) = delete;
const PlatformFreeBSD &operator=(const PlatformFreeBSD &) = delete;
};
} // namespace platform_freebsd

2
lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
View File

@ -124,8 +124,6 @@ PlatformLinux::PlatformLinux(bool is_host)
: PlatformPOSIX(is_host) // This is the local host platform
{}
PlatformLinux::~PlatformLinux() = default;
bool PlatformLinux::GetSupportedArchitectureAtIndex(uint32_t idx,
ArchSpec &arch) {
if (IsHost()) {

6
lldb/source/Plugins/Platform/Linux/PlatformLinux.h
View File

@ -18,8 +18,6 @@ class PlatformLinux : public PlatformPOSIX {
public:
PlatformLinux(bool is_host);
~PlatformLinux() override;
static void Initialize();
static void Terminate();
@ -54,10 +52,6 @@ public:
lldb::addr_t length, unsigned prot,
unsigned flags, lldb::addr_t fd,
lldb::addr_t offset) override;
private:
PlatformLinux(const PlatformLinux &) = delete;
const PlatformLinux &operator=(const PlatformLinux &) = delete;
};
} // namespace platform_linux

6
lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
View File

@ -171,12 +171,6 @@ const char *PlatformMacOSX::GetDescriptionStatic(bool is_host) {
/// Default Constructor
PlatformMacOSX::PlatformMacOSX(bool is_host) : PlatformDarwin(is_host) {}
/// Destructor.
///
/// The destructor is virtual since this class is designed to be
/// inherited from by the plug-in instance.
PlatformMacOSX::~PlatformMacOSX() {}
ConstString PlatformMacOSX::GetSDKDirectory(lldb_private::Target &target) {
ModuleSP exe_module_sp(target.GetExecutableModule());
if (!exe_module_sp)

5
lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
View File

@ -15,8 +15,6 @@ class PlatformMacOSX : public PlatformDarwin {
public:
PlatformMacOSX(bool is_host);
~PlatformMacOSX() override;
// Class functions
static lldb::PlatformSP CreateInstance(bool force,
const lldb_private::ArchSpec *arch);
@ -77,9 +75,6 @@ public:
}
private:
PlatformMacOSX(const PlatformMacOSX &) = delete;
const PlatformMacOSX &operator=(const PlatformMacOSX &) = delete;
#if defined(__arm__) || defined(__arm64__) || defined(__aarch64__)
uint32_t m_num_arm_arches = 0;
#endif

7
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.h
View File

@ -21,8 +21,6 @@ class PlatformRemoteAppleBridge : public PlatformRemoteDarwinDevice {
public:
PlatformRemoteAppleBridge();
~PlatformRemoteAppleBridge() override = default;
// Class Functions
static lldb::PlatformSP CreateInstance(bool force,
const lldb_private::ArchSpec *arch);
@ -56,11 +54,6 @@ protected:
void GetDeviceSupportDirectoryNames (std::vector<std::string> &dirnames) override;
std::string GetPlatformName () override;
private:
PlatformRemoteAppleBridge(const PlatformRemoteAppleBridge &) = delete;
const PlatformRemoteAppleBridge &
operator=(const PlatformRemoteAppleBridge &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEAPPLEBRIDGE_H

7
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.h
View File

@ -21,8 +21,6 @@ class PlatformRemoteAppleTV : public PlatformRemoteDarwinDevice {
public:
PlatformRemoteAppleTV();
~PlatformRemoteAppleTV() override = default;
// Class Functions
static lldb::PlatformSP CreateInstance(bool force,
const lldb_private::ArchSpec *arch);
@ -56,11 +54,6 @@ protected:
void GetDeviceSupportDirectoryNames (std::vector<std::string> &dirnames) override;
std::string GetPlatformName () override;
private:
PlatformRemoteAppleTV(const PlatformRemoteAppleTV &) = delete;
const PlatformRemoteAppleTV &
operator=(const PlatformRemoteAppleTV &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEAPPLETV_H

7
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.h
View File

@ -22,8 +22,6 @@ class PlatformRemoteAppleWatch : public PlatformRemoteDarwinDevice {
public:
PlatformRemoteAppleWatch();
~PlatformRemoteAppleWatch() override = default;
// Class Functions
static lldb::PlatformSP CreateInstance(bool force,
const lldb_private::ArchSpec *arch);
@ -59,11 +57,6 @@ protected:
void GetDeviceSupportDirectoryNames (std::vector<std::string> &dirnames) override;
std::string GetPlatformName () override;
private:
PlatformRemoteAppleWatch(const PlatformRemoteAppleWatch &) = delete;
const PlatformRemoteAppleWatch &
operator=(const PlatformRemoteAppleWatch &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEAPPLEWATCH_H

6
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
View File

@ -20,8 +20,6 @@ class PlatformRemoteiOS : public PlatformRemoteDarwinDevice {
public:
PlatformRemoteiOS();
~PlatformRemoteiOS() override = default;
// Class Functions
static lldb::PlatformSP CreateInstance(bool force,
const lldb_private::ArchSpec *arch);
@ -55,10 +53,6 @@ protected:
void GetDeviceSupportDirectoryNames (std::vector<std::string> &dirnames) override;
std::string GetPlatformName () override;
private:
PlatformRemoteiOS(const PlatformRemoteiOS &) = delete;
const PlatformRemoteiOS &operator=(const PlatformRemoteiOS &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEIOS_H

2
lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
View File

@ -117,8 +117,6 @@ PlatformNetBSD::PlatformNetBSD(bool is_host)
: PlatformPOSIX(is_host) // This is the local host platform
{}
PlatformNetBSD::~PlatformNetBSD() = default;
bool PlatformNetBSD::GetSupportedArchitectureAtIndex(uint32_t idx,
ArchSpec &arch) {
if (IsHost()) {

6
lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.h
View File

@ -18,8 +18,6 @@ class PlatformNetBSD : public PlatformPOSIX {
public:
PlatformNetBSD(bool is_host);
~PlatformNetBSD() override;
static void Initialize();
static void Terminate();
@ -54,10 +52,6 @@ public:
lldb::addr_t length, unsigned prot,
unsigned flags, lldb::addr_t fd,
lldb::addr_t offset) override;
private:
PlatformNetBSD(const PlatformNetBSD &) = delete;
const PlatformNetBSD &operator=(const PlatformNetBSD &) = delete;
};
} // namespace platform_netbsd

2
lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp
View File

@ -123,8 +123,6 @@ PlatformOpenBSD::PlatformOpenBSD(bool is_host)
: PlatformPOSIX(is_host) // This is the local host platform
{}
PlatformOpenBSD::~PlatformOpenBSD() = default;
bool PlatformOpenBSD::GetSupportedArchitectureAtIndex(uint32_t idx,
ArchSpec &arch) {
if (IsHost()) {

6
lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.h
View File

@ -18,8 +18,6 @@ class PlatformOpenBSD : public PlatformPOSIX {
public:
PlatformOpenBSD(bool is_host);
~PlatformOpenBSD() override;
static void Initialize();
static void Terminate();
@ -52,10 +50,6 @@ public:
lldb::addr_t length, unsigned prot,
unsigned flags, lldb::addr_t fd,
lldb::addr_t offset) override;
private:
PlatformOpenBSD(const PlatformOpenBSD &) = delete;
const PlatformOpenBSD &operator=(const PlatformOpenBSD &) = delete;
};
} // namespace platform_openbsd

6
lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
View File

@ -151,12 +151,6 @@ void PlatformWindows::Terminate() {
/// Default Constructor
PlatformWindows::PlatformWindows(bool is_host) : RemoteAwarePlatform(is_host) {}
/// Destructor.
///
/// The destructor is virtual since this class is designed to be
/// inherited from by the plug-in instance.
PlatformWindows::~PlatformWindows() = default;
Status PlatformWindows::ConnectRemote(Args &args) {
Status error;
if (IsHost()) {

6
lldb/source/Plugins/Platform/Windows/PlatformWindows.h
View File

@ -17,8 +17,6 @@ class PlatformWindows : public RemoteAwarePlatform {
public:
PlatformWindows(bool is_host);
~PlatformWindows() override;
static void Initialize();
static void Terminate();
@ -65,10 +63,6 @@ public:
void CalculateTrapHandlerSymbolNames() override {}
ConstString GetFullNameForDylib(ConstString basename) override;
private:
PlatformWindows(const PlatformWindows &) = delete;
const PlatformWindows &operator=(const PlatformWindows &) = delete;
};
} // namespace lldb_private

2
lldb/source/Plugins/Process/elf-core/ProcessElfCore.h
View File

@ -125,8 +125,6 @@ private:
lldb::ModuleSP m_core_module_sp;
lldb_private::FileSpec m_core_file;
std::string m_dyld_plugin_name;
ProcessElfCore(const ProcessElfCore &) = delete;
const ProcessElfCore &operator=(const ProcessElfCore &) = delete;
// True if m_thread_contexts contains valid entries
bool m_thread_data_valid = false;

3
lldb/source/Plugins/Process/mach-core/ProcessMachCore.h
View File

@ -120,9 +120,6 @@ private:
lldb::addr_t m_dyld_addr;
lldb::addr_t m_mach_kernel_addr;
lldb_private::ConstString m_dyld_plugin_name;
ProcessMachCore(const ProcessMachCore &) = delete;
const ProcessMachCore &operator=(const ProcessMachCore &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACH_CORE_PROCESSMACHCORE_H

2
lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp
View File

@ -59,8 +59,6 @@ SymbolFileSymtab::SymbolFileSymtab(ObjectFileSP objfile_sp)
: SymbolFile(std::move(objfile_sp)), m_source_indexes(), m_func_indexes(),
m_code_indexes(), m_objc_class_name_to_index() {}
SymbolFileSymtab::~SymbolFileSymtab() {}
uint32_t SymbolFileSymtab::CalculateAbilities() {
uint32_t abilities = 0;
if (m_objfile_sp) {

6
lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h
View File

@ -31,8 +31,6 @@ public:
// Constructors and Destructors
SymbolFileSymtab(lldb::ObjectFileSP objfile_sp);
~SymbolFileSymtab() override;
// Static Functions
static void Initialize();
@ -104,10 +102,6 @@ protected:
lldb_private::Symtab::IndexCollection m_data_indexes;
lldb_private::Symtab::NameToIndexMap m_objc_class_name_to_index;
TypeMap m_objc_class_types;
private:
SymbolFileSymtab(const SymbolFileSymtab &) = delete;
const SymbolFileSymtab &operator=(const SymbolFileSymtab &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_SYMBOLFILE_SYMTAB_SYMBOLFILESYMTAB_H

3
lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
View File

@ -31,9 +31,6 @@ LLDB_PLUGIN_DEFINE(SymbolVendorELF)
SymbolVendorELF::SymbolVendorELF(const lldb::ModuleSP &module_sp)
: SymbolVendor(module_sp) {}
// Destructor
SymbolVendorELF::~SymbolVendorELF() {}
void SymbolVendorELF::Initialize() {
PluginManager::RegisterPlugin(GetPluginNameStatic(),
GetPluginDescriptionStatic(), CreateInstance);

6
lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h
View File

@ -17,8 +17,6 @@ public:
// Constructors and Destructors
SymbolVendorELF(const lldb::ModuleSP &module_sp);
~SymbolVendorELF() override;
// Static Functions
static void Initialize();
@ -36,10 +34,6 @@ public:
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
private:
SymbolVendorELF(const SymbolVendorELF &) = delete;
const SymbolVendorELF &operator=(const SymbolVendorELF &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_SYMBOLVENDOR_ELF_SYMBOLVENDORELF_H

3
lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
View File

@ -33,9 +33,6 @@ LLDB_PLUGIN_DEFINE(SymbolVendorMacOSX)
SymbolVendorMacOSX::SymbolVendorMacOSX(const lldb::ModuleSP &module_sp)
: SymbolVendor(module_sp) {}
// Destructor
SymbolVendorMacOSX::~SymbolVendorMacOSX() {}
static bool UUIDsMatch(Module *module, ObjectFile *ofile,
lldb_private::Stream *feedback_strm) {
if (module && ofile) {

6
lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h
View File

@ -30,16 +30,10 @@ public:
// Constructors and Destructors
SymbolVendorMacOSX(const lldb::ModuleSP &module_sp);
virtual ~SymbolVendorMacOSX();
// PluginInterface protocol
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
private:
SymbolVendorMacOSX(const SymbolVendorMacOSX &) = delete;
const SymbolVendorMacOSX &operator=(const SymbolVendorMacOSX &) = delete;
};
#endif // LLDB_SOURCE_PLUGINS_SYMBOLVENDOR_MACOSX_SYMBOLVENDORMACOSX_H

4
lldb/source/Plugins/SymbolVendor/wasm/SymbolVendorWasm.h
View File

@ -33,10 +33,6 @@ public:
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
/// \}
private:
SymbolVendorWasm(const SymbolVendorWasm &) = delete;
const SymbolVendorWasm &operator=(const SymbolVendorWasm &) = delete;
};
} // namespace wasm

3
lldb/source/Symbol/SymbolVendor.cpp
View File

@ -60,9 +60,6 @@ SymbolVendor *SymbolVendor::FindPlugin(const lldb::ModuleSP &module_sp,
SymbolVendor::SymbolVendor(const lldb::ModuleSP &module_sp)
: ModuleChild(module_sp), m_sym_file_up() {}
// Destructor
SymbolVendor::~SymbolVendor() {}
// Add a representation given an object file.
void SymbolVendor::AddSymbolFileRepresentation(const ObjectFileSP &objfile_sp) {
ModuleSP module_sp(GetModule());

2
lldb/source/Target/LanguageRuntime.cpp
View File

@ -216,8 +216,6 @@ LanguageRuntime *LanguageRuntime::FindPlugin(Process *process,
LanguageRuntime::LanguageRuntime(Process *process) : Runtime(process) {}
LanguageRuntime::~LanguageRuntime() = default;
BreakpointPreconditionSP
LanguageRuntime::GetExceptionPrecondition(LanguageType language,
bool throw_bp) {

2
lldb/source/Target/OperatingSystem.cpp
View File

@ -44,8 +44,6 @@ OperatingSystem *OperatingSystem::FindPlugin(Process *process,
OperatingSystem::OperatingSystem(Process *process) : m_process(process) {}
OperatingSystem::~OperatingSystem() = default;
bool OperatingSystem::IsOperatingSystemPluginThread(
const lldb::ThreadSP &thread_sp) {
if (thread_sp)

2
lldb/source/Target/UnwindAssembly.cpp
View File

@ -29,5 +29,3 @@ UnwindAssemblySP UnwindAssembly::FindPlugin(const ArchSpec &arch) {
}
UnwindAssembly::UnwindAssembly(const ArchSpec &arch) : m_arch(arch) {}
UnwindAssembly::~UnwindAssembly() = default;