maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer] Fix capitalization in ObjCSuperDealloc checker diagnostic. 

Change "use of 'self'..." to "Use of 'self'...". The convention is to
start diagnostics with a capital letter.

rdar://problem/28322494

llvm-svn: 285759
This commit is contained in:
Devin Coughlin 2016-11-01 22:16:39 +00:00
parent 690f8e587e
commit 05c03845e7
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
View File

@ -191,7 +191,7 @@ void ObjCSuperDeallocChecker::reportUseAfterDealloc(SymbolRef Sym,
return; return;
if (Desc.empty()) if (Desc.empty())
Desc = "use of 'self' after it has been deallocated"; Desc = "Use of 'self' after it has been deallocated";
// Generate the report. // Generate the report.
std::unique_ptr<BugReport> BR( std::unique_ptr<BugReport> BR(

28
clang/test/Analysis/DeallocUseAfterFreeErrors.m
View File

@ -125,8 +125,8 @@ struct SomeStruct {
} }
- (void)dealloc { - (void)dealloc {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
self.ivar = nil; // expected-warning {{use of 'self' after it has been deallocated}} self.ivar = nil; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -144,8 +144,8 @@ struct SomeStruct {
} }
- (void)dealloc { - (void)dealloc {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
self.delegate = nil; // expected-warning {{use of 'self' after it has been deallocated}} self.delegate = nil; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -158,8 +158,8 @@ struct SomeStruct {
} }
- (void)dealloc { - (void)dealloc {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
[self _invalidate]; // expected-warning {{use of 'self' after it has been deallocated}} [self _invalidate]; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -173,8 +173,8 @@ static void _invalidate(NSObject *object) {
@implementation SuperDeallocThenCallNonObjectiveCMethodClass @implementation SuperDeallocThenCallNonObjectiveCMethodClass
- (void)dealloc { - (void)dealloc {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
_invalidate(self); // expected-warning {{use of 'self' after it has been deallocated}} _invalidate(self); // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -187,8 +187,8 @@ static void _invalidate(NSObject *object) {
- (void)dealloc { - (void)dealloc {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
[SuperDeallocThenCallObjectiveClassMethodClass invalidate:self]; // expected-warning {{use of 'self' after it has been deallocated}} [SuperDeallocThenCallObjectiveClassMethodClass invalidate:self]; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -208,8 +208,8 @@ static void _invalidate(NSObject *object) {
return; return;
} }
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
[self _invalidate]; // expected-warning {{use of 'self' after it has been deallocated}} [self _invalidate]; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
} }
@end @end
@ -366,8 +366,8 @@ static void _invalidate(NSObject *object) {
- (void)dealloc; { - (void)dealloc; {
[super dealloc]; // expected-note {{[super dealloc] called here}} [super dealloc]; // expected-note {{[super dealloc] called here}}
[self anotherMethod]; // expected-warning {{use of 'self' after it has been deallocated}} [self anotherMethod]; // expected-warning {{Use of 'self' after it has been deallocated}}
// expected-note@-1 {{use of 'self' after it has been deallocated}} // expected-note@-1 {{Use of 'self' after it has been deallocated}}
[super dealloc]; [super dealloc];
} }
@end @end