maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

The return value of createInternalFiles is unused, so remove it. 

llvm-svn: 198266
This commit is contained in:
Joey Gouly 2013-12-31 19:15:42 +00:00
parent e98c8cb9f0
commit 0518453e2e
6 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lld/include/lld/Core/LinkingContext.h
View File

@ -236,7 +236,7 @@ public:
/// during link. Flavors can override this function in their LinkingContext /// during link. Flavors can override this function in their LinkingContext
/// to add more internal files. These internal files are positioned before /// to add more internal files. These internal files are positioned before
/// the actual input files. /// the actual input files.
virtual bool createInternalFiles(std::vector<std::unique_ptr<File> > &) const; virtual void createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
/// Return the list of undefined symbols that are specified in the /// Return the list of undefined symbols that are specified in the
/// linker command line, using the -u option. /// linker command line, using the -u option.

3
lld/lib/Core/LinkingContext.cpp
View File

@ -71,7 +71,7 @@ LinkingContext::createUndefinedSymbolFile(StringRef filename) const {
return std::move(undefinedSymFile); return std::move(undefinedSymFile);
} }
bool LinkingContext::createInternalFiles( void LinkingContext::createInternalFiles(
std::vector<std::unique_ptr<File> > &result) const { std::vector<std::unique_ptr<File> > &result) const {
std::unique_ptr<File> internalFile; std::unique_ptr<File> internalFile;
internalFile = createEntrySymbolFile(); internalFile = createEntrySymbolFile();
@ -80,7 +80,6 @@ bool LinkingContext::createInternalFiles(
internalFile = createUndefinedSymbolFile(); internalFile = createUndefinedSymbolFile();
if (internalFile) if (internalFile)
result.push_back(std::move(internalFile)); result.push_back(std::move(internalFile));
return true;
} }
void LinkingContext::setResolverState(uint32_t state) { void LinkingContext::setResolverState(uint32_t state) {

3
lld/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp
View File

@ -90,7 +90,7 @@ private:
}; };
} }
bool elf::HexagonLinkingContext::createInternalFiles( void elf::HexagonLinkingContext::createInternalFiles(
std::vector<std::unique_ptr<File> > &result) const { std::vector<std::unique_ptr<File> > &result) const {
ELFLinkingContext::createInternalFiles(result); ELFLinkingContext::createInternalFiles(result);
std::unique_ptr<HexagonInitFiniFile> initFiniFile( std::unique_ptr<HexagonInitFiniFile> initFiniFile(
@ -100,5 +100,4 @@ bool elf::HexagonLinkingContext::createInternalFiles(
for (auto ai:finiFunctions()) for (auto ai:finiFunctions())
initFiniFile->addFiniFunction(ai); initFiniFile->addFiniFunction(ai);
result.push_back(std::move(initFiniFile)); result.push_back(std::move(initFiniFile));
return true;
} }

2
lld/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h
View File

@ -66,7 +66,7 @@ public:
} }
/// \brief Create Internal files for Init/Fini /// \brief Create Internal files for Init/Fini
bool createInternalFiles(std::vector<std::unique_ptr<File> > &result) const; void createInternalFiles(std::vector<std::unique_ptr<File> > &result) const;
}; };
} // elf } // elf

3
lld/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp
View File

@ -101,7 +101,7 @@ void elf::X86_64LinkingContext::addPasses(PassManager &pm) {
ELFLinkingContext::addPasses(pm); ELFLinkingContext::addPasses(pm);
} }
bool elf::X86_64LinkingContext::createInternalFiles( void elf::X86_64LinkingContext::createInternalFiles(
std::vector<std::unique_ptr<File> > &result) const { std::vector<std::unique_ptr<File> > &result) const {
ELFLinkingContext::createInternalFiles(result); ELFLinkingContext::createInternalFiles(result);
std::unique_ptr<X86_64InitFiniFile> initFiniFile( std::unique_ptr<X86_64InitFiniFile> initFiniFile(
@ -111,6 +111,5 @@ bool elf::X86_64LinkingContext::createInternalFiles(
for (auto ai:finiFunctions()) for (auto ai:finiFunctions())
initFiniFile->addFiniFunction(ai); initFiniFile->addFiniFunction(ai);
result.push_back(std::move(initFiniFile)); result.push_back(std::move(initFiniFile));
return true;
} }

2
lld/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h
View File

@ -86,7 +86,7 @@ public:
} }
/// \brief Create Internal files for Init/Fini /// \brief Create Internal files for Init/Fini
bool createInternalFiles(std::vector<std::unique_ptr<File> > &) const; void createInternalFiles(std::vector<std::unique_ptr<File> > &) const;
}; };
} // end namespace elf } // end namespace elf