[VE] Extend integer arguments and return values smaller than 64 bits

In order to follow NEC Aurora SX VE ABI correctly, change to sign/zero
extend integer arguments and return values smaller than 64 bits in clang.
Also update regression test.

Reviewed By: simoll

Differential Revision: https://reviews.llvm.org/D85071
This commit is contained in:
Kazushi (Jam) Marukawa 2020-07-25 16:31:07 +09:00
parent 3b92db4c84
commit 045e79e77c
2 changed files with 95 additions and 10 deletions

View File

@ -10743,21 +10743,24 @@ private:
} // end anonymous namespace
ABIArgInfo VEABIInfo::classifyReturnType(QualType Ty) const {
if (Ty->isAnyComplexType()) {
if (Ty->isAnyComplexType())
return ABIArgInfo::getDirect();
}
uint64_t Size = getContext().getTypeSize(Ty);
if (Size < 64 && Ty->isIntegerType())
return ABIArgInfo::getExtend(Ty);
return DefaultABIInfo::classifyReturnType(Ty);
}
ABIArgInfo VEABIInfo::classifyArgumentType(QualType Ty) const {
if (Ty->isAnyComplexType()) {
if (Ty->isAnyComplexType())
return ABIArgInfo::getDirect();
}
uint64_t Size = getContext().getTypeSize(Ty);
if (Size < 64 && Ty->isIntegerType())
return ABIArgInfo::getExtend(Ty);
return DefaultABIInfo::classifyArgumentType(Ty);
}
void VEABIInfo::computeInfo(CGFunctionInfo &FI) const {
FI.getReturnInfo() = classifyReturnType(FI.getReturnType());
for (auto &Arg : FI.arguments())
Arg.info = classifyArgumentType(Arg.type);

View File

@ -1,14 +1,96 @@
/// Check that ABI is correctly implemented.
///
/// 1. Check that all integer arguments and return values less than 64 bits
/// are sign/zero extended.
/// 2. Check that all complex arguments and return values are placed in
/// registers if it is possible. Not treat it as aggregate.
/// 3. Check that a function declared without argument type declarations is
/// treated as VARARGS (in order to place arguments in both registers and
/// memory locations in the back end)
// RUN: %clang_cc1 -triple ve-linux-gnu -emit-llvm %s -o - | FileCheck %s
// CHECK-LABEL: define { float, float } @p(float %a.coerce0, float %a.coerce1, float %b.coerce0, float %b.coerce1) #0 {
float __complex__ p(float __complex__ a, float __complex__ b) {
// CHECK-LABEL: define signext i8 @fun_si8(i8 signext %a, i8 signext %b) #0 {
char fun_si8(char a, char b) {
return a;
}
// CHECK-LABEL: define { double, double } @q(double %a.coerce0, double %a.coerce1, double %b.coerce0, double %b.coerce1) #0 {
double __complex__ q(double __complex__ a, double __complex__ b) {
// CHECK-LABEL: define zeroext i8 @fun_zi8(i8 zeroext %a, i8 zeroext %b) #0 {
unsigned char fun_zi8(unsigned char a, unsigned char b) {
return a;
}
// CHECK-LABEL: define signext i16 @fun_si16(i16 signext %a, i16 signext %b) #0 {
short fun_si16(short a, short b) {
return a;
}
// CHECK-LABEL: define zeroext i16 @fun_zi16(i16 zeroext %a, i16 zeroext %b) #0 {
unsigned short fun_zi16(unsigned short a, unsigned short b) {
return a;
}
// CHECK-LABEL: define signext i32 @fun_si32(i32 signext %a, i32 signext %b) #0 {
int fun_si32(int a, int b) {
return a;
}
// CHECK-LABEL: define zeroext i32 @fun_zi32(i32 zeroext %a, i32 zeroext %b) #0 {
unsigned int fun_zi32(unsigned int a, unsigned int b) {
return a;
}
// CHECK-LABEL: define i64 @fun_si64(i64 %a, i64 %b) #0 {
long fun_si64(long a, long b) {
return a;
}
// CHECK-LABEL: define i64 @fun_zi64(i64 %a, i64 %b) #0 {
unsigned long fun_zi64(unsigned long a, unsigned long b) {
return a;
}
// CHECK-LABEL: define i128 @fun_si128(i128 %a, i128 %b) #0 {
__int128 fun_si128(__int128 a, __int128 b) {
}
// CHECK-LABEL: define i128 @fun_zi128(i128 %a, i128 %b) #0 {
unsigned __int128 fun_zi128(unsigned __int128 a, unsigned __int128 b) {
return a;
}
// CHECK-LABEL: define float @fun_float(float %a, float %b) #0 {
float fun_float(float a, float b) {
return a;
}
// CHECK-LABEL: define double @fun_double(double %a, double %b) #0 {
double fun_double(double a, double b) {
return a;
}
// CHECK-LABEL: define fp128 @fun_quad(fp128 %a, fp128 %b) #0 {
long double fun_quad(long double a, long double b) {
return a;
}
// CHECK-LABEL: define { float, float } @fun_fcomplex(float %a.coerce0, float %a.coerce1, float %b.coerce0, float %b.coerce1) #0 {
float __complex__ fun_fcomplex(float __complex__ a, float __complex__ b) {
return a;
}
// CHECK-LABEL: define { double, double } @fun_dcomplex(double %a.coerce0, double %a.coerce1, double %b.coerce0, double %b.coerce1) #0 {
double __complex__ fun_dcomplex(double __complex__ a, double __complex__ b) {
return a;
}
// CHECK-LABEL: define { fp128, fp128 } @fun_qcomplex(fp128 %a.coerce0, fp128 %a.coerce1, fp128 %b.coerce0, fp128 %b.coerce1) #0 {
long double __complex__ fun_qcomplex(long double __complex__ a, long double __complex__ b) {
return a;
}
extern int hoge();
void func() {
// CHECK-LABEL: %call = call i32 (i32, i32, i32, i32, i32, i32, i32, ...) bitcast (i32 (...)* @hoge to i32 (i32, i32, i32, i32, i32, i32, i32, ...)*)(i32 1, i32 2, i32 3, i32 4, i32 5, i32 6, i32 7)
// CHECK: %call = call signext i32 (i32, i32, i32, i32, i32, i32, i32, ...) bitcast (i32 (...)* @hoge to i32 (i32, i32, i32, i32, i32, i32, i32, ...)*)(i32 signext 1, i32 signext 2, i32 signext 3, i32 signext 4, i32 signext 5, i32 signext 6, i32 signext 7)
hoge(1, 2, 3, 4, 5, 6, 7);
}