maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't fail step out if remote server doesn't implement qMemoryRegionInfo 

Summary:
The return address validation in D71372 will fail if the memory permissions can't be determined. Many embedded stubs either don't implement the qMemoryRegionInfo packet, or don't have memory permissions at all.

Remove the return from the if clause that calls GetLoadAddressPermissions, so this call failing doesn't cause the step out to abort. Instead, assume that the memory permission check doesn't apply to this type of target.

Reviewers: labath, jingham, clayborg, mossberg

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72513
This commit is contained in:
Ted Woodward 2020-01-28 13:31:40 -06:00
parent 90a10f00ff
commit 04488c485a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lldb/source/Target/ThreadPlanStepOut.cpp
View File

@ -135,7 +135,6 @@ ThreadPlanStepOut::ThreadPlanStepOut(
m_return_addr); m_return_addr);
LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this), LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this),
m_constructor_errors.GetData()); m_constructor_errors.GetData());
return;
} else if (!(permissions & ePermissionsExecutable)) { } else if (!(permissions & ePermissionsExecutable)) {
m_constructor_errors.Printf("Return address (0x%" PRIx64 m_constructor_errors.Printf("Return address (0x%" PRIx64
") did not point to executable memory.", ") did not point to executable memory.",