From 04419628e011d32a1b3dd8efd981ed9e978bf43d Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Sun, 4 Apr 2021 11:12:58 +0100 Subject: [PATCH] [AMDGPU, test] Fix use of undef FileCheck var Test CodeGen/AMDGPU/amdgpu.private-memory.ll and CodeGen/AMDGPU/private-memory-r600.ll have a block of CHECK directives whose prefix is inconsistent: R600-CHECK Vs R600. This leads to a R600-NOT directive using an undefined CHAN variable due to R600-CHECK directives never being considered by FileCheck. Fixing the prefix leads to the testcase failing. As per https://reviews.llvm.org/D99865#2675235 this commit removes the directives instead since it is not possible to write a reliable check. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D99865 --- llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll | 3 --- llvm/test/CodeGen/AMDGPU/private-memory-r600.ll | 3 --- 2 files changed, 6 deletions(-) diff --git a/llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll b/llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll index 8e455d98eba5..1d9e1bcec178 100644 --- a/llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll +++ b/llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll @@ -275,9 +275,6 @@ entry: ; Test that two stack objects are not stored in the same register ; The second stack object should be in T3.X ; FUNC-LABEL: {{^}}no_overlap: -; R600-CHECK: MOV -; R600-CHECK: [[CHAN:[XYZW]]]+ -; R600-NOT: [[CHAN]]+ ; ; A total of 5 bytes should be allocated and used. ; SI: buffer_store_byte v{{[0-9]+}}, off, s[{{[0-9]+:[0-9]+}}], 0 offset:4 ; diff --git a/llvm/test/CodeGen/AMDGPU/private-memory-r600.ll b/llvm/test/CodeGen/AMDGPU/private-memory-r600.ll index ddd44fd17ce3..5b784e473781 100644 --- a/llvm/test/CodeGen/AMDGPU/private-memory-r600.ll +++ b/llvm/test/CodeGen/AMDGPU/private-memory-r600.ll @@ -168,9 +168,6 @@ entry: ; Test that two stack objects are not stored in the same register ; The second stack object should be in T3.X ; FUNC-LABEL: {{^}}no_overlap: -; R600_CHECK: MOV -; R600_CHECK: [[CHAN:[XYZW]]]+ -; R600-NOT: [[CHAN]]+ define amdgpu_kernel void @no_overlap(i32 addrspace(1)* %out, i32 %in) #0 { entry: %0 = alloca [3 x i8], align 1, addrspace(5)