From 0412c902369d7e56b64d74e6f3895cb4636f9db7 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Mon, 7 May 2018 16:42:47 +0000 Subject: [PATCH] [DAGCombine][NFC] Masked merge unfolding: comment: some tests are non-canonical As requested in https://reviews.llvm.org/D46494#inline-407282 llvm-svn: 331650 --- .../AArch64/unfold-masked-merge-scalar-variablemask.ll | 8 ++++++++ .../X86/unfold-masked-merge-scalar-variablemask.ll | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/llvm/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll b/llvm/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll index ff0dfb9ce6a6..6cc4bf4ec596 100644 --- a/llvm/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll +++ b/llvm/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll @@ -355,6 +355,7 @@ define i32 @in_constant_varx_mone(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, -1 ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: out_constant_varx_mone_invmask: ; CHECK: // %bb.0: @@ -367,6 +368,7 @@ define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: in_constant_varx_mone_invmask: ; CHECK: // %bb.0: @@ -407,6 +409,7 @@ define i32 @in_constant_varx_42(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, 42 ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: out_constant_varx_42_invmask: ; CHECK: // %bb.0: @@ -421,6 +424,7 @@ define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: in_constant_varx_42_invmask: ; CHECK: // %bb.0: @@ -458,6 +462,7 @@ define i32 @in_constant_mone_vary(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, %y ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: out_constant_mone_vary_invmask: ; CHECK: // %bb.0: @@ -470,6 +475,7 @@ define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: in_constant_mone_vary_invmask: ; CHECK: // %bb.0: @@ -510,6 +516,7 @@ define i32 @in_constant_42_vary(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, %y ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: out_constant_42_vary_invmask: ; CHECK: // %bb.0: @@ -524,6 +531,7 @@ define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-LABEL: in_constant_42_vary_invmask: ; CHECK: // %bb.0: diff --git a/llvm/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll b/llvm/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll index 66ebbc0cd22e..a28a7edf656f 100644 --- a/llvm/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll +++ b/llvm/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll @@ -578,6 +578,7 @@ define i32 @in_constant_varx_mone(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, -1 ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: out_constant_varx_mone_invmask: ; CHECK-NOBMI: # %bb.0: @@ -598,6 +599,7 @@ define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: in_constant_varx_mone_invmask: ; CHECK-NOBMI: # %bb.0: @@ -666,6 +668,7 @@ define i32 @in_constant_varx_42(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, 42 ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: out_constant_varx_42_invmask: ; CHECK-NOBMI: # %bb.0: @@ -689,6 +692,7 @@ define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: in_constant_varx_42_invmask: ; CHECK-NOBMI: # %bb.0: @@ -750,6 +754,7 @@ define i32 @in_constant_mone_vary(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, %y ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: out_constant_mone_vary_invmask: ; CHECK-NOBMI: # %bb.0: @@ -772,6 +777,7 @@ define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: in_constant_mone_vary_invmask: ; CHECK-NOBMI: # %bb.0: @@ -836,6 +842,7 @@ define i32 @in_constant_42_vary(i32 %x, i32 %y, i32 %mask) { %r = xor i32 %n1, %y ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: out_constant_42_vary_invmask: ; CHECK-NOBMI: # %bb.0: @@ -860,6 +867,7 @@ define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { %r = or i32 %mx, %my ret i32 %r } +; This is not a canonical form. Testing for completeness only. define i32 @in_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) { ; CHECK-NOBMI-LABEL: in_constant_42_vary_invmask: ; CHECK-NOBMI: # %bb.0: