maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

tsan: fix potential false positive race on fd 

llvm-svn: 184430
This commit is contained in:
Dmitry Vyukov 2013-06-20 14:32:12 +00:00
parent 81ef929b8f
commit 03ec9545f5
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
compiler-rt/lib/tsan/lit_tests/fd_close_norace2.cc Normal file
View File

@ -0,0 +1,30 @@
// RUN: %clangxx_tsan -O1 %s -o %t && %t 2>&1 | FileCheck %s
#include <pthread.h>
#include <stdio.h>
#include <unistd.h>
int pipes[2];
void *Thread(void *x) {
// wait for shutown signal
while (read(pipes[0], &x, 1) != 1) {
}
close(pipes[0]);
close(pipes[1]);
return 0;
}
int main() {
if (pipe(pipes))
return 1;
pthread_t t;
pthread_create(&t, 0, Thread, 0);
// send shutdown signal
while (write(pipes[1], &t, 1) != 1) {
}
pthread_join(t, 0);
printf("OK\n");
}
// CHECK-NOT: WARNING: ThreadSanitizer: data race
// CHECK: OK

2
compiler-rt/lib/tsan/rtl/tsan_fd.cc
View File

@ -160,9 +160,9 @@ void FdRelease(ThreadState *thr, uptr pc, int fd) {
FdDesc *d = fddesc(thr, pc, fd);
FdSync *s = d->sync;
DPrintf("#%d: FdRelease(%d) -> %p\n", thr->tid, fd, s);
MemoryRead(thr, pc, (uptr)d, kSizeLog8);
if (s)
Release(thr, pc, (uptr)s);
MemoryRead(thr, pc, (uptr)d, kSizeLog8);
}
void FdAccess(ThreadState *thr, uptr pc, int fd) {