maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer] Eliminates all the cases with unknown family. 

Now treat AF_None family as impossible in isTrackedFamily()

llvm-svn: 178899
This commit is contained in:
Anton Yartsev 2013-04-05 19:08:04 +00:00
parent 1388893b7b
commit 030bcdd9e8
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
View File

@ -284,7 +284,7 @@ private:
bool(*CheckRefState)(const RefState*)) const; bool(*CheckRefState)(const RefState*)) const;
// Used to suppress warnings if they are not related to the tracked family // Used to suppress warnings if they are not related to the tracked family
// (derived from AllocDeallocStmt). // (derived from Sym or AllocDeallocStmt).
bool isTrackedFamily(AllocationFamily Family) const; bool isTrackedFamily(AllocationFamily Family) const;
bool isTrackedFamily(CheckerContext &C, const Stmt *AllocDeallocStmt) const; bool isTrackedFamily(CheckerContext &C, const Stmt *AllocDeallocStmt) const;
bool isTrackedFamily(CheckerContext &C, SymbolRef Sym) const; bool isTrackedFamily(CheckerContext &C, SymbolRef Sym) const;
@ -1058,7 +1058,8 @@ ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
} }
} }
AllocationFamily Family = RsBase ? RsBase->getAllocationFamily() : AF_None; AllocationFamily Family = RsBase ? RsBase->getAllocationFamily()
: getAllocationFamily(C, ParentExpr);
// Normal free. // Normal free.
if (Hold) if (Hold)
return State->set<RegionState>(SymBase, return State->set<RegionState>(SymBase,
@ -1083,7 +1084,7 @@ bool MallocChecker::isTrackedFamily(AllocationFamily Family) const {
return true; return true;
} }
case AF_None: { case AF_None: {
return true; llvm_unreachable("no family");
} }
} }
llvm_unreachable("unhandled family"); llvm_unreachable("unhandled family");
@ -1095,10 +1096,10 @@ bool MallocChecker::isTrackedFamily(CheckerContext &C,
} }
bool MallocChecker::isTrackedFamily(CheckerContext &C, SymbolRef Sym) const { bool MallocChecker::isTrackedFamily(CheckerContext &C, SymbolRef Sym) const {
const RefState *RS = C.getState()->get<RegionState>(Sym);
return RS ? isTrackedFamily(RS->getAllocationFamily()) const RefState *RS = C.getState()->get<RegionState>(Sym);
: isTrackedFamily(AF_None); assert(RS);
return isTrackedFamily(RS->getAllocationFamily());
} }
bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {