From 02d57cc92cb82d1bc48273ceafa4c173f8917e81 Mon Sep 17 00:00:00 2001 From: David Majnemer Date: Thu, 30 Jun 2016 03:02:03 +0000 Subject: [PATCH] [MS ABI] Pick an inheritance model if we resolve an overload set We didn't assign an inheritance model for 'Foo' if the event an exrepssion like '&Foo::Bar' occured if 'Bar' could resolve to multiple functions. Once the overload set is resolved to a particular member, we enforce a specific inheritance model. This fixes PR28360. llvm-svn: 274202 --- clang/lib/Sema/SemaOverload.cpp | 3 +++ clang/test/CodeGenCXX/pr28360.cpp | 16 ++++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 clang/test/CodeGenCXX/pr28360.cpp diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index a9a78244baf6..038be79309f6 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -13021,6 +13021,9 @@ Expr *Sema::FixOverloadedFunctionReference(Expr *E, DeclAccessPair Found, = Context.getTypeDeclType(cast(Method->getDeclContext())); QualType MemPtrType = Context.getMemberPointerType(Fn->getType(), ClassType.getTypePtr()); + // Under the MS ABI, lock down the inheritance model now. + if (Context.getTargetInfo().getCXXABI().isMicrosoft()) + (void)isCompleteType(UnOp->getOperatorLoc(), MemPtrType); return new (Context) UnaryOperator(SubExpr, UO_AddrOf, MemPtrType, VK_RValue, OK_Ordinary, diff --git a/clang/test/CodeGenCXX/pr28360.cpp b/clang/test/CodeGenCXX/pr28360.cpp new file mode 100644 index 000000000000..5d7e1ae0c1fd --- /dev/null +++ b/clang/test/CodeGenCXX/pr28360.cpp @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -triple i686-pc-win32 | FileCheck %s +struct A { + void Foo(); + void Foo(int); +}; + +using MpTy = void (A::*)(); + +void Bar(const MpTy &); + +void Baz() { Bar(&A::Foo); } + +// CHECK-LABEL: define void @"\01?Baz@@YAXXZ"( +// CHECK: %[[ref_tmp:.*]] = alloca i8*, align 4 +// CHECK: store i8* bitcast (void (%struct.A*)* @"\01?Foo@A@@QAEXXZ" to i8*), i8** %[[ref_tmp]], align 4 +// CHECK: call void @"\01?Bar@@YAXABQ8A@@AEXXZ@Z"(i8** dereferenceable(4) %[[ref_tmp]])