maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix another crash bug in --start-lib. 

The previous fix didn't work for bitcode files. This patch fixes
the remaining issue.

llvm-svn: 265854
This commit is contained in:
Rui Ueyama 2016-04-08 21:38:22 +00:00
parent 1d56225e3c
commit 029d89ee57
4 changed files with 25 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lld/ELF/InputFiles.cpp
View File

@ -609,7 +609,7 @@ std::vector<StringRef> LazyObjectFile::getBitcodeSymbols() {
for (const BasicSymbolRef &Sym : Obj->symbols()) {
if (BitcodeFile::shouldSkip(Sym))
continue;
if (Sym.getFlags() == BasicSymbolRef::SF_Undefined)
if (Sym.getFlags() & BasicSymbolRef::SF_Undefined)
continue;
SmallString<64> Name;
raw_svector_ostream OS(Name);

8
lld/test/ELF/lto/Inputs/start-lib1.ll Normal file
View File

@ -0,0 +1,8 @@
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
declare void @bar()
define void @foo() {
ret void
}

2
lld/test/ELF/lto/Inputs/start-lib.ll → lld/test/ELF/lto/Inputs/start-lib2.ll
View File

@ -1,6 +1,6 @@
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @_bar() {
define void @bar() {
ret void
}

22
lld/test/ELF/lto/start-lib.ll
View File

@ -1,15 +1,23 @@
; REQUIRES: x86
;
; RUN: llvm-as %s -o %t1.o
; RUN: llvm-as %p/Inputs/start-lib.ll -o %t2.o
; RUN: llvm-as %p/Inputs/start-lib1.ll -o %t2.o
; RUN: llvm-as %p/Inputs/start-lib2.ll -o %t3.o
;
; RUN: ld.lld -m elf_x86_64 -shared -o %t3 %t1.o %t2.o
; RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=ADDED %s
; ADDED: Name: _bar
; RUN: ld.lld -m elf_x86_64 -shared -o %t3 %t1.o %t2.o %t3.o
; RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=TEST1 %s
; TEST1: Name: bar
; TEST1: Name: foo
;
; RUN: ld.lld -m elf_x86_64 -shared -o %t3 %t1.o --start-lib %t2.o
; RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=LIB %s
; LIB-NOT: Name: _bar
; RUN: ld.lld -m elf_x86_64 -shared -o %t3 -u bar %t1.o --start-lib %t2.o %t3.o
; RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=TEST2 %s
; TEST2: Name: bar
; TEST2-NOT: Name: foo
;
; RUN: ld.lld -m elf_x86_64 -shared -o %t3 %t1.o --start-lib %t2.o %t3.o
; RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=TEST3 %s
; TEST3-NOT: Name: bar
; TEST3-NOT: Name: foo
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"