maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Attributor][FIX] Call right base method in AAValueConstantRangeFloating 

We now call the base class method as we should.
This commit is contained in:
Johannes Doerfert 2020-02-09 19:05:15 -06:00
parent d0a6b32b4f
commit 028db8c490
2 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Transforms/IPO/Attributor.cpp
View File

@ -6153,7 +6153,7 @@ struct AAValueConstantRangeFloating : AAValueConstantRangeImpl {
/// See AbstractAttribute::initialize(...). /// See AbstractAttribute::initialize(...).
void initialize(Attributor &A) override { void initialize(Attributor &A) override {
AAValueConstantRange::initialize(A); AAValueConstantRangeImpl::initialize(A);
Value &V = getAssociatedValue(); Value &V = getAssociatedValue();
if (auto *C = dyn_cast<ConstantInt>(&V)) { if (auto *C = dyn_cast<ConstantInt>(&V)) {

39
llvm/test/Transforms/Attributor/range.ll
View File

@ -455,23 +455,32 @@ return: ; preds = %if.else, %if.then
define dso_local i32 @test4-g2(i32 %u) { define dso_local i32 @test4-g2(i32 %u) {
; CHECK-LABEL: define {{[^@]+}}@test4-g2 ; OLD_PM-LABEL: define {{[^@]+}}@test4-g2
; CHECK-SAME: (i32 [[U:%.*]]) ; OLD_PM-SAME: (i32 [[U:%.*]])
; CHECK-NEXT: entry: ; OLD_PM-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = tail call i32 @test4-f2(i32 [[U]]) ; OLD_PM-NEXT: [[CALL:%.*]] = tail call i32 @test4-f2(i32 [[U]])
; CHECK-NEXT: ret i32 [[CALL]] ; OLD_PM-NEXT: ret i32 [[CALL]]
; ;
; FIXME: %call should have range [1, inf] ; NEW_PM-LABEL: define {{[^@]+}}@test4-g2
; NEW_PM-SAME: (i32 [[U:%.*]])
; NEW_PM-NEXT: entry:
; NEW_PM-NEXT: [[CALL:%.*]] = tail call i32 @test4-f2(i32 [[U]]) #2, !range !3
; NEW_PM-NEXT: ret i32 [[CALL]]
entry: entry:
%call = tail call i32 @test4-f2(i32 %u) %call = tail call i32 @test4-f2(i32 %u)
ret i32 %call ret i32 %call
} }
define dso_local i32 @test-5() { define dso_local i32 @test-5() {
; CHECK-LABEL: define {{[^@]+}}@test-5() ; OLD_PM-LABEL: define {{[^@]+}}@test-5()
; CHECK-NEXT: entry: ; OLD_PM-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = call i32 @rec(i32 0), !range !3 ; OLD_PM-NEXT: [[CALL:%.*]] = call i32 @rec(i32 0), !range !3
; CHECK-NEXT: ret i32 [[CALL]] ; OLD_PM-NEXT: ret i32 [[CALL]]
;
; NEW_PM-LABEL: define {{[^@]+}}@test-5()
; NEW_PM-NEXT: entry:
; NEW_PM-NEXT: [[CALL:%.*]] = call i32 @rec(i32 0), !range !4
; NEW_PM-NEXT: ret i32 [[CALL]]
; ;
entry: entry:
%call = call i32 @rec(i32 0) %call = call i32 @rec(i32 0)
@ -685,7 +694,11 @@ entry:
!0 = !{i32 0, i32 10} !0 = !{i32 0, i32 10}
!1 = !{i32 10, i32 100} !1 = !{i32 10, i32 100}
;CHECK: !0 = !{i32 0, i32 10} ; CHECK: !0 = !{i32 0, i32 10}
;CHECK-NEXT: !1 = !{i32 10, i32 100} ; CHECK-NEXT: !1 = !{i32 10, i32 100}
;CHECK-NEXT: !2 = !{i32 200, i32 1091} ; CHECK-NEXT: !2 = !{i32 200, i32 1091}
; OLD_PM: !3 = !{i32 0, i32 2}
; NEW_PM: !3 = !{i32 1, i32 -2147483648}
; NEW_PM: !4 = !{i32 0, i32 2}