diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 62ee9f554d57..65439032f2c2 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -2010,6 +2010,12 @@ Sema::LookupInObjCMethod(LookupResult &Lookup, Scope *S, Diag(Loc, diag::warn_ivar_use_hidden) << IV->getDeclName(); } } + } else if (Lookup.isSingleResult() && + Lookup.getFoundDecl()->isDefinedOutsideFunctionOrMethod()) { + // If accessing a stand-alone ivar in a class method, this is an error. + if (const ObjCIvarDecl *IV = dyn_cast(Lookup.getFoundDecl())) + return ExprError(Diag(Loc, diag::error_ivar_use_in_class_method) + << IV->getDeclName()); } if (Lookup.empty() && II && AllowBuiltinCreation) { diff --git a/clang/test/SemaObjC/err-ivar-access-in-class-method.m b/clang/test/SemaObjC/err-ivar-access-in-class-method.m new file mode 100644 index 000000000000..5efd6224a7a5 --- /dev/null +++ b/clang/test/SemaObjC/err-ivar-access-in-class-method.m @@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -x objective-c -fsyntax-only -verify %s +// RUN: %clang_cc1 -x objective-c++ -fsyntax-only -verify %s +// rdar://10593227 + +@class UIWindow; + +@interface CNAppDelegate + +@property (strong, nonatomic) UIWindow *window; + +@end + + +@interface CNAppDelegate () +@property (nonatomic,retain) id foo; +@end + +@implementation CNAppDelegate +@synthesize foo; +@synthesize window = _window; + ++(void)myClassMethod; +{ + foo = 0; // expected-error {{instance variable 'foo' accessed in class method}} +} +@end