maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC) 

`is_variadic_ptr` is unused.

Differential Revision: https://reviews.llvm.org/D92778
This commit is contained in:
Dave Lee 2020-12-07 10:38:14 -08:00
parent 8254d70a38
commit 012fd0b17f
5 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/Symbol/CompilerType.h
View File

@ -96,7 +96,7 @@ public:
bool IsFloatingPointType(uint32_t &count, bool &is_complex) const;
bool IsFunctionType(bool *is_variadic_ptr = nullptr) const;
bool IsFunctionType() const;
uint32_t IsHomogeneousAggregate(CompilerType *base_type_ptr) const;

3
lldb/include/lldb/Symbol/TypeSystem.h
View File

@ -152,8 +152,7 @@ public:
virtual bool IsFloatingPointType(lldb::opaque_compiler_type_t type,
uint32_t &count, bool &is_complex) = 0;
virtual bool IsFunctionType(lldb::opaque_compiler_type_t type,
bool *is_variadic_ptr) = 0;
virtual bool IsFunctionType(lldb::opaque_compiler_type_t type) = 0;
virtual size_t
GetNumberOfFunctionArguments(lldb::opaque_compiler_type_t type) = 0;

15
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View File

@ -2915,20 +2915,11 @@ bool TypeSystemClang::IsCStringType(lldb::opaque_compiler_type_t type,
return false;
}
bool TypeSystemClang::IsFunctionType(lldb::opaque_compiler_type_t type,
bool *is_variadic_ptr) {
bool TypeSystemClang::IsFunctionType(lldb::opaque_compiler_type_t type) {
if (type) {
clang::QualType qual_type = RemoveWrappingTypes(GetCanonicalQualType(type));
if (qual_type->isFunctionType()) {
if (is_variadic_ptr) {
const clang::FunctionProtoType *function_proto_type =
llvm::dyn_cast<clang::FunctionProtoType>(qual_type.getTypePtr());
if (function_proto_type)
*is_variadic_ptr = function_proto_type->isVariadic();
else
*is_variadic_ptr = false;
}
return true;
}
@ -2941,8 +2932,8 @@ bool TypeSystemClang::IsFunctionType(lldb::opaque_compiler_type_t type,
const clang::ReferenceType *reference_type =
llvm::cast<clang::ReferenceType>(qual_type.getTypePtr());
if (reference_type)
return IsFunctionType(reference_type->getPointeeType().getAsOpaquePtr(),
nullptr);
return IsFunctionType(
reference_type->getPointeeType().getAsOpaquePtr());
} break;
}
}

3
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
View File

@ -578,8 +578,7 @@ public:
bool IsFloatingPointType(lldb::opaque_compiler_type_t type, uint32_t &count,
bool &is_complex) override;
bool IsFunctionType(lldb::opaque_compiler_type_t type,
bool *is_variadic_ptr) override;
bool IsFunctionType(lldb::opaque_compiler_type_t type) override;
uint32_t IsHomogeneousAggregate(lldb::opaque_compiler_type_t type,
CompilerType *base_type_ptr) override;

4
lldb/source/Symbol/CompilerType.cpp
View File

@ -92,9 +92,9 @@ bool CompilerType::IsCStringType(uint32_t &length) const {
return false;
}
bool CompilerType::IsFunctionType(bool *is_variadic_ptr) const {
bool CompilerType::IsFunctionType() const {
if (IsValid())
return m_type_system->IsFunctionType(m_type, is_variadic_ptr);
return m_type_system->IsFunctionType(m_type);
return false;
}