maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Diagnostics] Make -Wenum-compare-conditional off by default 

Too many false positives, eg. in Chromium.

llvm-svn: 373371
This commit is contained in:
David Bolvansky 2019-10-01 18:12:13 +00:00
parent dca5b94e79
commit 00d632e089
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/DiagnosticGroups.td
View File

@ -565,7 +565,7 @@ def SwitchEnum : DiagGroup<"switch-enum">;
def Switch : DiagGroup<"switch">; def Switch : DiagGroup<"switch">;
def EnumCompareConditional : DiagGroup<"enum-compare-conditional">; def EnumCompareConditional : DiagGroup<"enum-compare-conditional">;
def EnumCompareSwitch : DiagGroup<"enum-compare-switch">; def EnumCompareSwitch : DiagGroup<"enum-compare-switch">;
def EnumCompare : DiagGroup<"enum-compare", [EnumCompareConditional, EnumCompareSwitch]>; def EnumCompare : DiagGroup<"enum-compare", [EnumCompareSwitch]>;
def ImplicitFallthroughPerFunction : def ImplicitFallthroughPerFunction :
DiagGroup<"implicit-fallthrough-per-function">; DiagGroup<"implicit-fallthrough-per-function">;
def ImplicitFallthrough : DiagGroup<"implicit-fallthrough", def ImplicitFallthrough : DiagGroup<"implicit-fallthrough",

2
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -6172,7 +6172,7 @@ def warn_comparison_of_mixed_enum_types : Warning<
def warn_conditional_mixed_enum_types : Warning< def warn_conditional_mixed_enum_types : Warning<
"enumeration type mismatch in conditional expression" "enumeration type mismatch in conditional expression"
"%diff{ ($ and $)|}0,1">, "%diff{ ($ and $)|}0,1">,
InGroup<EnumCompareConditional>; InGroup<EnumCompareConditional>, DefaultIgnore;
def warn_comparison_of_mixed_enum_types_switch : Warning< def warn_comparison_of_mixed_enum_types_switch : Warning<
"comparison of two values with different enumeration types in switch statement" "comparison of two values with different enumeration types in switch statement"
"%diff{ ($ and $)|}0,1">, "%diff{ ($ and $)|}0,1">,

4
clang/test/Sema/warn-conditional-emum-types-mismatch.c
View File

@ -1,9 +1,5 @@
// RUN: %clang_cc1 -x c -fsyntax-only -verify -Wenum-compare-conditional %s // RUN: %clang_cc1 -x c -fsyntax-only -verify -Wenum-compare-conditional %s
// RUN: %clang_cc1 -x c -fsyntax-only -verify -Wenum-compare %s
// RUN: %clang_cc1 -x c -fsyntax-only -verify %s
// RUN: %clang_cc1 -x c++ -fsyntax-only -verify -Wenum-compare-conditional %s // RUN: %clang_cc1 -x c++ -fsyntax-only -verify -Wenum-compare-conditional %s
// RUN: %clang_cc1 -x c++ -fsyntax-only -verify -Wenum-compare %s
// RUN: %clang_cc1 -x c++ -fsyntax-only -verify %s
enum ro { A = 0x10 }; enum ro { A = 0x10 };
enum rw { B = 0xFF }; enum rw { B = 0xFF };