maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Change SBThread::GetExtendedBacktrace to 

SBThread::GetExtendedBacktraceThread to make it more clear what is
being returned.

llvm-svn: 194531
This commit is contained in:
Jason Molenda 2013-11-12 23:33:32 +00:00
parent 6cd1b9aec4
commit 008c45f1a1
7 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/API/SBThread.h
View File

@ -202,7 +202,7 @@ public:
GetStatus (lldb::SBStream &status) const;
SBThread
GetExtendedBacktrace (const char *type);
GetExtendedBacktraceThread (const char *type);
protected:
friend class SBBreakpoint;

2
lldb/include/lldb/Target/SystemRuntime.h
View File

@ -158,7 +158,7 @@ public:
/// An empty ThreadSP will be returned if no thread origin is available.
//------------------------------------------------------------------
virtual lldb::ThreadSP
GetExtendedBacktrace (lldb::ThreadSP thread, ConstString type);
GetExtendedBacktraceThread (lldb::ThreadSP thread, ConstString type);
protected:
//------------------------------------------------------------------

4
lldb/scripts/Python/interface/SBThread.i
View File

@ -249,9 +249,9 @@ public:
normal threads -- you cannot step or resume it, for instance -- it is
intended to used primarily for generating a backtrace. You may request
the returned thread's own thread origin in turn.
") GetExtendedBacktrace;
") GetExtendedBacktraceThread;
lldb::SBThread
GetExtendedBacktrace (const char *type);
GetExtendedBacktraceThread (const char *type);
%pythoncode %{
class frames_access(object):

2
lldb/source/API/SBProcess.cpp
View File

@ -1278,7 +1278,7 @@ SBProcess::GetExtendedBacktraceTypeAtIndex (uint32_t idx)
if (process_sp && process_sp->GetSystemRuntime())
{
SystemRuntime *runtime = process_sp->GetSystemRuntime();
std::vector<ConstString> names = runtime->GetExtendedBacktraceTypes();
const std::vector<ConstString> &names = runtime->GetExtendedBacktraceTypes();
if (idx < names.size())
{
return names[idx].AsCString();

5
lldb/source/API/SBThread.cpp
View File

@ -433,7 +433,6 @@ SBThread::SetThread (const ThreadSP& lldb_object_sp)
m_opaque_sp->SetThreadSP (lldb_object_sp);
}
lldb::tid_t
SBThread::GetThreadID () const
{
@ -1283,7 +1282,7 @@ SBThread::GetDescription (SBStream &description) const
}
SBThread
SBThread::GetExtendedBacktrace (const char *type)
SBThread::GetExtendedBacktraceThread (const char *type)
{
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
Mutex::Locker api_locker;
@ -1305,7 +1304,7 @@ SBThread::GetExtendedBacktrace (const char *type)
SystemRuntime *runtime = process->GetSystemRuntime();
if (runtime)
{
ThreadSP new_thread_sp (runtime->GetExtendedBacktrace (real_thread, type_const));
ThreadSP new_thread_sp (runtime->GetExtendedBacktraceThread (real_thread, type_const));
// Save this in the Process' ExtendedThreadList so a strong pointer retains the
// object.
process->GetExtendedThreadList().AddThread (new_thread_sp);

2
lldb/source/Commands/CommandObjectThread.cpp
View File

@ -180,7 +180,7 @@ protected:
const std::vector<ConstString> &types = runtime->GetExtendedBacktraceTypes();
for (auto type : types)
{
ThreadSP ext_thread_sp = runtime->GetExtendedBacktrace (thread->shared_from_this(), type);
ThreadSP ext_thread_sp = runtime->GetExtendedBacktraceThread (thread->shared_from_this(), type);
if (ext_thread_sp && ext_thread_sp->IsValid ())
{
const uint32_t num_frames_with_source = 0;

2
lldb/source/Target/SystemRuntime.cpp
View File

@ -67,7 +67,7 @@ SystemRuntime::GetExtendedBacktraceTypes ()
}
ThreadSP
SystemRuntime::GetExtendedBacktrace (ThreadSP thread, ConstString type)
SystemRuntime::GetExtendedBacktraceThread (ThreadSP thread, ConstString type)
{
return ThreadSP();
}