[lldb][NFC] Fix all formatting errors in .cpp file headers
Summary:
A *.cpp file header in LLDB (and in LLDB) should like this:
```
//===-- TestUtilities.cpp -------------------------------------------------===//
```
However in LLDB most of our source files have arbitrary changes to this format and
these changes are spreading through LLDB as folks usually just use the existing
source files as templates for their new files (most notably the unnecessary
editor language indicator `-*- C++ -*-` is spreading and in every review
someone is pointing out that this is wrong, resulting in people pointing out that this
is done in the same way in other files).
This patch removes most of these inconsistencies including the editor language indicators,
all the different missing/additional '-' characters, files that center the file name, missing
trailing `===//` (mostly caused by clang-format breaking the line).
Reviewers: aprantl, espindola, jfb, shafik, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73258
2020-01-24 15:23:27 +08:00
|
|
|
//===-- SymbolFile.cpp ----------------------------------------------------===//
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "lldb/Symbol/SymbolFile.h"
|
2011-11-28 09:45:00 +08:00
|
|
|
|
2010-11-10 12:57:04 +08:00
|
|
|
#include "lldb/Core/Module.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
#include "lldb/Core/PluginManager.h"
|
2019-07-23 17:24:02 +08:00
|
|
|
#include "lldb/Symbol/CompileUnit.h"
|
2010-11-10 12:57:04 +08:00
|
|
|
#include "lldb/Symbol/ObjectFile.h"
|
2015-10-08 17:45:41 +08:00
|
|
|
#include "lldb/Symbol/TypeMap.h"
|
TypeSystem is now a plugin interface and removed any "ClangASTContext &Class::GetClangASTContext()" functions.
This cleans up type systems to be more pluggable. Prior to this we had issues:
- Module, SymbolFile, and many others has "ClangASTContext &GetClangASTContext()" functions. All have been switched over to use "TypeSystem *GetTypeSystemForLanguage()"
- Cleaned up any places that were using the GetClangASTContext() functions to use TypeSystem
- Cleaned up Module so that it no longer has dedicated type system member variables:
lldb::ClangASTContextUP m_ast; ///< The Clang AST context for this module.
lldb::GoASTContextUP m_go_ast; ///< The Go AST context for this module.
Now we have a type system map:
typedef std::map<lldb::LanguageType, lldb::TypeSystemSP> TypeSystemMap;
TypeSystemMap m_type_system_map; ///< A map of any type systems associated with this module
- Many places in code were using ClangASTContext static functions to place with CompilerType objects and add modifiers (const, volatile, restrict) and to make typedefs, L and R value references and more. These have been made into CompilerType functions that are abstract:
class CompilerType
{
...
//----------------------------------------------------------------------
// Return a new CompilerType that is a L value reference to this type if
// this type is valid and the type system supports L value references,
// else return an invalid type.
//----------------------------------------------------------------------
CompilerType
GetLValueReferenceType () const;
//----------------------------------------------------------------------
// Return a new CompilerType that is a R value reference to this type if
// this type is valid and the type system supports R value references,
// else return an invalid type.
//----------------------------------------------------------------------
CompilerType
GetRValueReferenceType () const;
//----------------------------------------------------------------------
// Return a new CompilerType adds a const modifier to this type if
// this type is valid and the type system supports const modifiers,
// else return an invalid type.
//----------------------------------------------------------------------
CompilerType
AddConstModifier () const;
//----------------------------------------------------------------------
// Return a new CompilerType adds a volatile modifier to this type if
// this type is valid and the type system supports volatile modifiers,
// else return an invalid type.
//----------------------------------------------------------------------
CompilerType
AddVolatileModifier () const;
//----------------------------------------------------------------------
// Return a new CompilerType adds a restrict modifier to this type if
// this type is valid and the type system supports restrict modifiers,
// else return an invalid type.
//----------------------------------------------------------------------
CompilerType
AddRestrictModifier () const;
//----------------------------------------------------------------------
// Create a typedef to this type using "name" as the name of the typedef
// this type is valid and the type system supports typedefs, else return
// an invalid type.
//----------------------------------------------------------------------
CompilerType
CreateTypedef (const char *name, const CompilerDeclContext &decl_ctx) const;
};
Other changes include:
- Removed "CompilerType TypeSystem::GetIntTypeFromBitSize(...)" and CompilerType TypeSystem::GetFloatTypeFromBitSize(...) and replaced it with "CompilerType TypeSystem::GetBuiltinTypeForEncodingAndBitSize(lldb::Encoding encoding, size_t bit_size);"
- Fixed code in Type.h to not request the full type for a type for no good reason, just request the forward type and let the type expand as needed
llvm-svn: 247953
2015-09-18 06:23:34 +08:00
|
|
|
#include "lldb/Symbol/TypeSystem.h"
|
2015-08-25 07:46:31 +08:00
|
|
|
#include "lldb/Symbol/VariableList.h"
|
2017-03-04 04:56:28 +08:00
|
|
|
#include "lldb/Utility/Log.h"
|
2017-02-03 05:39:50 +08:00
|
|
|
#include "lldb/Utility/StreamString.h"
|
2016-09-07 04:57:50 +08:00
|
|
|
#include "lldb/lldb-private.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2018-10-23 04:14:36 +08:00
|
|
|
#include <future>
|
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
using namespace lldb_private;
|
2019-07-23 17:24:02 +08:00
|
|
|
using namespace lldb;
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2019-11-16 02:13:16 +08:00
|
|
|
char SymbolFile::ID;
|
|
|
|
|
2017-04-28 08:51:06 +08:00
|
|
|
void SymbolFile::PreloadSymbols() {
|
|
|
|
// No-op for most implementations.
|
|
|
|
}
|
|
|
|
|
2018-10-23 04:14:36 +08:00
|
|
|
std::recursive_mutex &SymbolFile::GetModuleMutex() const {
|
|
|
|
return GetObjectFile()->GetModule()->GetMutex();
|
|
|
|
}
|
2019-07-29 23:53:36 +08:00
|
|
|
ObjectFile *SymbolFile::GetMainObjectFile() {
|
2019-07-31 16:25:25 +08:00
|
|
|
return m_objfile_sp->GetModule()->GetObjectFile();
|
2019-07-29 23:53:36 +08:00
|
|
|
}
|
2018-10-23 04:14:36 +08:00
|
|
|
|
2019-07-31 16:25:25 +08:00
|
|
|
SymbolFile *SymbolFile::FindPlugin(ObjectFileSP objfile_sp) {
|
2019-02-13 14:25:41 +08:00
|
|
|
std::unique_ptr<SymbolFile> best_symfile_up;
|
2019-07-31 16:25:25 +08:00
|
|
|
if (objfile_sp != nullptr) {
|
2016-09-07 04:57:50 +08:00
|
|
|
|
|
|
|
// We need to test the abilities of this section list. So create what it
|
2019-07-31 16:25:25 +08:00
|
|
|
// would be with this new objfile_sp.
|
|
|
|
lldb::ModuleSP module_sp(objfile_sp->GetModule());
|
2016-09-07 04:57:50 +08:00
|
|
|
if (module_sp) {
|
|
|
|
// Default to the main module section list.
|
|
|
|
ObjectFile *module_obj_file = module_sp->GetObjectFile();
|
2019-07-31 16:25:25 +08:00
|
|
|
if (module_obj_file != objfile_sp.get()) {
|
2016-09-07 04:57:50 +08:00
|
|
|
// Make sure the main object file's sections are created
|
|
|
|
module_obj_file->GetSectionList();
|
2019-07-31 16:25:25 +08:00
|
|
|
objfile_sp->CreateSections(*module_sp->GetUnifiedSectionList());
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
}
|
2013-07-10 09:23:25 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
// TODO: Load any plug-ins in the appropriate plug-in search paths and
|
|
|
|
// iterate over all of them to find the best one for the job.
|
|
|
|
|
|
|
|
uint32_t best_symfile_abilities = 0;
|
|
|
|
|
|
|
|
SymbolFileCreateInstance create_callback;
|
|
|
|
for (uint32_t idx = 0;
|
|
|
|
(create_callback = PluginManager::GetSymbolFileCreateCallbackAtIndex(
|
|
|
|
idx)) != nullptr;
|
|
|
|
++idx) {
|
2019-07-31 16:25:25 +08:00
|
|
|
std::unique_ptr<SymbolFile> curr_symfile_up(create_callback(objfile_sp));
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2019-02-13 14:25:41 +08:00
|
|
|
if (curr_symfile_up) {
|
|
|
|
const uint32_t sym_file_abilities = curr_symfile_up->GetAbilities();
|
2016-09-07 04:57:50 +08:00
|
|
|
if (sym_file_abilities > best_symfile_abilities) {
|
|
|
|
best_symfile_abilities = sym_file_abilities;
|
2019-02-13 14:25:41 +08:00
|
|
|
best_symfile_up.reset(curr_symfile_up.release());
|
2018-05-01 00:49:04 +08:00
|
|
|
// If any symbol file parser has all of the abilities, then we should
|
|
|
|
// just stop looking.
|
2016-09-07 04:57:50 +08:00
|
|
|
if ((kAllAbilities & sym_file_abilities) == kAllAbilities)
|
|
|
|
break;
|
A few of the issue I have been trying to track down and fix have been due to
the way LLDB lazily gets complete definitions for types within the debug info.
When we run across a class/struct/union definition in the DWARF, we will only
parse the full definition if we need to. This works fine for top level types
that are assigned directly to variables and arguments, but when we have a
variable with a class, lets say "A" for this example, that has a member:
"B *m_b". Initially we don't need to hunt down a definition for this class
unless we are ever asked to do something with it ("expr m_b->getDecl()" for
example). With my previous approach to lazy type completion, we would be able
to take a "A *a" and get a complete type for it, but we wouldn't be able to
then do an "a->m_b->getDecl()" unless we always expanded all types within a
class prior to handing out the type. Expanding everything is very costly and
it would be great if there were a better way.
A few months ago I worked with the llvm/clang folks to have the
ExternalASTSource class be able to complete classes if there weren't completed
yet:
class ExternalASTSource {
....
virtual void
CompleteType (clang::TagDecl *Tag);
virtual void
CompleteType (clang::ObjCInterfaceDecl *Class);
};
This was great, because we can now have the class that is producing the AST
(SymbolFileDWARF and SymbolFileDWARFDebugMap) sign up as external AST sources
and the object that creates the forward declaration types can now also
complete them anywhere within the clang type system.
This patch makes a few major changes:
- lldb_private::Module classes now own the AST context. Previously the TypeList
objects did.
- The DWARF parsers now sign up as an external AST sources so they can complete
types.
- All of the pure clang type system wrapper code we have in LLDB (ClangASTContext,
ClangASTType, and more) can now be iterating through children of any type,
and if a class/union/struct type (clang::RecordType or ObjC interface)
is found that is incomplete, we can ask the AST to get the definition.
- The SymbolFileDWARFDebugMap class now will create and use a single AST that
all child SymbolFileDWARF classes will share (much like what happens when
we have a complete linked DWARF for an executable).
We will need to modify some of the ClangUserExpression code to take more
advantage of this completion ability in the near future. Meanwhile we should
be better off now that we can be accessing any children of variables through
pointers and always be able to resolve the clang type if needed.
llvm-svn: 123613
2011-01-17 11:46:26 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2019-02-13 14:25:41 +08:00
|
|
|
if (best_symfile_up) {
|
2018-05-01 00:49:04 +08:00
|
|
|
// Let the winning symbol file parser initialize itself more completely
|
|
|
|
// now that it has been chosen
|
2019-02-13 14:25:41 +08:00
|
|
|
best_symfile_up->InitializeObject();
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
|
|
|
}
|
2019-02-13 14:25:41 +08:00
|
|
|
return best_symfile_up.release();
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
2019-07-31 06:12:34 +08:00
|
|
|
llvm::Expected<TypeSystem &>
|
|
|
|
SymbolFile::GetTypeSystemForLanguage(lldb::LanguageType language) {
|
|
|
|
auto type_system_or_err =
|
2019-07-31 16:25:25 +08:00
|
|
|
m_objfile_sp->GetModule()->GetTypeSystemForLanguage(language);
|
2019-07-31 06:12:34 +08:00
|
|
|
if (type_system_or_err) {
|
|
|
|
type_system_or_err->SetSymbolFile(this);
|
|
|
|
}
|
|
|
|
return type_system_or_err;
|
2015-08-15 04:02:05 +08:00
|
|
|
}
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
uint32_t SymbolFile::ResolveSymbolContext(const FileSpec &file_spec,
|
|
|
|
uint32_t line, bool check_inlines,
|
2018-10-26 04:45:19 +08:00
|
|
|
lldb::SymbolContextItem resolve_scope,
|
2016-09-07 04:57:50 +08:00
|
|
|
SymbolContextList &sc_list) {
|
|
|
|
return 0;
|
2015-08-25 07:46:31 +08:00
|
|
|
}
|
|
|
|
|
2019-10-18 03:56:40 +08:00
|
|
|
void SymbolFile::FindGlobalVariables(ConstString name,
|
2020-02-18 02:25:52 +08:00
|
|
|
const CompilerDeclContext &parent_decl_ctx,
|
2019-10-18 03:56:40 +08:00
|
|
|
uint32_t max_matches,
|
|
|
|
VariableList &variables) {}
|
|
|
|
|
|
|
|
void SymbolFile::FindGlobalVariables(const RegularExpression ®ex,
|
|
|
|
uint32_t max_matches,
|
|
|
|
VariableList &variables) {}
|
|
|
|
|
|
|
|
void SymbolFile::FindFunctions(ConstString name,
|
2020-02-18 02:25:52 +08:00
|
|
|
const CompilerDeclContext &parent_decl_ctx,
|
2019-10-18 03:56:40 +08:00
|
|
|
lldb::FunctionNameType name_type_mask,
|
|
|
|
bool include_inlines,
|
|
|
|
SymbolContextList &sc_list) {}
|
|
|
|
|
|
|
|
void SymbolFile::FindFunctions(const RegularExpression ®ex,
|
|
|
|
bool include_inlines,
|
|
|
|
SymbolContextList &sc_list) {}
|
2015-08-25 07:46:31 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
void SymbolFile::GetMangledNamesForFunction(
|
|
|
|
const std::string &scope_qualified_name,
|
|
|
|
std::vector<ConstString> &mangled_names) {
|
|
|
|
return;
|
Better scheme to lookup alternate mangled name when looking up function address.
Summary:
This change is relevant for inferiors compiled with GCC. GCC does not
emit complete debug info for std::basic_string<...>, and consequently, Clang
(the LLDB compiler) does not generate correct mangled names for certain
functions.
This change removes the hard-coded alternate names in
ItaniumABILanguageRuntime.cpp.
Before the hard-coded names were put in ItaniumABILanguageRuntime.cpp, one could
not evaluate std::string methods (ex. std::string::length). After putting in
the hard-coded names, one could evaluate them. However, it did not still
enable one to call methods on, say for example, std::vector<string>.
This change makes that possible.
There is some amount of incompleteness in this change. Consider the
following example:
std::string hello("hello"), world("world");
std::map<std::string, std::string> m;
m[hello] = world;
One can still not evaluate the expression "m[hello]" in LLDB. Will
address this issue in another pass.
Reviewers: jingham, vharron, evgeny777, spyffe, dawn
Subscribers: clayborg, dawn, lldb-commits
Differential Revision: http://reviews.llvm.org/D12809
llvm-svn: 257113
2016-01-08 07:32:34 +08:00
|
|
|
}
|
|
|
|
|
2019-10-01 23:40:41 +08:00
|
|
|
void SymbolFile::FindTypes(
|
2020-02-18 02:25:52 +08:00
|
|
|
ConstString name, const CompilerDeclContext &parent_decl_ctx,
|
2019-10-01 00:42:28 +08:00
|
|
|
uint32_t max_matches,
|
2016-09-07 04:57:50 +08:00
|
|
|
llvm::DenseSet<lldb_private::SymbolFile *> &searched_symbol_files,
|
2019-10-01 23:40:41 +08:00
|
|
|
TypeMap &types) {}
|
2015-08-25 07:46:31 +08:00
|
|
|
|
2019-10-01 23:40:41 +08:00
|
|
|
void SymbolFile::FindTypes(llvm::ArrayRef<CompilerContext> pattern,
|
2019-11-13 01:25:59 +08:00
|
|
|
LanguageSet languages,
|
|
|
|
llvm::DenseSet<SymbolFile *> &searched_symbol_files,
|
|
|
|
TypeMap &types) {}
|
2018-10-23 04:14:36 +08:00
|
|
|
|
|
|
|
void SymbolFile::AssertModuleLock() {
|
|
|
|
// The code below is too expensive to leave enabled in release builds. It's
|
|
|
|
// enabled in debug builds or when the correct macro is set.
|
|
|
|
#if defined(LLDB_CONFIGURATION_DEBUG)
|
|
|
|
// We assert that we have to module lock by trying to acquire the lock from a
|
|
|
|
// different thread. Note that we must abort if the result is true to
|
|
|
|
// guarantee correctness.
|
|
|
|
assert(std::async(std::launch::async,
|
|
|
|
[this] { return this->GetModuleMutex().try_lock(); })
|
|
|
|
.get() == false &&
|
|
|
|
"Module is not locked");
|
|
|
|
#endif
|
|
|
|
}
|
FuncUnwinders: Add a new "SymbolFile" unwind plan
Summary:
some unwind formats are specific to a single symbol file and so it does
not make sense for their parsing code live in the general Symbol library
(as is the case with eh_frame for instance). This is the case for the
unwind information in breakpad files, but the same will probably be true
for PDB unwind info (once we are able to parse that).
This patch adds the ability to fetch an unwind plan provided by a symbol
file plugin, as discussed in the RFC at
<http://lists.llvm.org/pipermail/lldb-dev/2019-February/014703.html>.
I've kept the set of changes to a minimum, as there is no way to test
them until we have a symbol file which implements this API -- that is
comming in a follow-up patch, which will also implicitly test this
change.
The interesting part here is the introduction of the
"RegisterInfoResolver" interface. The reason for this is that breakpad
needs to be able to resolve register names (which are present as strings
in the file) into register enums so that it can construct the unwind
plan. This is normally done via the RegisterContext class, handing this
over to the SymbolFile plugin would mean that it has full access to the
debugged process, which is not something we want it to have. So instead,
I create a facade, which only provides the ability to query register
names, and hide the RegisterContext behind the facade.
Also note that this only adds the ability to dump the unwind plan
created by the symbol file plugin -- the plan is not used for unwinding
yet -- this will be added in a third patch, which will add additional
tests which makes sure the unwinding works as a whole.
Reviewers: jasonmolenda, clayborg
Subscribers: markmentovai, amccarth, lldb-commits
Differential Revision: https://reviews.llvm.org/D61732
llvm-svn: 360409
2019-05-10 15:54:37 +08:00
|
|
|
|
2019-07-23 17:24:02 +08:00
|
|
|
uint32_t SymbolFile::GetNumCompileUnits() {
|
|
|
|
std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
|
|
|
|
if (!m_compile_units) {
|
|
|
|
// Create an array of compile unit shared pointers -- which will each
|
|
|
|
// remain NULL until someone asks for the actual compile unit information.
|
|
|
|
m_compile_units.emplace(CalculateNumCompileUnits());
|
|
|
|
}
|
|
|
|
return m_compile_units->size();
|
|
|
|
}
|
|
|
|
|
|
|
|
CompUnitSP SymbolFile::GetCompileUnitAtIndex(uint32_t idx) {
|
2019-07-30 16:20:05 +08:00
|
|
|
std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
|
2019-07-23 17:24:02 +08:00
|
|
|
uint32_t num = GetNumCompileUnits();
|
|
|
|
if (idx >= num)
|
|
|
|
return nullptr;
|
|
|
|
lldb::CompUnitSP &cu_sp = (*m_compile_units)[idx];
|
|
|
|
if (!cu_sp)
|
|
|
|
cu_sp = ParseCompileUnitAtIndex(idx);
|
|
|
|
return cu_sp;
|
|
|
|
}
|
|
|
|
|
|
|
|
void SymbolFile::SetCompileUnitAtIndex(uint32_t idx, const CompUnitSP &cu_sp) {
|
|
|
|
std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
|
|
|
|
const size_t num_compile_units = GetNumCompileUnits();
|
|
|
|
assert(idx < num_compile_units);
|
2019-07-25 17:56:45 +08:00
|
|
|
(void)num_compile_units;
|
2019-07-23 17:24:02 +08:00
|
|
|
|
|
|
|
// Fire off an assertion if this compile unit already exists for now. The
|
|
|
|
// partial parsing should take care of only setting the compile unit
|
|
|
|
// once, so if this assertion fails, we need to make sure that we don't
|
|
|
|
// have a race condition, or have a second parse of the same compile
|
|
|
|
// unit.
|
|
|
|
assert((*m_compile_units)[idx] == nullptr);
|
|
|
|
(*m_compile_units)[idx] = cu_sp;
|
|
|
|
}
|
|
|
|
|
2019-07-26 15:03:28 +08:00
|
|
|
Symtab *SymbolFile::GetSymtab() {
|
|
|
|
std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
|
|
|
|
if (m_symtab)
|
|
|
|
return m_symtab;
|
|
|
|
|
|
|
|
// Fetch the symtab from the main object file.
|
2019-07-29 23:53:36 +08:00
|
|
|
m_symtab = GetMainObjectFile()->GetSymtab();
|
2019-07-26 15:03:28 +08:00
|
|
|
|
|
|
|
// Then add our symbols to it.
|
|
|
|
if (m_symtab)
|
|
|
|
AddSymbols(*m_symtab);
|
|
|
|
|
|
|
|
return m_symtab;
|
|
|
|
}
|
|
|
|
|
2019-07-29 23:53:36 +08:00
|
|
|
void SymbolFile::SectionFileAddressesChanged() {
|
|
|
|
ObjectFile *module_objfile = GetMainObjectFile();
|
|
|
|
ObjectFile *symfile_objfile = GetObjectFile();
|
|
|
|
if (symfile_objfile != module_objfile)
|
|
|
|
symfile_objfile->SectionFileAddressesChanged();
|
|
|
|
if (m_symtab)
|
|
|
|
m_symtab->SectionFileAddressesChanged();
|
|
|
|
}
|
|
|
|
|
2019-07-23 17:24:02 +08:00
|
|
|
void SymbolFile::Dump(Stream &s) {
|
2019-08-05 19:29:01 +08:00
|
|
|
s.Format("SymbolFile {0} ({1})\n", GetPluginName(),
|
|
|
|
GetMainObjectFile()->GetFileSpec());
|
2019-07-25 16:22:05 +08:00
|
|
|
s.PutCString("Types:\n");
|
|
|
|
m_type_list.Dump(&s, /*show_context*/ false);
|
|
|
|
s.PutChar('\n');
|
|
|
|
|
2019-07-23 17:24:02 +08:00
|
|
|
s.PutCString("Compile units:\n");
|
|
|
|
if (m_compile_units) {
|
|
|
|
for (const CompUnitSP &cu_sp : *m_compile_units) {
|
|
|
|
// We currently only dump the compile units that have been parsed
|
|
|
|
if (cu_sp)
|
|
|
|
cu_sp->Dump(&s, /*show_context*/ false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
s.PutChar('\n');
|
2019-08-05 17:21:47 +08:00
|
|
|
|
|
|
|
if (Symtab *symtab = GetSymtab())
|
|
|
|
symtab->Dump(&s, nullptr, eSortOrderNone);
|
2019-07-23 17:24:02 +08:00
|
|
|
}
|
|
|
|
|
FuncUnwinders: Add a new "SymbolFile" unwind plan
Summary:
some unwind formats are specific to a single symbol file and so it does
not make sense for their parsing code live in the general Symbol library
(as is the case with eh_frame for instance). This is the case for the
unwind information in breakpad files, but the same will probably be true
for PDB unwind info (once we are able to parse that).
This patch adds the ability to fetch an unwind plan provided by a symbol
file plugin, as discussed in the RFC at
<http://lists.llvm.org/pipermail/lldb-dev/2019-February/014703.html>.
I've kept the set of changes to a minimum, as there is no way to test
them until we have a symbol file which implements this API -- that is
comming in a follow-up patch, which will also implicitly test this
change.
The interesting part here is the introduction of the
"RegisterInfoResolver" interface. The reason for this is that breakpad
needs to be able to resolve register names (which are present as strings
in the file) into register enums so that it can construct the unwind
plan. This is normally done via the RegisterContext class, handing this
over to the SymbolFile plugin would mean that it has full access to the
debugged process, which is not something we want it to have. So instead,
I create a facade, which only provides the ability to query register
names, and hide the RegisterContext behind the facade.
Also note that this only adds the ability to dump the unwind plan
created by the symbol file plugin -- the plan is not used for unwinding
yet -- this will be added in a third patch, which will add additional
tests which makes sure the unwinding works as a whole.
Reviewers: jasonmolenda, clayborg
Subscribers: markmentovai, amccarth, lldb-commits
Differential Revision: https://reviews.llvm.org/D61732
llvm-svn: 360409
2019-05-10 15:54:37 +08:00
|
|
|
SymbolFile::RegisterInfoResolver::~RegisterInfoResolver() = default;
|