2015-03-09 19:48:54 +08:00
|
|
|
//===--- UnusedRAIICheck.h - clang-tidy -------------------------*- C++ -*-===//
|
2014-07-23 19:49:46 +08:00
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-03-10 00:52:33 +08:00
|
|
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H
|
|
|
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H
|
2014-07-23 19:49:46 +08:00
|
|
|
|
|
|
|
#include "../ClangTidy.h"
|
|
|
|
|
|
|
|
namespace clang {
|
|
|
|
namespace tidy {
|
2015-03-02 20:25:03 +08:00
|
|
|
namespace misc {
|
2014-07-23 19:49:46 +08:00
|
|
|
|
|
|
|
/// \brief Finds temporaries that look like RAII objects.
|
|
|
|
///
|
|
|
|
/// The canonical example for this is a scoped lock.
|
|
|
|
/// \code
|
|
|
|
/// {
|
|
|
|
/// scoped_lock(&global_mutex);
|
|
|
|
/// critical_section();
|
|
|
|
/// }
|
|
|
|
/// \endcode
|
|
|
|
/// The destructor of the scoped_lock is called before the critical_section is
|
|
|
|
/// entered, leaving it unprotected.
|
|
|
|
///
|
|
|
|
/// We apply a number of heuristics to reduce the false positive count of this
|
|
|
|
/// check:
|
|
|
|
/// - Ignore code expanded from macros. Testing frameworks make heavy use of
|
|
|
|
/// this.
|
|
|
|
/// - Ignore types with no user-declared constructor. Those are very unlikely
|
|
|
|
/// to be RAII objects.
|
|
|
|
/// - Ignore objects at the end of a compound statement (doesn't change behavior).
|
|
|
|
/// - Ignore objects returned from a call.
|
|
|
|
class UnusedRAIICheck : public ClangTidyCheck {
|
|
|
|
public:
|
2014-09-12 16:53:36 +08:00
|
|
|
UnusedRAIICheck(StringRef Name, ClangTidyContext *Context)
|
|
|
|
: ClangTidyCheck(Name, Context) {}
|
2014-07-23 19:49:46 +08:00
|
|
|
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
|
|
|
|
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
|
|
|
|
};
|
|
|
|
|
2015-03-02 20:25:03 +08:00
|
|
|
} // namespace misc
|
2014-07-23 19:49:46 +08:00
|
|
|
} // namespace tidy
|
|
|
|
} // namespace clang
|
|
|
|
|
2015-03-10 00:52:33 +08:00
|
|
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H
|