2018-08-17 01:59:38 +08:00
|
|
|
//===-- JSONUtils.h ---------------------------------------------*- C++ -*-===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2018-08-17 01:59:38 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2020-02-18 07:57:45 +08:00
|
|
|
#ifndef LLDB_TOOLS_LLDB_VSCODE_JSONUTILS_H
|
|
|
|
#define LLDB_TOOLS_LLDB_VSCODE_JSONUTILS_H
|
2018-08-17 01:59:38 +08:00
|
|
|
|
|
|
|
#include "VSCodeForward.h"
|
2020-07-14 03:10:49 +08:00
|
|
|
#include "lldb/API/SBModule.h"
|
2020-08-18 00:17:54 +08:00
|
|
|
#include "llvm/ADT/StringRef.h"
|
|
|
|
#include "llvm/Support/JSON.h"
|
|
|
|
#include <stdint.h>
|
2018-08-17 01:59:38 +08:00
|
|
|
|
|
|
|
namespace lldb_vscode {
|
2018-11-16 03:49:57 +08:00
|
|
|
|
|
|
|
/// Emplace a StringRef in a json::Object after enusring that the
|
|
|
|
/// string is valid UTF8. If not, first call llvm::json::fixUTF8
|
|
|
|
/// before emplacing.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-11-16 03:49:57 +08:00
|
|
|
/// A JSON object that we will attempt to emplace the value in
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-11-16 03:49:57 +08:00
|
|
|
/// The key to use when emplacing the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] str
|
2018-11-16 03:49:57 +08:00
|
|
|
/// The string to emplace
|
|
|
|
void EmplaceSafeString(llvm::json::Object &obj, llvm::StringRef key,
|
|
|
|
llvm::StringRef str);
|
|
|
|
|
2018-08-17 01:59:38 +08:00
|
|
|
/// Extract simple values as a string.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] value
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON value to extract the string from.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A llvm::StringRef that contains the string value, or an empty
|
|
|
|
/// string if \a value isn't a string.
|
|
|
|
llvm::StringRef GetAsString(const llvm::json::Value &value);
|
|
|
|
|
|
|
|
/// Extract the string value for the specified key from the
|
|
|
|
/// specified object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the value from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to use when extracting the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A llvm::StringRef that contains the string value for the
|
|
|
|
/// specified \a key, or an empty string if there is no key that
|
|
|
|
/// matches or if the value is not a string.
|
|
|
|
llvm::StringRef GetString(const llvm::json::Object &obj, llvm::StringRef key);
|
|
|
|
llvm::StringRef GetString(const llvm::json::Object *obj, llvm::StringRef key);
|
|
|
|
|
|
|
|
/// Extract the unsigned integer value for the specified key from
|
|
|
|
/// the specified object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the value from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to use when extracting the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The unsigned integer value for the specified \a key, or
|
|
|
|
/// \a fail_value if there is no key that matches or if the
|
|
|
|
/// value is not an integer.
|
|
|
|
uint64_t GetUnsigned(const llvm::json::Object &obj, llvm::StringRef key,
|
|
|
|
uint64_t fail_value);
|
|
|
|
uint64_t GetUnsigned(const llvm::json::Object *obj, llvm::StringRef key,
|
|
|
|
uint64_t fail_value);
|
|
|
|
|
|
|
|
/// Extract the boolean value for the specified key from the
|
|
|
|
/// specified object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the value from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to use when extracting the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The boolean value for the specified \a key, or \a fail_value
|
|
|
|
/// if there is no key that matches or if the value is not a
|
|
|
|
/// boolean value of an integer.
|
|
|
|
bool GetBoolean(const llvm::json::Object &obj, llvm::StringRef key,
|
|
|
|
bool fail_value);
|
|
|
|
bool GetBoolean(const llvm::json::Object *obj, llvm::StringRef key,
|
|
|
|
bool fail_value);
|
|
|
|
|
|
|
|
/// Extract the signed integer for the specified key from the
|
|
|
|
/// specified object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the value from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to use when extracting the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The signed integer value for the specified \a key, or
|
|
|
|
/// \a fail_value if there is no key that matches or if the
|
|
|
|
/// value is not an integer.
|
|
|
|
int64_t GetSigned(const llvm::json::Object &obj, llvm::StringRef key,
|
|
|
|
int64_t fail_value);
|
|
|
|
int64_t GetSigned(const llvm::json::Object *obj, llvm::StringRef key,
|
|
|
|
int64_t fail_value);
|
|
|
|
|
|
|
|
/// Check if the specified key exists in the specified object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the value from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to check for
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// \b True if the key exists in the \a obj, \b False otherwise.
|
|
|
|
bool ObjectContainsKey(const llvm::json::Object &obj, llvm::StringRef key);
|
|
|
|
|
|
|
|
/// Extract an array of strings for the specified key from an object.
|
|
|
|
///
|
|
|
|
/// String values in the array will be extracted without any quotes
|
|
|
|
/// around them. Numbers and Booleans will be converted into
|
|
|
|
/// strings. Any NULL, array or objects values in the array will be
|
|
|
|
/// ignored.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] obj
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON object that we will attempt to extract the array from
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key to use when extracting the value
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// An array of string values for the specified \a key, or
|
|
|
|
/// \a fail_value if there is no key that matches or if the
|
|
|
|
/// value is not an array or all items in the array are not
|
|
|
|
/// strings, numbers or booleans.
|
|
|
|
std::vector<std::string> GetStrings(const llvm::json::Object *obj,
|
|
|
|
llvm::StringRef key);
|
|
|
|
|
|
|
|
/// Fill a response object given the request object.
|
|
|
|
///
|
|
|
|
/// The \a response object will get its "type" set to "response",
|
|
|
|
/// the "seq" set to zero, "response_seq" set to the "seq" value from
|
|
|
|
/// \a request, "command" set to the "command" from \a request,
|
|
|
|
/// and "success" set to true.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] request
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The request object received from a call to VSCode::ReadJSON().
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in,out] response
|
2018-08-17 01:59:38 +08:00
|
|
|
/// An empty llvm::json::Object object that will be filled
|
|
|
|
/// in as noted in description.
|
|
|
|
void FillResponse(const llvm::json::Object &request,
|
|
|
|
llvm::json::Object &response);
|
|
|
|
|
|
|
|
/// Emplace the string value from an SBValue into the supplied object
|
|
|
|
/// using \a key as the key that will contain the value.
|
|
|
|
///
|
|
|
|
/// The value is what we will display in VS Code. Some SBValue objects
|
|
|
|
/// can have a value and/or a summary. If a value has both, we
|
|
|
|
/// combine the value and the summary into one string. If we only have a
|
|
|
|
/// value or summary, then that is considered the value. If there is
|
|
|
|
/// no value and no summary then the value is the type name followed by
|
|
|
|
/// the address of the type if it has an address.
|
|
|
|
///
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] v
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A lldb::SBValue object to extract the string value from
|
|
|
|
///
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] object
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The object to place the value object into
|
|
|
|
///
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] key
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The key name to use when inserting the value object we create
|
|
|
|
void SetValueForKey(lldb::SBValue &v, llvm::json::Object &object,
|
|
|
|
llvm::StringRef key);
|
|
|
|
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
/// Converts \a bp to a JSON value and appends the first valid location to the
|
2018-08-17 01:59:38 +08:00
|
|
|
/// \a breakpoints array.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] bp
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
/// A LLDB breakpoint object which will get the first valid location
|
|
|
|
/// extracted and converted into a JSON object in the \a breakpoints array
|
2018-08-17 01:59:38 +08:00
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] breakpoints
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A JSON array that will get a llvm::json::Value for \a bp
|
|
|
|
/// appended to it.
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
///
|
|
|
|
/// \param[in] request_path
|
|
|
|
/// An optional source path to use when creating the "Source" object of this
|
|
|
|
/// breakpoint. If not specified, the "Source" object is created from the
|
|
|
|
/// breakpoint's address' LineEntry. It is useful to ensure the same source
|
|
|
|
/// paths provided by the setBreakpoints request are returned to the IDE.
|
|
|
|
///
|
|
|
|
/// \param[in] request_line
|
|
|
|
/// An optional line to use when creating the "Breakpoint" object to append.
|
|
|
|
/// It is used if the breakpoint has no valid locations.
|
|
|
|
/// It is useful to ensure the same line
|
|
|
|
/// provided by the setBreakpoints request are returned to the IDE as a
|
|
|
|
/// fallback.
|
|
|
|
void AppendBreakpoint(lldb::SBBreakpoint &bp, llvm::json::Array &breakpoints,
|
|
|
|
llvm::Optional<llvm::StringRef> request_path = llvm::None,
|
|
|
|
llvm::Optional<uint32_t> request_line = llvm::None);
|
2018-08-17 01:59:38 +08:00
|
|
|
|
|
|
|
/// Converts breakpoint location to a Visual Studio Code "Breakpoint"
|
|
|
|
///
|
2020-01-30 06:11:40 +08:00
|
|
|
/// \param[in] bp
|
|
|
|
/// A LLDB breakpoint object to convert into a JSON value
|
2018-08-17 01:59:38 +08:00
|
|
|
///
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
/// \param[in] request_path
|
|
|
|
/// An optional source path to use when creating the "Source" object of this
|
|
|
|
/// breakpoint. If not specified, the "Source" object is created from the
|
|
|
|
/// breakpoint's address' LineEntry. It is useful to ensure the same source
|
|
|
|
/// paths provided by the setBreakpoints request are returned to the IDE.
|
|
|
|
///
|
|
|
|
/// \param[in] request_line
|
|
|
|
/// An optional line to use when creating the resulting "Breakpoint" object.
|
|
|
|
/// It is used if the breakpoint has no valid locations.
|
|
|
|
/// It is useful to ensure the same line
|
|
|
|
/// provided by the setBreakpoints request are returned to the IDE as a
|
|
|
|
/// fallback.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Breakpoint" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
llvm::json::Value
|
|
|
|
CreateBreakpoint(lldb::SBBreakpoint &bp,
|
|
|
|
llvm::Optional<llvm::StringRef> request_path = llvm::None,
|
|
|
|
llvm::Optional<uint32_t> request_line = llvm::None);
|
2018-08-17 01:59:38 +08:00
|
|
|
|
2020-07-14 03:10:49 +08:00
|
|
|
/// Converts a LLDB module to a VS Code DAP module for use in "modules" events.
|
|
|
|
///
|
|
|
|
/// \param[in] module
|
|
|
|
/// A LLDB module object to convert into a JSON value
|
|
|
|
///
|
|
|
|
/// \return
|
|
|
|
/// A "Module" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateModule(lldb::SBModule &module);
|
|
|
|
|
2018-08-17 01:59:38 +08:00
|
|
|
/// Create a "Event" JSON object using \a event_name as the event name
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] event_name
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The string value to use for the "event" key in the JSON object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Event" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
2018-08-17 02:24:59 +08:00
|
|
|
llvm::json::Object CreateEventObject(const llvm::StringRef event_name);
|
2018-08-17 01:59:38 +08:00
|
|
|
|
|
|
|
/// Create a "ExceptionBreakpointsFilter" JSON object as described in
|
|
|
|
/// the Visual Studio Code debug adaptor definition.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] bp
|
2020-04-07 00:06:02 +08:00
|
|
|
/// The exception breakpoint object to use
|
2018-08-17 01:59:38 +08:00
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "ExceptionBreakpointsFilter" JSON object with that follows
|
|
|
|
/// the formal JSON definition outlined by Microsoft.
|
|
|
|
llvm::json::Value
|
|
|
|
CreateExceptionBreakpointFilter(const ExceptionBreakpoint &bp);
|
|
|
|
|
|
|
|
/// Create a "Scope" JSON object as described in the Visual Studio Code
|
|
|
|
/// debug adaptor definition.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] name
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The value to place into the "name" key
|
|
|
|
//
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] variablesReference
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The value to place into the "variablesReference" key
|
|
|
|
//
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] namedVariables
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The value to place into the "namedVariables" key
|
|
|
|
//
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] expensive
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The value to place into the "expensive" key
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Scope" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateScope(const llvm::StringRef name,
|
|
|
|
int64_t variablesReference,
|
|
|
|
int64_t namedVariables, bool expensive);
|
|
|
|
|
|
|
|
/// Create a "Source" JSON object as described in the Visual Studio Code
|
|
|
|
/// debug adaptor definition.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] line_entry
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB line table to use when populating out the "Source"
|
|
|
|
/// object
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Source" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateSource(lldb::SBLineEntry &line_entry);
|
|
|
|
|
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
Summary:
When using source maps for a breakpoint, in order to find the actual source that breakpoint has resolved, we
need to use a query similar to what CommandObjectSource::DumpLinesInSymbolContexts does, which is the logic
used by the CLI to display the source line at a given breakpoint. That's necessary because from a breakpoint
location you only have an address, which points to the original source location, not the source mapped one.
in the setBreakpoints request handler, we haven't been doing such query and we were returning the original
source location, which was breaking the UX of VSCode, as many breakpoints were being set but not displayed
in the source file next to each line. Besides, clicking the source path of a breakpoint in the breakpoints
view in the debug tab was not working for this case, as VSCode was trying to open a non-existent file, thus
showing an error to the user.
Ideally, we should do the query mentioned above to find the actual source location to respond to the IDE,
however, that query is expensive and users can have an arbitrary number of breakpoints set. As a simpler fix,
the request sent by VSCode already contains the full source path, which exists because the user set it from
the IDE itself, so we can simply reuse it instead of querying from the SB API.
I wrote a test for this, and found out that I had to move SetSourceMapFromArguments after RunInitCommands in
lldb-vscode.cpp, because an init command used in all tests is `settings clear -all`, which would clear the
source map unless specified after initCommands. And in any case, I think it makes sense to have initCommands
run before anything the debugger would do.
Reviewers: clayborg, kusmour, labath, aadsm
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D76968
2020-03-28 10:31:14 +08:00
|
|
|
/// Create a "Source" object for a given source path.
|
|
|
|
///
|
|
|
|
/// \param[in] source_path
|
|
|
|
/// The path to the source to use when creating the "Source" object.
|
|
|
|
///
|
|
|
|
/// \return
|
|
|
|
/// A "Source" JSON object that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateSource(llvm::StringRef source_path);
|
|
|
|
|
2018-08-17 01:59:38 +08:00
|
|
|
/// Create a "Source" object for a given frame.
|
|
|
|
///
|
|
|
|
/// When there is no source file information for a stack frame, we will
|
|
|
|
/// create disassembly for a function and store a permanent
|
|
|
|
/// "sourceReference" that contains the textual disassembly for a
|
|
|
|
/// function along with address to line information. The "Source" object
|
|
|
|
/// that is created will contain a "sourceReference" that the VSCode
|
|
|
|
/// protocol can later fetch as text in order to display disassembly.
|
|
|
|
/// The PC will be extracted from the frame and the disassembly line
|
|
|
|
/// within the source referred to by "sourceReference" will be filled
|
|
|
|
/// in.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] frame
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB stack frame to use when populating out the "Source"
|
|
|
|
/// object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[out] disasm_line
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The line within the "sourceReference" file that the PC from
|
|
|
|
/// \a frame matches.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Source" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateSource(lldb::SBFrame &frame, int64_t &disasm_line);
|
|
|
|
|
|
|
|
/// Create a "StackFrame" object for a LLDB frame object.
|
|
|
|
///
|
|
|
|
/// This function will fill in the following keys in the returned
|
|
|
|
/// object:
|
|
|
|
/// "id" - the stack frame ID as an integer
|
|
|
|
/// "name" - the function name as a string
|
|
|
|
/// "source" - source file information as a "Source" VSCode object
|
|
|
|
/// "line" - the source file line number as an integer
|
|
|
|
/// "column" - the source file column number as an integer
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] frame
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB stack frame to use when populating out the "StackFrame"
|
|
|
|
/// object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "StackFrame" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateStackFrame(lldb::SBFrame &frame);
|
|
|
|
|
|
|
|
/// Create a "Thread" object for a LLDB thread object.
|
|
|
|
///
|
|
|
|
/// This function will fill in the following keys in the returned
|
|
|
|
/// object:
|
|
|
|
/// "id" - the thread ID as an integer
|
|
|
|
/// "name" - the thread name as a string which combines the LLDB
|
|
|
|
/// thread index ID along with the string name of the thread
|
|
|
|
/// from the OS if it has a name.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] thread
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB thread to use when populating out the "Thread"
|
|
|
|
/// object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Thread" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateThread(lldb::SBThread &thread);
|
|
|
|
|
|
|
|
/// Create a "StoppedEvent" object for a LLDB thread object.
|
|
|
|
///
|
|
|
|
/// This function will fill in the following keys in the returned
|
|
|
|
/// object's "body" object:
|
|
|
|
/// "reason" - With a valid stop reason enumeration string value
|
|
|
|
/// that Microsoft specifies
|
|
|
|
/// "threadId" - The thread ID as an integer
|
|
|
|
/// "description" - a stop description (like "breakpoint 12.3") as a
|
|
|
|
/// string
|
|
|
|
/// "preserveFocusHint" - a boolean value that states if this thread
|
|
|
|
/// should keep the focus in the GUI.
|
|
|
|
/// "allThreadsStopped" - set to True to indicate that all threads
|
|
|
|
/// stop when any thread stops.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] thread
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB thread to use when populating out the "StoppedEvent"
|
|
|
|
/// object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "StoppedEvent" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateThreadStopped(lldb::SBThread &thread, uint32_t stop_id);
|
|
|
|
|
2021-04-28 07:02:38 +08:00
|
|
|
/// \return
|
|
|
|
/// The variable name of \a value or a default placeholder.
|
|
|
|
const char *GetNonNullVariableName(lldb::SBValue value);
|
|
|
|
|
2021-04-22 06:06:44 +08:00
|
|
|
/// VSCode can't display two variables with the same name, so we need to
|
|
|
|
/// distinguish them by using a suffix.
|
|
|
|
///
|
|
|
|
/// If the source and line information is present, we use it as the suffix.
|
|
|
|
/// Otherwise, we fallback to the variable address or register location.
|
|
|
|
std::string CreateUniqueVariableNameForDisplay(lldb::SBValue v,
|
|
|
|
bool is_name_duplicated);
|
|
|
|
|
2018-08-17 01:59:38 +08:00
|
|
|
/// Create a "Variable" object for a LLDB thread object.
|
|
|
|
///
|
|
|
|
/// This function will fill in the following keys in the returned
|
|
|
|
/// object:
|
|
|
|
/// "name" - the name of the variable
|
|
|
|
/// "value" - the value of the variable as a string
|
2018-10-05 06:33:39 +08:00
|
|
|
/// "type" - the typename of the variable as a string
|
2018-08-17 01:59:38 +08:00
|
|
|
/// "id" - a unique identifier for a value in case there are multiple
|
|
|
|
/// variables with the same name. Other parts of the VSCode
|
|
|
|
/// protocol refer to values by name so this can help
|
|
|
|
/// disambiguate such cases if a IDE passes this "id" value
|
|
|
|
/// back down.
|
|
|
|
/// "variablesReference" - Zero if the variable has no children,
|
|
|
|
/// non-zero integer otherwise which can be used to expand
|
|
|
|
/// the variable.
|
|
|
|
/// "evaluateName" - The name of the variable to use in expressions
|
|
|
|
/// as a string.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] v
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The LLDB value to use when populating out the "Variable"
|
|
|
|
/// object.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] variablesReference
|
2018-08-17 01:59:38 +08:00
|
|
|
/// The variable reference. Zero if this value isn't structured
|
|
|
|
/// and has no children, non-zero if it does have children and
|
|
|
|
/// might be asked to expand itself.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] varID
|
2018-10-05 06:33:39 +08:00
|
|
|
/// A unique variable identifier to help in properly identifying
|
2018-08-17 01:59:38 +08:00
|
|
|
/// variables with the same name. This is an extension to the
|
|
|
|
/// VS protocol.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \param[in] format_hex
|
2018-08-17 01:59:38 +08:00
|
|
|
/// It set to true the variable will be formatted as hex in
|
|
|
|
/// the "value" key value pair for the value of the variable.
|
|
|
|
///
|
2021-04-22 06:06:44 +08:00
|
|
|
/// \param[in] is_name_duplicated
|
|
|
|
/// Whether the same variable name appears multiple times within the same
|
|
|
|
/// context (e.g. locals). This can happen due to shadowed variables in
|
|
|
|
/// nested blocks.
|
|
|
|
///
|
|
|
|
/// As VSCode doesn't render two of more variables with the same name, we
|
|
|
|
/// apply a suffix to distinguish duplicated variables.
|
|
|
|
///
|
2019-03-12 01:09:29 +08:00
|
|
|
/// \return
|
2018-08-17 01:59:38 +08:00
|
|
|
/// A "Variable" JSON object with that follows the formal JSON
|
|
|
|
/// definition outlined by Microsoft.
|
|
|
|
llvm::json::Value CreateVariable(lldb::SBValue v, int64_t variablesReference,
|
2021-04-22 06:06:44 +08:00
|
|
|
int64_t varID, bool format_hex,
|
|
|
|
bool is_name_duplicated = false);
|
2018-08-17 01:59:38 +08:00
|
|
|
|
2020-07-14 03:10:49 +08:00
|
|
|
llvm::json::Value CreateCompileUnit(lldb::SBCompileUnit unit);
|
|
|
|
|
2020-09-02 09:52:14 +08:00
|
|
|
/// Create a runInTerminal reverse request object
|
|
|
|
///
|
|
|
|
/// \param[in] launch_request
|
|
|
|
/// The original launch_request object whose fields are used to construct
|
|
|
|
/// the reverse request object.
|
|
|
|
///
|
[vscode] Improve runInTerminal and support linux
Depends on D93874.
runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the debuggee:
- it gets to know of the target late, which renders breakpoints in the main function almost impossible
- polling might fail if there are already other processes with the same name
- polling might also fail on some linux machine, as it's implemented with the ps command, and the ps command's args and output are not standard everywhere
As a better way to implement this so that it works well on Darwin and Linux, I'm using now the following process:
- lldb-vscode notices the runInTerminal, so it spawns lldb-vscode with a special flag --launch-target <target>. This flags tells lldb-vscode to wait to be attached and then it execs the target program. I'm using lldb-vscode itself to do this, because it makes finding the launcher program easier. Also no CMAKE INSTALL scripts are needed.
- Besides this, the debugger creates a temporary FIFO file where the launcher program will write its pid to. That way the debugger will be sure of which program to attach.
- Once attach happend, the debugger creates a second temporary file to notify the launcher program that it has been attached, so that it can then exec. I'm using this instead of using a signal or a similar mechanism because I don't want the launcher program to wait indefinitely to be attached in case the debugger crashed. That would pollute the process list with a lot of hanging processes. Instead, I'm setting a 20 seconds timeout (that's an overkill) and the launcher program seeks in intervals the second tepmorary file.
Some notes:
- I preferred not to use sockets because it requires a lot of code and I only need a pid. It would also require a lot of code when windows support is implemented.
- I didn't add Windows support, as I don't have a windows machine, but adding support for it should be easy, as the FIFO file can be implemented with a named pipe, which is standard on Windows and works pretty much the same way.
The existing test which didn't pass on Linux, now passes.
Differential Revision: https://reviews.llvm.org/D93951
2020-12-29 04:00:47 +08:00
|
|
|
/// \param[in] debug_adaptor_path
|
|
|
|
/// Path to the current debug adaptor. It will be used to delegate the
|
|
|
|
/// launch of the target.
|
|
|
|
///
|
|
|
|
/// \param[in] comm_file
|
|
|
|
/// The fifo file used to communicate the with the target launcher.
|
|
|
|
///
|
2020-09-02 09:52:14 +08:00
|
|
|
/// \return
|
|
|
|
/// A "runInTerminal" JSON object that follows the specification outlined by
|
|
|
|
/// Microsoft.
|
|
|
|
llvm::json::Object
|
[vscode] Improve runInTerminal and support linux
Depends on D93874.
runInTerminal was using --wait-for, but it was some problems because it uses process polling looking for a single instance of the debuggee:
- it gets to know of the target late, which renders breakpoints in the main function almost impossible
- polling might fail if there are already other processes with the same name
- polling might also fail on some linux machine, as it's implemented with the ps command, and the ps command's args and output are not standard everywhere
As a better way to implement this so that it works well on Darwin and Linux, I'm using now the following process:
- lldb-vscode notices the runInTerminal, so it spawns lldb-vscode with a special flag --launch-target <target>. This flags tells lldb-vscode to wait to be attached and then it execs the target program. I'm using lldb-vscode itself to do this, because it makes finding the launcher program easier. Also no CMAKE INSTALL scripts are needed.
- Besides this, the debugger creates a temporary FIFO file where the launcher program will write its pid to. That way the debugger will be sure of which program to attach.
- Once attach happend, the debugger creates a second temporary file to notify the launcher program that it has been attached, so that it can then exec. I'm using this instead of using a signal or a similar mechanism because I don't want the launcher program to wait indefinitely to be attached in case the debugger crashed. That would pollute the process list with a lot of hanging processes. Instead, I'm setting a 20 seconds timeout (that's an overkill) and the launcher program seeks in intervals the second tepmorary file.
Some notes:
- I preferred not to use sockets because it requires a lot of code and I only need a pid. It would also require a lot of code when windows support is implemented.
- I didn't add Windows support, as I don't have a windows machine, but adding support for it should be easy, as the FIFO file can be implemented with a named pipe, which is standard on Windows and works pretty much the same way.
The existing test which didn't pass on Linux, now passes.
Differential Revision: https://reviews.llvm.org/D93951
2020-12-29 04:00:47 +08:00
|
|
|
CreateRunInTerminalReverseRequest(const llvm::json::Object &launch_request,
|
|
|
|
llvm::StringRef debug_adaptor_path,
|
|
|
|
llvm::StringRef comm_file);
|
|
|
|
|
|
|
|
/// Convert a given JSON object to a string.
|
|
|
|
std::string JSONToString(const llvm::json::Value &json);
|
2020-09-02 09:52:14 +08:00
|
|
|
|
2018-08-17 01:59:38 +08:00
|
|
|
} // namespace lldb_vscode
|
|
|
|
|
|
|
|
#endif
|