[GlobalOpt] Include padding in debug fragments
Summary:
When creating the debug fragments for a SRA'd variable, use the types'
allocation sizes. This fixes issues where the pass would emit too small
fragments, placed at the wrong offset, for padded types.
An example of this is long double on x86. The type is represented using
x86_fp80, which is 10 bytes, but the value is aligned to 12/16 bytes.
The padding is included in the type's DW_AT_byte_size attribute;
therefore, the fragments should also include that. Newer GCC releases
(I tested 7.2.0) emit 12/16-byte pieces for long double. Earlier
releases, e.g. GCC 5.5.0, behaved as LLVM did, i.e. by emitting a
10-byte piece, followed by an empty 2/6-byte piece for the padding.
Failing to cover all `DW_AT_byte_size' bytes of a value with non-empty
pieces results in the value being printed as <optimized out> by GDB.
Patch by: David Stenberg
Reviewers: aprantl, JDevlieghere
Reviewed By: aprantl, JDevlieghere
Subscribers: llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D42807
llvm-svn: 324066
2018-02-02 18:34:13 +08:00
; RUN: opt -S -globalopt < %s | FileCheck %s
source_filename = "array.c"
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%struct.mystruct = type { i32 , i64 }
; Generated from:
;
; static long double array[2];
; void __attribute__((nodebug)) foo(int in) { array[0] = in; }
; void __attribute__((nodebug)) bar(int in) { array[1] = in; }
; int main(int argc, char **argv)
; {
; foo(argv[0][1]);
; bar(argv[0][1]);
; return (array[0] + array[1]) > 0;
; }
;
; using clang -O0 -g2 -S -emit-llvm
@array = internal global [ 2 x x86_fp80 ] zeroinitializer , align 16 , !dbg !0
; CHECK: @array.0 = internal unnamed_addr global x86_fp80 0xK00000000000000000000, align 16, !dbg ![[EL0:.*]]
; CHECK: @array.1 = internal unnamed_addr global x86_fp80 0xK00000000000000000000, align 16, !dbg ![[EL1:.*]]
;
; CHECK: ![[EL0]] = !DIGlobalVariableExpression(var: ![[VAR:.*]], expr: !DIExpression(DW_OP_LLVM_fragment, 0, 128))
; CHECK: ![[VAR]] = distinct !DIGlobalVariable(name: "array"
; CHECK: ![[EL1]] = !DIGlobalVariableExpression(var: ![[VAR]], expr: !DIExpression(DW_OP_LLVM_fragment, 128, 128))
; Function Attrs: noinline nounwind optnone uwtable
define void @foo ( i32 %in ) #0 {
entry:
%in.addr = alloca i32 , align 4
store i32 %in , i32 * %in.addr , align 4
%0 = load i32 , i32 * %in.addr , align 4
%conv = sitofp i32 %0 to x86_fp80
store x86_fp80 %conv , x86_fp80 * getelementptr inbounds ( [ 2 x x86_fp80 ] , [ 2 x x86_fp80 ] * @array , i64 0 , i64 0 ) , align 16
ret void
}
; Function Attrs: noinline nounwind optnone uwtable
define void @bar ( i32 %in ) #0 {
entry:
%in.addr = alloca i32 , align 4
store i32 %in , i32 * %in.addr , align 4
%0 = load i32 , i32 * %in.addr , align 4
%conv = sitofp i32 %0 to x86_fp80
store x86_fp80 %conv , x86_fp80 * getelementptr inbounds ( [ 2 x x86_fp80 ] , [ 2 x x86_fp80 ] * @array , i64 0 , i64 1 ) , align 16
ret void
}
; Function Attrs: noinline nounwind optnone uwtable
define i32 @main ( i32 %argc , i8 * * %argv ) #0 !dbg !14 {
entry:
%retval = alloca i32 , align 4
%argc.addr = alloca i32 , align 4
%argv.addr = alloca i8 * * , align 8
store i32 0 , i32 * %retval , align 4
store i32 %argc , i32 * %argc.addr , align 4
call void @llvm.dbg.declare ( metadata i32 * %argc.addr , metadata !21 , metadata !DIExpression ( ) ) , !dbg !22
store i8 * * %argv , i8 * * * %argv.addr , align 8
call void @llvm.dbg.declare ( metadata i8 * * * %argv.addr , metadata !23 , metadata !DIExpression ( ) ) , !dbg !24
%0 = load i8 * * , i8 * * * %argv.addr , align 8 , !dbg !25
%arrayidx = getelementptr inbounds i8 * , i8 * * %0 , i64 0 , !dbg !25
%1 = load i8 * , i8 * * %arrayidx , align 8 , !dbg !25
%arrayidx1 = getelementptr inbounds i8 , i8 * %1 , i64 1 , !dbg !25
%2 = load i8 , i8 * %arrayidx1 , align 1 , !dbg !25
%conv = sext i8 %2 to i32 , !dbg !25
call void @foo ( i32 %conv ) , !dbg !26
%3 = load i8 * * , i8 * * * %argv.addr , align 8 , !dbg !27
%arrayidx2 = getelementptr inbounds i8 * , i8 * * %3 , i64 0 , !dbg !27
%4 = load i8 * , i8 * * %arrayidx2 , align 8 , !dbg !27
%arrayidx3 = getelementptr inbounds i8 , i8 * %4 , i64 1 , !dbg !27
%5 = load i8 , i8 * %arrayidx3 , align 1 , !dbg !27
%conv4 = sext i8 %5 to i32 , !dbg !27
call void @bar ( i32 %conv4 ) , !dbg !28
%6 = load x86_fp80 , x86_fp80 * getelementptr inbounds ( [ 2 x x86_fp80 ] , [ 2 x x86_fp80 ] * @array , i64 0 , i64 0 ) , align 16 , !dbg !29
%7 = load x86_fp80 , x86_fp80 * getelementptr inbounds ( [ 2 x x86_fp80 ] , [ 2 x x86_fp80 ] * @array , i64 0 , i64 1 ) , align 16 , !dbg !30
%add = fadd x86_fp80 %6 , %7 , !dbg !31
%cmp = fcmp ogt x86_fp80 %add , 0 x K 00000000000000000000 , !dbg !32
%conv5 = zext i1 %cmp to i32 , !dbg !32
ret i32 %conv5 , !dbg !33
}
; Function Attrs: nounwind readnone speculatable
declare void @llvm.dbg.declare ( metadata , metadata , metadata ) #1
attributes #0 = { noinline nounwind optnone uwtable }
attributes #1 = { nounwind readnone s p e c u l a t a b l e }
!llvm.dbg.cu = ! { !2 }
!llvm.module.flags = ! { !10 , !11 , !12 }
!llvm.ident = ! { !13 }
!0 = !DIGlobalVariableExpression ( var: !1 , expr: !DIExpression ( ) )
!1 = distinct !DIGlobalVariable ( name: "array" , scope: !2 , file: !3 , line: 1 , type: !6 , isLocal: true , isDefinition: true )
!2 = distinct !DICompileUnit ( language: D W _ L A N G _ C 99 , file: !3 , producer: "clang version 7.0.0" , isOptimized: false , runtimeVersion: 0 , emissionKind: F u l l D e b u g , enums: !4 , globals: !5 )
!3 = !DIFile ( filename: "array.c" , directory: "/" )
!4 = ! { }
!5 = ! { !0 }
!6 = !DICompositeType ( tag: D W _ T A G _ a r r a y _ type , baseType: !7 , size: 256 , elements: !8 )
!7 = !DIBasicType ( name: "long double" , size: 128 , encoding: D W _ A T E _ float )
!8 = ! { !9 }
!9 = !DISubrange ( count: 2 )
!10 = ! { i32 2 , !"Dwarf Version" , i32 4 }
!11 = ! { i32 2 , !"Debug Info Version" , i32 3 }
!12 = ! { i32 1 , !"wchar_size" , i32 4 }
!13 = ! { !"clang version 7.0.0" }
[DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label.
In order to set breakpoints on labels and list source code around
labels, we need collect debug information for labels, i.e., label
name, the function label belong, line number in the file, and the
address label located. In order to keep these information in LLVM
IR and to allow backend to generate debug information correctly.
We create a new kind of metadata for labels, DILabel. The format
of DILabel is
!DILabel(scope: !1, name: "foo", file: !2, line: 3)
We hope to keep debug information as much as possible even the
code is optimized. So, we create a new kind of intrinsic for label
metadata to avoid the metadata is eliminated with basic block.
The intrinsic will keep existing if we keep it from optimized out.
The format of the intrinsic is
llvm.dbg.label(metadata !1)
It has only one argument, that is the DILabel metadata. The
intrinsic will follow the label immediately. Backend could get the
label metadata through the intrinsic's parameter.
We also create DIBuilder API for labels to be used by Frontend.
Frontend could use createLabel() to allocate DILabel objects, and use
insertLabel() to insert llvm.dbg.label intrinsic in LLVM IR.
Differential Revision: https://reviews.llvm.org/D45024
Patch by Hsiangkai Wang.
llvm-svn: 331841
2018-05-09 10:40:45 +08:00
!14 = distinct !DISubprogram ( name: "main" , scope: !3 , file: !3 , line: 4 , type: !15 , isLocal: false , isDefinition: true , scopeLine: 5 , flags: D I F l a g P r o t o t y p e d , isOptimized: false , unit: !2 , retainedNodes: !4 )
[GlobalOpt] Include padding in debug fragments
Summary:
When creating the debug fragments for a SRA'd variable, use the types'
allocation sizes. This fixes issues where the pass would emit too small
fragments, placed at the wrong offset, for padded types.
An example of this is long double on x86. The type is represented using
x86_fp80, which is 10 bytes, but the value is aligned to 12/16 bytes.
The padding is included in the type's DW_AT_byte_size attribute;
therefore, the fragments should also include that. Newer GCC releases
(I tested 7.2.0) emit 12/16-byte pieces for long double. Earlier
releases, e.g. GCC 5.5.0, behaved as LLVM did, i.e. by emitting a
10-byte piece, followed by an empty 2/6-byte piece for the padding.
Failing to cover all `DW_AT_byte_size' bytes of a value with non-empty
pieces results in the value being printed as <optimized out> by GDB.
Patch by: David Stenberg
Reviewers: aprantl, JDevlieghere
Reviewed By: aprantl, JDevlieghere
Subscribers: llvm-commits
Tags: #debug-info
Differential Revision: https://reviews.llvm.org/D42807
llvm-svn: 324066
2018-02-02 18:34:13 +08:00
!15 = !DISubroutineType ( types: !16 )
!16 = ! { !17 , !17 , !18 }
!17 = !DIBasicType ( name: "int" , size: 32 , encoding: D W _ A T E _ s i g n e d )
!18 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , baseType: !19 , size: 64 )
!19 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , baseType: !20 , size: 64 )
!20 = !DIBasicType ( name: "char" , size: 8 , encoding: D W _ A T E _ s i g n e d _ c h a r )
!21 = !DILocalVariable ( name: "argc" , arg: 1 , scope: !14 , file: !3 , line: 4 , type: !17 )
!22 = !DILocation ( line: 4 , column: 14 , scope: !14 )
!23 = !DILocalVariable ( name: "argv" , arg: 2 , scope: !14 , file: !3 , line: 4 , type: !18 )
!24 = !DILocation ( line: 4 , column: 27 , scope: !14 )
!25 = !DILocation ( line: 6 , column: 7 , scope: !14 )
!26 = !DILocation ( line: 6 , column: 3 , scope: !14 )
!27 = !DILocation ( line: 7 , column: 7 , scope: !14 )
!28 = !DILocation ( line: 7 , column: 3 , scope: !14 )
!29 = !DILocation ( line: 8 , column: 11 , scope: !14 )
!30 = !DILocation ( line: 8 , column: 22 , scope: !14 )
!31 = !DILocation ( line: 8 , column: 20 , scope: !14 )
!32 = !DILocation ( line: 8 , column: 32 , scope: !14 )
!33 = !DILocation ( line: 8 , column: 3 , scope: !14 )