2018-11-21 01:04:02 +08:00
|
|
|
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
2021-01-07 02:34:21 +08:00
|
|
|
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=hawaii -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=CIVI,HAWAII %s
|
|
|
|
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=fiji -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=CIVI,FIJI %s
|
|
|
|
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -enable-var-scope --check-prefix=GFX9 %s
|
2017-11-29 01:11:30 +08:00
|
|
|
|
|
|
|
define void @local_store_i56(i56 addrspace(3)* %ptr, i56 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; CIVI-LABEL: local_store_i56:
|
|
|
|
; CIVI: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; CIVI-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; CIVI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; CIVI-NEXT: ds_write_b16 v0, v2 offset:4
|
|
|
|
; CIVI-NEXT: ds_write_b32 v0, v1
|
|
|
|
; CIVI-NEXT: v_lshrrev_b32_e32 v1, 16, v2
|
|
|
|
; CIVI-NEXT: ds_write_b8 v0, v1 offset:6
|
2020-09-23 23:16:39 +08:00
|
|
|
; CIVI-NEXT: s_waitcnt lgkmcnt(0)
|
2020-06-03 17:01:12 +08:00
|
|
|
; CIVI-NEXT: s_setpc_b64 s[30:31]
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i56:
|
|
|
|
; GFX9: ; %bb.0:
|
|
|
|
; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: ds_write_b8_d16_hi v0, v2 offset:6
|
|
|
|
; GFX9-NEXT: ds_write_b16 v0, v2 offset:4
|
|
|
|
; GFX9-NEXT: ds_write_b32 v0, v1
|
2020-09-23 23:16:39 +08:00
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
2018-11-21 01:04:02 +08:00
|
|
|
; GFX9-NEXT: s_setpc_b64 s[30:31]
|
2017-11-29 01:11:30 +08:00
|
|
|
store i56 %arg, i56 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
define amdgpu_kernel void @local_store_i55(i55 addrspace(3)* %ptr, i55 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; HAWAII-LABEL: local_store_i55:
|
|
|
|
; HAWAII: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; HAWAII-NEXT: s_or_b32 s0, s4, 14
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v1, s5
|
|
|
|
; HAWAII-NEXT: flat_load_ubyte v0, v[0:1]
|
|
|
|
; HAWAII-NEXT: s_load_dword s2, s[4:5], 0x3
|
|
|
|
; HAWAII-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; HAWAII-NEXT: s_load_dword s1, s[4:5], 0x2
|
|
|
|
; HAWAII-NEXT: s_mov_b32 m0, -1
|
|
|
|
; HAWAII-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v1, s0
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v3, s2
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v2, s1
|
|
|
|
; HAWAII-NEXT: ds_write_b16 v1, v3 offset:4
|
|
|
|
; HAWAII-NEXT: s_waitcnt vmcnt(0)
|
|
|
|
; HAWAII-NEXT: v_and_b32_e32 v0, 0x7f, v0
|
|
|
|
; HAWAII-NEXT: ds_write_b8 v1, v0 offset:6
|
|
|
|
; HAWAII-NEXT: ds_write_b32 v1, v2
|
|
|
|
; HAWAII-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; FIJI-LABEL: local_store_i55:
|
|
|
|
; FIJI: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; FIJI-NEXT: s_or_b32 s0, s4, 14
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v1, s5
|
|
|
|
; FIJI-NEXT: flat_load_ubyte v0, v[0:1]
|
|
|
|
; FIJI-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; FIJI-NEXT: s_load_dword s1, s[4:5], 0x8
|
|
|
|
; FIJI-NEXT: s_load_dword s2, s[4:5], 0xc
|
|
|
|
; FIJI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; FIJI-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v1, s0
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v3, s1
|
|
|
|
; FIJI-NEXT: s_and_b32 s3, s2, 0xffff
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v2, s2
|
|
|
|
; FIJI-NEXT: ds_write_b16 v1, v2 offset:4
|
|
|
|
; FIJI-NEXT: s_waitcnt vmcnt(0)
|
|
|
|
; FIJI-NEXT: v_lshlrev_b32_e32 v0, 16, v0
|
|
|
|
; FIJI-NEXT: v_or_b32_e32 v0, s3, v0
|
|
|
|
; FIJI-NEXT: v_bfe_u32 v0, v0, 16, 7
|
|
|
|
; FIJI-NEXT: ds_write_b8 v1, v0 offset:6
|
|
|
|
; FIJI-NEXT: ds_write_b32 v1, v3
|
|
|
|
; FIJI-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i55:
|
|
|
|
; GFX9: ; %bb.0:
|
2020-11-11 00:06:59 +08:00
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v0, 0
|
|
|
|
; GFX9-NEXT: global_load_ubyte_d16_hi v0, v0, s[4:5] offset:14
|
|
|
|
; GFX9-NEXT: s_load_dword s2, s[4:5], 0xc
|
2020-06-03 17:01:12 +08:00
|
|
|
; GFX9-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; GFX9-NEXT: s_load_dword s1, s[4:5], 0x8
|
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: s_and_b32 s3, s2, 0xffff
|
2020-11-11 00:06:59 +08:00
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v1, s0
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v2, s2
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v3, s1
|
|
|
|
; GFX9-NEXT: ds_write_b16 v1, v2 offset:4
|
2020-06-03 17:01:12 +08:00
|
|
|
; GFX9-NEXT: s_waitcnt vmcnt(0)
|
2020-11-11 00:06:59 +08:00
|
|
|
; GFX9-NEXT: v_or_b32_e32 v0, s3, v0
|
|
|
|
; GFX9-NEXT: v_and_b32_e32 v0, 0x7fffff, v0
|
|
|
|
; GFX9-NEXT: ds_write_b8_d16_hi v1, v0 offset:6
|
|
|
|
; GFX9-NEXT: ds_write_b32 v1, v3
|
2020-06-03 17:01:12 +08:00
|
|
|
; GFX9-NEXT: s_endpgm
|
2017-11-29 01:11:30 +08:00
|
|
|
store i55 %arg, i55 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
define amdgpu_kernel void @local_store_i48(i48 addrspace(3)* %ptr, i48 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; HAWAII-LABEL: local_store_i48:
|
|
|
|
; HAWAII: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; HAWAII-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; HAWAII-NEXT: s_load_dword s1, s[4:5], 0x2
|
|
|
|
; HAWAII-NEXT: s_load_dword s2, s[4:5], 0x3
|
|
|
|
; HAWAII-NEXT: s_mov_b32 m0, -1
|
|
|
|
; HAWAII-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v1, s2
|
|
|
|
; HAWAII-NEXT: ds_write_b16 v0, v1 offset:4
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v1, s1
|
|
|
|
; HAWAII-NEXT: ds_write_b32 v0, v1
|
|
|
|
; HAWAII-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; FIJI-LABEL: local_store_i48:
|
|
|
|
; FIJI: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; FIJI-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; FIJI-NEXT: s_load_dword s1, s[4:5], 0x8
|
|
|
|
; FIJI-NEXT: s_load_dword s2, s[4:5], 0xc
|
|
|
|
; FIJI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; FIJI-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v1, s2
|
|
|
|
; FIJI-NEXT: ds_write_b16 v0, v1 offset:4
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v1, s1
|
|
|
|
; FIJI-NEXT: ds_write_b32 v0, v1
|
|
|
|
; FIJI-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i48:
|
|
|
|
; GFX9: ; %bb.0:
|
|
|
|
; GFX9-NEXT: s_load_dword s0, s[4:5], 0x0
|
|
|
|
; GFX9-NEXT: s_load_dword s1, s[4:5], 0x8
|
|
|
|
; GFX9-NEXT: s_load_dword s2, s[4:5], 0xc
|
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v0, s0
|
[AMDGPU] Remove dubious logic in bidirectional list scheduler
Summary:
pickNodeBidirectional tried to compare the best top candidate and the
best bottom candidate by examining TopCand.Reason and BotCand.Reason.
This is unsound because, after calling pickNodeFromQueue, Cand.Reason
does not reflect the most important reason why Cand was chosen. Rather
it reflects the most recent reason why it beat some other potential
candidate, which could have been for some low priority tie breaker
reason.
I have seen this cause problems where TopCand is a good candidate, but
because TopCand.Reason is ORDER (which is very low priority) it is
repeatedly ignored in favour of a mediocre BotCand. This is not how
bidirectional scheduling is supposed to work.
To fix this I changed the code to always compare TopCand and BotCand
directly, like the generic implementation of pickNodeBidirectional does.
This removes some uncommented AMDGPU-specific logic; if this logic turns
out to be important then perhaps it could be moved into an override of
tryCandidate instead.
Graphics shader benchmarking on gfx10 shows a lot more positive than
negative effects from this change.
Reviewers: arsenm, tstellar, rampitec, kzhuravl, vpykhtin, dstuttard, tpr, atrick, MatzeB
Subscribers: jvesely, wdng, nhaehnle, yaxunl, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68338
2019-10-07 22:33:59 +08:00
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v2, s1
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v1, s2
|
|
|
|
; GFX9-NEXT: ds_write_b16 v0, v1 offset:4
|
|
|
|
; GFX9-NEXT: ds_write_b32 v0, v2
|
2018-11-21 01:04:02 +08:00
|
|
|
; GFX9-NEXT: s_endpgm
|
2017-11-29 01:11:30 +08:00
|
|
|
store i48 %arg, i48 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
define amdgpu_kernel void @local_store_i65(i65 addrspace(3)* %ptr, i65 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; HAWAII-LABEL: local_store_i65:
|
|
|
|
; HAWAII: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; HAWAII-NEXT: s_load_dword s2, s[4:5], 0x0
|
|
|
|
; HAWAII-NEXT: s_load_dwordx2 s[0:1], s[4:5], 0x2
|
|
|
|
; HAWAII-NEXT: s_load_dword s3, s[4:5], 0x4
|
|
|
|
; HAWAII-NEXT: s_mov_b32 m0, -1
|
|
|
|
; HAWAII-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v2, s2
|
|
|
|
; HAWAII-NEXT: s_and_b32 s3, s3, 1
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v0, s3
|
|
|
|
; HAWAII-NEXT: ds_write_b8 v2, v0 offset:8
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; HAWAII-NEXT: v_mov_b32_e32 v1, s1
|
|
|
|
; HAWAII-NEXT: ds_write_b64 v2, v[0:1]
|
|
|
|
; HAWAII-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; FIJI-LABEL: local_store_i65:
|
|
|
|
; FIJI: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; FIJI-NEXT: s_load_dword s2, s[4:5], 0x0
|
|
|
|
; FIJI-NEXT: s_load_dwordx2 s[0:1], s[4:5], 0x8
|
|
|
|
; FIJI-NEXT: s_load_dword s3, s[4:5], 0x10
|
|
|
|
; FIJI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; FIJI-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v2, s2
|
|
|
|
; FIJI-NEXT: s_and_b32 s3, s3, 1
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v0, s3
|
|
|
|
; FIJI-NEXT: ds_write_b8 v2, v0 offset:8
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v0, s0
|
|
|
|
; FIJI-NEXT: v_mov_b32_e32 v1, s1
|
|
|
|
; FIJI-NEXT: ds_write_b64 v2, v[0:1]
|
|
|
|
; FIJI-NEXT: s_endpgm
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i65:
|
|
|
|
; GFX9: ; %bb.0:
|
|
|
|
; GFX9-NEXT: s_load_dword s2, s[4:5], 0x0
|
|
|
|
; GFX9-NEXT: s_load_dwordx2 s[0:1], s[4:5], 0x8
|
|
|
|
; GFX9-NEXT: s_load_dword s3, s[4:5], 0x10
|
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v2, s2
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v0, s0
|
[AMDGPU] Remove dubious logic in bidirectional list scheduler
Summary:
pickNodeBidirectional tried to compare the best top candidate and the
best bottom candidate by examining TopCand.Reason and BotCand.Reason.
This is unsound because, after calling pickNodeFromQueue, Cand.Reason
does not reflect the most important reason why Cand was chosen. Rather
it reflects the most recent reason why it beat some other potential
candidate, which could have been for some low priority tie breaker
reason.
I have seen this cause problems where TopCand is a good candidate, but
because TopCand.Reason is ORDER (which is very low priority) it is
repeatedly ignored in favour of a mediocre BotCand. This is not how
bidirectional scheduling is supposed to work.
To fix this I changed the code to always compare TopCand and BotCand
directly, like the generic implementation of pickNodeBidirectional does.
This removes some uncommented AMDGPU-specific logic; if this logic turns
out to be important then perhaps it could be moved into an override of
tryCandidate instead.
Graphics shader benchmarking on gfx10 shows a lot more positive than
negative effects from this change.
Reviewers: arsenm, tstellar, rampitec, kzhuravl, vpykhtin, dstuttard, tpr, atrick, MatzeB
Subscribers: jvesely, wdng, nhaehnle, yaxunl, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68338
2019-10-07 22:33:59 +08:00
|
|
|
; GFX9-NEXT: s_and_b32 s3, s3, 1
|
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v3, s3
|
2018-11-21 01:04:02 +08:00
|
|
|
; GFX9-NEXT: v_mov_b32_e32 v1, s1
|
|
|
|
; GFX9-NEXT: ds_write_b8 v2, v3 offset:8
|
|
|
|
; GFX9-NEXT: ds_write_b64 v2, v[0:1]
|
|
|
|
; GFX9-NEXT: s_endpgm
|
2017-11-29 01:11:30 +08:00
|
|
|
store i65 %arg, i65 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
define void @local_store_i13(i13 addrspace(3)* %ptr, i13 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; CIVI-LABEL: local_store_i13:
|
|
|
|
; CIVI: ; %bb.0:
|
|
|
|
; CIVI-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; CIVI-NEXT: v_and_b32_e32 v1, 0x1fff, v1
|
|
|
|
; CIVI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; CIVI-NEXT: ds_write_b16 v0, v1
|
2020-09-23 23:16:39 +08:00
|
|
|
; CIVI-NEXT: s_waitcnt lgkmcnt(0)
|
2018-11-21 01:04:02 +08:00
|
|
|
; CIVI-NEXT: s_setpc_b64 s[30:31]
|
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i13:
|
|
|
|
; GFX9: ; %bb.0:
|
|
|
|
; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: v_and_b32_e32 v1, 0x1fff, v1
|
|
|
|
; GFX9-NEXT: ds_write_b16 v0, v1
|
2020-09-23 23:16:39 +08:00
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
2018-11-21 01:04:02 +08:00
|
|
|
; GFX9-NEXT: s_setpc_b64 s[30:31]
|
2017-11-29 01:11:30 +08:00
|
|
|
store i13 %arg, i13 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
define void @local_store_i17(i17 addrspace(3)* %ptr, i17 %arg) #0 {
|
2018-11-21 01:04:02 +08:00
|
|
|
; CIVI-LABEL: local_store_i17:
|
|
|
|
; CIVI: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; CIVI-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; CIVI-NEXT: s_mov_b32 m0, -1
|
|
|
|
; CIVI-NEXT: ds_write_b16 v0, v1
|
|
|
|
; CIVI-NEXT: v_bfe_u32 v1, v1, 16, 1
|
|
|
|
; CIVI-NEXT: ds_write_b8 v0, v1 offset:2
|
2020-09-23 23:16:39 +08:00
|
|
|
; CIVI-NEXT: s_waitcnt lgkmcnt(0)
|
2020-06-03 17:01:12 +08:00
|
|
|
; CIVI-NEXT: s_setpc_b64 s[30:31]
|
2018-11-21 01:04:02 +08:00
|
|
|
;
|
|
|
|
; GFX9-LABEL: local_store_i17:
|
|
|
|
; GFX9: ; %bb.0:
|
2020-06-03 17:01:12 +08:00
|
|
|
; GFX9-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
|
|
|
|
; GFX9-NEXT: ds_write_b16 v0, v1
|
|
|
|
; GFX9-NEXT: v_and_b32_e32 v1, 0x1ffff, v1
|
|
|
|
; GFX9-NEXT: ds_write_b8_d16_hi v0, v1 offset:2
|
2020-09-23 23:16:39 +08:00
|
|
|
; GFX9-NEXT: s_waitcnt lgkmcnt(0)
|
2020-06-03 17:01:12 +08:00
|
|
|
; GFX9-NEXT: s_setpc_b64 s[30:31]
|
2017-11-29 01:11:30 +08:00
|
|
|
store i17 %arg, i17 addrspace(3)* %ptr, align 8
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
attributes #0 = { nounwind }
|