2019-12-17 04:54:17 +08:00
// RUN: %clang_cc1 -fsyntax-only -fopenmp -triple x86_64-unknown-unknown -fopenmp-version=45 -verify=expected,omp45 %s -Wuninitialized
// RUN: %clang_cc1 -fsyntax-only -fopenmp -triple x86_64-unknown-unknown -fopenmp-version=50 -verify=expected,omp50 %s -Wuninitialized
2015-12-03 17:40:15 +08:00
2019-12-17 04:54:17 +08:00
// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -triple x86_64-unknown-unknown -fopenmp-version=45 -verify=expected,omp45 %s -Wuninitialized
// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -triple x86_64-unknown-unknown -fopenmp-version=50 -verify=expected,omp50 %s -Wuninitialized
2017-12-30 02:07:07 +08:00
[OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.
Summary:
Some OpenMP clauses rely on the values of the variables. If the variable
is not initialized and used in OpenMP clauses that depend on the
variables values, it should be reported that the uninitialized variable
is used in the OpenMP clause expression.
This patch adds initial processing for uninitialized variables in OpenMP
constructs. Currently, it checks for use of the uninitialized variables
in the structured blocks.
Reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet
Subscribers: rnkovacs, guansong, jfb, jdoerfert, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64356
llvm-svn: 365786
2019-07-11 22:54:17 +08:00
void xxx ( int argc ) {
int x ; // expected-note {{initialize the variable 'x' to silence this warning}}
# pragma omp taskloop simd
for ( int i = 0 ; i < 10 ; + + i )
argc = x ; // expected-warning {{variable 'x' is uninitialized when used here}}
}
2015-12-03 17:40:15 +08:00
// expected-error@+1 {{unexpected OpenMP directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd
// expected-error@+1 {{unexpected OpenMP directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd foo
void test_no_clause ( ) {
int i ;
# pragma omp taskloop simd
for ( i = 0 ; i < 16 ; + + i )
;
// expected-error@+2 {{statement after '#pragma omp taskloop simd' must be a for loop}}
# pragma omp taskloop simd
+ + i ;
}
void test_branch_protected_scope ( ) {
int i = 0 ;
L1 :
+ + i ;
int x [ 24 ] ;
# pragma omp parallel
# pragma omp taskloop simd
for ( i = 0 ; i < 16 ; + + i ) {
if ( i = = 5 )
goto L1 ; // expected-error {{use of undeclared label 'L1'}}
else if ( i = = 6 )
return ; // expected-error {{cannot return from OpenMP region}}
else if ( i = = 7 )
goto L2 ;
else if ( i = = 8 ) {
L2 :
x [ i ] + + ;
}
}
if ( x [ 0 ] = = 0 )
goto L2 ; // expected-error {{use of undeclared label 'L2'}}
else if ( x [ 1 ] = = 1 )
goto L1 ;
}
void test_invalid_clause ( ) {
int i ;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
# pragma omp taskloop simd foo bar
for ( i = 0 ; i < 16 ; + + i )
;
2015-12-07 18:51:44 +08:00
// expected-error@+1 {{directive '#pragma omp taskloop simd' cannot contain more than one 'nogroup' clause}}
# pragma omp taskloop simd nogroup nogroup
for ( i = 0 ; i < 16 ; + + i )
;
2015-12-03 17:40:15 +08:00
}
void test_non_identifiers ( ) {
int i , x ;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
# pragma omp taskloop simd;
for ( i = 0 ; i < 16 ; + + i )
;
// expected-warning@+2 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
# pragma omp parallel
# pragma omp taskloop simd linear(x);
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
# pragma omp taskloop simd private(x);
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
# pragma omp taskloop simd, private(x);
for ( i = 0 ; i < 16 ; + + i )
;
}
extern int foo ( ) ;
void test_collapse ( ) {
int i ;
# pragma omp parallel
// expected-error@+1 {{expected '('}}
# pragma omp taskloop simd collapse
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd collapse(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd collapse()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd collapse(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd collapse(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+2 {{extra tokens at the end of '#pragma omp taskloop simd' are ignored}}
// expected-error@+1 {{expected '('}}
# pragma omp taskloop simd collapse 4)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4,
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4, )
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4)
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4 4)
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4, , 4)
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
# pragma omp taskloop simd collapse(4)
for ( int i1 = 0 ; i1 < 16 ; + + i1 )
for ( int i2 = 0 ; i2 < 16 ; + + i2 )
for ( int i3 = 0 ; i3 < 16 ; + + i3 )
for ( int i4 = 0 ; i4 < 16 ; + + i4 )
foo ( ) ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
# pragma omp taskloop simd collapse(4, 8)
for ( i = 0 ; i < 16 ; + + i )
; // expected-error {{expected 4 for loops after '#pragma omp taskloop simd', but found only 1}}
# pragma omp parallel
// expected-error@+1 {{expression is not an integer constant expression}}
# pragma omp taskloop simd collapse(2.5)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expression is not an integer constant expression}}
# pragma omp taskloop simd collapse(foo())
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
# pragma omp taskloop simd collapse(-5)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
# pragma omp taskloop simd collapse(0)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
# pragma omp taskloop simd collapse(5 - 5)
for ( i = 0 ; i < 16 ; + + i )
;
}
void test_private ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected expression}}
// expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd private(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd private(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd private(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd private()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd private(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp taskloop simd private(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp taskloop simd private(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd private(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd private(x, y, z)
for ( i = 0 ; i < 16 ; + + i ) {
x = y * i + z ;
}
}
void test_lastprivate ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd lastprivate(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd lastprivate(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd lastprivate(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd lastprivate()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd lastprivate(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp taskloop simd lastprivate(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x, y, z)
for ( i = 0 ; i < 16 ; + + i )
;
}
void test_firstprivate ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd firstprivate(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd firstprivate(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2015-12-03 17:40:15 +08:00
# pragma omp taskloop simd firstprivate(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd firstprivate()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp taskloop simd firstprivate(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp taskloop simd firstprivate(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x) firstprivate(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x, y) firstprivate(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp taskloop simd lastprivate(x, y, z) firstprivate(x, y, z)
for ( i = 0 ; i < 16 ; + + i )
;
2017-11-23 02:34:02 +08:00
// expected-error@+1 {{the value of 'simdlen' parameter must be less than or equal to the value of the 'safelen' parameter}}
# pragma omp taskloop simd simdlen(64) safelen(8)
for ( i = 0 ; i < 16 ; + + i )
;
2015-12-03 17:40:15 +08:00
}
void test_loop_messages ( ) {
float a [ 100 ] , b [ 100 ] , c [ 100 ] ;
# pragma omp parallel
// expected-error@+2 {{variable must be of integer or pointer type}}
# pragma omp taskloop simd
for ( float fi = 0 ; fi < 10.0 ; fi + + ) {
c [ ( int ) fi ] = a [ ( int ) fi ] + b [ ( int ) fi ] ;
}
# pragma omp parallel
// expected-error@+2 {{variable must be of integer or pointer type}}
# pragma omp taskloop simd
for ( double fi = 0 ; fi < 10.0 ; fi + + ) {
c [ ( int ) fi ] = a [ ( int ) fi ] + b [ ( int ) fi ] ;
}
// expected-warning@+2 {{OpenMP loop iteration variable cannot have more than 64 bits size and will be narrowed}}
# pragma omp taskloop simd
for ( __int128 ii = 0 ; ii < 10 ; ii + + ) {
c [ ii ] = a [ ii ] + b [ ii ] ;
}
}
2019-12-17 04:54:17 +08:00
void test_nontemporal ( ) {
int i ;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd nontemporal(
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 2 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd nontemporal(,
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 2 {{expected expression}}
# pragma omp taskloop simd nontemporal(, )
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{expected expression}}
# pragma omp taskloop simd nontemporal()
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{expected expression}}
# pragma omp taskloop simd nontemporal(int)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} omp50-error@+1 {{expected variable name}}
# pragma omp taskloop simd nontemporal(0)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{use of undeclared identifier 'x'}}
# pragma omp taskloop simd nontemporal(x)
for ( i = 0 ; i < 16 ; + + i )
;
// expected-error@+2 {{use of undeclared identifier 'x'}}
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{use of undeclared identifier 'y'}}
# pragma omp taskloop simd nontemporal(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
// expected-error@+3 {{use of undeclared identifier 'x'}}
// expected-error@+2 {{use of undeclared identifier 'y'}}
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{use of undeclared identifier 'z'}}
# pragma omp taskloop simd nontemporal(x, y, z)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y ;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{expected ',' or ')' in 'nontemporal' clause}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp taskloop simd nontemporal(x :)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}} expected-error@+1 {{expected ',' or ')' in 'nontemporal' clause}}
# pragma omp taskloop simd nontemporal(x :, )
for ( i = 0 ; i < 16 ; + + i )
;
// omp50-note@+2 {{defined as nontemporal}}
// omp45-error@+1 2 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} omp50-error@+1 {{a variable cannot appear in more than one nontemporal clause}}
# pragma omp taskloop simd nontemporal(x) nontemporal(x)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd private(x) nontemporal(x)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd nontemporal(x) private(x)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}} expected-note@+1 {{to match this '('}} expected-error@+1 {{expected ',' or ')' in 'nontemporal' clause}} expected-error@+1 {{expected ')'}}
# pragma omp taskloop simd nontemporal(x, y : 0)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd nontemporal(x) lastprivate(x)
for ( i = 0 ; i < 16 ; + + i )
;
// omp45-error@+1 {{unexpected OpenMP clause 'nontemporal' in directive '#pragma omp taskloop simd'}}
# pragma omp taskloop simd lastprivate(x) nontemporal(x)
for ( i = 0 ; i < 16 ; + + i )
;
2020-02-01 05:09:26 +08:00
# pragma omp taskloop simd order // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp taskloop simd'}} expected-error {{expected '(' after 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp taskloop simd order( // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp taskloop simd'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp taskloop simd order(none // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp taskloop simd'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp taskloop simd order(concurrent // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp taskloop simd'}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp taskloop simd order(concurrent) // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp taskloop simd'}}
for ( int i = 0 ; i < 10 ; + + i )
;
2019-12-17 04:54:17 +08:00
}