maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang/test/Sema/warn-absolute-value-header.c

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

37 lines
1.5 KiB
C
Raw Normal View History

Add -Wabsolute-value, warnings about absolute value functions. The warnings fall into three groups. 1) Using an absolute value function of the wrong type, for instance, using the int absolute value function when the argument is a floating point type. 2) Using the improper sized absolute value function, for instance, using abs when the argument is a long long. llabs should be used instead. From these two cases, an implicit conversion will occur which may cause unexpected behavior. Where possible, suggest the proper absolute value function to use, and which header to include if the function is not available. 3) Taking the absolute value of an unsigned value. In addition to this warning, suggest to remove the function call. This usually indicates a logic error since the programmer assumed negative values would have been possible. llvm-svn: 202211
2014-02-26 09:17:28 +08:00
// RUN: %clang_cc1 -triple i686-pc-linux-gnu -fsyntax-only -verify %s -Wabsolute-value
// RUN: %clang_cc1 -triple i686-pc-linux-gnu -fsyntax-only %s -Wabsolute-value -fdiagnostics-parseable-fixits 2>&1 | FileCheck %s
int abs(int);
// Wrong signature
int fabsf(int);
// expected-warning@-1{{incompatible redeclaration of library function 'fabsf'}}
// expected-note@-2{{'fabsf' is a builtin with type 'float (float)'}}
void test_int(int i, unsigned u, long long ll, float f, double d) {
(void)abs(i);
// Remove abs call
(void)abs(u);
// expected-warning@-1{{taking the absolute value of unsigned type 'unsigned int' has no effect}}
// expected-note@-2{{remove the call to 'abs' since unsigned values cannot be negative}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:9-[[@LINE-3]]:12}:""
int llabs;
(void)llabs;
// Conflict in names, no notes
(void)abs(ll);
// expected-warning@-1{{absolute value function 'abs' given an argument of type 'long long' but has parameter of type 'int' which may cause truncation of value}}
// Conflict in names, no notes
(void)abs(f);
// expected-warning@-1{{using integer absolute value function 'abs' when argument is of floating point type}}
// Suggest header.
(void)abs(d);
// expected-warning@-1{{using integer absolute value function 'abs' when argument is of floating point type}}
// expected-note@-2{{use function 'fabs' instead}}
Consolidate header inclusion diagnostics Make argument orders match, unify diagnostic IDs and reword the message to be a little less saccharine. llvm-svn: 212845
2014-07-12 04:53:51 +08:00
// expected-note@-3{{include the header <math.h> or explicitly provide a declaration for 'fabs'}}
Add -Wabsolute-value, warnings about absolute value functions. The warnings fall into three groups. 1) Using an absolute value function of the wrong type, for instance, using the int absolute value function when the argument is a floating point type. 2) Using the improper sized absolute value function, for instance, using abs when the argument is a long long. llabs should be used instead. From these two cases, an implicit conversion will occur which may cause unexpected behavior. Where possible, suggest the proper absolute value function to use, and which header to include if the function is not available. 3) Taking the absolute value of an unsigned value. In addition to this warning, suggest to remove the function call. This usually indicates a logic error since the programmer assumed negative values would have been possible. llvm-svn: 202211
2014-02-26 09:17:28 +08:00
// CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:9-[[@LINE-4]]:12}:"fabs"
}