2018-01-18 08:10:21 +08:00
|
|
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection,unix.Malloc -analyzer-config c++-allocator-inlining=true -analyzer-output=text -std=c++11 -verify %s
|
2018-01-18 07:46:13 +08:00
|
|
|
|
|
|
|
void clang_analyzer_eval(bool);
|
|
|
|
|
|
|
|
typedef __typeof__(sizeof(int)) size_t;
|
|
|
|
|
|
|
|
void *malloc(size_t size);
|
|
|
|
|
|
|
|
void *operator new(size_t size) throw() {
|
2018-01-18 08:10:21 +08:00
|
|
|
void *x = malloc(size); // expected-note {{Memory is allocated}}
|
|
|
|
if (!x) // expected-note {{Assuming 'x' is non-null}}
|
|
|
|
// expected-note@-1 {{Taking false branch}}
|
2018-01-18 07:46:13 +08:00
|
|
|
return nullptr;
|
[clang] Annotating C++'s `operator new` with more attributes
Summary:
Right now we annotate C++'s `operator new` with `noalias` attribute,
which very much is healthy for optimizations.
However as per [[ http://eel.is/c++draft/basic.stc.dynamic.allocation | `[basic.stc.dynamic.allocation]` ]],
there are more promises on global `operator new`, namely:
* non-`std::nothrow_t` `operator new` *never* returns `nullptr`
* If `std::align_val_t align` parameter is taken, the pointer will also be `align`-aligned
* ~~global `operator new`-returned pointer is `__STDCPP_DEFAULT_NEW_ALIGNMENT__`-aligned ~~ It's more caveated than that.
Supplying this information may not cause immediate landslide effects
on any specific benchmarks, but it for sure will be healthy for optimizer
in the sense that the IR will better reflect the guarantees provided in the source code.
The caveat is `-fno-assume-sane-operator-new`, which currently prevents emitting `noalias`
attribute, and is automatically passed by Sanitizers ([[ https://bugs.llvm.org/show_bug.cgi?id=16386 | PR16386 ]]) - should it also cover these attributes?
The problem is that the flag is back-end-specific, as seen in `test/Modules/explicit-build-flags.cpp`.
But while it is okay to add `noalias` metadata in backend, we really should be adding at least
the alignment metadata to the AST, since that allows us to perform sema checks on it.
Reviewers: erichkeane, rjmccall, jdoerfert, eugenis, rsmith
Reviewed By: rsmith
Subscribers: xbolva00, jrtc27, atanasyan, nlopes, cfe-commits
Tags: #llvm, #clang
Differential Revision: https://reviews.llvm.org/D73380
2020-02-26 06:37:17 +08:00
|
|
|
// expected-warning@-1 {{null returned from function that requires a non-null return value}}
|
2018-01-18 07:46:13 +08:00
|
|
|
return x;
|
|
|
|
}
|
|
|
|
|
|
|
|
void checkNewAndConstructorInlining() {
|
2018-01-18 08:10:21 +08:00
|
|
|
int *s = new int; // expected-note {{Calling 'operator new'}}
|
|
|
|
// expected-note@-1{{Returning from 'operator new'}}
|
2018-01-18 07:46:13 +08:00
|
|
|
} // expected-warning {{Potential leak of memory pointed to by 's'}}
|
2018-01-18 08:10:21 +08:00
|
|
|
// expected-note@-1 {{Potential leak of memory pointed to by 's'}}
|