AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
|
2017-01-25 06:02:15 +08:00
|
|
|
; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
|
|
|
|
; This used to crash because during intermediate control flow lowering, there
|
|
|
|
; was a sequence
|
|
|
|
; s_mov_b64 s[0:1], exec
|
|
|
|
; s_and_b64 s[2:3], s[0:1], s[2:3] ; def & use of the same register pair
|
|
|
|
; ...
|
|
|
|
; s_mov_b64_term exec, s[2:3]
|
|
|
|
; that was not treated correctly.
|
|
|
|
;
|
|
|
|
; GCN-LABEL: {{^}}ham:
|
|
|
|
; GCN-DAG: v_cmp_lt_f32_e64 [[OTHERCC:s\[[0-9]+:[0-9]+\]]],
|
|
|
|
; GCN-DAG: v_cmp_lt_f32_e32 vcc,
|
|
|
|
; GCN: s_and_b64 [[AND:s\[[0-9]+:[0-9]+\]]], vcc, [[OTHERCC]]
|
|
|
|
; GCN: s_and_saveexec_b64 [[SAVED:s\[[0-9]+:[0-9]+\]]], [[AND]]
|
2016-11-22 09:42:34 +08:00
|
|
|
; GCN: s_xor_b64 {{s\[[0-9]+:[0-9]+\]}}, exec, [[SAVED]]
|
2017-03-25 03:52:05 +08:00
|
|
|
; GCN: ; mask branch [[BB5:BB[0-9]+_[0-9]+]]
|
|
|
|
|
|
|
|
; GCN-NEXT: BB{{[0-9]+_[0-9]+}}: ; %bb4
|
|
|
|
; GCN: ds_write_b32
|
|
|
|
|
2017-06-02 22:19:25 +08:00
|
|
|
; GCN: [[BB5]]
|
2017-03-25 03:52:05 +08:00
|
|
|
; GCN: s_or_b64 exec, exec
|
|
|
|
; GCN-NEXT: s_endpgm
|
|
|
|
; GCN-NEXT: .Lfunc_end
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
define amdgpu_ps void @ham(float %arg, float %arg1) #0 {
|
|
|
|
bb:
|
|
|
|
%tmp = fcmp ogt float %arg, 0.000000e+00
|
|
|
|
%tmp2 = fcmp ogt float %arg1, 0.000000e+00
|
|
|
|
%tmp3 = and i1 %tmp, %tmp2
|
|
|
|
br i1 %tmp3, label %bb4, label %bb5
|
|
|
|
|
|
|
|
bb4: ; preds = %bb
|
2017-03-25 03:52:05 +08:00
|
|
|
store volatile i32 4, i32 addrspace(3)* undef
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
unreachable
|
|
|
|
|
|
|
|
bb5: ; preds = %bb
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
|
|
|
|
attributes #0 = { nounwind readonly "InitialPSInputAddr"="36983" }
|
|
|
|
attributes #1 = { nounwind readnone }
|