2007-08-11 04:18:51 +08:00
|
|
|
//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 03:59:25 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2007-08-11 04:18:51 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2009-09-09 23:08:12 +08:00
|
|
|
// This file implements extra semantic analysis beyond what is enforced
|
2007-08-11 04:18:51 +08:00
|
|
|
// by the C type system.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "Sema.h"
|
2010-07-16 10:11:22 +08:00
|
|
|
#include "clang/Analysis/Analyses/FormatString.h"
|
2007-08-11 04:18:51 +08:00
|
|
|
#include "clang/AST/ASTContext.h"
|
2010-01-12 01:06:35 +08:00
|
|
|
#include "clang/AST/CharUnits.h"
|
2008-08-11 13:35:13 +08:00
|
|
|
#include "clang/AST/DeclObjC.h"
|
2007-08-21 00:18:38 +08:00
|
|
|
#include "clang/AST/ExprCXX.h"
|
2008-06-17 02:00:42 +08:00
|
|
|
#include "clang/AST/ExprObjC.h"
|
2010-01-21 11:59:47 +08:00
|
|
|
#include "clang/AST/DeclObjC.h"
|
|
|
|
#include "clang/AST/StmtCXX.h"
|
|
|
|
#include "clang/AST/StmtObjC.h"
|
2009-02-19 03:21:10 +08:00
|
|
|
#include "clang/Lex/LiteralSupport.h"
|
2007-08-11 04:18:51 +08:00
|
|
|
#include "clang/Lex/Preprocessor.h"
|
2010-01-21 11:59:47 +08:00
|
|
|
#include "llvm/ADT/BitVector.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
2010-06-13 12:47:52 +08:00
|
|
|
#include "llvm/ADT/StringExtras.h"
|
2010-06-09 12:11:11 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2010-04-17 10:26:23 +08:00
|
|
|
#include "clang/Basic/TargetBuiltins.h"
|
2010-06-08 10:47:44 +08:00
|
|
|
#include "clang/Basic/TargetInfo.h"
|
2009-05-20 09:55:10 +08:00
|
|
|
#include <limits>
|
2007-08-11 04:18:51 +08:00
|
|
|
using namespace clang;
|
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
/// getLocationOfStringLiteralByte - Return a source location that points to the
|
|
|
|
/// specified byte of the specified string literal.
|
|
|
|
///
|
|
|
|
/// Strings are amazingly complex. They can be formed from multiple tokens and
|
|
|
|
/// can have escape sequences in them in addition to the usual trigraph and
|
|
|
|
/// escaped newline business. This routine handles this complexity.
|
|
|
|
///
|
|
|
|
SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
|
|
|
|
unsigned ByteNo) const {
|
|
|
|
assert(!SL->isWide() && "This doesn't work for wide strings yet");
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
// Loop over all of the tokens in this string until we find the one that
|
|
|
|
// contains the byte we're looking for.
|
|
|
|
unsigned TokNo = 0;
|
|
|
|
while (1) {
|
|
|
|
assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!");
|
|
|
|
SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
// Get the spelling of the string so that we can get the data that makes up
|
|
|
|
// the string literal, not the identifier for the macro it is potentially
|
|
|
|
// expanded through.
|
|
|
|
SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc);
|
|
|
|
|
|
|
|
// Re-lex the token to get its length and original spelling.
|
|
|
|
std::pair<FileID, unsigned> LocInfo =
|
|
|
|
SourceMgr.getDecomposedLoc(StrTokSpellingLoc);
|
2010-03-16 08:06:06 +08:00
|
|
|
bool Invalid = false;
|
2010-03-16 22:14:31 +08:00
|
|
|
llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid);
|
2010-03-16 08:06:06 +08:00
|
|
|
if (Invalid)
|
2010-03-16 06:54:52 +08:00
|
|
|
return StrTokSpellingLoc;
|
|
|
|
|
2010-03-16 22:14:31 +08:00
|
|
|
const char *StrData = Buffer.data()+LocInfo.second;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
// Create a langops struct and enable trigraphs. This is sufficient for
|
|
|
|
// relexing tokens.
|
|
|
|
LangOptions LangOpts;
|
|
|
|
LangOpts.Trigraphs = true;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
// Create a lexer starting at the beginning of this token.
|
2010-03-16 22:14:31 +08:00
|
|
|
Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData,
|
|
|
|
Buffer.end());
|
2009-02-19 01:49:48 +08:00
|
|
|
Token TheTok;
|
|
|
|
TheLexer.LexFromRawLexer(TheTok);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 03:26:42 +08:00
|
|
|
// Use the StringLiteralParser to compute the length of the string in bytes.
|
2010-05-26 13:35:51 +08:00
|
|
|
StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false);
|
2009-02-19 03:26:42 +08:00
|
|
|
unsigned TokNumBytes = SLP.GetStringLength();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 02:52:52 +08:00
|
|
|
// If the byte is in this token, return the location of the byte.
|
2009-02-19 01:49:48 +08:00
|
|
|
if (ByteNo < TokNumBytes ||
|
|
|
|
(ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) {
|
2009-09-09 23:08:12 +08:00
|
|
|
unsigned Offset =
|
2010-05-26 13:35:51 +08:00
|
|
|
StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP,
|
|
|
|
/*Complain=*/false);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 03:21:10 +08:00
|
|
|
// Now that we know the offset of the token in the spelling, use the
|
|
|
|
// preprocessor to get the offset in the original source.
|
|
|
|
return PP.AdvanceToTokenCharacter(StrTokLoc, Offset);
|
2009-02-19 01:49:48 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-19 01:49:48 +08:00
|
|
|
// Move to the next string token.
|
|
|
|
++TokNo;
|
|
|
|
ByteNo -= TokNumBytes;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-08-06 11:00:50 +08:00
|
|
|
/// CheckablePrintfAttr - does a function call have a "printf" attribute
|
|
|
|
/// and arguments that merit checking?
|
|
|
|
bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) {
|
|
|
|
if (Format->getType() == "printf") return true;
|
|
|
|
if (Format->getType() == "printf0") {
|
|
|
|
// printf0 allows null "format" string; if so don't check format/args
|
|
|
|
unsigned format_idx = Format->getFormatIdx() - 1;
|
2009-11-18 02:02:24 +08:00
|
|
|
// Does the index refer to the implicit object argument?
|
|
|
|
if (isa<CXXMemberCallExpr>(TheCall)) {
|
|
|
|
if (format_idx == 0)
|
|
|
|
return false;
|
|
|
|
--format_idx;
|
|
|
|
}
|
2009-08-06 11:00:50 +08:00
|
|
|
if (format_idx < TheCall->getNumArgs()) {
|
|
|
|
Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts();
|
2010-02-27 09:41:03 +08:00
|
|
|
if (!Format->isNullPointerConstant(Context,
|
|
|
|
Expr::NPC_ValueDependentIsNull))
|
2009-08-06 11:00:50 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
2009-02-19 01:49:48 +08:00
|
|
|
|
2009-01-19 08:08:26 +08:00
|
|
|
Action::OwningExprResult
|
2009-08-16 09:56:34 +08:00
|
|
|
Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
|
2009-01-19 08:08:26 +08:00
|
|
|
OwningExprResult TheCallResult(Owned(TheCall));
|
2008-11-18 04:34:05 +08:00
|
|
|
|
2009-08-16 09:56:34 +08:00
|
|
|
switch (BuiltinID) {
|
2007-12-20 07:59:04 +08:00
|
|
|
case Builtin::BI__builtin___CFStringMakeConstantString:
|
2007-12-28 13:29:59 +08:00
|
|
|
assert(TheCall->getNumArgs() == 1 &&
|
2007-12-20 08:26:33 +08:00
|
|
|
"Wrong # arguments to builtin CFStringMakeConstantString");
|
2009-02-18 14:01:06 +08:00
|
|
|
if (CheckObjCString(TheCall->getArg(0)))
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2008-07-10 01:58:53 +08:00
|
|
|
case Builtin::BI__builtin_stdarg_start:
|
2007-12-20 07:59:04 +08:00
|
|
|
case Builtin::BI__builtin_va_start:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinVAStart(TheCall))
|
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2007-12-20 08:26:33 +08:00
|
|
|
case Builtin::BI__builtin_isgreater:
|
|
|
|
case Builtin::BI__builtin_isgreaterequal:
|
|
|
|
case Builtin::BI__builtin_isless:
|
|
|
|
case Builtin::BI__builtin_islessequal:
|
|
|
|
case Builtin::BI__builtin_islessgreater:
|
|
|
|
case Builtin::BI__builtin_isunordered:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinUnorderedCompare(TheCall))
|
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2010-02-16 06:42:31 +08:00
|
|
|
case Builtin::BI__builtin_fpclassify:
|
|
|
|
if (SemaBuiltinFPClassification(TheCall, 6))
|
|
|
|
return ExprError();
|
|
|
|
break;
|
2009-09-01 04:06:00 +08:00
|
|
|
case Builtin::BI__builtin_isfinite:
|
|
|
|
case Builtin::BI__builtin_isinf:
|
|
|
|
case Builtin::BI__builtin_isinf_sign:
|
|
|
|
case Builtin::BI__builtin_isnan:
|
|
|
|
case Builtin::BI__builtin_isnormal:
|
2010-02-16 18:07:31 +08:00
|
|
|
if (SemaBuiltinFPClassification(TheCall, 1))
|
2009-09-01 04:06:00 +08:00
|
|
|
return ExprError();
|
|
|
|
break;
|
2008-05-20 16:23:37 +08:00
|
|
|
case Builtin::BI__builtin_return_address:
|
2010-04-17 10:26:23 +08:00
|
|
|
case Builtin::BI__builtin_frame_address: {
|
|
|
|
llvm::APSInt Result;
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, 0, Result))
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2010-04-17 10:26:23 +08:00
|
|
|
}
|
|
|
|
case Builtin::BI__builtin_eh_return_data_regno: {
|
|
|
|
llvm::APSInt Result;
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, 0, Result))
|
2009-09-23 14:06:36 +08:00
|
|
|
return ExprError();
|
|
|
|
break;
|
2010-04-17 10:26:23 +08:00
|
|
|
}
|
2008-05-15 03:38:39 +08:00
|
|
|
case Builtin::BI__builtin_shufflevector:
|
2009-01-19 08:08:26 +08:00
|
|
|
return SemaBuiltinShuffleVector(TheCall);
|
|
|
|
// TheCall will be freed by the smart pointer here, but that's fine, since
|
|
|
|
// SemaBuiltinShuffleVector guts it, but then doesn't release it.
|
2008-07-22 06:59:13 +08:00
|
|
|
case Builtin::BI__builtin_prefetch:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinPrefetch(TheCall))
|
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2008-09-04 05:13:56 +08:00
|
|
|
case Builtin::BI__builtin_object_size:
|
2009-01-19 08:08:26 +08:00
|
|
|
if (SemaBuiltinObjectSize(TheCall))
|
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2009-05-03 12:46:36 +08:00
|
|
|
case Builtin::BI__builtin_longjmp:
|
|
|
|
if (SemaBuiltinLongjmp(TheCall))
|
|
|
|
return ExprError();
|
2009-08-16 09:56:34 +08:00
|
|
|
break;
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_fetch_and_add:
|
|
|
|
case Builtin::BI__sync_fetch_and_sub:
|
|
|
|
case Builtin::BI__sync_fetch_and_or:
|
|
|
|
case Builtin::BI__sync_fetch_and_and:
|
|
|
|
case Builtin::BI__sync_fetch_and_xor:
|
|
|
|
case Builtin::BI__sync_add_and_fetch:
|
|
|
|
case Builtin::BI__sync_sub_and_fetch:
|
|
|
|
case Builtin::BI__sync_and_and_fetch:
|
|
|
|
case Builtin::BI__sync_or_and_fetch:
|
|
|
|
case Builtin::BI__sync_xor_and_fetch:
|
|
|
|
case Builtin::BI__sync_val_compare_and_swap:
|
|
|
|
case Builtin::BI__sync_bool_compare_and_swap:
|
|
|
|
case Builtin::BI__sync_lock_test_and_set:
|
|
|
|
case Builtin::BI__sync_lock_release:
|
2010-07-10 02:59:35 +08:00
|
|
|
return SemaBuiltinAtomicOverloaded(move(TheCallResult));
|
2010-06-08 10:47:44 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Since the target specific builtins for each arch overlap, only check those
|
|
|
|
// of the arch we are compiling for.
|
|
|
|
if (BuiltinID >= Builtin::FirstTSBuiltin) {
|
|
|
|
switch (Context.Target.getTriple().getArch()) {
|
|
|
|
case llvm::Triple::arm:
|
|
|
|
case llvm::Triple::thumb:
|
|
|
|
if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
|
|
|
|
return ExprError();
|
|
|
|
break;
|
|
|
|
case llvm::Triple::x86:
|
|
|
|
case llvm::Triple::x86_64:
|
|
|
|
if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
|
|
|
|
return ExprError();
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return move(TheCallResult);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
|
|
|
|
switch (BuiltinID) {
|
2010-04-17 10:26:23 +08:00
|
|
|
case X86::BI__builtin_ia32_palignr128:
|
|
|
|
case X86::BI__builtin_ia32_palignr: {
|
|
|
|
llvm::APSInt Result;
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, 2, Result))
|
2010-06-08 10:47:44 +08:00
|
|
|
return true;
|
2010-04-17 10:26:23 +08:00
|
|
|
break;
|
|
|
|
}
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
2010-06-08 10:47:44 +08:00
|
|
|
return false;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-06-14 13:21:25 +08:00
|
|
|
// Get the valid immediate range for the specified NEON type code.
|
|
|
|
static unsigned RFT(unsigned t, bool shift = false) {
|
|
|
|
bool quad = t & 0x10;
|
|
|
|
|
|
|
|
switch (t & 0x7) {
|
|
|
|
case 0: // i8
|
2010-06-17 10:26:59 +08:00
|
|
|
return shift ? 7 : (8 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 1: // i16
|
2010-06-17 10:26:59 +08:00
|
|
|
return shift ? 15 : (4 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 2: // i32
|
2010-06-17 10:26:59 +08:00
|
|
|
return shift ? 31 : (2 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 3: // i64
|
2010-06-17 10:26:59 +08:00
|
|
|
return shift ? 63 : (1 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 4: // f32
|
|
|
|
assert(!shift && "cannot shift float types!");
|
2010-06-17 10:26:59 +08:00
|
|
|
return (2 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 5: // poly8
|
|
|
|
assert(!shift && "cannot shift polynomial types!");
|
2010-06-17 10:26:59 +08:00
|
|
|
return (8 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 6: // poly16
|
|
|
|
assert(!shift && "cannot shift polynomial types!");
|
2010-06-17 10:26:59 +08:00
|
|
|
return (4 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
case 7: // float16
|
|
|
|
assert(!shift && "cannot shift float types!");
|
2010-06-17 10:26:59 +08:00
|
|
|
return (4 << (int)quad) - 1;
|
2010-06-14 13:21:25 +08:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-06-08 10:47:44 +08:00
|
|
|
bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
|
2010-06-09 09:10:23 +08:00
|
|
|
llvm::APSInt Result;
|
|
|
|
|
2010-06-13 12:47:52 +08:00
|
|
|
unsigned mask = 0;
|
2010-06-14 13:21:25 +08:00
|
|
|
unsigned TV = 0;
|
2010-06-09 09:10:23 +08:00
|
|
|
switch (BuiltinID) {
|
2010-06-17 12:17:01 +08:00
|
|
|
#define GET_NEON_OVERLOAD_CHECK
|
|
|
|
#include "clang/Basic/arm_neon.inc"
|
|
|
|
#undef GET_NEON_OVERLOAD_CHECK
|
2010-06-09 09:10:23 +08:00
|
|
|
}
|
|
|
|
|
2010-06-13 12:47:52 +08:00
|
|
|
// For NEON intrinsics which are overloaded on vector element type, validate
|
|
|
|
// the immediate which specifies which variant to emit.
|
|
|
|
if (mask) {
|
|
|
|
unsigned ArgNo = TheCall->getNumArgs()-1;
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
|
|
|
|
return true;
|
|
|
|
|
2010-06-14 13:21:25 +08:00
|
|
|
TV = Result.getLimitedValue(32);
|
|
|
|
if ((TV > 31) || (mask & (1 << TV)) == 0)
|
2010-06-13 12:47:52 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
|
|
|
|
<< TheCall->getArg(ArgNo)->getSourceRange();
|
|
|
|
}
|
2010-06-09 09:10:23 +08:00
|
|
|
|
2010-06-13 12:47:52 +08:00
|
|
|
// For NEON intrinsics which take an immediate value as part of the
|
|
|
|
// instruction, range check them here.
|
2010-06-14 13:21:25 +08:00
|
|
|
unsigned i = 0, l = 0, u = 0;
|
2010-06-13 12:47:52 +08:00
|
|
|
switch (BuiltinID) {
|
|
|
|
default: return false;
|
2010-06-17 12:17:01 +08:00
|
|
|
#define GET_NEON_IMMEDIATE_CHECK
|
|
|
|
#include "clang/Basic/arm_neon.inc"
|
|
|
|
#undef GET_NEON_IMMEDIATE_CHECK
|
2010-06-13 12:47:52 +08:00
|
|
|
};
|
|
|
|
|
2010-06-14 13:21:25 +08:00
|
|
|
// Check that the immediate argument is actually a constant.
|
2010-06-13 12:47:52 +08:00
|
|
|
if (SemaBuiltinConstantArg(TheCall, i, Result))
|
|
|
|
return true;
|
|
|
|
|
2010-06-14 13:21:25 +08:00
|
|
|
// Range check against the upper/lower values for this isntruction.
|
2010-06-13 12:47:52 +08:00
|
|
|
unsigned Val = Result.getZExtValue();
|
2010-06-14 13:21:25 +08:00
|
|
|
if (Val < l || Val > (u + l))
|
2010-06-13 12:47:52 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
2010-06-14 13:21:25 +08:00
|
|
|
<< llvm::utostr(l) << llvm::utostr(u+l)
|
|
|
|
<< TheCall->getArg(i)->getSourceRange();
|
2010-06-13 12:47:52 +08:00
|
|
|
|
2010-06-08 10:47:44 +08:00
|
|
|
return false;
|
2009-08-16 09:56:34 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// CheckFunctionCall - Check a direct function call for various correctness
|
|
|
|
/// and safety properties not strictly enforced by the C type system.
|
|
|
|
bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
|
|
|
|
// Get the IdentifierInfo* for the called function.
|
|
|
|
IdentifierInfo *FnInfo = FDecl->getIdentifier();
|
2008-10-03 02:44:07 +08:00
|
|
|
|
2009-08-16 09:56:34 +08:00
|
|
|
// None of the checks below are needed for functions that don't have
|
|
|
|
// simple names (e.g., C++ conversion functions).
|
|
|
|
if (!FnInfo)
|
|
|
|
return false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-10-03 02:44:07 +08:00
|
|
|
// FIXME: This mechanism should be abstracted to be less fragile and
|
|
|
|
// more efficient. For example, just map function ids to custom
|
|
|
|
// handlers.
|
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
// Printf checking.
|
2009-06-30 10:34:44 +08:00
|
|
|
if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) {
|
2010-07-16 10:11:22 +08:00
|
|
|
const bool b = Format->getType() == "scanf";
|
|
|
|
if (b || CheckablePrintfAttr(Format, TheCall)) {
|
2009-02-28 01:58:43 +08:00
|
|
|
bool HasVAListArg = Format->getFirstArg() == 0;
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckPrintfScanfArguments(TheCall, HasVAListArg,
|
|
|
|
Format->getFormatIdx() - 1,
|
|
|
|
HasVAListArg ? 0 : Format->getFirstArg() - 1,
|
|
|
|
!b);
|
2009-02-15 02:57:46 +08:00
|
|
|
}
|
2007-08-11 04:18:51 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull;
|
2009-08-16 09:56:34 +08:00
|
|
|
NonNull = NonNull->getNext<NonNullAttr>())
|
|
|
|
CheckNonNullArguments(NonNull, TheCall);
|
2009-01-19 08:08:26 +08:00
|
|
|
|
2009-08-16 09:56:34 +08:00
|
|
|
return false;
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
|
|
|
|
2009-08-16 09:56:34 +08:00
|
|
|
bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
|
2009-05-19 05:05:18 +08:00
|
|
|
// Printf checking.
|
2009-06-30 10:34:44 +08:00
|
|
|
const FormatAttr *Format = NDecl->getAttr<FormatAttr>();
|
2009-05-19 05:05:18 +08:00
|
|
|
if (!Format)
|
2009-08-16 09:56:34 +08:00
|
|
|
return false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-19 05:05:18 +08:00
|
|
|
const VarDecl *V = dyn_cast<VarDecl>(NDecl);
|
|
|
|
if (!V)
|
2009-08-16 09:56:34 +08:00
|
|
|
return false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-19 05:05:18 +08:00
|
|
|
QualType Ty = V->getType();
|
|
|
|
if (!Ty->isBlockPointerType())
|
2009-08-16 09:56:34 +08:00
|
|
|
return false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
const bool b = Format->getType() == "scanf";
|
|
|
|
if (!b && !CheckablePrintfAttr(Format, TheCall))
|
2009-08-16 09:56:34 +08:00
|
|
|
return false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-08-16 09:56:34 +08:00
|
|
|
bool HasVAListArg = Format->getFirstArg() == 0;
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1,
|
|
|
|
HasVAListArg ? 0 : Format->getFirstArg() - 1, !b);
|
2009-08-16 09:56:34 +08:00
|
|
|
|
|
|
|
return false;
|
2009-05-19 05:05:18 +08:00
|
|
|
}
|
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
/// SemaBuiltinAtomicOverloaded - We have a call to a function like
|
|
|
|
/// __sync_fetch_and_add, which is an overloaded function based on the pointer
|
|
|
|
/// type of its first argument. The main ActOnCallExpr routines have already
|
|
|
|
/// promoted the types of arguments because all of these calls are prototyped as
|
|
|
|
/// void(...).
|
|
|
|
///
|
|
|
|
/// This function goes through and does final semantic checking for these
|
|
|
|
/// builtins,
|
2010-07-10 02:59:35 +08:00
|
|
|
Sema::OwningExprResult
|
|
|
|
Sema::SemaBuiltinAtomicOverloaded(OwningExprResult TheCallResult) {
|
|
|
|
CallExpr *TheCall = (CallExpr *)TheCallResult.get();
|
2009-05-08 14:58:22 +08:00
|
|
|
DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
|
|
|
|
FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
|
|
|
|
|
|
|
|
// Ensure that we have at least one argument to do type inference from.
|
2010-07-10 02:59:35 +08:00
|
|
|
if (TheCall->getNumArgs() < 1) {
|
|
|
|
Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
|
|
|
|
<< 0 << 1 << TheCall->getNumArgs()
|
|
|
|
<< TheCall->getCallee()->getSourceRange();
|
|
|
|
return ExprError();
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Inspect the first argument of the atomic builtin. This should always be
|
|
|
|
// a pointer type, whose element is an integral scalar or pointer type.
|
|
|
|
// Because it is a pointer type, we don't have to worry about any implicit
|
|
|
|
// casts here.
|
2010-07-10 02:59:35 +08:00
|
|
|
// FIXME: We don't allow floating point scalars as input.
|
2009-05-08 14:58:22 +08:00
|
|
|
Expr *FirstArg = TheCall->getArg(0);
|
2010-07-10 02:59:35 +08:00
|
|
|
if (!FirstArg->getType()->isPointerType()) {
|
|
|
|
Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
return ExprError();
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-07-10 02:59:35 +08:00
|
|
|
QualType ValType =
|
|
|
|
FirstArg->getType()->getAs<PointerType>()->getPointeeType();
|
2009-09-09 23:08:12 +08:00
|
|
|
if (!ValType->isIntegerType() && !ValType->isPointerType() &&
|
2010-07-10 02:59:35 +08:00
|
|
|
!ValType->isBlockPointerType()) {
|
|
|
|
Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
return ExprError();
|
|
|
|
}
|
2009-05-08 14:58:22 +08:00
|
|
|
|
2010-07-19 04:54:12 +08:00
|
|
|
// The majority of builtins return a value, but a few have special return
|
|
|
|
// types, so allow them to override appropriately below.
|
|
|
|
QualType ResultType = ValType;
|
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// We need to figure out which concrete builtin this maps onto. For example,
|
|
|
|
// __sync_fetch_and_add with a 2 byte object turns into
|
|
|
|
// __sync_fetch_and_add_2.
|
|
|
|
#define BUILTIN_ROW(x) \
|
|
|
|
{ Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
|
|
|
|
Builtin::BI##x##_8, Builtin::BI##x##_16 }
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
static const unsigned BuiltinIndices[][5] = {
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_add),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_sub),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_or),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_and),
|
|
|
|
BUILTIN_ROW(__sync_fetch_and_xor),
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
BUILTIN_ROW(__sync_add_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_sub_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_and_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_or_and_fetch),
|
|
|
|
BUILTIN_ROW(__sync_xor_and_fetch),
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
BUILTIN_ROW(__sync_val_compare_and_swap),
|
|
|
|
BUILTIN_ROW(__sync_bool_compare_and_swap),
|
|
|
|
BUILTIN_ROW(__sync_lock_test_and_set),
|
|
|
|
BUILTIN_ROW(__sync_lock_release)
|
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
#undef BUILTIN_ROW
|
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Determine the index of the size.
|
|
|
|
unsigned SizeIndex;
|
2010-01-12 01:06:35 +08:00
|
|
|
switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
|
2009-05-08 14:58:22 +08:00
|
|
|
case 1: SizeIndex = 0; break;
|
|
|
|
case 2: SizeIndex = 1; break;
|
|
|
|
case 4: SizeIndex = 2; break;
|
|
|
|
case 8: SizeIndex = 3; break;
|
|
|
|
case 16: SizeIndex = 4; break;
|
|
|
|
default:
|
2010-07-10 02:59:35 +08:00
|
|
|
Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
|
|
|
|
<< FirstArg->getType() << FirstArg->getSourceRange();
|
|
|
|
return ExprError();
|
2009-05-08 14:58:22 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Each of these builtins has one pointer argument, followed by some number of
|
|
|
|
// values (0, 1 or 2) followed by a potentially empty varags list of stuff
|
|
|
|
// that we ignore. Find out which row of BuiltinIndices to read from as well
|
|
|
|
// as the number of fixed args.
|
2009-09-12 08:22:50 +08:00
|
|
|
unsigned BuiltinID = FDecl->getBuiltinID();
|
2009-05-08 14:58:22 +08:00
|
|
|
unsigned BuiltinIndex, NumFixed = 1;
|
|
|
|
switch (BuiltinID) {
|
|
|
|
default: assert(0 && "Unknown overloaded atomic builtin!");
|
|
|
|
case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break;
|
|
|
|
case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-03-26 01:13:09 +08:00
|
|
|
case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break;
|
|
|
|
case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break;
|
|
|
|
case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break;
|
|
|
|
case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break;
|
|
|
|
case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_val_compare_and_swap:
|
2010-03-26 01:13:09 +08:00
|
|
|
BuiltinIndex = 10;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 2;
|
|
|
|
break;
|
|
|
|
case Builtin::BI__sync_bool_compare_and_swap:
|
2010-03-26 01:13:09 +08:00
|
|
|
BuiltinIndex = 11;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 2;
|
2010-07-19 04:54:12 +08:00
|
|
|
ResultType = Context.BoolTy;
|
2009-05-08 14:58:22 +08:00
|
|
|
break;
|
2010-03-26 01:13:09 +08:00
|
|
|
case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break;
|
2009-05-08 14:58:22 +08:00
|
|
|
case Builtin::BI__sync_lock_release:
|
2010-03-26 01:13:09 +08:00
|
|
|
BuiltinIndex = 13;
|
2009-05-08 14:58:22 +08:00
|
|
|
NumFixed = 0;
|
2010-07-19 04:54:12 +08:00
|
|
|
ResultType = Context.VoidTy;
|
2009-05-08 14:58:22 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Now that we know how many fixed arguments we expect, first check that we
|
|
|
|
// have at least that many.
|
2010-07-10 02:59:35 +08:00
|
|
|
if (TheCall->getNumArgs() < 1+NumFixed) {
|
|
|
|
Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
|
|
|
|
<< 0 << 1+NumFixed << TheCall->getNumArgs()
|
|
|
|
<< TheCall->getCallee()->getSourceRange();
|
|
|
|
return ExprError();
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 23:36:58 +08:00
|
|
|
// Get the decl for the concrete builtin from this, we can tell what the
|
|
|
|
// concrete integer type we should convert to is.
|
|
|
|
unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
|
|
|
|
const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
|
|
|
|
IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
|
2009-09-09 23:08:12 +08:00
|
|
|
FunctionDecl *NewBuiltinDecl =
|
2009-05-08 23:36:58 +08:00
|
|
|
cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
|
|
|
|
TUScope, false, DRE->getLocStart()));
|
2010-07-10 02:59:35 +08:00
|
|
|
|
2010-07-18 15:23:17 +08:00
|
|
|
// The first argument is by definition correct, we use it's type as the type
|
|
|
|
// of the entire operation. Walk the remaining arguments promoting them to
|
|
|
|
// the deduced value type.
|
2009-05-08 14:58:22 +08:00
|
|
|
for (unsigned i = 0; i != NumFixed; ++i) {
|
|
|
|
Expr *Arg = TheCall->getArg(i+1);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// If the argument is an implicit cast, then there was a promotion due to
|
|
|
|
// "...", just remove it now.
|
|
|
|
if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
|
|
|
|
Arg = ICE->getSubExpr();
|
|
|
|
ICE->setSubExpr(0);
|
|
|
|
ICE->Destroy(Context);
|
|
|
|
TheCall->setArg(i+1, Arg);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// GCC does an implicit conversion to the pointer or integer ValType. This
|
|
|
|
// can fail in some cases (1i -> int**), check for this error case now.
|
2009-08-08 06:21:05 +08:00
|
|
|
CastExpr::CastKind Kind = CastExpr::CK_Unknown;
|
2010-04-25 03:06:50 +08:00
|
|
|
CXXBaseSpecifierArray BasePath;
|
|
|
|
if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath))
|
2010-07-10 02:59:35 +08:00
|
|
|
return ExprError();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Okay, we have something that *can* be converted to the right type. Check
|
|
|
|
// to see if there is a potentially weird extension going on here. This can
|
|
|
|
// happen when you do an atomic operation on something like an char* and
|
|
|
|
// pass in 42. The 42 gets converted to char. This is even more strange
|
|
|
|
// for things like 45.123 -> char, etc.
|
2009-09-09 23:08:12 +08:00
|
|
|
// FIXME: Do this check.
|
2010-04-25 00:36:20 +08:00
|
|
|
ImpCastExprToType(Arg, ValType, Kind);
|
2009-05-08 14:58:22 +08:00
|
|
|
TheCall->setArg(i+1, Arg);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Switch the DeclRefExpr to refer to the new decl.
|
|
|
|
DRE->setDecl(NewBuiltinDecl);
|
|
|
|
DRE->setType(NewBuiltinDecl->getType());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 14:58:22 +08:00
|
|
|
// Set the callee in the CallExpr.
|
|
|
|
// FIXME: This leaks the original parens and implicit casts.
|
|
|
|
Expr *PromotedCall = DRE;
|
|
|
|
UsualUnaryConversions(PromotedCall);
|
|
|
|
TheCall->setCallee(PromotedCall);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-07-18 15:23:17 +08:00
|
|
|
// Change the result type of the call to match the original value type. This
|
|
|
|
// is arbitrary, but the codegen for these builtins ins design to handle it
|
|
|
|
// gracefully.
|
2010-07-19 04:54:12 +08:00
|
|
|
TheCall->setType(ResultType);
|
2010-07-10 02:59:35 +08:00
|
|
|
|
|
|
|
return move(TheCallResult);
|
2009-05-08 14:58:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-02-18 14:01:06 +08:00
|
|
|
/// CheckObjCString - Checks that the argument to the builtin
|
2007-08-17 13:31:46 +08:00
|
|
|
/// CFString constructor is correct
|
2009-04-14 04:26:29 +08:00
|
|
|
/// FIXME: GCC currently emits the following warning:
|
2009-09-09 23:08:12 +08:00
|
|
|
/// "warning: input conversion stopped due to an input byte that does not
|
2009-04-14 04:26:29 +08:00
|
|
|
/// belong to the input codeset UTF-8"
|
|
|
|
/// Note: It might also make sense to do the UTF-16 conversion here (would
|
|
|
|
/// simplify the backend).
|
2009-02-18 14:01:06 +08:00
|
|
|
bool Sema::CheckObjCString(Expr *Arg) {
|
2008-02-13 09:02:39 +08:00
|
|
|
Arg = Arg->IgnoreParenCasts();
|
2007-08-17 13:31:46 +08:00
|
|
|
StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
|
|
|
|
|
|
|
|
if (!Literal || Literal->isWide()) {
|
2008-11-19 13:08:23 +08:00
|
|
|
Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
|
|
|
|
<< Arg->getSourceRange();
|
2007-08-17 23:44:17 +08:00
|
|
|
return true;
|
2007-08-17 13:31:46 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-09-22 18:03:52 +08:00
|
|
|
const char *Data = Literal->getStrData();
|
|
|
|
unsigned Length = Literal->getByteLength();
|
|
|
|
|
|
|
|
for (unsigned i = 0; i < Length; ++i) {
|
|
|
|
if (!Data[i]) {
|
|
|
|
Diag(getLocationOfStringLiteralByte(Literal, i),
|
|
|
|
diag::warn_cfstring_literal_contains_nul_character)
|
|
|
|
<< Arg->getSourceRange();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-17 23:44:17 +08:00
|
|
|
return false;
|
2007-08-11 04:18:51 +08:00
|
|
|
}
|
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
|
|
|
|
/// Emit an error and return true on failure, return false on success.
|
2007-12-28 13:29:59 +08:00
|
|
|
bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
|
|
|
|
Expr *Fn = TheCall->getCallee();
|
|
|
|
if (TheCall->getNumArgs() > 2) {
|
2008-11-22 02:44:24 +08:00
|
|
|
Diag(TheCall->getArg(2)->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
2010-04-16 12:56:46 +08:00
|
|
|
<< 0 /*function call*/ << 2 << TheCall->getNumArgs()
|
|
|
|
<< Fn->getSourceRange()
|
2009-09-09 23:08:12 +08:00
|
|
|
<< SourceRange(TheCall->getArg(2)->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
(*(TheCall->arg_end()-1))->getLocEnd());
|
2007-12-20 07:59:04 +08:00
|
|
|
return true;
|
|
|
|
}
|
2008-12-16 06:05:35 +08:00
|
|
|
|
|
|
|
if (TheCall->getNumArgs() < 2) {
|
2010-04-16 12:48:22 +08:00
|
|
|
return Diag(TheCall->getLocEnd(),
|
|
|
|
diag::err_typecheck_call_too_few_args_at_least)
|
|
|
|
<< 0 /*function call*/ << 2 << TheCall->getNumArgs();
|
2008-12-16 06:05:35 +08:00
|
|
|
}
|
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
// Determine whether the current function is variadic or not.
|
Keep an explicit stack of function and block scopes, each element of
which has the label map, switch statement stack, etc. Previously, we
had a single set of maps in Sema (for the function) along with a stack
of block scopes. However, this lead to funky behavior with nested
functions, e.g., in the member functions of local classes.
The explicit-stack approach is far cleaner, and we retain a 1-element
cache so that we're not malloc/free'ing every time we enter a
function. Fixes PR6382.
Also, tweaked the unused-variable warning suppression logic to look at
errors within a given Scope rather than within a given function. The
prior code wasn't looking at the right number-of-errors count when
dealing with blocks, since the block's count would be deallocated
before we got to ActOnPopScope. This approach works with nested
blocks/functions, and gives tighter error recovery.
llvm-svn: 97518
2010-03-02 07:15:13 +08:00
|
|
|
BlockScopeInfo *CurBlock = getCurBlock();
|
2007-12-20 08:05:45 +08:00
|
|
|
bool isVariadic;
|
2009-04-16 03:33:47 +08:00
|
|
|
if (CurBlock)
|
2010-06-05 03:02:56 +08:00
|
|
|
isVariadic = CurBlock->TheDecl->isVariadic();
|
2010-04-30 00:49:01 +08:00
|
|
|
else if (FunctionDecl *FD = getCurFunctionDecl())
|
|
|
|
isVariadic = FD->isVariadic();
|
|
|
|
else
|
2008-06-28 14:07:14 +08:00
|
|
|
isVariadic = getCurMethodDecl()->isVariadic();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-20 08:05:45 +08:00
|
|
|
if (!isVariadic) {
|
2007-12-20 07:59:04 +08:00
|
|
|
Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
|
|
|
|
return true;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-20 07:59:04 +08:00
|
|
|
// Verify that the second argument to the builtin is the last argument of the
|
|
|
|
// current function or method.
|
|
|
|
bool SecondArgIsLastNamedArgument = false;
|
2008-02-13 09:22:59 +08:00
|
|
|
const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-02-11 12:20:54 +08:00
|
|
|
if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
|
|
|
|
if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
|
2007-12-20 07:59:04 +08:00
|
|
|
// FIXME: This isn't correct for methods (results in bogus warning).
|
|
|
|
// Get the last formal in the current function.
|
2008-02-11 12:20:54 +08:00
|
|
|
const ParmVarDecl *LastArg;
|
2009-04-16 03:33:47 +08:00
|
|
|
if (CurBlock)
|
|
|
|
LastArg = *(CurBlock->TheDecl->param_end()-1);
|
|
|
|
else if (FunctionDecl *FD = getCurFunctionDecl())
|
2008-12-05 07:50:19 +08:00
|
|
|
LastArg = *(FD->param_end()-1);
|
2007-12-20 07:59:04 +08:00
|
|
|
else
|
2008-06-28 14:07:14 +08:00
|
|
|
LastArg = *(getCurMethodDecl()->param_end()-1);
|
2007-12-20 07:59:04 +08:00
|
|
|
SecondArgIsLastNamedArgument = PV == LastArg;
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-20 07:59:04 +08:00
|
|
|
if (!SecondArgIsLastNamedArgument)
|
2009-09-09 23:08:12 +08:00
|
|
|
Diag(TheCall->getArg(1)->getLocStart(),
|
2007-12-20 07:59:04 +08:00
|
|
|
diag::warn_second_parameter_of_va_start_not_last_named_argument);
|
|
|
|
return false;
|
2008-05-20 16:23:37 +08:00
|
|
|
}
|
2007-12-20 07:59:04 +08:00
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
|
|
|
|
/// friends. This is declared to take (...), so we have to check everything.
|
2007-12-28 13:29:59 +08:00
|
|
|
bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
|
|
|
|
if (TheCall->getNumArgs() < 2)
|
2008-11-22 02:44:24 +08:00
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
2010-04-16 12:48:22 +08:00
|
|
|
<< 0 << 2 << TheCall->getNumArgs()/*function call*/;
|
2007-12-28 13:29:59 +08:00
|
|
|
if (TheCall->getNumArgs() > 2)
|
2009-09-09 23:08:12 +08:00
|
|
|
return Diag(TheCall->getArg(2)->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
2010-04-16 12:56:46 +08:00
|
|
|
<< 0 /*function call*/ << 2 << TheCall->getNumArgs()
|
2008-11-19 13:08:23 +08:00
|
|
|
<< SourceRange(TheCall->getArg(2)->getLocStart(),
|
|
|
|
(*(TheCall->arg_end()-1))->getLocEnd());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:29:59 +08:00
|
|
|
Expr *OrigArg0 = TheCall->getArg(0);
|
|
|
|
Expr *OrigArg1 = TheCall->getArg(1);
|
2009-05-20 06:10:17 +08:00
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
// Do standard promotions between the two arguments, returning their common
|
|
|
|
// type.
|
2007-12-28 13:29:59 +08:00
|
|
|
QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
|
2009-02-20 03:28:43 +08:00
|
|
|
|
|
|
|
// Make sure any conversions are pushed back into the call; this is
|
|
|
|
// type safe since unordered compare builtins are declared as "_Bool
|
|
|
|
// foo(...)".
|
|
|
|
TheCall->setArg(0, OrigArg0);
|
|
|
|
TheCall->setArg(1, OrigArg1);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent())
|
|
|
|
return false;
|
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
// If the common type isn't a real floating type, then the arguments were
|
|
|
|
// invalid for this operation.
|
|
|
|
if (!Res->isRealFloatingType())
|
2009-09-09 23:08:12 +08:00
|
|
|
return Diag(OrigArg0->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_typecheck_call_invalid_ordered_compare)
|
2008-11-24 14:25:27 +08:00
|
|
|
<< OrigArg0->getType() << OrigArg1->getType()
|
2008-11-19 13:08:23 +08:00
|
|
|
<< SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-20 08:26:33 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2010-02-16 06:42:31 +08:00
|
|
|
/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
|
|
|
|
/// __builtin_isnan and friends. This is declared to take (...), so we have
|
2010-02-16 18:07:31 +08:00
|
|
|
/// to check everything. We expect the last argument to be a floating point
|
|
|
|
/// value.
|
|
|
|
bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
|
|
|
|
if (TheCall->getNumArgs() < NumArgs)
|
2009-09-01 04:06:00 +08:00
|
|
|
return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
|
2010-04-16 12:48:22 +08:00
|
|
|
<< 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
|
2010-02-16 18:07:31 +08:00
|
|
|
if (TheCall->getNumArgs() > NumArgs)
|
|
|
|
return Diag(TheCall->getArg(NumArgs)->getLocStart(),
|
2009-09-01 04:06:00 +08:00
|
|
|
diag::err_typecheck_call_too_many_args)
|
2010-04-16 12:56:46 +08:00
|
|
|
<< 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
|
2010-02-16 18:07:31 +08:00
|
|
|
<< SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
|
2009-09-01 04:06:00 +08:00
|
|
|
(*(TheCall->arg_end()-1))->getLocEnd());
|
|
|
|
|
2010-02-16 18:07:31 +08:00
|
|
|
Expr *OrigArg = TheCall->getArg(NumArgs-1);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-09-01 04:06:00 +08:00
|
|
|
if (OrigArg->isTypeDependent())
|
|
|
|
return false;
|
|
|
|
|
2010-05-06 13:50:07 +08:00
|
|
|
// This operation requires a non-_Complex floating-point number.
|
2009-09-01 04:06:00 +08:00
|
|
|
if (!OrigArg->getType()->isRealFloatingType())
|
2009-09-09 23:08:12 +08:00
|
|
|
return Diag(OrigArg->getLocStart(),
|
2009-09-01 04:06:00 +08:00
|
|
|
diag::err_typecheck_call_invalid_unary_fp)
|
|
|
|
<< OrigArg->getType() << OrigArg->getSourceRange();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-05-06 13:50:07 +08:00
|
|
|
// If this is an implicit conversion from float -> double, remove it.
|
|
|
|
if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
|
|
|
|
Expr *CastArg = Cast->getSubExpr();
|
|
|
|
if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
|
|
|
|
assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
|
|
|
|
"promotion from float to double is the only expected cast here");
|
|
|
|
Cast->setSubExpr(0);
|
|
|
|
Cast->Destroy(Context);
|
|
|
|
TheCall->setArg(NumArgs-1, CastArg);
|
|
|
|
OrigArg = CastArg;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-09-01 04:06:00 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-05-15 03:38:39 +08:00
|
|
|
/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
|
|
|
|
// This is declared to take (...), so we have to check everything.
|
2009-01-19 08:08:26 +08:00
|
|
|
Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
|
2010-06-08 08:16:34 +08:00
|
|
|
if (TheCall->getNumArgs() < 2)
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocEnd(),
|
2010-04-16 12:48:22 +08:00
|
|
|
diag::err_typecheck_call_too_few_args_at_least)
|
2010-06-08 08:16:34 +08:00
|
|
|
<< 0 /*function call*/ << 2 << TheCall->getNumArgs()
|
2010-04-16 12:48:22 +08:00
|
|
|
<< TheCall->getSourceRange());
|
2008-05-15 03:38:39 +08:00
|
|
|
|
2010-06-08 08:16:34 +08:00
|
|
|
// Determine which of the following types of shufflevector we're checking:
|
|
|
|
// 1) unary, vector mask: (lhs, mask)
|
|
|
|
// 2) binary, vector mask: (lhs, rhs, mask)
|
|
|
|
// 3) binary, scalar mask: (lhs, rhs, index, ..., index)
|
|
|
|
QualType resType = TheCall->getArg(0)->getType();
|
|
|
|
unsigned numElements = 0;
|
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
if (!TheCall->getArg(0)->isTypeDependent() &&
|
|
|
|
!TheCall->getArg(1)->isTypeDependent()) {
|
2010-06-08 08:16:34 +08:00
|
|
|
QualType LHSType = TheCall->getArg(0)->getType();
|
|
|
|
QualType RHSType = TheCall->getArg(1)->getType();
|
|
|
|
|
|
|
|
if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
|
2009-05-20 06:10:17 +08:00
|
|
|
Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
|
2009-09-09 23:08:12 +08:00
|
|
|
<< SourceRange(TheCall->getArg(0)->getLocStart(),
|
2009-05-20 06:10:17 +08:00
|
|
|
TheCall->getArg(1)->getLocEnd());
|
|
|
|
return ExprError();
|
|
|
|
}
|
2010-06-08 08:16:34 +08:00
|
|
|
|
|
|
|
numElements = LHSType->getAs<VectorType>()->getNumElements();
|
|
|
|
unsigned numResElements = TheCall->getNumArgs() - 2;
|
|
|
|
|
|
|
|
// Check to see if we have a call with 2 vector arguments, the unary shuffle
|
|
|
|
// with mask. If so, verify that RHS is an integer vector type with the
|
|
|
|
// same number of elts as lhs.
|
|
|
|
if (TheCall->getNumArgs() == 2) {
|
|
|
|
if (!RHSType->isIntegerType() ||
|
|
|
|
RHSType->getAs<VectorType>()->getNumElements() != numElements)
|
|
|
|
Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
|
|
|
|
<< SourceRange(TheCall->getArg(1)->getLocStart(),
|
|
|
|
TheCall->getArg(1)->getLocEnd());
|
|
|
|
numResElements = numElements;
|
|
|
|
}
|
|
|
|
else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
|
2009-05-20 06:10:17 +08:00
|
|
|
Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
|
2009-09-09 23:08:12 +08:00
|
|
|
<< SourceRange(TheCall->getArg(0)->getLocStart(),
|
2009-05-20 06:10:17 +08:00
|
|
|
TheCall->getArg(1)->getLocEnd());
|
|
|
|
return ExprError();
|
2010-06-08 08:16:34 +08:00
|
|
|
} else if (numElements != numResElements) {
|
|
|
|
QualType eltType = LHSType->getAs<VectorType>()->getElementType();
|
2010-06-23 14:00:24 +08:00
|
|
|
resType = Context.getVectorType(eltType, numResElements,
|
|
|
|
VectorType::NotAltiVec);
|
2009-05-20 06:10:17 +08:00
|
|
|
}
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
|
2009-05-20 06:10:17 +08:00
|
|
|
if (TheCall->getArg(i)->isTypeDependent() ||
|
|
|
|
TheCall->getArg(i)->isValueDependent())
|
|
|
|
continue;
|
|
|
|
|
2010-06-08 08:16:34 +08:00
|
|
|
llvm::APSInt Result(32);
|
|
|
|
if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
|
|
|
|
return ExprError(Diag(TheCall->getLocStart(),
|
|
|
|
diag::err_shufflevector_nonconstant_argument)
|
|
|
|
<< TheCall->getArg(i)->getSourceRange());
|
2009-01-19 08:08:26 +08:00
|
|
|
|
2008-08-10 10:05:13 +08:00
|
|
|
if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
|
2009-01-19 08:08:26 +08:00
|
|
|
return ExprError(Diag(TheCall->getLocStart(),
|
2008-11-19 13:08:23 +08:00
|
|
|
diag::err_shufflevector_argument_too_large)
|
2009-01-19 08:08:26 +08:00
|
|
|
<< TheCall->getArg(i)->getSourceRange());
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
llvm::SmallVector<Expr*, 32> exprs;
|
|
|
|
|
2008-08-10 10:05:13 +08:00
|
|
|
for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
|
2008-05-15 03:38:39 +08:00
|
|
|
exprs.push_back(TheCall->getArg(i));
|
|
|
|
TheCall->setArg(i, 0);
|
|
|
|
}
|
|
|
|
|
2009-08-12 10:10:25 +08:00
|
|
|
return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
|
2010-06-08 08:16:34 +08:00
|
|
|
exprs.size(), resType,
|
2009-02-07 09:47:29 +08:00
|
|
|
TheCall->getCallee()->getLocStart(),
|
|
|
|
TheCall->getRParenLoc()));
|
2008-05-15 03:38:39 +08:00
|
|
|
}
|
2007-12-20 07:59:04 +08:00
|
|
|
|
2008-07-22 06:59:13 +08:00
|
|
|
/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
|
|
|
|
// This is declared to take (const void*, ...) and can take two
|
|
|
|
// optional constant int args.
|
|
|
|
bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
|
2008-11-19 13:08:23 +08:00
|
|
|
unsigned NumArgs = TheCall->getNumArgs();
|
2008-07-22 06:59:13 +08:00
|
|
|
|
2008-11-19 13:08:23 +08:00
|
|
|
if (NumArgs > 3)
|
2010-04-16 12:56:46 +08:00
|
|
|
return Diag(TheCall->getLocEnd(),
|
|
|
|
diag::err_typecheck_call_too_many_args_at_most)
|
|
|
|
<< 0 /*function call*/ << 3 << NumArgs
|
|
|
|
<< TheCall->getSourceRange();
|
2008-07-22 06:59:13 +08:00
|
|
|
|
|
|
|
// Argument 0 is checked for us and the remaining arguments must be
|
|
|
|
// constant integers.
|
2008-11-19 13:08:23 +08:00
|
|
|
for (unsigned i = 1; i != NumArgs; ++i) {
|
2008-07-22 06:59:13 +08:00
|
|
|
Expr *Arg = TheCall->getArg(i);
|
2010-04-17 10:26:23 +08:00
|
|
|
|
2009-12-04 08:30:06 +08:00
|
|
|
llvm::APSInt Result;
|
2010-04-17 10:26:23 +08:00
|
|
|
if (SemaBuiltinConstantArg(TheCall, i, Result))
|
|
|
|
return true;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-07-22 06:59:13 +08:00
|
|
|
// FIXME: gcc issues a warning and rewrites these to 0. These
|
|
|
|
// seems especially odd for the third argument since the default
|
|
|
|
// is 3.
|
2008-11-19 13:08:23 +08:00
|
|
|
if (i == 1) {
|
2009-12-04 08:30:06 +08:00
|
|
|
if (Result.getLimitedValue() > 1)
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
2009-09-23 14:06:36 +08:00
|
|
|
<< "0" << "1" << Arg->getSourceRange();
|
2008-07-22 06:59:13 +08:00
|
|
|
} else {
|
2009-12-04 08:30:06 +08:00
|
|
|
if (Result.getLimitedValue() > 3)
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
2009-09-23 14:06:36 +08:00
|
|
|
<< "0" << "3" << Arg->getSourceRange();
|
2008-07-22 06:59:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-11-19 13:08:23 +08:00
|
|
|
return false;
|
2008-07-22 06:59:13 +08:00
|
|
|
}
|
|
|
|
|
2010-04-17 10:26:23 +08:00
|
|
|
/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
|
|
|
|
/// TheCall is a constant expression.
|
|
|
|
bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
|
|
|
|
llvm::APSInt &Result) {
|
|
|
|
Expr *Arg = TheCall->getArg(ArgNum);
|
|
|
|
DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
|
|
|
|
FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
|
|
|
|
|
|
|
|
if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
|
|
|
|
|
|
|
|
if (!Arg->isIntegerConstantExpr(Result, Context))
|
|
|
|
return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
|
2010-04-20 02:23:02 +08:00
|
|
|
<< FDecl->getDeclName() << Arg->getSourceRange();
|
2010-04-17 10:26:23 +08:00
|
|
|
|
2009-09-23 14:06:36 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-09-04 05:13:56 +08:00
|
|
|
/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
|
|
|
|
/// int type). This simply type checks that type is one of the defined
|
|
|
|
/// constants (0-3).
|
2009-12-23 11:49:37 +08:00
|
|
|
// For compatability check 0-3, llvm only handles 0 and 2.
|
2008-09-04 05:13:56 +08:00
|
|
|
bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
|
2010-04-17 10:26:23 +08:00
|
|
|
llvm::APSInt Result;
|
|
|
|
|
|
|
|
// Check constant-ness first.
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, 1, Result))
|
|
|
|
return true;
|
2008-09-04 05:13:56 +08:00
|
|
|
|
2010-04-17 10:26:23 +08:00
|
|
|
Expr *Arg = TheCall->getArg(1);
|
2008-09-04 05:13:56 +08:00
|
|
|
if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
|
2008-11-19 13:08:23 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
|
|
|
|
<< "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
2008-09-04 05:13:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2009-05-03 14:04:26 +08:00
|
|
|
/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
|
2009-05-03 12:46:36 +08:00
|
|
|
/// This checks that val is a constant 1.
|
|
|
|
bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
|
|
|
|
Expr *Arg = TheCall->getArg(1);
|
2010-04-17 10:26:23 +08:00
|
|
|
llvm::APSInt Result;
|
2009-05-20 06:10:17 +08:00
|
|
|
|
2010-04-17 10:26:23 +08:00
|
|
|
// TODO: This is less than ideal. Overload this to take a value.
|
|
|
|
if (SemaBuiltinConstantArg(TheCall, 1, Result))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (Result != 1)
|
2009-05-03 12:46:36 +08:00
|
|
|
return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
|
|
|
|
<< SourceRange(Arg->getLocStart(), Arg->getLocEnd());
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2009-01-13 07:09:09 +08:00
|
|
|
// Handle i > 1 ? "x" : "y", recursivelly
|
2009-03-21 05:35:28 +08:00
|
|
|
bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall,
|
|
|
|
bool HasVAListArg,
|
2010-07-16 10:11:22 +08:00
|
|
|
unsigned format_idx, unsigned firstDataArg,
|
|
|
|
bool isPrintf) {
|
|
|
|
|
2009-05-20 06:10:17 +08:00
|
|
|
if (E->isTypeDependent() || E->isValueDependent())
|
|
|
|
return false;
|
2009-01-13 07:09:09 +08:00
|
|
|
|
|
|
|
switch (E->getStmtClass()) {
|
|
|
|
case Stmt::ConditionalOperatorClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ConditionalOperator *C = cast<ConditionalOperator>(E);
|
2010-07-16 10:11:22 +08:00
|
|
|
return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg,
|
|
|
|
format_idx, firstDataArg, isPrintf)
|
|
|
|
&& SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg,
|
|
|
|
format_idx, firstDataArg, isPrintf);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ImplicitCastExprClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E);
|
2009-01-13 07:09:09 +08:00
|
|
|
return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
|
2010-07-16 10:11:22 +08:00
|
|
|
format_idx, firstDataArg, isPrintf);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ParenExprClass: {
|
2009-03-21 05:35:28 +08:00
|
|
|
const ParenExpr *Expr = cast<ParenExpr>(E);
|
2009-01-13 07:09:09 +08:00
|
|
|
return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg,
|
2010-07-16 10:11:22 +08:00
|
|
|
format_idx, firstDataArg, isPrintf);
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
case Stmt::DeclRefExprClass: {
|
|
|
|
const DeclRefExpr *DR = cast<DeclRefExpr>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
// As an exception, do not flag errors for variables binding to
|
|
|
|
// const string literals.
|
|
|
|
if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
|
|
|
|
bool isConstant = false;
|
|
|
|
QualType T = DR->getType();
|
|
|
|
|
|
|
|
if (const ArrayType *AT = Context.getAsArrayType(T)) {
|
|
|
|
isConstant = AT->getElementType().isConstant(Context);
|
2009-08-05 05:02:39 +08:00
|
|
|
} else if (const PointerType *PT = T->getAs<PointerType>()) {
|
2009-09-09 23:08:12 +08:00
|
|
|
isConstant = T.isConstant(Context) &&
|
2009-03-21 05:35:28 +08:00
|
|
|
PT->getPointeeType().isConstant(Context);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
if (isConstant) {
|
2010-02-02 04:16:42 +08:00
|
|
|
if (const Expr *Init = VD->getAnyInitializer())
|
2009-03-21 05:35:28 +08:00
|
|
|
return SemaCheckStringLiteral(Init, TheCall,
|
2010-07-16 10:11:22 +08:00
|
|
|
HasVAListArg, format_idx, firstDataArg,
|
|
|
|
isPrintf);
|
2009-03-21 05:35:28 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-06-29 03:55:58 +08:00
|
|
|
// For vprintf* functions (i.e., HasVAListArg==true), we add a
|
|
|
|
// special check to see if the format string is a function parameter
|
|
|
|
// of the function calling the printf function. If the function
|
|
|
|
// has an attribute indicating it is a printf-like function, then we
|
|
|
|
// should suppress warnings concerning non-literals being used in a call
|
|
|
|
// to a vprintf function. For example:
|
|
|
|
//
|
|
|
|
// void
|
|
|
|
// logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
|
|
|
|
// va_list ap;
|
|
|
|
// va_start(ap, fmt);
|
|
|
|
// vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
|
|
|
|
// ...
|
|
|
|
//
|
|
|
|
//
|
|
|
|
// FIXME: We don't have full attribute support yet, so just check to see
|
|
|
|
// if the argument is a DeclRefExpr that references a parameter. We'll
|
|
|
|
// add proper support for checking the attribute later.
|
|
|
|
if (HasVAListArg)
|
|
|
|
if (isa<ParmVarDecl>(VD))
|
|
|
|
return true;
|
2009-03-21 05:35:28 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
return false;
|
|
|
|
}
|
2009-01-13 07:09:09 +08:00
|
|
|
|
2009-06-27 12:05:33 +08:00
|
|
|
case Stmt::CallExprClass: {
|
|
|
|
const CallExpr *CE = cast<CallExpr>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
if (const ImplicitCastExpr *ICE
|
2009-06-27 12:05:33 +08:00
|
|
|
= dyn_cast<ImplicitCastExpr>(CE->getCallee())) {
|
|
|
|
if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) {
|
|
|
|
if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) {
|
2009-06-30 10:34:44 +08:00
|
|
|
if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) {
|
2009-06-27 12:05:33 +08:00
|
|
|
unsigned ArgIndex = FA->getFormatIdx();
|
|
|
|
const Expr *Arg = CE->getArg(ArgIndex - 1);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg,
|
2010-07-16 10:11:22 +08:00
|
|
|
format_idx, firstDataArg, isPrintf);
|
2009-06-27 12:05:33 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-06-27 12:05:33 +08:00
|
|
|
return false;
|
|
|
|
}
|
2009-03-21 05:35:28 +08:00
|
|
|
case Stmt::ObjCStringLiteralClass:
|
|
|
|
case Stmt::StringLiteralClass: {
|
|
|
|
const StringLiteral *StrE = NULL;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
|
2009-01-13 07:09:09 +08:00
|
|
|
StrE = ObjCFExpr->getString();
|
|
|
|
else
|
2009-03-21 05:35:28 +08:00
|
|
|
StrE = cast<StringLiteral>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-13 07:09:09 +08:00
|
|
|
if (StrE) {
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx,
|
|
|
|
firstDataArg, isPrintf);
|
2009-01-13 07:09:09 +08:00
|
|
|
return true;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-13 07:09:09 +08:00
|
|
|
return false;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
default:
|
|
|
|
return false;
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-05-22 02:48:51 +08:00
|
|
|
void
|
2009-09-09 23:08:12 +08:00
|
|
|
Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
|
|
|
|
const CallExpr *TheCall) {
|
2009-05-22 02:48:51 +08:00
|
|
|
for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end();
|
|
|
|
i != e; ++i) {
|
2009-05-26 02:23:36 +08:00
|
|
|
const Expr *ArgExpr = TheCall->getArg(*i);
|
2010-02-16 09:46:59 +08:00
|
|
|
if (ArgExpr->isNullPointerConstant(Context,
|
2009-09-25 12:25:58 +08:00
|
|
|
Expr::NPC_ValueDependentIsNotNull))
|
2009-05-26 02:23:36 +08:00
|
|
|
Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg)
|
|
|
|
<< ArgExpr->getSourceRange();
|
2009-05-22 02:48:51 +08:00
|
|
|
}
|
|
|
|
}
|
2009-01-13 07:09:09 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
|
|
|
|
/// functions) for correct use of format strings.
|
2007-08-11 04:18:51 +08:00
|
|
|
void
|
2010-07-16 10:11:22 +08:00
|
|
|
Sema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg,
|
|
|
|
unsigned format_idx, unsigned firstDataArg,
|
|
|
|
bool isPrintf) {
|
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
const Expr *Fn = TheCall->getCallee();
|
2007-12-28 13:29:59 +08:00
|
|
|
|
2009-11-18 02:02:24 +08:00
|
|
|
// The way the format attribute works in GCC, the implicit this argument
|
|
|
|
// of member functions is counted. However, it doesn't appear in our own
|
|
|
|
// lists, so decrement format_idx in that case.
|
|
|
|
if (isa<CXXMemberCallExpr>(TheCall)) {
|
|
|
|
// Catch a format attribute mistakenly referring to the object argument.
|
|
|
|
if (format_idx == 0)
|
|
|
|
return;
|
|
|
|
--format_idx;
|
|
|
|
if(firstDataArg != 0)
|
|
|
|
--firstDataArg;
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
// CHECK: printf/scanf-like function is called with no format string.
|
2007-12-28 13:29:59 +08:00
|
|
|
if (format_idx >= TheCall->getNumArgs()) {
|
2010-07-16 10:11:22 +08:00
|
|
|
Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string)
|
2008-11-19 13:27:50 +08:00
|
|
|
<< Fn->getSourceRange();
|
2007-08-15 01:39:48 +08:00
|
|
|
return;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-21 05:35:28 +08:00
|
|
|
const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-11 04:18:51 +08:00
|
|
|
// CHECK: format string is not a string literal.
|
2009-09-09 23:08:12 +08:00
|
|
|
//
|
2007-08-15 01:39:48 +08:00
|
|
|
// Dynamically generated format strings are difficult to
|
|
|
|
// automatically vet at compile time. Requiring that format strings
|
|
|
|
// are string literals: (1) permits the checking of format strings by
|
|
|
|
// the compiler and thereby (2) can practically remove the source of
|
|
|
|
// many format string exploits.
|
2008-06-17 02:00:42 +08:00
|
|
|
|
2009-09-09 23:08:12 +08:00
|
|
|
// Format string can be either ObjC string (e.g. @"%d") or
|
2008-06-17 02:00:42 +08:00
|
|
|
// C string (e.g. "%d")
|
2009-09-09 23:08:12 +08:00
|
|
|
// ObjC string uses the same format specifiers as C string, so we can use
|
2008-06-17 02:00:42 +08:00
|
|
|
// the same format string checking logic for both ObjC and C strings.
|
2009-04-29 12:49:34 +08:00
|
|
|
if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx,
|
2010-07-16 10:11:22 +08:00
|
|
|
firstDataArg, isPrintf))
|
2009-04-29 12:49:34 +08:00
|
|
|
return; // Literal format string found, check done!
|
|
|
|
|
2009-04-29 12:59:47 +08:00
|
|
|
// If there are no arguments specified, warn with -Wformat-security, otherwise
|
|
|
|
// warn only with -Wformat-nonliteral.
|
|
|
|
if (TheCall->getNumArgs() == format_idx+1)
|
2009-09-09 23:08:12 +08:00
|
|
|
Diag(TheCall->getArg(format_idx)->getLocStart(),
|
2010-07-16 10:11:22 +08:00
|
|
|
diag::warn_format_nonliteral_noargs)
|
2009-04-29 12:59:47 +08:00
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
else
|
2009-09-09 23:08:12 +08:00
|
|
|
Diag(TheCall->getArg(format_idx)->getLocStart(),
|
2010-07-16 10:11:22 +08:00
|
|
|
diag::warn_format_nonliteral)
|
2009-04-29 12:59:47 +08:00
|
|
|
<< OrigFormatExpr->getSourceRange();
|
2009-01-13 07:09:09 +08:00
|
|
|
}
|
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
namespace {
|
2010-07-16 10:11:22 +08:00
|
|
|
class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
|
|
|
|
protected:
|
2010-01-29 07:39:18 +08:00
|
|
|
Sema &S;
|
|
|
|
const StringLiteral *FExpr;
|
|
|
|
const Expr *OrigFormatExpr;
|
2010-03-25 11:59:12 +08:00
|
|
|
const unsigned FirstDataArg;
|
2010-01-29 07:39:18 +08:00
|
|
|
const unsigned NumDataArgs;
|
|
|
|
const bool IsObjCLiteral;
|
|
|
|
const char *Beg; // Start of format string.
|
2010-01-29 09:06:55 +08:00
|
|
|
const bool HasVAListArg;
|
|
|
|
const CallExpr *TheCall;
|
|
|
|
unsigned FormatIdx;
|
2010-02-27 03:18:41 +08:00
|
|
|
llvm::BitVector CoveredArgs;
|
2010-02-27 09:41:03 +08:00
|
|
|
bool usesPositionalArgs;
|
|
|
|
bool atFirstArg;
|
2010-02-16 09:46:59 +08:00
|
|
|
public:
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
|
2010-03-25 11:59:12 +08:00
|
|
|
const Expr *origFormatExpr, unsigned firstDataArg,
|
2010-01-29 07:39:18 +08:00
|
|
|
unsigned numDataArgs, bool isObjCLiteral,
|
2010-01-29 09:06:55 +08:00
|
|
|
const char *beg, bool hasVAListArg,
|
|
|
|
const CallExpr *theCall, unsigned formatIdx)
|
2010-01-29 07:39:18 +08:00
|
|
|
: S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
|
2010-03-25 11:59:12 +08:00
|
|
|
FirstDataArg(firstDataArg),
|
2010-02-27 03:18:41 +08:00
|
|
|
NumDataArgs(numDataArgs),
|
2010-01-29 09:06:55 +08:00
|
|
|
IsObjCLiteral(isObjCLiteral), Beg(beg),
|
|
|
|
HasVAListArg(hasVAListArg),
|
2010-02-27 09:41:03 +08:00
|
|
|
TheCall(theCall), FormatIdx(formatIdx),
|
|
|
|
usesPositionalArgs(false), atFirstArg(true) {
|
2010-02-27 03:18:41 +08:00
|
|
|
CoveredArgs.resize(numDataArgs);
|
|
|
|
CoveredArgs.reset();
|
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-01-29 09:50:07 +08:00
|
|
|
void DoneProcessing();
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void HandleIncompleteSpecifier(const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
|
|
|
|
2010-02-27 09:41:03 +08:00
|
|
|
virtual void HandleInvalidPosition(const char *startSpecifier,
|
|
|
|
unsigned specifierLen,
|
2010-07-16 10:11:22 +08:00
|
|
|
analyze_format_string::PositionContext p);
|
2010-02-27 09:41:03 +08:00
|
|
|
|
|
|
|
virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
|
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
void HandleNullChar(const char *nullCharacter);
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
protected:
|
2010-07-20 05:25:57 +08:00
|
|
|
bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
|
|
|
|
const char *startSpec,
|
|
|
|
unsigned specifierLen,
|
|
|
|
const char *csStart, unsigned csLen);
|
|
|
|
|
2010-01-30 04:55:36 +08:00
|
|
|
SourceRange getFormatStringRange();
|
2010-07-16 10:11:22 +08:00
|
|
|
CharSourceRange getSpecifierRange(const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
2010-01-29 07:39:18 +08:00
|
|
|
SourceLocation getLocationOfByte(const char *x);
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-01-29 09:06:55 +08:00
|
|
|
const Expr *getDataArg(unsigned i) const;
|
2010-01-29 07:39:18 +08:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
SourceRange CheckFormatHandler::getFormatStringRange() {
|
2010-01-29 07:39:18 +08:00
|
|
|
return OrigFormatExpr->getSourceRange();
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
CharSourceRange CheckFormatHandler::
|
|
|
|
getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
|
2010-06-22 05:21:01 +08:00
|
|
|
SourceLocation Start = getLocationOfByte(startSpecifier);
|
|
|
|
SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
|
|
|
|
|
|
|
|
// Advance the end SourceLocation by one due to half-open ranges.
|
|
|
|
End = End.getFileLocWithOffset(1);
|
|
|
|
|
|
|
|
return CharSourceRange::getCharRange(Start, End);
|
2010-01-30 04:55:36 +08:00
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
|
2010-02-16 09:46:59 +08:00
|
|
|
return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
|
2010-01-29 07:39:18 +08:00
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
|
|
|
|
unsigned specifierLen){
|
2010-01-29 11:16:21 +08:00
|
|
|
SourceLocation Loc = getLocationOfByte(startSpecifier);
|
|
|
|
S.Diag(Loc, diag::warn_printf_incomplete_specifier)
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
2010-01-29 11:16:21 +08:00
|
|
|
}
|
|
|
|
|
2010-02-27 09:41:03 +08:00
|
|
|
void
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
|
|
|
|
analyze_format_string::PositionContext p) {
|
2010-02-27 09:41:03 +08:00
|
|
|
SourceLocation Loc = getLocationOfByte(startPos);
|
2010-07-16 10:11:22 +08:00
|
|
|
S.Diag(Loc, diag::warn_format_invalid_positional_specifier)
|
|
|
|
<< (unsigned) p << getSpecifierRange(startPos, posLen);
|
2010-02-27 09:41:03 +08:00
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void CheckFormatHandler::HandleZeroPosition(const char *startPos,
|
2010-02-27 09:41:03 +08:00
|
|
|
unsigned posLen) {
|
|
|
|
SourceLocation Loc = getLocationOfByte(startPos);
|
2010-07-16 10:11:22 +08:00
|
|
|
S.Diag(Loc, diag::warn_format_zero_positional_specifier)
|
|
|
|
<< getSpecifierRange(startPos, posLen);
|
2010-02-27 09:41:03 +08:00
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
|
|
|
|
// The presence of a null character is likely an error.
|
|
|
|
S.Diag(getLocationOfByte(nullCharacter),
|
|
|
|
diag::warn_printf_format_string_contains_null_char)
|
|
|
|
<< getFormatStringRange();
|
|
|
|
}
|
|
|
|
|
|
|
|
const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
|
|
|
|
return TheCall->getArg(FirstDataArg + i);
|
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void CheckFormatHandler::DoneProcessing() {
|
|
|
|
// Does the number of data arguments exceed the number of
|
|
|
|
// format conversions in the format string?
|
|
|
|
if (!HasVAListArg) {
|
|
|
|
// Find any arguments that weren't covered.
|
|
|
|
CoveredArgs.flip();
|
|
|
|
signed notCoveredArg = CoveredArgs.find_first();
|
|
|
|
if (notCoveredArg >= 0) {
|
|
|
|
assert((unsigned)notCoveredArg < NumDataArgs);
|
|
|
|
S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(),
|
|
|
|
diag::warn_printf_data_arg_not_used)
|
|
|
|
<< getFormatStringRange();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-07-20 05:25:57 +08:00
|
|
|
bool
|
|
|
|
CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
|
|
|
|
SourceLocation Loc,
|
|
|
|
const char *startSpec,
|
|
|
|
unsigned specifierLen,
|
|
|
|
const char *csStart,
|
|
|
|
unsigned csLen) {
|
|
|
|
|
|
|
|
bool keepGoing = true;
|
|
|
|
if (argIndex < NumDataArgs) {
|
|
|
|
// Consider the argument coverered, even though the specifier doesn't
|
|
|
|
// make sense.
|
|
|
|
CoveredArgs.set(argIndex);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
// If argIndex exceeds the number of data arguments we
|
|
|
|
// don't issue a warning because that is just a cascade of warnings (and
|
|
|
|
// they may have intended '%%' anyway). We don't want to continue processing
|
|
|
|
// the format string after this point, however, as we will like just get
|
|
|
|
// gibberish when trying to match arguments.
|
|
|
|
keepGoing = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
S.Diag(Loc, diag::warn_format_invalid_conversion)
|
|
|
|
<< llvm::StringRef(csStart, csLen)
|
|
|
|
<< getSpecifierRange(startSpec, specifierLen);
|
|
|
|
|
|
|
|
return keepGoing;
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
//===--- CHECK: Printf format string checking ------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class CheckPrintfHandler : public CheckFormatHandler {
|
|
|
|
public:
|
|
|
|
CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
|
|
|
|
const Expr *origFormatExpr, unsigned firstDataArg,
|
|
|
|
unsigned numDataArgs, bool isObjCLiteral,
|
|
|
|
const char *beg, bool hasVAListArg,
|
|
|
|
const CallExpr *theCall, unsigned formatIdx)
|
|
|
|
: CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
|
|
|
|
numDataArgs, isObjCLiteral, beg, hasVAListArg,
|
|
|
|
theCall, formatIdx) {}
|
|
|
|
|
|
|
|
|
|
|
|
bool HandleInvalidPrintfConversionSpecifier(
|
|
|
|
const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
|
|
|
|
|
|
|
bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
|
|
|
|
|
|
|
bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
|
|
|
|
const char *startSpecifier, unsigned specifierLen);
|
|
|
|
void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const analyze_printf::OptionalAmount &Amt,
|
|
|
|
unsigned type,
|
|
|
|
const char *startSpecifier, unsigned specifierLen);
|
|
|
|
void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const analyze_printf::OptionalFlag &flag,
|
|
|
|
const char *startSpecifier, unsigned specifierLen);
|
|
|
|
void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const analyze_printf::OptionalFlag &ignoredFlag,
|
|
|
|
const analyze_printf::OptionalFlag &flag,
|
|
|
|
const char *startSpecifier, unsigned specifierLen);
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
|
|
|
|
const analyze_printf::PrintfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
2010-07-21 04:04:27 +08:00
|
|
|
const analyze_printf::PrintfConversionSpecifier &CS =
|
2010-07-20 05:25:57 +08:00
|
|
|
FS.getConversionSpecifier();
|
2010-07-16 10:11:22 +08:00
|
|
|
|
2010-07-20 05:25:57 +08:00
|
|
|
return HandleInvalidConversionSpecifier(FS.getArgIndex(),
|
|
|
|
getLocationOfByte(CS.getStart()),
|
|
|
|
startSpecifier, specifierLen,
|
|
|
|
CS.getStart(), CS.getLength());
|
2010-01-29 10:40:24 +08:00
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
bool CheckPrintfHandler::HandleAmount(
|
|
|
|
const analyze_format_string::OptionalAmount &Amt,
|
|
|
|
unsigned k, const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
2010-01-29 09:06:55 +08:00
|
|
|
|
|
|
|
if (Amt.hasDataArgument()) {
|
|
|
|
if (!HasVAListArg) {
|
2010-02-27 03:18:41 +08:00
|
|
|
unsigned argIndex = Amt.getArgIndex();
|
|
|
|
if (argIndex >= NumDataArgs) {
|
2010-02-27 09:41:03 +08:00
|
|
|
S.Diag(getLocationOfByte(Amt.getStart()),
|
|
|
|
diag::warn_printf_asterisk_missing_arg)
|
2010-07-16 10:11:22 +08:00
|
|
|
<< k << getSpecifierRange(startSpecifier, specifierLen);
|
2010-01-29 09:06:55 +08:00
|
|
|
// Don't do any more checking. We will just emit
|
|
|
|
// spurious errors.
|
|
|
|
return false;
|
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-01-29 09:06:55 +08:00
|
|
|
// Type check the data argument. It should be an 'int'.
|
2010-01-30 07:32:22 +08:00
|
|
|
// Although not in conformance with C99, we also allow the argument to be
|
|
|
|
// an 'unsigned int' as that is a reasonably safe case. GCC also
|
|
|
|
// doesn't emit a warning for that case.
|
2010-02-27 03:18:41 +08:00
|
|
|
CoveredArgs.set(argIndex);
|
|
|
|
const Expr *Arg = getDataArg(argIndex);
|
2010-01-29 09:06:55 +08:00
|
|
|
QualType T = Arg->getType();
|
2010-02-16 09:46:59 +08:00
|
|
|
|
|
|
|
const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
|
|
|
|
assert(ATR.isValid());
|
|
|
|
|
|
|
|
if (!ATR.matchesType(S.Context, T)) {
|
2010-02-27 09:41:03 +08:00
|
|
|
S.Diag(getLocationOfByte(Amt.getStart()),
|
|
|
|
diag::warn_printf_asterisk_wrong_type)
|
|
|
|
<< k
|
2010-02-16 09:46:59 +08:00
|
|
|
<< ATR.getRepresentativeType(S.Context) << T
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
2010-01-30 08:49:51 +08:00
|
|
|
<< Arg->getSourceRange();
|
2010-01-29 09:06:55 +08:00
|
|
|
// Don't do any more checking. We will just emit
|
|
|
|
// spurious errors.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2010-06-18 03:00:27 +08:00
|
|
|
void CheckPrintfHandler::HandleInvalidAmount(
|
2010-07-16 10:11:22 +08:00
|
|
|
const analyze_printf::PrintfSpecifier &FS,
|
2010-06-18 03:00:27 +08:00
|
|
|
const analyze_printf::OptionalAmount &Amt,
|
|
|
|
unsigned type,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
2010-07-21 04:04:27 +08:00
|
|
|
const analyze_printf::PrintfConversionSpecifier &CS =
|
|
|
|
FS.getConversionSpecifier();
|
2010-06-18 03:00:27 +08:00
|
|
|
switch (Amt.getHowSpecified()) {
|
|
|
|
case analyze_printf::OptionalAmount::Constant:
|
|
|
|
S.Diag(getLocationOfByte(Amt.getStart()),
|
|
|
|
diag::warn_printf_nonsensical_optional_amount)
|
|
|
|
<< type
|
|
|
|
<< CS.toString()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
|
|
|
<< FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
|
2010-06-18 03:00:27 +08:00
|
|
|
Amt.getConstantLength()));
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
S.Diag(getLocationOfByte(Amt.getStart()),
|
|
|
|
diag::warn_printf_nonsensical_optional_amount)
|
|
|
|
<< type
|
|
|
|
<< CS.toString()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
2010-06-18 03:00:27 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
|
2010-06-18 03:00:27 +08:00
|
|
|
const analyze_printf::OptionalFlag &flag,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
|
|
|
// Warn about pointless flag with a fixit removal.
|
2010-07-21 04:04:27 +08:00
|
|
|
const analyze_printf::PrintfConversionSpecifier &CS =
|
|
|
|
FS.getConversionSpecifier();
|
2010-06-18 03:00:27 +08:00
|
|
|
S.Diag(getLocationOfByte(flag.getPosition()),
|
|
|
|
diag::warn_printf_nonsensical_flag)
|
|
|
|
<< flag.toString() << CS.toString()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
|
|
|
<< FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1));
|
2010-06-18 03:00:27 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void CheckPrintfHandler::HandleIgnoredFlag(
|
2010-07-16 10:11:22 +08:00
|
|
|
const analyze_printf::PrintfSpecifier &FS,
|
2010-06-18 03:00:27 +08:00
|
|
|
const analyze_printf::OptionalFlag &ignoredFlag,
|
|
|
|
const analyze_printf::OptionalFlag &flag,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
|
|
|
// Warn about ignored flag with a fixit removal.
|
|
|
|
S.Diag(getLocationOfByte(ignoredFlag.getPosition()),
|
|
|
|
diag::warn_printf_ignored_flag)
|
|
|
|
<< ignoredFlag.toString() << flag.toString()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
|
|
|
<< FixItHint::CreateRemoval(getSpecifierRange(
|
2010-06-18 03:00:27 +08:00
|
|
|
ignoredFlag.getPosition(), 1));
|
|
|
|
}
|
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
bool
|
2010-07-16 10:11:22 +08:00
|
|
|
CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
|
2010-02-11 17:27:41 +08:00
|
|
|
&FS,
|
2010-01-29 07:39:18 +08:00
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
|
|
|
|
2010-07-21 04:04:27 +08:00
|
|
|
using namespace analyze_format_string;
|
2010-02-27 09:41:03 +08:00
|
|
|
using namespace analyze_printf;
|
2010-07-21 04:04:27 +08:00
|
|
|
const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
|
2010-01-29 07:39:18 +08:00
|
|
|
|
2010-07-20 06:01:06 +08:00
|
|
|
if (FS.consumesDataArgument()) {
|
|
|
|
if (atFirstArg) {
|
|
|
|
atFirstArg = false;
|
|
|
|
usesPositionalArgs = FS.usesPositionalArg();
|
|
|
|
}
|
|
|
|
else if (usesPositionalArgs != FS.usesPositionalArg()) {
|
|
|
|
// Cannot mix-and-match positional and non-positional arguments.
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_format_mix_positional_nonpositional_args)
|
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
|
|
|
return false;
|
|
|
|
}
|
2010-02-27 09:41:03 +08:00
|
|
|
}
|
|
|
|
|
2010-01-29 09:06:55 +08:00
|
|
|
// First check if the field width, precision, and conversion specifier
|
|
|
|
// have matching data arguments.
|
2010-02-27 09:41:03 +08:00
|
|
|
if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
|
|
|
|
startSpecifier, specifierLen)) {
|
2010-01-29 09:06:55 +08:00
|
|
|
return false;
|
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-02-27 09:41:03 +08:00
|
|
|
if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
|
|
|
|
startSpecifier, specifierLen)) {
|
2010-01-29 09:06:55 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2010-01-30 04:55:36 +08:00
|
|
|
if (!CS.consumesDataArgument()) {
|
|
|
|
// FIXME: Technically specifying a precision or field width here
|
|
|
|
// makes no sense. Worth issuing a warning at some point.
|
2010-02-10 10:16:30 +08:00
|
|
|
return true;
|
2010-01-30 04:55:36 +08:00
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-02-27 03:18:41 +08:00
|
|
|
// Consume the argument.
|
|
|
|
unsigned argIndex = FS.getArgIndex();
|
2010-02-27 16:34:51 +08:00
|
|
|
if (argIndex < NumDataArgs) {
|
|
|
|
// The check to see if the argIndex is valid will come later.
|
|
|
|
// We set the bit here because we may exit early from this
|
|
|
|
// function if we encounter some other error.
|
|
|
|
CoveredArgs.set(argIndex);
|
|
|
|
}
|
2010-02-27 03:18:41 +08:00
|
|
|
|
|
|
|
// Check for using an Objective-C specific conversion specifier
|
|
|
|
// in a non-ObjC literal.
|
|
|
|
if (!IsObjCLiteral && CS.isObjCArg()) {
|
2010-07-16 10:11:22 +08:00
|
|
|
return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
|
|
|
|
specifierLen);
|
2010-02-27 03:18:41 +08:00
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-06-18 03:00:27 +08:00
|
|
|
// Check for invalid use of field width
|
|
|
|
if (!FS.hasValidFieldWidth()) {
|
2010-06-22 05:21:01 +08:00
|
|
|
HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
|
2010-06-18 03:00:27 +08:00
|
|
|
startSpecifier, specifierLen);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check for invalid use of precision
|
|
|
|
if (!FS.hasValidPrecision()) {
|
|
|
|
HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
|
|
|
|
startSpecifier, specifierLen);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check each flag does not conflict with any other component.
|
|
|
|
if (!FS.hasValidLeadingZeros())
|
|
|
|
HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
|
|
|
|
if (!FS.hasValidPlusPrefix())
|
|
|
|
HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
|
2010-06-22 05:21:01 +08:00
|
|
|
if (!FS.hasValidSpacePrefix())
|
|
|
|
HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
|
2010-06-18 03:00:27 +08:00
|
|
|
if (!FS.hasValidAlternativeForm())
|
|
|
|
HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
|
|
|
|
if (!FS.hasValidLeftJustified())
|
|
|
|
HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
|
|
|
|
|
|
|
|
// Check that flags are not ignored by another flag
|
2010-06-22 05:21:01 +08:00
|
|
|
if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
|
|
|
|
HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
|
|
|
|
startSpecifier, specifierLen);
|
2010-06-18 03:00:27 +08:00
|
|
|
if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
|
|
|
|
HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
|
|
|
|
startSpecifier, specifierLen);
|
|
|
|
|
|
|
|
// Check the length modifier is valid with the given conversion specifier.
|
|
|
|
const LengthModifier &LM = FS.getLengthModifier();
|
|
|
|
if (!FS.hasValidLengthModifier())
|
|
|
|
S.Diag(getLocationOfByte(LM.getStart()),
|
2010-07-21 04:03:43 +08:00
|
|
|
diag::warn_format_nonsensical_length)
|
2010-06-18 03:00:27 +08:00
|
|
|
<< LM.toString() << CS.toString()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
|
|
|
<< FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(),
|
2010-06-18 03:00:27 +08:00
|
|
|
LM.getLength()));
|
|
|
|
|
|
|
|
// Are we using '%n'?
|
2010-07-21 04:04:10 +08:00
|
|
|
if (CS.getKind() == ConversionSpecifier::nArg) {
|
2010-06-18 03:00:27 +08:00
|
|
|
// Issue a warning about this being a possible security issue.
|
2010-01-29 09:35:25 +08:00
|
|
|
S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back)
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
2010-01-29 09:35:25 +08:00
|
|
|
// Continue checking the other format specifiers.
|
|
|
|
return true;
|
|
|
|
}
|
2010-02-11 17:27:41 +08:00
|
|
|
|
2010-01-29 09:43:31 +08:00
|
|
|
// The remaining checks depend on the data arguments.
|
|
|
|
if (HasVAListArg)
|
|
|
|
return true;
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-02-27 03:18:41 +08:00
|
|
|
if (argIndex >= NumDataArgs) {
|
2010-03-25 11:59:12 +08:00
|
|
|
if (FS.usesPositionalArg()) {
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_positional_arg_exceeds_data_args)
|
|
|
|
<< (argIndex+1) << NumDataArgs
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
2010-03-25 11:59:12 +08:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_insufficient_data_args)
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
2010-03-25 11:59:12 +08:00
|
|
|
}
|
|
|
|
|
2010-01-29 09:43:31 +08:00
|
|
|
// Don't do any more checking.
|
|
|
|
return false;
|
|
|
|
}
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-01-30 08:49:51 +08:00
|
|
|
// Now type check the data expression that matches the
|
|
|
|
// format specifier.
|
2010-02-27 03:18:41 +08:00
|
|
|
const Expr *Ex = getDataArg(argIndex);
|
2010-01-30 08:49:51 +08:00
|
|
|
const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context);
|
2010-02-16 09:46:59 +08:00
|
|
|
if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
|
|
|
|
// Check if we didn't match because of an implicit cast from a 'char'
|
|
|
|
// or 'short' to an 'int'. This is done because printf is a varargs
|
|
|
|
// function.
|
|
|
|
if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
|
|
|
|
if (ICE->getType() == S.Context.IntTy)
|
|
|
|
if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType()))
|
|
|
|
return true;
|
2010-02-02 03:38:10 +08:00
|
|
|
|
2010-06-09 12:11:11 +08:00
|
|
|
// We may be able to offer a FixItHint if it is a supported type.
|
2010-07-16 10:11:22 +08:00
|
|
|
PrintfSpecifier fixedFS = FS;
|
2010-06-09 12:11:11 +08:00
|
|
|
bool success = fixedFS.fixType(Ex->getType());
|
|
|
|
|
|
|
|
if (success) {
|
|
|
|
// Get the fix string from the fixed format specifier
|
|
|
|
llvm::SmallString<128> buf;
|
|
|
|
llvm::raw_svector_ostream os(buf);
|
|
|
|
fixedFS.toString(os);
|
|
|
|
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_conversion_argument_type_mismatch)
|
|
|
|
<< ATR.getRepresentativeType(S.Context) << Ex->getType()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
2010-06-09 12:11:11 +08:00
|
|
|
<< Ex->getSourceRange()
|
|
|
|
<< FixItHint::CreateReplacement(
|
2010-07-16 10:11:22 +08:00
|
|
|
getSpecifierRange(startSpecifier, specifierLen),
|
2010-06-09 12:11:11 +08:00
|
|
|
os.str());
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_conversion_argument_type_mismatch)
|
|
|
|
<< ATR.getRepresentativeType(S.Context) << Ex->getType()
|
2010-07-16 10:11:22 +08:00
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen)
|
2010-06-09 12:11:11 +08:00
|
|
|
<< Ex->getSourceRange();
|
|
|
|
}
|
2010-01-30 08:49:51 +08:00
|
|
|
}
|
2010-01-29 07:39:18 +08:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
//===--- CHECK: Scanf format string checking ------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class CheckScanfHandler : public CheckFormatHandler {
|
|
|
|
public:
|
|
|
|
CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
|
|
|
|
const Expr *origFormatExpr, unsigned firstDataArg,
|
|
|
|
unsigned numDataArgs, bool isObjCLiteral,
|
|
|
|
const char *beg, bool hasVAListArg,
|
|
|
|
const CallExpr *theCall, unsigned formatIdx)
|
|
|
|
: CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
|
|
|
|
numDataArgs, isObjCLiteral, beg, hasVAListArg,
|
|
|
|
theCall, formatIdx) {}
|
|
|
|
|
|
|
|
bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
2010-07-20 05:25:57 +08:00
|
|
|
|
|
|
|
bool HandleInvalidScanfConversionSpecifier(
|
|
|
|
const analyze_scanf::ScanfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen);
|
2010-07-17 02:28:03 +08:00
|
|
|
|
|
|
|
void HandleIncompleteScanList(const char *start, const char *end);
|
2010-07-16 10:11:22 +08:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2010-07-17 02:28:03 +08:00
|
|
|
void CheckScanfHandler::HandleIncompleteScanList(const char *start,
|
|
|
|
const char *end) {
|
|
|
|
S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete)
|
|
|
|
<< getSpecifierRange(start, end - start);
|
|
|
|
}
|
|
|
|
|
2010-07-20 05:25:57 +08:00
|
|
|
bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
|
|
|
|
const analyze_scanf::ScanfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
|
|
|
|
2010-07-21 04:04:27 +08:00
|
|
|
const analyze_scanf::ScanfConversionSpecifier &CS =
|
2010-07-20 05:25:57 +08:00
|
|
|
FS.getConversionSpecifier();
|
|
|
|
|
|
|
|
return HandleInvalidConversionSpecifier(FS.getArgIndex(),
|
|
|
|
getLocationOfByte(CS.getStart()),
|
|
|
|
startSpecifier, specifierLen,
|
|
|
|
CS.getStart(), CS.getLength());
|
|
|
|
}
|
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
bool CheckScanfHandler::HandleScanfSpecifier(
|
|
|
|
const analyze_scanf::ScanfSpecifier &FS,
|
|
|
|
const char *startSpecifier,
|
|
|
|
unsigned specifierLen) {
|
|
|
|
|
|
|
|
using namespace analyze_scanf;
|
|
|
|
using namespace analyze_format_string;
|
|
|
|
|
2010-07-21 04:04:27 +08:00
|
|
|
const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
|
2010-07-16 10:11:22 +08:00
|
|
|
|
2010-07-20 06:01:06 +08:00
|
|
|
// Handle case where '%' and '*' don't consume an argument. These shouldn't
|
|
|
|
// be used to decide if we are using positional arguments consistently.
|
|
|
|
if (FS.consumesDataArgument()) {
|
|
|
|
if (atFirstArg) {
|
|
|
|
atFirstArg = false;
|
|
|
|
usesPositionalArgs = FS.usesPositionalArg();
|
|
|
|
}
|
|
|
|
else if (usesPositionalArgs != FS.usesPositionalArg()) {
|
|
|
|
// Cannot mix-and-match positional and non-positional arguments.
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_format_mix_positional_nonpositional_args)
|
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
|
|
|
return false;
|
|
|
|
}
|
2010-07-16 10:11:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check if the field with is non-zero.
|
|
|
|
const OptionalAmount &Amt = FS.getFieldWidth();
|
|
|
|
if (Amt.getHowSpecified() == OptionalAmount::Constant) {
|
|
|
|
if (Amt.getConstantAmount() == 0) {
|
|
|
|
const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
|
|
|
|
Amt.getConstantLength());
|
|
|
|
S.Diag(getLocationOfByte(Amt.getStart()),
|
|
|
|
diag::warn_scanf_nonzero_width)
|
|
|
|
<< R << FixItHint::CreateRemoval(R);
|
2010-02-27 03:18:41 +08:00
|
|
|
}
|
|
|
|
}
|
2010-07-16 10:11:22 +08:00
|
|
|
|
|
|
|
if (!FS.consumesDataArgument()) {
|
|
|
|
// FIXME: Technically specifying a precision or field width here
|
|
|
|
// makes no sense. Worth issuing a warning at some point.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Consume the argument.
|
|
|
|
unsigned argIndex = FS.getArgIndex();
|
|
|
|
if (argIndex < NumDataArgs) {
|
|
|
|
// The check to see if the argIndex is valid will come later.
|
|
|
|
// We set the bit here because we may exit early from this
|
|
|
|
// function if we encounter some other error.
|
|
|
|
CoveredArgs.set(argIndex);
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: Check that the length modifier is valid with the given
|
|
|
|
// conversion specifier.
|
|
|
|
|
|
|
|
// The remaining checks depend on the data arguments.
|
|
|
|
if (HasVAListArg)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (argIndex >= NumDataArgs) {
|
|
|
|
if (FS.usesPositionalArg()) {
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_positional_arg_exceeds_data_args)
|
|
|
|
<< (argIndex+1) << NumDataArgs
|
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
S.Diag(getLocationOfByte(CS.getStart()),
|
|
|
|
diag::warn_printf_insufficient_data_args)
|
|
|
|
<< getSpecifierRange(startSpecifier, specifierLen);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Don't do any more checking.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: Check that the argument type matches the format specifier.
|
|
|
|
|
|
|
|
return true;
|
2010-01-29 09:50:07 +08:00
|
|
|
}
|
2010-01-29 07:39:18 +08:00
|
|
|
|
2010-07-16 10:11:22 +08:00
|
|
|
void Sema::CheckFormatString(const StringLiteral *FExpr,
|
2010-02-10 10:16:30 +08:00
|
|
|
const Expr *OrigFormatExpr,
|
|
|
|
const CallExpr *TheCall, bool HasVAListArg,
|
2010-07-16 10:11:22 +08:00
|
|
|
unsigned format_idx, unsigned firstDataArg,
|
|
|
|
bool isPrintf) {
|
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
// CHECK: is the format string a wide literal?
|
|
|
|
if (FExpr->isWide()) {
|
|
|
|
Diag(FExpr->getLocStart(),
|
2010-07-16 10:11:22 +08:00
|
|
|
diag::warn_format_string_is_wide_literal)
|
2010-01-29 07:39:18 +08:00
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
return;
|
|
|
|
}
|
2010-07-16 10:11:22 +08:00
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
// Str - The format string. NOTE: this is NOT null-terminated!
|
|
|
|
const char *Str = FExpr->getStrData();
|
2010-07-16 10:11:22 +08:00
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
// CHECK: empty format string?
|
|
|
|
unsigned StrLen = FExpr->getByteLength();
|
2010-07-16 10:11:22 +08:00
|
|
|
|
2010-01-29 07:39:18 +08:00
|
|
|
if (StrLen == 0) {
|
2010-07-16 10:11:22 +08:00
|
|
|
Diag(FExpr->getLocStart(), diag::warn_empty_format_string)
|
2010-01-29 07:39:18 +08:00
|
|
|
<< OrigFormatExpr->getSourceRange();
|
|
|
|
return;
|
|
|
|
}
|
2010-07-16 10:11:22 +08:00
|
|
|
|
|
|
|
if (isPrintf) {
|
|
|
|
CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
|
|
|
|
TheCall->getNumArgs() - firstDataArg,
|
|
|
|
isa<ObjCStringLiteral>(OrigFormatExpr), Str,
|
|
|
|
HasVAListArg, TheCall, format_idx);
|
|
|
|
|
|
|
|
if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen))
|
|
|
|
H.DoneProcessing();
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
|
|
|
|
TheCall->getNumArgs() - firstDataArg,
|
|
|
|
isa<ObjCStringLiteral>(OrigFormatExpr), Str,
|
|
|
|
HasVAListArg, TheCall, format_idx);
|
|
|
|
|
|
|
|
if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen))
|
|
|
|
H.DoneProcessing();
|
|
|
|
}
|
2010-01-28 09:18:22 +08:00
|
|
|
}
|
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
//===--- CHECK: Return Address of Stack Variable --------------------------===//
|
|
|
|
|
|
|
|
static DeclRefExpr* EvalVal(Expr *E);
|
|
|
|
static DeclRefExpr* EvalAddr(Expr* E);
|
|
|
|
|
|
|
|
/// CheckReturnStackAddr - Check if a return statement returns the address
|
|
|
|
/// of a stack variable.
|
|
|
|
void
|
|
|
|
Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
|
|
|
|
SourceLocation ReturnLoc) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Perform checking for returned stack addresses.
|
2008-09-06 06:11:13 +08:00
|
|
|
if (lhsType->isPointerType() || lhsType->isBlockPointerType()) {
|
2007-08-18 00:46:58 +08:00
|
|
|
if (DeclRefExpr *DR = EvalAddr(RetValExp))
|
2008-11-19 16:23:25 +08:00
|
|
|
Diag(DR->getLocStart(), diag::warn_ret_stack_addr)
|
2008-11-24 05:45:46 +08:00
|
|
|
<< DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-09-17 06:25:10 +08:00
|
|
|
// Skip over implicit cast expressions when checking for block expressions.
|
2009-09-08 08:36:37 +08:00
|
|
|
RetValExp = RetValExp->IgnoreParenCasts();
|
2008-09-17 06:25:10 +08:00
|
|
|
|
2009-10-30 12:01:58 +08:00
|
|
|
if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp))
|
2009-04-17 08:09:41 +08:00
|
|
|
if (C->hasBlockDeclRefExprs())
|
|
|
|
Diag(C->getLocStart(), diag::err_ret_local_block)
|
|
|
|
<< C->getSourceRange();
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2009-10-30 12:01:58 +08:00
|
|
|
if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp))
|
|
|
|
Diag(ALE->getLocStart(), diag::warn_ret_addr_label)
|
|
|
|
<< ALE->getSourceRange();
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2009-08-05 05:02:39 +08:00
|
|
|
} else if (lhsType->isReferenceType()) {
|
|
|
|
// Perform checking for stack values returned by reference.
|
2008-10-28 03:41:14 +08:00
|
|
|
// Check for a reference to the stack
|
|
|
|
if (DeclRefExpr *DR = EvalVal(RetValExp))
|
2008-11-19 13:27:50 +08:00
|
|
|
Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
|
2008-11-24 05:45:46 +08:00
|
|
|
<< DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
|
|
|
|
/// check if the expression in a return statement evaluates to an address
|
|
|
|
/// to a location on the stack. The recursion is used to traverse the
|
|
|
|
/// AST of the return expression, with recursion backtracking when we
|
|
|
|
/// encounter a subexpression that (1) clearly does not lead to the address
|
|
|
|
/// of a stack variable or (2) is something we cannot determine leads to
|
|
|
|
/// the address of a stack variable based on such local checking.
|
|
|
|
///
|
2007-08-29 01:02:55 +08:00
|
|
|
/// EvalAddr processes expressions that are pointers that are used as
|
|
|
|
/// references (and not L-values). EvalVal handles all other values.
|
2009-09-09 23:08:12 +08:00
|
|
|
/// At the base case of the recursion is a check for a DeclRefExpr* in
|
2007-08-18 00:46:58 +08:00
|
|
|
/// the refers to a stack variable.
|
|
|
|
///
|
|
|
|
/// This implementation handles:
|
|
|
|
///
|
|
|
|
/// * pointer-to-pointer casts
|
|
|
|
/// * implicit conversions from array references to pointers
|
|
|
|
/// * taking the address of fields
|
|
|
|
/// * arbitrary interplay between "&" and "*" operators
|
|
|
|
/// * pointer arithmetic from an address of a stack variable
|
|
|
|
/// * taking the address of an array element where the array is on the stack
|
|
|
|
static DeclRefExpr* EvalAddr(Expr *E) {
|
|
|
|
// We should only be called for evaluating pointer expressions.
|
2009-08-18 00:35:33 +08:00
|
|
|
assert((E->getType()->isAnyPointerType() ||
|
2008-09-06 06:11:13 +08:00
|
|
|
E->getType()->isBlockPointerType() ||
|
2008-01-08 03:49:32 +08:00
|
|
|
E->getType()->isObjCQualifiedIdType()) &&
|
2007-12-28 13:31:15 +08:00
|
|
|
"EvalAddr only works on pointers");
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Our "symbolic interpreter" is just a dispatch off the currently
|
|
|
|
// viewed AST node. We then recursively traverse the AST by calling
|
|
|
|
// EvalAddr and EvalVal appropriately.
|
|
|
|
switch (E->getStmtClass()) {
|
2007-12-28 13:31:15 +08:00
|
|
|
case Stmt::ParenExprClass:
|
|
|
|
// Ignore parentheses.
|
|
|
|
return EvalAddr(cast<ParenExpr>(E)->getSubExpr());
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
case Stmt::UnaryOperatorClass: {
|
|
|
|
// The only unary operator that make sense to handle here
|
|
|
|
// is AddrOf. All others don't make sense as pointers.
|
|
|
|
UnaryOperator *U = cast<UnaryOperator>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
if (U->getOpcode() == UnaryOperator::AddrOf)
|
|
|
|
return EvalVal(U->getSubExpr());
|
|
|
|
else
|
|
|
|
return NULL;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
case Stmt::BinaryOperatorClass: {
|
|
|
|
// Handle pointer arithmetic. All other binary operators are not valid
|
|
|
|
// in this context.
|
|
|
|
BinaryOperator *B = cast<BinaryOperator>(E);
|
|
|
|
BinaryOperator::Opcode op = B->getOpcode();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
if (op != BinaryOperator::Add && op != BinaryOperator::Sub)
|
|
|
|
return NULL;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
Expr *Base = B->getLHS();
|
2007-12-01 03:04:31 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// Determine which argument is the real pointer base. It could be
|
|
|
|
// the RHS argument instead of the LHS.
|
|
|
|
if (!Base->getType()->isPointerType()) Base = B->getRHS();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
assert (Base->getType()->isPointerType());
|
|
|
|
return EvalAddr(Base);
|
|
|
|
}
|
2008-09-11 03:17:48 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// For conditional operators we need to see if either the LHS or RHS are
|
|
|
|
// valid DeclRefExpr*s. If one of them is valid, we return it.
|
|
|
|
case Stmt::ConditionalOperatorClass: {
|
|
|
|
ConditionalOperator *C = cast<ConditionalOperator>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// Handle the GNU extension for missing LHS.
|
|
|
|
if (Expr *lhsExpr = C->getLHS())
|
|
|
|
if (DeclRefExpr* LHS = EvalAddr(lhsExpr))
|
|
|
|
return LHS;
|
2007-08-18 00:46:58 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(C->getRHS());
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-08-07 08:49:01 +08:00
|
|
|
// For casts, we need to handle conversions from arrays to
|
|
|
|
// pointer values, and pointer-to-pointer conversions.
|
2008-10-28 03:41:14 +08:00
|
|
|
case Stmt::ImplicitCastExprClass:
|
2008-10-28 23:36:24 +08:00
|
|
|
case Stmt::CStyleCastExprClass:
|
2008-10-28 03:41:14 +08:00
|
|
|
case Stmt::CXXFunctionalCastExprClass: {
|
2008-08-19 07:01:59 +08:00
|
|
|
Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
|
2008-08-07 08:49:01 +08:00
|
|
|
QualType T = SubExpr->getType();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-09-06 06:11:13 +08:00
|
|
|
if (SubExpr->getType()->isPointerType() ||
|
|
|
|
SubExpr->getType()->isBlockPointerType() ||
|
|
|
|
SubExpr->getType()->isObjCQualifiedIdType())
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(SubExpr);
|
2008-08-07 08:49:01 +08:00
|
|
|
else if (T->isArrayType())
|
|
|
|
return EvalVal(SubExpr);
|
2007-12-28 13:31:15 +08:00
|
|
|
else
|
2008-08-07 08:49:01 +08:00
|
|
|
return 0;
|
2007-12-28 13:31:15 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// C++ casts. For dynamic casts, static casts, and const casts, we
|
|
|
|
// are always converting from a pointer-to-pointer, so we just blow
|
2008-10-28 03:41:14 +08:00
|
|
|
// through the cast. In the case the dynamic cast doesn't fail (and
|
|
|
|
// return NULL), we take the conservative route and report cases
|
2007-12-28 13:31:15 +08:00
|
|
|
// where we return the address of a stack variable. For Reinterpre
|
2008-10-28 03:41:14 +08:00
|
|
|
// FIXME: The comment about is wrong; we're not always converting
|
|
|
|
// from pointer to pointer. I'm guessing that this code should also
|
2009-09-09 23:08:12 +08:00
|
|
|
// handle references to objects.
|
|
|
|
case Stmt::CXXStaticCastExprClass:
|
|
|
|
case Stmt::CXXDynamicCastExprClass:
|
2008-10-28 03:41:14 +08:00
|
|
|
case Stmt::CXXConstCastExprClass:
|
|
|
|
case Stmt::CXXReinterpretCastExprClass: {
|
|
|
|
Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr();
|
2008-09-06 06:11:13 +08:00
|
|
|
if (S->getType()->isPointerType() || S->getType()->isBlockPointerType())
|
2007-12-28 13:31:15 +08:00
|
|
|
return EvalAddr(S);
|
2007-08-18 00:46:58 +08:00
|
|
|
else
|
|
|
|
return NULL;
|
2007-12-28 13:31:15 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-12-28 13:31:15 +08:00
|
|
|
// Everything else: we simply don't reason about them.
|
|
|
|
default:
|
|
|
|
return NULL;
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
|
|
|
|
/// EvalVal - This function is complements EvalAddr in the mutual recursion.
|
|
|
|
/// See the comments for EvalAddr for more details.
|
|
|
|
static DeclRefExpr* EvalVal(Expr *E) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-29 01:02:55 +08:00
|
|
|
// We should only be called for evaluating non-pointer expressions, or
|
|
|
|
// expressions with a pointer type that are not used as references but instead
|
|
|
|
// are l-values (e.g., DeclRefExpr with a pointer type).
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Our "symbolic interpreter" is just a dispatch off the currently
|
|
|
|
// viewed AST node. We then recursively traverse the AST by calling
|
|
|
|
// EvalAddr and EvalVal appropriately.
|
|
|
|
switch (E->getStmtClass()) {
|
2009-10-24 02:54:35 +08:00
|
|
|
case Stmt::DeclRefExprClass: {
|
2007-08-18 00:46:58 +08:00
|
|
|
// DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking
|
|
|
|
// at code that refers to a variable's name. We check if it has local
|
|
|
|
// storage within the function, and if so, return the expression.
|
|
|
|
DeclRefExpr *DR = cast<DeclRefExpr>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
|
2009-09-09 23:08:12 +08:00
|
|
|
if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
|
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
case Stmt::ParenExprClass:
|
|
|
|
// Ignore parentheses.
|
|
|
|
return EvalVal(cast<ParenExpr>(E)->getSubExpr());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
case Stmt::UnaryOperatorClass: {
|
|
|
|
// The only unary operator that make sense to handle here
|
|
|
|
// is Deref. All others don't resolve to a "name." This includes
|
|
|
|
// handling all sorts of rvalues passed to a unary operator.
|
|
|
|
UnaryOperator *U = cast<UnaryOperator>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
if (U->getOpcode() == UnaryOperator::Deref)
|
|
|
|
return EvalAddr(U->getSubExpr());
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
case Stmt::ArraySubscriptExprClass: {
|
|
|
|
// Array subscripts are potential references to data on the stack. We
|
|
|
|
// retrieve the DeclRefExpr* for the array variable if it indeed
|
|
|
|
// has local storage.
|
2007-08-21 00:18:38 +08:00
|
|
|
return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase());
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
case Stmt::ConditionalOperatorClass: {
|
|
|
|
// For conditional operators we need to see if either the LHS or RHS are
|
|
|
|
// non-NULL DeclRefExpr's. If one is non-NULL, we return it.
|
|
|
|
ConditionalOperator *C = cast<ConditionalOperator>(E);
|
|
|
|
|
2007-12-01 03:04:31 +08:00
|
|
|
// Handle the GNU extension for missing LHS.
|
|
|
|
if (Expr *lhsExpr = C->getLHS())
|
|
|
|
if (DeclRefExpr *LHS = EvalVal(lhsExpr))
|
|
|
|
return LHS;
|
|
|
|
|
|
|
|
return EvalVal(C->getRHS());
|
2007-08-18 00:46:58 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Accesses to members are potential references to data on the stack.
|
2009-09-01 07:41:50 +08:00
|
|
|
case Stmt::MemberExprClass: {
|
2007-08-18 00:46:58 +08:00
|
|
|
MemberExpr *M = cast<MemberExpr>(E);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Check for indirect access. We only want direct field accesses.
|
|
|
|
if (!M->isArrow())
|
|
|
|
return EvalVal(M->getBase());
|
|
|
|
else
|
|
|
|
return NULL;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-08-18 00:46:58 +08:00
|
|
|
// Everything else: we simply don't reason about them.
|
|
|
|
default:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
2007-11-25 08:58:00 +08:00
|
|
|
|
|
|
|
//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
|
|
|
|
|
|
|
|
/// Check for comparisons of floating point operands using != and ==.
|
|
|
|
/// Issue a warning if these are no self-comparisons, as they are not likely
|
|
|
|
/// to do what the programmer intended.
|
|
|
|
void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) {
|
|
|
|
bool EmitWarning = true;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-01-18 00:57:34 +08:00
|
|
|
Expr* LeftExprSansParen = lex->IgnoreParens();
|
2008-01-18 01:55:13 +08:00
|
|
|
Expr* RightExprSansParen = rex->IgnoreParens();
|
2007-11-25 08:58:00 +08:00
|
|
|
|
|
|
|
// Special case: check for x == x (which is OK).
|
|
|
|
// Do not emit warnings for such cases.
|
|
|
|
if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
|
|
|
|
if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
|
|
|
|
if (DRL->getDecl() == DRR->getDecl())
|
|
|
|
EmitWarning = false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
|
2007-11-29 08:59:04 +08:00
|
|
|
// Special case: check for comparisons against literals that can be exactly
|
|
|
|
// represented by APFloat. In such cases, do not emit a warning. This
|
|
|
|
// is a heuristic: often comparison against such literals are used to
|
|
|
|
// detect if a value in a variable has not changed. This clearly can
|
|
|
|
// lead to false negatives.
|
|
|
|
if (EmitWarning) {
|
|
|
|
if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
|
|
|
|
if (FLL->isExact())
|
|
|
|
EmitWarning = false;
|
2009-08-05 05:02:39 +08:00
|
|
|
} else
|
2007-11-29 08:59:04 +08:00
|
|
|
if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
|
|
|
|
if (FLR->isExact())
|
|
|
|
EmitWarning = false;
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-11-25 08:58:00 +08:00
|
|
|
// Check for comparisons with builtin types.
|
2009-01-19 08:08:26 +08:00
|
|
|
if (EmitWarning)
|
2007-11-25 08:58:00 +08:00
|
|
|
if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
|
2009-02-15 02:57:46 +08:00
|
|
|
if (CL->isBuiltinCall(Context))
|
2007-11-25 08:58:00 +08:00
|
|
|
EmitWarning = false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-19 08:08:26 +08:00
|
|
|
if (EmitWarning)
|
2007-11-25 08:58:00 +08:00
|
|
|
if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
|
2009-02-15 02:57:46 +08:00
|
|
|
if (CR->isBuiltinCall(Context))
|
2007-11-25 08:58:00 +08:00
|
|
|
EmitWarning = false;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2007-11-25 08:58:00 +08:00
|
|
|
// Emit the diagnostic.
|
|
|
|
if (EmitWarning)
|
2008-11-19 13:08:23 +08:00
|
|
|
Diag(loc, diag::warn_floatingpoint_eq)
|
|
|
|
<< lex->getSourceRange() << rex->getSourceRange();
|
2007-11-25 08:58:00 +08:00
|
|
|
}
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
|
|
|
|
//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
namespace {
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
/// Structure recording the 'active' range of an integer-valued
|
|
|
|
/// expression.
|
|
|
|
struct IntRange {
|
|
|
|
/// The number of bits active in the int.
|
|
|
|
unsigned Width;
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
/// True if the int is known not to have negative values.
|
|
|
|
bool NonNegative;
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
IntRange() {}
|
|
|
|
IntRange(unsigned Width, bool NonNegative)
|
|
|
|
: Width(Width), NonNegative(NonNegative)
|
|
|
|
{}
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Returns the range of the bool type.
|
|
|
|
static IntRange forBoolType() {
|
|
|
|
return IntRange(1, true);
|
|
|
|
}
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Returns the range of an integral type.
|
|
|
|
static IntRange forType(ASTContext &C, QualType T) {
|
|
|
|
return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr());
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Returns the range of an integeral type based on its canonical
|
|
|
|
// representation.
|
|
|
|
static IntRange forCanonicalType(ASTContext &C, const Type *T) {
|
|
|
|
assert(T->isCanonicalUnqualified());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (const VectorType *VT = dyn_cast<VectorType>(T))
|
|
|
|
T = VT->getElementType().getTypePtr();
|
|
|
|
if (const ComplexType *CT = dyn_cast<ComplexType>(T))
|
|
|
|
T = CT->getElementType().getTypePtr();
|
2010-05-06 16:58:33 +08:00
|
|
|
|
|
|
|
if (const EnumType *ET = dyn_cast<EnumType>(T)) {
|
|
|
|
EnumDecl *Enum = ET->getDecl();
|
|
|
|
unsigned NumPositive = Enum->getNumPositiveBits();
|
|
|
|
unsigned NumNegative = Enum->getNumNegativeBits();
|
|
|
|
|
|
|
|
return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
|
|
|
|
}
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
const BuiltinType *BT = cast<BuiltinType>(T);
|
|
|
|
assert(BT->isInteger());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Returns the supremum of two ranges: i.e. their conservative merge.
|
2010-02-24 03:22:29 +08:00
|
|
|
static IntRange join(IntRange L, IntRange R) {
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange(std::max(L.Width, R.Width),
|
2010-01-07 06:07:33 +08:00
|
|
|
L.NonNegative && R.NonNegative);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Returns the infinum of two ranges: i.e. their aggressive merge.
|
2010-02-24 03:22:29 +08:00
|
|
|
static IntRange meet(IntRange L, IntRange R) {
|
2010-01-07 06:07:33 +08:00
|
|
|
return IntRange(std::min(L.Width, R.Width),
|
|
|
|
L.NonNegative || R.NonNegative);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
2010-01-06 13:24:50 +08:00
|
|
|
};
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) {
|
|
|
|
if (value.isSigned() && value.isNegative())
|
|
|
|
return IntRange(value.getMinSignedBits(), false);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (value.getBitWidth() > MaxWidth)
|
|
|
|
value.trunc(MaxWidth);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// isNonNegative() just checks the sign bit without considering
|
|
|
|
// signedness.
|
|
|
|
return IntRange(value.getActiveBits(), true);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-07 06:57:21 +08:00
|
|
|
IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
|
2010-01-06 13:24:50 +08:00
|
|
|
unsigned MaxWidth) {
|
|
|
|
if (result.isInt())
|
|
|
|
return GetValueRange(C, result.getInt(), MaxWidth);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (result.isVector()) {
|
2010-01-07 06:57:21 +08:00
|
|
|
IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
|
|
|
|
for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
|
|
|
|
IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
|
|
|
|
R = IntRange::join(R, El);
|
|
|
|
}
|
2010-01-06 13:24:50 +08:00
|
|
|
return R;
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (result.isComplexInt()) {
|
|
|
|
IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
|
|
|
|
IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
|
|
|
|
return IntRange::join(R, I);
|
|
|
|
}
|
|
|
|
|
|
|
|
// This can happen with lossless casts to intptr_t of "based" lvalues.
|
|
|
|
// Assume it might use arbitrary bits.
|
2010-01-07 06:57:21 +08:00
|
|
|
// FIXME: The only reason we need to pass the type in here is to get
|
|
|
|
// the sign right on this one case. It would be nice if APValue
|
|
|
|
// preserved this.
|
2010-01-06 13:24:50 +08:00
|
|
|
assert(result.isLValue());
|
2010-01-07 06:57:21 +08:00
|
|
|
return IntRange(MaxWidth, Ty->isUnsignedIntegerType());
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
/// Pseudo-evaluate the given integer expression, estimating the
|
|
|
|
/// range of values it might take.
|
|
|
|
///
|
|
|
|
/// \param MaxWidth - the width to which the value will be truncated
|
|
|
|
IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
|
2010-01-05 07:31:57 +08:00
|
|
|
E = E->IgnoreParens();
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Try a full evaluation first.
|
|
|
|
Expr::EvalResult result;
|
|
|
|
if (E->Evaluate(result, C))
|
2010-01-07 06:57:21 +08:00
|
|
|
return GetValueRange(C, result.Val, E->getType(), MaxWidth);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// I think we only want to look through implicit casts here; if the
|
|
|
|
// user has an explicit widening cast, we should treat the value as
|
|
|
|
// being of the new, wider type.
|
|
|
|
if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
|
|
|
|
if (CE->getCastKind() == CastExpr::CK_NoOp)
|
|
|
|
return GetExprRange(C, CE->getSubExpr(), MaxWidth);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
IntRange OutputTypeRange = IntRange::forType(C, CE->getType());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-07 06:07:33 +08:00
|
|
|
bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast);
|
|
|
|
if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown)
|
|
|
|
isIntegerCast = CE->getSubExpr()->getType()->isIntegerType();
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Assume that non-integer casts can span the full range of the type.
|
2010-01-07 06:07:33 +08:00
|
|
|
if (!isIntegerCast)
|
2010-01-06 13:24:50 +08:00
|
|
|
return OutputTypeRange;
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
IntRange SubRange
|
|
|
|
= GetExprRange(C, CE->getSubExpr(),
|
|
|
|
std::min(MaxWidth, OutputTypeRange.Width));
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Bail out if the subexpr's range is as wide as the cast type.
|
|
|
|
if (SubRange.Width >= OutputTypeRange.Width)
|
|
|
|
return OutputTypeRange;
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Otherwise, we take the smaller width, and we're non-negative if
|
|
|
|
// either the output type or the subexpr is.
|
|
|
|
return IntRange(SubRange.Width,
|
|
|
|
SubRange.NonNegative || OutputTypeRange.NonNegative);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
|
|
|
|
// If we can fold the condition, just take that operand.
|
|
|
|
bool CondResult;
|
|
|
|
if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
|
|
|
|
return GetExprRange(C, CondResult ? CO->getTrueExpr()
|
|
|
|
: CO->getFalseExpr(),
|
|
|
|
MaxWidth);
|
|
|
|
|
|
|
|
// Otherwise, conservatively merge.
|
|
|
|
IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
|
|
|
|
IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
|
|
|
|
return IntRange::join(L, R);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
|
|
|
|
switch (BO->getOpcode()) {
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
// Boolean-valued operations are single-bit and positive.
|
2010-01-05 07:31:57 +08:00
|
|
|
case BinaryOperator::LAnd:
|
|
|
|
case BinaryOperator::LOr:
|
|
|
|
case BinaryOperator::LT:
|
|
|
|
case BinaryOperator::GT:
|
|
|
|
case BinaryOperator::LE:
|
|
|
|
case BinaryOperator::GE:
|
|
|
|
case BinaryOperator::EQ:
|
|
|
|
case BinaryOperator::NE:
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forBoolType();
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-02-24 03:22:29 +08:00
|
|
|
// The type of these compound assignments is the type of the LHS,
|
|
|
|
// so the RHS is not necessarily an integer.
|
|
|
|
case BinaryOperator::MulAssign:
|
|
|
|
case BinaryOperator::DivAssign:
|
|
|
|
case BinaryOperator::RemAssign:
|
|
|
|
case BinaryOperator::AddAssign:
|
|
|
|
case BinaryOperator::SubAssign:
|
|
|
|
return IntRange::forType(C, E->getType());
|
|
|
|
|
2010-01-05 07:31:57 +08:00
|
|
|
// Operations with opaque sources are black-listed.
|
|
|
|
case BinaryOperator::PtrMemD:
|
|
|
|
case BinaryOperator::PtrMemI:
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forType(C, E->getType());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-07 06:07:33 +08:00
|
|
|
// Bitwise-and uses the *infinum* of the two source ranges.
|
|
|
|
case BinaryOperator::And:
|
2010-02-24 03:22:29 +08:00
|
|
|
case BinaryOperator::AndAssign:
|
2010-01-07 06:07:33 +08:00
|
|
|
return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
|
|
|
|
GetExprRange(C, BO->getRHS(), MaxWidth));
|
|
|
|
|
2010-01-05 07:31:57 +08:00
|
|
|
// Left shift gets black-listed based on a judgement call.
|
|
|
|
case BinaryOperator::Shl:
|
2010-04-07 09:14:35 +08:00
|
|
|
// ...except that we want to treat '1 << (blah)' as logically
|
|
|
|
// positive. It's an important idiom.
|
|
|
|
if (IntegerLiteral *I
|
|
|
|
= dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
|
|
|
|
if (I->getValue() == 1) {
|
|
|
|
IntRange R = IntRange::forType(C, E->getType());
|
|
|
|
return IntRange(R.Width, /*NonNegative*/ true);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// fallthrough
|
|
|
|
|
2010-02-24 03:22:29 +08:00
|
|
|
case BinaryOperator::ShlAssign:
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forType(C, E->getType());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-07 06:07:33 +08:00
|
|
|
// Right shift by a constant can narrow its left argument.
|
2010-02-24 03:22:29 +08:00
|
|
|
case BinaryOperator::Shr:
|
|
|
|
case BinaryOperator::ShrAssign: {
|
2010-01-07 06:07:33 +08:00
|
|
|
IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
|
|
|
|
|
|
|
|
// If the shift amount is a positive constant, drop the width by
|
|
|
|
// that much.
|
|
|
|
llvm::APSInt shift;
|
|
|
|
if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
|
|
|
|
shift.isNonNegative()) {
|
|
|
|
unsigned zext = shift.getZExtValue();
|
|
|
|
if (zext >= L.Width)
|
|
|
|
L.Width = (L.NonNegative ? 0 : 1);
|
|
|
|
else
|
|
|
|
L.Width -= zext;
|
|
|
|
}
|
|
|
|
|
|
|
|
return L;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Comma acts as its right operand.
|
2010-01-05 07:31:57 +08:00
|
|
|
case BinaryOperator::Comma:
|
2010-01-06 13:24:50 +08:00
|
|
|
return GetExprRange(C, BO->getRHS(), MaxWidth);
|
|
|
|
|
2010-01-07 06:07:33 +08:00
|
|
|
// Black-list pointer subtractions.
|
2010-01-05 07:31:57 +08:00
|
|
|
case BinaryOperator::Sub:
|
|
|
|
if (BO->getLHS()->getType()->isPointerType())
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forType(C, E->getType());
|
2010-01-05 07:31:57 +08:00
|
|
|
// fallthrough
|
2010-02-16 09:46:59 +08:00
|
|
|
|
2010-01-05 07:31:57 +08:00
|
|
|
default:
|
2010-01-06 13:24:50 +08:00
|
|
|
break;
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
2010-01-06 13:24:50 +08:00
|
|
|
|
|
|
|
// Treat every other operator as if it were closed on the
|
|
|
|
// narrowest type that encompasses both operands.
|
|
|
|
IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
|
|
|
|
IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
|
|
|
|
return IntRange::join(L, R);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
|
|
|
|
switch (UO->getOpcode()) {
|
|
|
|
// Boolean-valued operations are white-listed.
|
|
|
|
case UnaryOperator::LNot:
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forBoolType();
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
// Operations with opaque sources are black-listed.
|
|
|
|
case UnaryOperator::Deref:
|
|
|
|
case UnaryOperator::AddrOf: // should be impossible
|
|
|
|
case UnaryOperator::OffsetOf:
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange::forType(C, E->getType());
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
default:
|
2010-01-06 13:24:50 +08:00
|
|
|
return GetExprRange(C, UO->getSubExpr(), MaxWidth);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
}
|
Completely reimplement __builtin_offsetof, based on a patch by Roberto
Amadini.
This change introduces a new expression node type, OffsetOfExpr, that
describes __builtin_offsetof. Previously, __builtin_offsetof was
implemented using a unary operator whose subexpression involved
various synthesized array-subscript and member-reference expressions,
which was ugly and made it very hard to instantiate as a
template. OffsetOfExpr represents the AST more faithfully, with proper
type source information and a more compact representation.
OffsetOfExpr also has support for dependent __builtin_offsetof
expressions; it can be value-dependent, but will never be
type-dependent (like sizeof or alignof). This commit introduces
template instantiation for __builtin_offsetof as well.
There are two major caveats to this patch:
1) CodeGen cannot handle the case where __builtin_offsetof is not a
constant expression, so it produces an error. So, to avoid
regressing in C, we retain the old UnaryOperator-based
__builtin_offsetof implementation in C while using the shiny new
OffsetOfExpr implementation in C++. The old implementation can go
away once we have proper CodeGen support for this case, which we
expect won't cause much trouble in C++.
2) __builtin_offsetof doesn't work well with non-POD class types,
particularly when the designated field is found within a base
class. I will address this in a subsequent patch.
Fixes PR5880 and a bunch of assertions when building Boost.Python
tests.
llvm-svn: 102542
2010-04-29 06:16:22 +08:00
|
|
|
|
|
|
|
if (dyn_cast<OffsetOfExpr>(E)) {
|
|
|
|
IntRange::forType(C, E->getType());
|
|
|
|
}
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
FieldDecl *BitField = E->getBitField();
|
|
|
|
if (BitField) {
|
|
|
|
llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C);
|
|
|
|
unsigned BitWidth = BitWidthAP.getZExtValue();
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType());
|
|
|
|
}
|
|
|
|
|
|
|
|
return IntRange::forType(C, E->getType());
|
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
IntRange GetExprRange(ASTContext &C, Expr *E) {
|
|
|
|
return GetExprRange(C, E, C.getIntWidth(E->getType()));
|
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
/// Checks whether the given value, which currently has the given
|
|
|
|
/// source semantics, has the same value when coerced through the
|
|
|
|
/// target semantics.
|
|
|
|
bool IsSameFloatAfterCast(const llvm::APFloat &value,
|
|
|
|
const llvm::fltSemantics &Src,
|
|
|
|
const llvm::fltSemantics &Tgt) {
|
|
|
|
llvm::APFloat truncated = value;
|
|
|
|
|
|
|
|
bool ignored;
|
|
|
|
truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
|
|
|
|
truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
|
|
|
|
|
|
|
|
return truncated.bitwiseIsEqual(value);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
/// Checks whether the given value, which currently has the given
|
|
|
|
/// source semantics, has the same value when coerced through the
|
|
|
|
/// target semantics.
|
|
|
|
///
|
|
|
|
/// The value might be a vector of floats (or a complex number).
|
|
|
|
bool IsSameFloatAfterCast(const APValue &value,
|
|
|
|
const llvm::fltSemantics &Src,
|
|
|
|
const llvm::fltSemantics &Tgt) {
|
|
|
|
if (value.isFloat())
|
|
|
|
return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
|
|
|
|
|
|
|
|
if (value.isVector()) {
|
|
|
|
for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
|
|
|
|
if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
|
|
|
|
return false;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(value.isComplexFloat());
|
|
|
|
return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
|
|
|
|
IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
|
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
void AnalyzeImplicitConversions(Sema &S, Expr *E);
|
|
|
|
|
|
|
|
bool IsZero(Sema &S, Expr *E) {
|
|
|
|
llvm::APSInt Value;
|
|
|
|
return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
|
|
|
|
BinaryOperator::Opcode op = E->getOpcode();
|
|
|
|
if (op == BinaryOperator::LT && IsZero(S, E->getRHS())) {
|
|
|
|
S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
|
|
|
|
<< "< 0" << "false"
|
|
|
|
<< E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
|
|
|
|
} else if (op == BinaryOperator::GE && IsZero(S, E->getRHS())) {
|
|
|
|
S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
|
|
|
|
<< ">= 0" << "true"
|
|
|
|
<< E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
|
|
|
|
} else if (op == BinaryOperator::GT && IsZero(S, E->getLHS())) {
|
|
|
|
S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
|
|
|
|
<< "0 >" << "false"
|
|
|
|
<< E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
|
|
|
|
} else if (op == BinaryOperator::LE && IsZero(S, E->getLHS())) {
|
|
|
|
S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
|
|
|
|
<< "0 <=" << "true"
|
|
|
|
<< E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Analyze the operands of the given comparison. Implements the
|
|
|
|
/// fallback case from AnalyzeComparison.
|
|
|
|
void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
|
|
|
|
AnalyzeImplicitConversions(S, E->getLHS());
|
|
|
|
AnalyzeImplicitConversions(S, E->getRHS());
|
|
|
|
}
|
2010-01-06 13:24:50 +08:00
|
|
|
|
2010-01-05 07:21:16 +08:00
|
|
|
/// \brief Implements -Wsign-compare.
|
|
|
|
///
|
|
|
|
/// \param lex the left-hand expression
|
|
|
|
/// \param rex the right-hand expression
|
|
|
|
/// \param OpLoc the location of the joining operator
|
2010-03-12 03:43:18 +08:00
|
|
|
/// \param BinOpc binary opcode or 0
|
2010-05-06 16:58:33 +08:00
|
|
|
void AnalyzeComparison(Sema &S, BinaryOperator *E) {
|
|
|
|
// The type the comparison is being performed in.
|
|
|
|
QualType T = E->getLHS()->getType();
|
|
|
|
assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
|
|
|
|
&& "comparison with mismatched types");
|
|
|
|
|
|
|
|
// We don't do anything special if this isn't an unsigned integral
|
|
|
|
// comparison: we're only interested in integral comparisons, and
|
|
|
|
// signed comparisons only happen in cases we don't care to warn about.
|
|
|
|
if (!T->isUnsignedIntegerType())
|
|
|
|
return AnalyzeImpConvsInComparison(S, E);
|
|
|
|
|
|
|
|
Expr *lex = E->getLHS()->IgnoreParenImpCasts();
|
|
|
|
Expr *rex = E->getRHS()->IgnoreParenImpCasts();
|
|
|
|
|
|
|
|
// Check to see if one of the (unmodified) operands is of different
|
|
|
|
// signedness.
|
|
|
|
Expr *signedOperand, *unsignedOperand;
|
|
|
|
if (lex->getType()->isSignedIntegerType()) {
|
|
|
|
assert(!rex->getType()->isSignedIntegerType() &&
|
|
|
|
"unsigned comparison between two signed integer expressions?");
|
|
|
|
signedOperand = lex;
|
|
|
|
unsignedOperand = rex;
|
|
|
|
} else if (rex->getType()->isSignedIntegerType()) {
|
|
|
|
signedOperand = rex;
|
|
|
|
unsignedOperand = lex;
|
2010-01-05 07:21:16 +08:00
|
|
|
} else {
|
2010-05-06 16:58:33 +08:00
|
|
|
CheckTrivialUnsignedComparison(S, E);
|
|
|
|
return AnalyzeImpConvsInComparison(S, E);
|
2010-01-05 07:21:16 +08:00
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
// Otherwise, calculate the effective range of the signed operand.
|
|
|
|
IntRange signedRange = GetExprRange(S.Context, signedOperand);
|
2010-01-06 13:24:50 +08:00
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
// Go ahead and analyze implicit conversions in the operands. Note
|
|
|
|
// that we skip the implicit conversions on both sides.
|
|
|
|
AnalyzeImplicitConversions(S, lex);
|
|
|
|
AnalyzeImplicitConversions(S, rex);
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
// If the signed range is non-negative, -Wsign-compare won't fire,
|
|
|
|
// but we should still check for comparisons which are always true
|
|
|
|
// or false.
|
|
|
|
if (signedRange.NonNegative)
|
|
|
|
return CheckTrivialUnsignedComparison(S, E);
|
2010-01-05 07:21:16 +08:00
|
|
|
|
|
|
|
// For (in)equality comparisons, if the unsigned operand is a
|
|
|
|
// constant which cannot collide with a overflowed signed operand,
|
|
|
|
// then reinterpreting the signed operand as unsigned will not
|
|
|
|
// change the result of the comparison.
|
2010-05-06 16:58:33 +08:00
|
|
|
if (E->isEqualityOp()) {
|
|
|
|
unsigned comparisonWidth = S.Context.getIntWidth(T);
|
|
|
|
IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
|
|
|
|
|
|
|
|
// We should never be unable to prove that the unsigned operand is
|
|
|
|
// non-negative.
|
|
|
|
assert(unsignedRange.NonNegative && "unsigned range includes negative?");
|
2010-01-05 07:21:16 +08:00
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
if (unsignedRange.Width < comparisonWidth)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison)
|
|
|
|
<< lex->getType() << rex->getType()
|
|
|
|
<< lex->getSourceRange() << rex->getSourceRange();
|
2010-01-05 07:21:16 +08:00
|
|
|
}
|
|
|
|
|
2010-01-05 07:31:57 +08:00
|
|
|
/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
|
2010-05-06 16:58:33 +08:00
|
|
|
void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) {
|
2010-01-05 07:31:57 +08:00
|
|
|
S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange();
|
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
|
|
|
|
bool *ICContext = 0) {
|
|
|
|
if (E->isTypeDependent() || E->isValueDependent()) return;
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
|
|
|
|
const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
|
|
|
|
if (Source == Target) return;
|
|
|
|
if (Target->isDependentType()) return;
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
// Never diagnose implicit casts to bool.
|
|
|
|
if (Target->isSpecificBuiltinType(BuiltinType::Bool))
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Strip vector types.
|
|
|
|
if (isa<VectorType>(Source)) {
|
|
|
|
if (!isa<VectorType>(Target))
|
2010-05-06 16:58:33 +08:00
|
|
|
return DiagnoseImpCast(S, E, T, diag::warn_impcast_vector_scalar);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
Source = cast<VectorType>(Source)->getElementType().getTypePtr();
|
|
|
|
Target = cast<VectorType>(Target)->getElementType().getTypePtr();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Strip complex types.
|
|
|
|
if (isa<ComplexType>(Source)) {
|
|
|
|
if (!isa<ComplexType>(Target))
|
2010-05-06 16:58:33 +08:00
|
|
|
return DiagnoseImpCast(S, E, T, diag::warn_impcast_complex_scalar);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
|
|
|
|
Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
|
|
|
|
}
|
|
|
|
|
|
|
|
const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
|
|
|
|
const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
|
|
|
|
|
|
|
|
// If the source is floating point...
|
|
|
|
if (SourceBT && SourceBT->isFloatingPoint()) {
|
|
|
|
// ...and the target is floating point...
|
|
|
|
if (TargetBT && TargetBT->isFloatingPoint()) {
|
|
|
|
// ...then warn if we're dropping FP rank.
|
|
|
|
|
|
|
|
// Builtin FP kinds are ordered by increasing FP rank.
|
|
|
|
if (SourceBT->getKind() > TargetBT->getKind()) {
|
|
|
|
// Don't warn about float constants that are precisely
|
|
|
|
// representable in the target type.
|
|
|
|
Expr::EvalResult result;
|
2010-05-06 16:58:33 +08:00
|
|
|
if (E->Evaluate(result, S.Context)) {
|
2010-01-05 07:31:57 +08:00
|
|
|
// Value might be a float, a float vector, or a float complex.
|
|
|
|
if (IsSameFloatAfterCast(result.Val,
|
2010-05-06 16:58:33 +08:00
|
|
|
S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
|
|
|
|
S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
|
2010-01-05 07:31:57 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
DiagnoseImpCast(S, E, T, diag::warn_impcast_float_precision);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the target is integral, always warn.
|
|
|
|
if ((TargetBT && TargetBT->isInteger()))
|
|
|
|
// TODO: don't warn for integer values?
|
2010-05-06 16:58:33 +08:00
|
|
|
DiagnoseImpCast(S, E, T, diag::warn_impcast_float_integer);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (!Source->isIntegerType() || !Target->isIntegerType())
|
2010-01-05 07:31:57 +08:00
|
|
|
return;
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
IntRange SourceRange = GetExprRange(S.Context, E);
|
|
|
|
IntRange TargetRange = IntRange::forCanonicalType(S.Context, Target);
|
2010-01-05 07:31:57 +08:00
|
|
|
|
2010-01-06 13:24:50 +08:00
|
|
|
if (SourceRange.Width > TargetRange.Width) {
|
2010-01-05 07:31:57 +08:00
|
|
|
// People want to build with -Wshorten-64-to-32 and not -Wconversion
|
|
|
|
// and by god we'll let them.
|
2010-01-06 13:24:50 +08:00
|
|
|
if (SourceRange.Width == 64 && TargetRange.Width == 32)
|
2010-05-06 16:58:33 +08:00
|
|
|
return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_64_32);
|
|
|
|
return DiagnoseImpCast(S, E, T, diag::warn_impcast_integer_precision);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
|
|
|
|
(!TargetRange.NonNegative && SourceRange.NonNegative &&
|
|
|
|
SourceRange.Width == TargetRange.Width)) {
|
|
|
|
unsigned DiagID = diag::warn_impcast_integer_sign;
|
|
|
|
|
|
|
|
// Traditionally, gcc has warned about this under -Wsign-compare.
|
|
|
|
// We also want to warn about it in -Wconversion.
|
|
|
|
// So if -Wconversion is off, use a completely identical diagnostic
|
|
|
|
// in the sign-compare group.
|
|
|
|
// The conditional-checking code will
|
|
|
|
if (ICContext) {
|
|
|
|
DiagID = diag::warn_impcast_integer_sign_conditional;
|
|
|
|
*ICContext = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return DiagnoseImpCast(S, E, T, DiagID);
|
2010-01-05 07:31:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-05-06 16:58:33 +08:00
|
|
|
void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
|
|
|
|
|
|
|
|
void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
|
|
|
|
bool &ICContext) {
|
|
|
|
E = E->IgnoreParenImpCasts();
|
|
|
|
|
|
|
|
if (isa<ConditionalOperator>(E))
|
|
|
|
return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
|
|
|
|
|
|
|
|
AnalyzeImplicitConversions(S, E);
|
|
|
|
if (E->getType() != T)
|
|
|
|
return CheckImplicitConversion(S, E, T, &ICContext);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
|
|
|
|
AnalyzeImplicitConversions(S, E->getCond());
|
|
|
|
|
|
|
|
bool Suspicious = false;
|
|
|
|
CheckConditionalOperand(S, E->getTrueExpr(), T, Suspicious);
|
|
|
|
CheckConditionalOperand(S, E->getFalseExpr(), T, Suspicious);
|
|
|
|
|
|
|
|
// If -Wconversion would have warned about either of the candidates
|
|
|
|
// for a signedness conversion to the context type...
|
|
|
|
if (!Suspicious) return;
|
|
|
|
|
|
|
|
// ...but it's currently ignored...
|
|
|
|
if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional))
|
|
|
|
return;
|
|
|
|
|
|
|
|
// ...and -Wsign-compare isn't...
|
|
|
|
if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional))
|
|
|
|
return;
|
|
|
|
|
|
|
|
// ...then check whether it would have warned about either of the
|
|
|
|
// candidates for a signedness conversion to the condition type.
|
|
|
|
if (E->getType() != T) {
|
|
|
|
Suspicious = false;
|
|
|
|
CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
|
|
|
|
E->getType(), &Suspicious);
|
|
|
|
if (!Suspicious)
|
|
|
|
CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
|
|
|
|
E->getType(), &Suspicious);
|
|
|
|
if (!Suspicious)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If so, emit a diagnostic under -Wsign-compare.
|
|
|
|
Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts();
|
|
|
|
Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts();
|
|
|
|
S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional)
|
|
|
|
<< lex->getType() << rex->getType()
|
|
|
|
<< lex->getSourceRange() << rex->getSourceRange();
|
|
|
|
}
|
|
|
|
|
|
|
|
/// AnalyzeImplicitConversions - Find and report any interesting
|
|
|
|
/// implicit conversions in the given expression. There are a couple
|
|
|
|
/// of competing diagnostics here, -Wconversion and -Wsign-compare.
|
|
|
|
void AnalyzeImplicitConversions(Sema &S, Expr *OrigE) {
|
|
|
|
QualType T = OrigE->getType();
|
|
|
|
Expr *E = OrigE->IgnoreParenImpCasts();
|
|
|
|
|
|
|
|
// For conditional operators, we analyze the arguments as if they
|
|
|
|
// were being fed directly into the output.
|
|
|
|
if (isa<ConditionalOperator>(E)) {
|
|
|
|
ConditionalOperator *CO = cast<ConditionalOperator>(E);
|
|
|
|
CheckConditionalOperator(S, CO, T);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Go ahead and check any implicit conversions we might have skipped.
|
|
|
|
// The non-canonical typecheck is just an optimization;
|
|
|
|
// CheckImplicitConversion will filter out dead implicit conversions.
|
|
|
|
if (E->getType() != T)
|
|
|
|
CheckImplicitConversion(S, E, T);
|
|
|
|
|
|
|
|
// Now continue drilling into this expression.
|
|
|
|
|
|
|
|
// Skip past explicit casts.
|
|
|
|
if (isa<ExplicitCastExpr>(E)) {
|
|
|
|
E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
|
|
|
|
return AnalyzeImplicitConversions(S, E);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Do a somewhat different check with comparison operators.
|
|
|
|
if (isa<BinaryOperator>(E) && cast<BinaryOperator>(E)->isComparisonOp())
|
|
|
|
return AnalyzeComparison(S, cast<BinaryOperator>(E));
|
|
|
|
|
|
|
|
// These break the otherwise-useful invariant below. Fortunately,
|
|
|
|
// we don't really need to recurse into them, because any internal
|
|
|
|
// expressions should have been analyzed already when they were
|
|
|
|
// built into statements.
|
|
|
|
if (isa<StmtExpr>(E)) return;
|
|
|
|
|
|
|
|
// Don't descend into unevaluated contexts.
|
|
|
|
if (isa<SizeOfAlignOfExpr>(E)) return;
|
|
|
|
|
|
|
|
// Now just recurse over the expression's children.
|
|
|
|
for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end();
|
|
|
|
I != IE; ++I)
|
|
|
|
AnalyzeImplicitConversions(S, cast<Expr>(*I));
|
|
|
|
}
|
|
|
|
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
/// Diagnoses "dangerous" implicit conversions within the given
|
|
|
|
/// expression (which is a full expression). Implements -Wconversion
|
|
|
|
/// and -Wsign-compare.
|
|
|
|
void Sema::CheckImplicitConversions(Expr *E) {
|
|
|
|
// Don't diagnose in unevaluated contexts.
|
|
|
|
if (ExprEvalContexts.back().Context == Sema::Unevaluated)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Don't diagnose for value- or type-dependent expressions.
|
|
|
|
if (E->isTypeDependent() || E->isValueDependent())
|
|
|
|
return;
|
|
|
|
|
|
|
|
AnalyzeImplicitConversions(*this, E);
|
|
|
|
}
|
|
|
|
|
2010-01-21 11:59:47 +08:00
|
|
|
/// CheckParmsForFunctionDef - Check that the parameters of the given
|
|
|
|
/// function are appropriate for the definition of a function. This
|
|
|
|
/// takes care of any checks that cannot be performed on the
|
|
|
|
/// declaration itself, e.g., that the types of each of the function
|
|
|
|
/// parameters are complete.
|
|
|
|
bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) {
|
|
|
|
bool HasInvalidParm = false;
|
|
|
|
for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) {
|
|
|
|
ParmVarDecl *Param = FD->getParamDecl(p);
|
|
|
|
|
|
|
|
// C99 6.7.5.3p4: the parameters in a parameter type list in a
|
|
|
|
// function declarator that is part of a function definition of
|
|
|
|
// that function shall not have incomplete type.
|
|
|
|
//
|
|
|
|
// This is also C++ [dcl.fct]p6.
|
|
|
|
if (!Param->isInvalidDecl() &&
|
|
|
|
RequireCompleteType(Param->getLocation(), Param->getType(),
|
|
|
|
diag::err_typecheck_decl_incomplete_type)) {
|
|
|
|
Param->setInvalidDecl();
|
|
|
|
HasInvalidParm = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// C99 6.9.1p5: If the declarator includes a parameter type list, the
|
|
|
|
// declaration of each parameter shall include an identifier.
|
|
|
|
if (Param->getIdentifier() == 0 &&
|
|
|
|
!Param->isImplicit() &&
|
|
|
|
!getLangOptions().CPlusPlus)
|
|
|
|
Diag(Param->getLocation(), diag::err_parameter_name_omitted);
|
2010-02-01 13:02:49 +08:00
|
|
|
|
|
|
|
// C99 6.7.5.3p12:
|
|
|
|
// If the function declarator is not part of a definition of that
|
|
|
|
// function, parameters may have incomplete type and may use the [*]
|
|
|
|
// notation in their sequences of declarator specifiers to specify
|
|
|
|
// variable length array types.
|
|
|
|
QualType PType = Param->getOriginalType();
|
|
|
|
if (const ArrayType *AT = Context.getAsArrayType(PType)) {
|
|
|
|
if (AT->getSizeModifier() == ArrayType::Star) {
|
|
|
|
// FIXME: This diagnosic should point the the '[*]' if source-location
|
|
|
|
// information is added for it.
|
|
|
|
Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
|
|
|
|
}
|
|
|
|
}
|
2010-01-21 11:59:47 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return HasInvalidParm;
|
|
|
|
}
|