2017-08-28 19:12:05 +08:00
|
|
|
//===- unittest/Tooling/RefactoringTestActionRulesTest.cpp ----------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "ReplacementTest.h"
|
|
|
|
#include "RewriterTestContext.h"
|
|
|
|
#include "clang/Tooling/Refactoring.h"
|
2017-10-28 02:19:11 +08:00
|
|
|
#include "clang/Tooling/Refactoring/Extract/Extract.h"
|
|
|
|
#include "clang/Tooling/Refactoring/RefactoringAction.h"
|
2017-10-17 02:28:26 +08:00
|
|
|
#include "clang/Tooling/Refactoring/RefactoringDiagnostic.h"
|
2017-09-12 20:48:37 +08:00
|
|
|
#include "clang/Tooling/Refactoring/Rename/SymbolName.h"
|
2017-08-28 19:12:05 +08:00
|
|
|
#include "clang/Tooling/Tooling.h"
|
|
|
|
#include "llvm/Support/Errc.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
|
|
|
|
using namespace clang;
|
|
|
|
using namespace tooling;
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
class RefactoringActionRulesTest : public ::testing::Test {
|
|
|
|
protected:
|
|
|
|
void SetUp() override {
|
|
|
|
Context.Sources.setMainFileID(
|
|
|
|
Context.createInMemoryFile("input.cpp", DefaultCode));
|
|
|
|
}
|
|
|
|
|
|
|
|
RewriterTestContext Context;
|
|
|
|
std::string DefaultCode = std::string(100, 'a');
|
|
|
|
};
|
|
|
|
|
2017-09-01 17:16:02 +08:00
|
|
|
Expected<AtomicChanges>
|
2017-08-28 19:12:05 +08:00
|
|
|
createReplacements(const std::unique_ptr<RefactoringActionRule> &Rule,
|
|
|
|
RefactoringRuleContext &Context) {
|
2017-09-01 17:16:02 +08:00
|
|
|
class Consumer final : public RefactoringResultConsumer {
|
|
|
|
void handleError(llvm::Error Err) override { Result = std::move(Err); }
|
|
|
|
|
|
|
|
void handle(AtomicChanges SourceReplacements) override {
|
|
|
|
Result = std::move(SourceReplacements);
|
|
|
|
}
|
2017-09-12 21:03:42 +08:00
|
|
|
void handle(SymbolOccurrences Occurrences) override {
|
|
|
|
RefactoringResultConsumer::handle(std::move(Occurrences));
|
|
|
|
}
|
2017-09-01 17:16:02 +08:00
|
|
|
|
|
|
|
public:
|
|
|
|
Optional<Expected<AtomicChanges>> Result;
|
|
|
|
};
|
|
|
|
|
|
|
|
Consumer C;
|
|
|
|
Rule->invoke(C, Context);
|
|
|
|
return std::move(*C.Result);
|
2017-08-28 19:12:05 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(RefactoringActionRulesTest, MyFirstRefactoringRule) {
|
2017-10-03 02:42:43 +08:00
|
|
|
class ReplaceAWithB : public SourceChangeRefactoringRule {
|
|
|
|
std::pair<SourceRange, int> Selection;
|
|
|
|
|
|
|
|
public:
|
|
|
|
ReplaceAWithB(std::pair<SourceRange, int> Selection)
|
|
|
|
: Selection(Selection) {}
|
|
|
|
|
2017-10-28 02:19:11 +08:00
|
|
|
static Expected<ReplaceAWithB>
|
|
|
|
initiate(RefactoringRuleContext &Cotnext,
|
|
|
|
std::pair<SourceRange, int> Selection) {
|
|
|
|
return ReplaceAWithB(Selection);
|
|
|
|
}
|
|
|
|
|
2017-10-03 02:42:43 +08:00
|
|
|
Expected<AtomicChanges>
|
|
|
|
createSourceReplacements(RefactoringRuleContext &Context) {
|
|
|
|
const SourceManager &SM = Context.getSources();
|
|
|
|
SourceLocation Loc =
|
|
|
|
Selection.first.getBegin().getLocWithOffset(Selection.second);
|
|
|
|
AtomicChange Change(SM, Loc);
|
|
|
|
llvm::Error E = Change.replace(SM, Loc, 1, "b");
|
|
|
|
if (E)
|
|
|
|
return std::move(E);
|
|
|
|
return AtomicChanges{Change};
|
|
|
|
}
|
2017-08-28 19:12:05 +08:00
|
|
|
};
|
2017-10-03 02:42:43 +08:00
|
|
|
|
|
|
|
class SelectionRequirement : public SourceRangeSelectionRequirement {
|
2017-08-28 19:12:05 +08:00
|
|
|
public:
|
2017-10-03 02:42:43 +08:00
|
|
|
Expected<std::pair<SourceRange, int>>
|
|
|
|
evaluate(RefactoringRuleContext &Context) const {
|
|
|
|
Expected<SourceRange> R =
|
|
|
|
SourceRangeSelectionRequirement::evaluate(Context);
|
|
|
|
if (!R)
|
|
|
|
return R.takeError();
|
|
|
|
return std::make_pair(*R, 20);
|
2017-08-28 19:12:05 +08:00
|
|
|
}
|
|
|
|
};
|
2017-10-03 02:42:43 +08:00
|
|
|
auto Rule =
|
|
|
|
createRefactoringActionRule<ReplaceAWithB>(SelectionRequirement());
|
2017-08-28 19:12:05 +08:00
|
|
|
|
2018-02-06 21:12:29 +08:00
|
|
|
// When the requirements are satisfied, the rule's function must be invoked.
|
2017-08-28 19:12:05 +08:00
|
|
|
{
|
|
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
|
|
SourceLocation Cursor =
|
|
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID())
|
|
|
|
.getLocWithOffset(10);
|
|
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
|
|
|
|
2017-09-01 17:16:02 +08:00
|
|
|
Expected<AtomicChanges> ErrorOrResult =
|
2017-08-28 19:12:05 +08:00
|
|
|
createReplacements(Rule, RefContext);
|
|
|
|
ASSERT_FALSE(!ErrorOrResult);
|
2017-09-01 17:16:02 +08:00
|
|
|
AtomicChanges Result = std::move(*ErrorOrResult);
|
2017-08-28 19:12:05 +08:00
|
|
|
ASSERT_EQ(Result.size(), 1u);
|
|
|
|
std::string YAMLString =
|
|
|
|
const_cast<AtomicChange &>(Result[0]).toYAMLString();
|
|
|
|
|
|
|
|
ASSERT_STREQ("---\n"
|
|
|
|
"Key: 'input.cpp:30'\n"
|
|
|
|
"FilePath: input.cpp\n"
|
|
|
|
"Error: ''\n"
|
|
|
|
"InsertedHeaders: \n"
|
|
|
|
"RemovedHeaders: \n"
|
|
|
|
"Replacements: \n" // Extra whitespace here!
|
|
|
|
" - FilePath: input.cpp\n"
|
|
|
|
" Offset: 30\n"
|
|
|
|
" Length: 1\n"
|
|
|
|
" ReplacementText: b\n"
|
|
|
|
"...\n",
|
|
|
|
YAMLString.c_str());
|
|
|
|
}
|
|
|
|
|
2017-09-01 17:16:02 +08:00
|
|
|
// When one of the requirements is not satisfied, invoke should return a
|
|
|
|
// valid error.
|
2017-08-28 19:12:05 +08:00
|
|
|
{
|
|
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
2017-09-01 17:16:02 +08:00
|
|
|
Expected<AtomicChanges> ErrorOrResult =
|
2017-08-28 19:12:05 +08:00
|
|
|
createReplacements(Rule, RefContext);
|
|
|
|
|
2017-09-01 17:16:02 +08:00
|
|
|
ASSERT_TRUE(!ErrorOrResult);
|
2017-10-17 02:28:26 +08:00
|
|
|
unsigned DiagID;
|
|
|
|
llvm::handleAllErrors(ErrorOrResult.takeError(),
|
|
|
|
[&](DiagnosticError &Error) {
|
|
|
|
DiagID = Error.getDiagnostic().second.getDiagID();
|
|
|
|
});
|
|
|
|
EXPECT_EQ(DiagID, diag::err_refactor_no_selection);
|
2017-08-28 19:12:05 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(RefactoringActionRulesTest, ReturnError) {
|
2017-10-03 02:42:43 +08:00
|
|
|
class ErrorRule : public SourceChangeRefactoringRule {
|
2017-08-28 19:12:05 +08:00
|
|
|
public:
|
2017-10-28 02:19:11 +08:00
|
|
|
static Expected<ErrorRule> initiate(RefactoringRuleContext &,
|
|
|
|
SourceRange R) {
|
|
|
|
return ErrorRule(R);
|
|
|
|
}
|
|
|
|
|
2017-10-03 02:42:43 +08:00
|
|
|
ErrorRule(SourceRange R) {}
|
|
|
|
Expected<AtomicChanges> createSourceReplacements(RefactoringRuleContext &) {
|
2017-08-28 19:12:05 +08:00
|
|
|
return llvm::make_error<llvm::StringError>(
|
2017-10-03 02:42:43 +08:00
|
|
|
"Error", llvm::make_error_code(llvm::errc::invalid_argument));
|
2017-08-28 19:12:05 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2017-10-03 02:42:43 +08:00
|
|
|
auto Rule =
|
|
|
|
createRefactoringActionRule<ErrorRule>(SourceRangeSelectionRequirement());
|
|
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
2017-08-28 19:12:05 +08:00
|
|
|
SourceLocation Cursor =
|
|
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID());
|
|
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
2017-09-01 17:16:02 +08:00
|
|
|
Expected<AtomicChanges> Result = createReplacements(Rule, RefContext);
|
2017-08-28 19:12:05 +08:00
|
|
|
|
|
|
|
ASSERT_TRUE(!Result);
|
|
|
|
std::string Message;
|
|
|
|
llvm::handleAllErrors(Result.takeError(), [&](llvm::StringError &Error) {
|
|
|
|
Message = Error.getMessage();
|
|
|
|
});
|
2017-10-03 02:42:43 +08:00
|
|
|
EXPECT_EQ(Message, "Error");
|
2017-08-28 19:12:05 +08:00
|
|
|
}
|
|
|
|
|
2017-09-12 20:48:37 +08:00
|
|
|
Optional<SymbolOccurrences> findOccurrences(RefactoringActionRule &Rule,
|
|
|
|
RefactoringRuleContext &Context) {
|
|
|
|
class Consumer final : public RefactoringResultConsumer {
|
|
|
|
void handleError(llvm::Error) override {}
|
|
|
|
void handle(SymbolOccurrences Occurrences) override {
|
|
|
|
Result = std::move(Occurrences);
|
|
|
|
}
|
2017-09-12 21:03:42 +08:00
|
|
|
void handle(AtomicChanges Changes) override {
|
|
|
|
RefactoringResultConsumer::handle(std::move(Changes));
|
|
|
|
}
|
2017-09-12 20:48:37 +08:00
|
|
|
|
|
|
|
public:
|
|
|
|
Optional<SymbolOccurrences> Result;
|
|
|
|
};
|
|
|
|
|
|
|
|
Consumer C;
|
|
|
|
Rule.invoke(C, Context);
|
|
|
|
return std::move(C.Result);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(RefactoringActionRulesTest, ReturnSymbolOccurrences) {
|
2017-10-03 02:42:43 +08:00
|
|
|
class FindOccurrences : public FindSymbolOccurrencesRefactoringRule {
|
|
|
|
SourceRange Selection;
|
|
|
|
|
|
|
|
public:
|
|
|
|
FindOccurrences(SourceRange Selection) : Selection(Selection) {}
|
|
|
|
|
2017-10-28 02:19:11 +08:00
|
|
|
static Expected<FindOccurrences> initiate(RefactoringRuleContext &,
|
|
|
|
SourceRange Selection) {
|
|
|
|
return FindOccurrences(Selection);
|
|
|
|
}
|
|
|
|
|
2017-10-03 02:42:43 +08:00
|
|
|
Expected<SymbolOccurrences>
|
|
|
|
findSymbolOccurrences(RefactoringRuleContext &) override {
|
|
|
|
SymbolOccurrences Occurrences;
|
|
|
|
Occurrences.push_back(SymbolOccurrence(SymbolName("test"),
|
|
|
|
SymbolOccurrence::MatchingSymbol,
|
|
|
|
Selection.getBegin()));
|
2017-10-03 03:02:42 +08:00
|
|
|
return std::move(Occurrences);
|
2017-10-03 02:42:43 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
auto Rule = createRefactoringActionRule<FindOccurrences>(
|
|
|
|
SourceRangeSelectionRequirement());
|
2017-09-12 20:48:37 +08:00
|
|
|
|
|
|
|
RefactoringRuleContext RefContext(Context.Sources);
|
|
|
|
SourceLocation Cursor =
|
|
|
|
Context.Sources.getLocForStartOfFile(Context.Sources.getMainFileID());
|
|
|
|
RefContext.setSelectionRange({Cursor, Cursor});
|
|
|
|
Optional<SymbolOccurrences> Result = findOccurrences(*Rule, RefContext);
|
|
|
|
|
|
|
|
ASSERT_FALSE(!Result);
|
|
|
|
SymbolOccurrences Occurrences = std::move(*Result);
|
|
|
|
EXPECT_EQ(Occurrences.size(), 1u);
|
|
|
|
EXPECT_EQ(Occurrences[0].getKind(), SymbolOccurrence::MatchingSymbol);
|
|
|
|
EXPECT_EQ(Occurrences[0].getNameRanges().size(), 1u);
|
|
|
|
EXPECT_EQ(Occurrences[0].getNameRanges()[0],
|
|
|
|
SourceRange(Cursor, Cursor.getLocWithOffset(strlen("test"))));
|
|
|
|
}
|
|
|
|
|
2017-10-28 02:19:11 +08:00
|
|
|
TEST_F(RefactoringActionRulesTest, EditorCommandBinding) {
|
|
|
|
const RefactoringDescriptor &Descriptor = ExtractFunction::describe();
|
|
|
|
EXPECT_EQ(Descriptor.Name, "extract-function");
|
|
|
|
EXPECT_EQ(
|
|
|
|
Descriptor.Description,
|
|
|
|
"(WIP action; use with caution!) Extracts code into a new function");
|
|
|
|
EXPECT_EQ(Descriptor.Title, "Extract Function");
|
|
|
|
}
|
|
|
|
|
2017-08-28 19:12:05 +08:00
|
|
|
} // end anonymous namespace
|