maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Verifier/invalid-eh.ll

186 lines
6.5 KiB
LLVM
Raw Normal View History

[IR] Reformulate LLVM's EH funclet IR While we have successfully implemented a funclet-oriented EH scheme on top of LLVM IR, our scheme has some notable deficiencies: - catchendpad and cleanupendpad are necessary in the current design but they are difficult to explain to others, even to seasoned LLVM experts. - catchendpad and cleanupendpad are optimization barriers. They cannot be split and force all potentially throwing call-sites to be invokes. This has a noticable effect on the quality of our code generation. - catchpad, while similar in some aspects to invoke, is fairly awkward. It is unsplittable, starts a funclet, and has control flow to other funclets. - The nesting relationship between funclets is currently a property of control flow edges. Because of this, we are forced to carefully analyze the flow graph to see if there might potentially exist illegal nesting among funclets. While we have logic to clone funclets when they are illegally nested, it would be nicer if we had a representation which forbade them upfront. Let's clean this up a bit by doing the following: - Instead, make catchpad more like cleanuppad and landingpad: no control flow, just a bunch of simple operands; catchpad would be splittable. - Introduce catchswitch, a control flow instruction designed to model the constraints of funclet oriented EH. - Make funclet scoping explicit by having funclet instructions consume the token produced by the funclet which contains them. - Remove catchendpad and cleanupendpad. Their presence can be inferred implicitly using coloring information. N.B. The state numbering code for the CLR has been updated but the veracity of it's output cannot be spoken for. An expert should take a look to make sure the results are reasonable. Reviewers: rnk, JosephTremoulet, andrew.w.kaylor Differential Revision: http://reviews.llvm.org/D15139 llvm-svn: 255422
2015-12-12 13:38:55 +08:00
; RUN: sed -e s/.T1:// %s | not llvm-as -disable-output 2>&1 | FileCheck --check-prefix=CHECK1 %s
; RUN: sed -e s/.T2:// %s | not llvm-as -disable-output 2>&1 | FileCheck --check-prefix=CHECK2 %s
; RUN: sed -e s/.T3:// %s | not llvm-as -disable-output 2>&1 | FileCheck --check-prefix=CHECK3 %s
; RUN: sed -e s/.T4:// %s | not llvm-as -disable-output 2>&1 | FileCheck --check-prefix=CHECK4 %s
[WinEH] Tighten parentPad verifier checks Summary: A catchswitch cannot be a parent of a cleanuppad or another catchswitch. Reviewers: rnk, andrew.w.kaylor, majnemer Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15841 llvm-svn: 256690
2016-01-02 23:24:24 +08:00
; RUN: sed -e s/.T5:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK5 %s
; RUN: sed -e s/.T6:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK6 %s
; RUN: sed -e s/.T7:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK7 %s
[WinEH] Verify catchswitch handlers Summary: The handler list must be nonempty and consist solely of CatchPads. Reviewers: rnk, andrew.w.kaylor, majnemer Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15842 llvm-svn: 256691
2016-01-02 23:25:25 +08:00
; RUN: sed -e s/.T8:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK8 %s
[WinEH] Verify unwind edges against EH pad tree Summary: Funclet EH personalities require a tree-like nesting among funclets (enforced by the ParentPad linkage in the IR), and also require that unwind edges conform to certain rules with respect to the tree: - An unwind edge may exit 0 or more ancestor pads - An unwind edge must enter exactly one EH pad, which must be distinct from any exited pads - A cleanupret's edge must exit its cleanuppad Describe these rules in the LangRef, and enforce them in the verifier. Reviewers: rnk, majnemer, andrew.w.kaylor Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15961 llvm-svn: 257272
2016-01-10 12:28:38 +08:00
; RUN: sed -e s/.T9:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK9 %s
; RUN: sed -e s/.T10:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK10 %s
; RUN: sed -e s/.T11:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK11 %s
; RUN: sed -e s/.T12:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK12 %s
; RUN: sed -e s/.T13:// %s | not opt -verify -disable-output 2>&1 | FileCheck --check-prefix=CHECK13 %s
[WinEH] Tighten parentPad verifier checks Summary: A catchswitch cannot be a parent of a cleanuppad or another catchswitch. Reviewers: rnk, andrew.w.kaylor, majnemer Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15841 llvm-svn: 256690
2016-01-02 23:24:24 +08:00
declare void @g()
[IR] Reformulate LLVM's EH funclet IR While we have successfully implemented a funclet-oriented EH scheme on top of LLVM IR, our scheme has some notable deficiencies: - catchendpad and cleanupendpad are necessary in the current design but they are difficult to explain to others, even to seasoned LLVM experts. - catchendpad and cleanupendpad are optimization barriers. They cannot be split and force all potentially throwing call-sites to be invokes. This has a noticable effect on the quality of our code generation. - catchpad, while similar in some aspects to invoke, is fairly awkward. It is unsplittable, starts a funclet, and has control flow to other funclets. - The nesting relationship between funclets is currently a property of control flow edges. Because of this, we are forced to carefully analyze the flow graph to see if there might potentially exist illegal nesting among funclets. While we have logic to clone funclets when they are illegally nested, it would be nicer if we had a representation which forbade them upfront. Let's clean this up a bit by doing the following: - Instead, make catchpad more like cleanuppad and landingpad: no control flow, just a bunch of simple operands; catchpad would be splittable. - Introduce catchswitch, a control flow instruction designed to model the constraints of funclet oriented EH. - Make funclet scoping explicit by having funclet instructions consume the token produced by the funclet which contains them. - Remove catchendpad and cleanupendpad. Their presence can be inferred implicitly using coloring information. N.B. The state numbering code for the CLR has been updated but the veracity of it's output cannot be spoken for. An expert should take a look to make sure the results are reasonable. Reviewers: rnk, JosephTremoulet, andrew.w.kaylor Differential Revision: http://reviews.llvm.org/D15139 llvm-svn: 255422
2015-12-12 13:38:55 +08:00
;T1: define void @f() {
;T1: entry:
;T1: catchret from undef to label %next
;T1: ; CHECK1: CatchReturnInst needs to be provided a CatchPad
;T1: next:
;T1: unreachable
;T1: }
;T2: define void @f() {
;T2: entry:
;T2: %x = cleanuppad within none []
;T2: ; catchret's first operand's operator must be catchpad
;T2: catchret from %x to label %entry
;T2: ; CHECK2: CatchReturnInst needs to be provided a CatchPad
;T2: }
;T3: define void @f() {
;T3: entry:
;T3: cleanupret from undef unwind label %next
;T3: ; CHECK3: CleanupReturnInst needs to be provided a CleanupPad
;T3: next:
;T3: unreachable
;T3: }
;T4: define void @f() {
;T4: entry:
;T4: %cs = catchswitch within none [label %next] unwind to caller
;T4: next:
;T4: %x = catchpad within %cs []
;T4: ; cleanupret first operand's operator must be cleanuppad
;T4: cleanupret from %x unwind to caller
;T4: ; CHECK4: CleanupReturnInst needs to be provided a CleanupPad
;T4: }
[WinEH] Tighten parentPad verifier checks Summary: A catchswitch cannot be a parent of a cleanuppad or another catchswitch. Reviewers: rnk, andrew.w.kaylor, majnemer Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15841 llvm-svn: 256690
2016-01-02 23:24:24 +08:00
;T5: define void @f() personality void ()* @g {
;T5: entry:
;T5: ret void
;T5: switch:
;T5: %cs = catchswitch within none [label %catch] unwind to caller
;T5: catch:
;T5: catchpad within %cs []
;T5: unreachable
;T5: bogus:
;T5: cleanuppad within %cs []
;T5: ; CHECK5: CleanupPadInst has an invalid parent
;T5: unreachable
;T5: }
;T6: define void @f() personality void ()* @g {
;T6: entry:
;T6: ret void
;T6: switch1:
;T6: %cs1 = catchswitch within none [label %catch1] unwind label %catch2
;T6: ; CHECK6: Block containg CatchPadInst must be jumped to only by its catchswitch
;T6: catch1:
;T6: catchpad within %cs1 []
;T6: unreachable
;T6: switch2:
;T6: %cs2 = catchswitch within none [label %catch2] unwind to caller
;T6: catch2:
;T6: catchpad within %cs2 []
;T6: unreachable
;T6: }
;T7: define void @f() personality void ()* @g {
;T7: entry:
;T7: ret void
;T7: switch1:
;T7: %cs1 = catchswitch within none [label %catch1] unwind to caller
;T7: catch1:
;T7: catchpad within %cs1 []
;T7: unreachable
;T7: switch2:
;T7: %cs2 = catchswitch within %cs1 [label %catch2] unwind to caller
;T7: ; CHECK7: CatchSwitchInst has an invalid parent
;T7: catch2:
;T7: catchpad within %cs2 []
;T7: unreachable
;T7: }
[WinEH] Verify catchswitch handlers Summary: The handler list must be nonempty and consist solely of CatchPads. Reviewers: rnk, andrew.w.kaylor, majnemer Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15842 llvm-svn: 256691
2016-01-02 23:25:25 +08:00
;T8: define void @f() personality void ()* @g {
;T8: entry:
;T8: ret void
;T8: switch1:
;T8: %cs1 = catchswitch within none [ label %switch1 ] unwind to caller
;T8: ; CHECK8: CatchSwitchInst handlers must be catchpads
;T8: }
[WinEH] Verify unwind edges against EH pad tree Summary: Funclet EH personalities require a tree-like nesting among funclets (enforced by the ParentPad linkage in the IR), and also require that unwind edges conform to certain rules with respect to the tree: - An unwind edge may exit 0 or more ancestor pads - An unwind edge must enter exactly one EH pad, which must be distinct from any exited pads - A cleanupret's edge must exit its cleanuppad Describe these rules in the LangRef, and enforce them in the verifier. Reviewers: rnk, majnemer, andrew.w.kaylor Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D15961 llvm-svn: 257272
2016-01-10 12:28:38 +08:00
;T9: define void @f() personality void ()* @g {
;T9: entry:
;T9: ret void
;T9: cleanup:
;T9: %cp = cleanuppad within none []
;T9: invoke void @g() [ "funclet"(token %cp) ]
;T9: to label %exit unwind label %cleanup
;T9: ; CHECK9: EH pad cannot handle exceptions raised within it
;T9: ; CHECK9-NEXT: %cp = cleanuppad within none []
;T9: ; CHECK9-NEXT: invoke void @g() [ "funclet"(token %cp) ]
;T9: exit:
;T9: ret void
;T9: }
;T10: define void @f() personality void ()* @g {
;T10: entry:
;T10: ret void
;T10: cleanup1:
;T10: %cp1 = cleanuppad within none []
;T10: unreachable
;T10: switch:
;T10: %cs = catchswitch within %cp1 [label %catch] unwind to caller
;T10: catch:
;T10: %catchp1 = catchpad within %cs [i32 1]
;T10: unreachable
;T10: cleanup2:
;T10: %cp2 = cleanuppad within %catchp1 []
;T10: unreachable
;T10: cleanup3:
;T10: %cp3 = cleanuppad within %cp2 []
;T10: cleanupret from %cp3 unwind label %switch
;T10: ; CHECK10: EH pad cannot handle exceptions raised within it
;T10: ; CHECK10-NEXT: %cs = catchswitch within %cp1 [label %catch] unwind to caller
;T10: ; CHECK10-NEXT: cleanupret from %cp3 unwind label %switch
;T10: }
;T11: define void @f() personality void ()* @g {
;T11: entry:
;T11: ret void
;T11: cleanup1:
;T11: %cp1 = cleanuppad within none []
;T11: unreachable
;T11: cleanup2:
;T11: %cp2 = cleanuppad within %cp1 []
;T11: unreachable
;T11: switch:
;T11: %cs = catchswitch within none [label %catch] unwind label %cleanup2
;T11: ; CHECK11: A single unwind edge may only enter one EH pad
;T11: ; CHECK11-NEXT: %cs = catchswitch within none [label %catch] unwind label %cleanup2
;T11: catch:
;T11: catchpad within %cs [i32 1]
;T11: unreachable
;T11: }
;T12: define void @f() personality void ()* @g {
;T12: entry:
;T12: ret void
;T12: cleanup:
;T12: %cp = cleanuppad within none []
;T12: cleanupret from %cp unwind label %switch
;T12: ; CHECK12: A cleanupret must exit its cleanup
;T12: ; CHECK12-NEXT: cleanupret from %cp unwind label %switch
;T12: switch:
;T12: %cs = catchswitch within %cp [label %catch] unwind to caller
;T12: catch:
;T12: catchpad within %cs [i32 1]
;T12: unreachable
;T12: }
;T13: define void @f() personality void ()* @g {
;T13: entry:
;T13: ret void
;T13: switch:
;T13: %cs = catchswitch within none [label %catch] unwind label %switch
;T13: ; CHECK13: EH pad cannot handle exceptions raised within it
;T13: ; CHECK13-NEXT: %cs = catchswitch within none [label %catch] unwind label %switch
;T13: catch:
;T13: catchpad within %cs [i32 0]
;T13: unreachable
;T13: }