2016-09-29 09:44:16 +08:00
|
|
|
//===-- SIOptimizeExecMasking.cpp -----------------------------------------===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2016-09-29 09:44:16 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "AMDGPU.h"
|
|
|
|
#include "AMDGPUSubtarget.h"
|
|
|
|
#include "SIInstrInfo.h"
|
AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers
Summary:
MCTargetDesc/AMDGPUMCTargetDesc.h contains enums for all the instuction
and register defintions, which are huge so we only want to include
them where needed.
This will also make it easier if we want to split the R600 and GCN
definitions into separate tablegenerated files.
I was unable to remove AMDGPUMCTargetDesc.h from SIMachineFunctionInfo.h
because it uses some enums from the header to initialize default values
for the SIMachineFunction class, so I ended up having to remove includes of
SIMachineFunctionInfo.h from headers too.
Reviewers: arsenm, nhaehnle
Reviewed By: nhaehnle
Subscribers: MatzeB, kzhuravl, wdng, yaxunl, dstuttard, tpr, t-tye, javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D46272
llvm-svn: 332930
2018-05-22 10:03:23 +08:00
|
|
|
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
|
2017-11-14 10:16:54 +08:00
|
|
|
#include "llvm/ADT/SmallSet.h"
|
2016-09-29 09:44:16 +08:00
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "si-optimize-exec-masking"
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
class SIOptimizeExecMasking : public MachineFunctionPass {
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
public:
|
|
|
|
SIOptimizeExecMasking() : MachineFunctionPass(ID) {
|
|
|
|
initializeSIOptimizeExecMaskingPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
|
2016-10-01 10:56:57 +08:00
|
|
|
StringRef getPassName() const override {
|
2016-09-29 09:44:16 +08:00
|
|
|
return "SI optimize exec mask operations";
|
|
|
|
}
|
|
|
|
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
|
|
AU.setPreservesCFG();
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
} // End anonymous namespace.
|
|
|
|
|
|
|
|
INITIALIZE_PASS_BEGIN(SIOptimizeExecMasking, DEBUG_TYPE,
|
|
|
|
"SI optimize exec mask operations", false, false)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(LiveIntervals)
|
|
|
|
INITIALIZE_PASS_END(SIOptimizeExecMasking, DEBUG_TYPE,
|
|
|
|
"SI optimize exec mask operations", false, false)
|
|
|
|
|
|
|
|
char SIOptimizeExecMasking::ID = 0;
|
|
|
|
|
|
|
|
char &llvm::SIOptimizeExecMaskingID = SIOptimizeExecMasking::ID;
|
|
|
|
|
|
|
|
/// If \p MI is a copy from exec, return the register copied to.
|
|
|
|
static unsigned isCopyFromExec(const MachineInstr &MI) {
|
|
|
|
switch (MI.getOpcode()) {
|
|
|
|
case AMDGPU::COPY:
|
|
|
|
case AMDGPU::S_MOV_B64:
|
|
|
|
case AMDGPU::S_MOV_B64_term: {
|
|
|
|
const MachineOperand &Src = MI.getOperand(1);
|
|
|
|
if (Src.isReg() && Src.getReg() == AMDGPU::EXEC)
|
|
|
|
return MI.getOperand(0).getReg();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return AMDGPU::NoRegister;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// If \p MI is a copy to exec, return the register copied from.
|
|
|
|
static unsigned isCopyToExec(const MachineInstr &MI) {
|
|
|
|
switch (MI.getOpcode()) {
|
|
|
|
case AMDGPU::COPY:
|
|
|
|
case AMDGPU::S_MOV_B64: {
|
|
|
|
const MachineOperand &Dst = MI.getOperand(0);
|
2018-04-23 21:05:50 +08:00
|
|
|
if (Dst.isReg() && Dst.getReg() == AMDGPU::EXEC && MI.getOperand(1).isReg())
|
2016-09-29 09:44:16 +08:00
|
|
|
return MI.getOperand(1).getReg();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case AMDGPU::S_MOV_B64_term:
|
|
|
|
llvm_unreachable("should have been replaced");
|
|
|
|
}
|
|
|
|
|
|
|
|
return AMDGPU::NoRegister;
|
|
|
|
}
|
|
|
|
|
2017-08-02 07:44:35 +08:00
|
|
|
/// If \p MI is a logical operation on an exec value,
|
|
|
|
/// return the register copied to.
|
|
|
|
static unsigned isLogicalOpOnExec(const MachineInstr &MI) {
|
|
|
|
switch (MI.getOpcode()) {
|
|
|
|
case AMDGPU::S_AND_B64:
|
|
|
|
case AMDGPU::S_OR_B64:
|
|
|
|
case AMDGPU::S_XOR_B64:
|
|
|
|
case AMDGPU::S_ANDN2_B64:
|
|
|
|
case AMDGPU::S_ORN2_B64:
|
|
|
|
case AMDGPU::S_NAND_B64:
|
|
|
|
case AMDGPU::S_NOR_B64:
|
|
|
|
case AMDGPU::S_XNOR_B64: {
|
|
|
|
const MachineOperand &Src1 = MI.getOperand(1);
|
|
|
|
if (Src1.isReg() && Src1.getReg() == AMDGPU::EXEC)
|
|
|
|
return MI.getOperand(0).getReg();
|
|
|
|
const MachineOperand &Src2 = MI.getOperand(2);
|
|
|
|
if (Src2.isReg() && Src2.getReg() == AMDGPU::EXEC)
|
|
|
|
return MI.getOperand(0).getReg();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return AMDGPU::NoRegister;
|
|
|
|
}
|
|
|
|
|
2016-09-29 09:44:16 +08:00
|
|
|
static unsigned getSaveExecOp(unsigned Opc) {
|
|
|
|
switch (Opc) {
|
|
|
|
case AMDGPU::S_AND_B64:
|
|
|
|
return AMDGPU::S_AND_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_OR_B64:
|
|
|
|
return AMDGPU::S_OR_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_XOR_B64:
|
|
|
|
return AMDGPU::S_XOR_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_ANDN2_B64:
|
|
|
|
return AMDGPU::S_ANDN2_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_ORN2_B64:
|
|
|
|
return AMDGPU::S_ORN2_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_NAND_B64:
|
|
|
|
return AMDGPU::S_NAND_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_NOR_B64:
|
|
|
|
return AMDGPU::S_NOR_SAVEEXEC_B64;
|
|
|
|
case AMDGPU::S_XNOR_B64:
|
|
|
|
return AMDGPU::S_XNOR_SAVEEXEC_B64;
|
|
|
|
default:
|
|
|
|
return AMDGPU::INSTRUCTION_LIST_END;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// These are only terminators to get correct spill code placement during
|
|
|
|
// register allocation, so turn them back into normal instructions. Only one of
|
|
|
|
// these is expected per block.
|
|
|
|
static bool removeTerminatorBit(const SIInstrInfo &TII, MachineInstr &MI) {
|
|
|
|
switch (MI.getOpcode()) {
|
|
|
|
case AMDGPU::S_MOV_B64_term: {
|
|
|
|
MI.setDesc(TII.get(AMDGPU::COPY));
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
case AMDGPU::S_XOR_B64_term: {
|
|
|
|
// This is only a terminator to get the correct spill code placement during
|
|
|
|
// register allocation.
|
|
|
|
MI.setDesc(TII.get(AMDGPU::S_XOR_B64));
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
case AMDGPU::S_ANDN2_B64_term: {
|
|
|
|
// This is only a terminator to get the correct spill code placement during
|
|
|
|
// register allocation.
|
|
|
|
MI.setDesc(TII.get(AMDGPU::S_ANDN2_B64));
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static MachineBasicBlock::reverse_iterator fixTerminators(
|
|
|
|
const SIInstrInfo &TII,
|
|
|
|
MachineBasicBlock &MBB) {
|
|
|
|
MachineBasicBlock::reverse_iterator I = MBB.rbegin(), E = MBB.rend();
|
|
|
|
for (; I != E; ++I) {
|
|
|
|
if (!I->isTerminator())
|
|
|
|
return I;
|
|
|
|
|
|
|
|
if (removeTerminatorBit(TII, *I))
|
|
|
|
return I;
|
|
|
|
}
|
|
|
|
|
|
|
|
return E;
|
|
|
|
}
|
|
|
|
|
|
|
|
static MachineBasicBlock::reverse_iterator findExecCopy(
|
|
|
|
const SIInstrInfo &TII,
|
|
|
|
MachineBasicBlock &MBB,
|
|
|
|
MachineBasicBlock::reverse_iterator I,
|
|
|
|
unsigned CopyToExec) {
|
|
|
|
const unsigned InstLimit = 25;
|
|
|
|
|
|
|
|
auto E = MBB.rend();
|
|
|
|
for (unsigned N = 0; N <= InstLimit && I != E; ++I, ++N) {
|
|
|
|
unsigned CopyFromExec = isCopyFromExec(*I);
|
|
|
|
if (CopyFromExec != AMDGPU::NoRegister)
|
|
|
|
return I;
|
|
|
|
}
|
|
|
|
|
|
|
|
return E;
|
|
|
|
}
|
|
|
|
|
|
|
|
// XXX - Seems LivePhysRegs doesn't work correctly since it will incorrectly
|
|
|
|
// repor tthe register as unavailable because a super-register with a lane mask
|
|
|
|
// as unavailable.
|
|
|
|
static bool isLiveOut(const MachineBasicBlock &MBB, unsigned Reg) {
|
|
|
|
for (MachineBasicBlock *Succ : MBB.successors()) {
|
|
|
|
if (Succ->isLiveIn(Reg))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool SIOptimizeExecMasking::runOnMachineFunction(MachineFunction &MF) {
|
2017-12-16 06:22:58 +08:00
|
|
|
if (skipFunction(MF.getFunction()))
|
2017-10-11 04:48:36 +08:00
|
|
|
return false;
|
|
|
|
|
2018-07-12 04:59:01 +08:00
|
|
|
const GCNSubtarget &ST = MF.getSubtarget<GCNSubtarget>();
|
2016-09-29 09:44:16 +08:00
|
|
|
const SIRegisterInfo *TRI = ST.getRegisterInfo();
|
|
|
|
const SIInstrInfo *TII = ST.getInstrInfo();
|
|
|
|
|
|
|
|
// Optimize sequences emitted for control flow lowering. They are originally
|
|
|
|
// emitted as the separate operations because spill code may need to be
|
|
|
|
// inserted for the saved copy of exec.
|
|
|
|
//
|
|
|
|
// x = copy exec
|
|
|
|
// z = s_<op>_b64 x, y
|
|
|
|
// exec = copy z
|
|
|
|
// =>
|
|
|
|
// x = s_<op>_saveexec_b64 y
|
|
|
|
//
|
|
|
|
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
|
|
|
MachineBasicBlock::reverse_iterator I = fixTerminators(*TII, MBB);
|
|
|
|
MachineBasicBlock::reverse_iterator E = MBB.rend();
|
|
|
|
if (I == E)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
unsigned CopyToExec = isCopyToExec(*I);
|
|
|
|
if (CopyToExec == AMDGPU::NoRegister)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Scan backwards to find the def.
|
|
|
|
auto CopyToExecInst = &*I;
|
|
|
|
auto CopyFromExecInst = findExecCopy(*TII, MBB, I, CopyToExec);
|
2017-08-02 07:44:35 +08:00
|
|
|
if (CopyFromExecInst == E) {
|
|
|
|
auto PrepareExecInst = std::next(I);
|
|
|
|
if (PrepareExecInst == E)
|
|
|
|
continue;
|
|
|
|
// Fold exec = COPY (S_AND_B64 reg, exec) -> exec = S_AND_B64 reg, exec
|
|
|
|
if (CopyToExecInst->getOperand(1).isKill() &&
|
|
|
|
isLogicalOpOnExec(*PrepareExecInst) == CopyToExec) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Fold exec copy: " << *PrepareExecInst);
|
2017-08-02 07:44:35 +08:00
|
|
|
|
|
|
|
PrepareExecInst->getOperand(0).setReg(AMDGPU::EXEC);
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "into: " << *PrepareExecInst << '\n');
|
2017-08-02 07:44:35 +08:00
|
|
|
|
|
|
|
CopyToExecInst->eraseFromParent();
|
|
|
|
}
|
|
|
|
|
2016-09-29 09:44:16 +08:00
|
|
|
continue;
|
2017-08-02 07:44:35 +08:00
|
|
|
}
|
2016-09-29 09:44:16 +08:00
|
|
|
|
|
|
|
if (isLiveOut(MBB, CopyToExec)) {
|
|
|
|
// The copied register is live out and has a second use in another block.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Exec copy source register is live out\n");
|
2016-09-29 09:44:16 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned CopyFromExec = CopyFromExecInst->getOperand(0).getReg();
|
|
|
|
MachineInstr *SaveExecInst = nullptr;
|
|
|
|
SmallVector<MachineInstr *, 4> OtherUseInsts;
|
|
|
|
|
|
|
|
for (MachineBasicBlock::iterator J
|
|
|
|
= std::next(CopyFromExecInst->getIterator()), JE = I->getIterator();
|
|
|
|
J != JE; ++J) {
|
|
|
|
if (SaveExecInst && J->readsRegister(AMDGPU::EXEC, TRI)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "exec read prevents saveexec: " << *J << '\n');
|
2016-09-29 09:44:16 +08:00
|
|
|
// Make sure this is inserted after any VALU ops that may have been
|
|
|
|
// scheduled in between.
|
|
|
|
SaveExecInst = nullptr;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2017-11-14 10:16:54 +08:00
|
|
|
bool ReadsCopyFromExec = J->readsRegister(CopyFromExec, TRI);
|
|
|
|
|
2016-09-29 09:44:16 +08:00
|
|
|
if (J->modifiesRegister(CopyToExec, TRI)) {
|
|
|
|
if (SaveExecInst) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Multiple instructions modify "
|
|
|
|
<< printReg(CopyToExec, TRI) << '\n');
|
2016-09-29 09:44:16 +08:00
|
|
|
SaveExecInst = nullptr;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned SaveExecOp = getSaveExecOp(J->getOpcode());
|
|
|
|
if (SaveExecOp == AMDGPU::INSTRUCTION_LIST_END)
|
|
|
|
break;
|
|
|
|
|
2017-11-14 10:16:54 +08:00
|
|
|
if (ReadsCopyFromExec) {
|
2016-09-29 09:44:16 +08:00
|
|
|
SaveExecInst = &*J;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Found save exec op: " << *SaveExecInst << '\n');
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
continue;
|
2016-09-29 09:44:16 +08:00
|
|
|
} else {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs()
|
|
|
|
<< "Instruction does not read exec copy: " << *J << '\n');
|
2016-09-29 09:44:16 +08:00
|
|
|
break;
|
|
|
|
}
|
2017-11-14 10:16:54 +08:00
|
|
|
} else if (ReadsCopyFromExec && !SaveExecInst) {
|
|
|
|
// Make sure no other instruction is trying to use this copy, before it
|
|
|
|
// will be rewritten by the saveexec, i.e. hasOneUse. There may have
|
|
|
|
// been another use, such as an inserted spill. For example:
|
|
|
|
//
|
|
|
|
// %sgpr0_sgpr1 = COPY %exec
|
|
|
|
// spill %sgpr0_sgpr1
|
|
|
|
// %sgpr2_sgpr3 = S_AND_B64 %sgpr0_sgpr1
|
|
|
|
//
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Found second use of save inst candidate: " << *J
|
|
|
|
<< '\n');
|
2017-11-14 10:16:54 +08:00
|
|
|
break;
|
2016-09-29 09:44:16 +08:00
|
|
|
}
|
|
|
|
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
if (SaveExecInst && J->readsRegister(CopyToExec, TRI)) {
|
|
|
|
assert(SaveExecInst != &*J);
|
2016-09-29 09:44:16 +08:00
|
|
|
OtherUseInsts.push_back(&*J);
|
AMDGPU: Fix use-after-free in SIOptimizeExecMasking
Summary:
There was a bug with sequences like
s_mov_b64 s[0:1], exec
s_and_b64 s[2:3]<def>, s[0:1], s[2:3]<kill>
...
s_mov_b64_term exec, s[2:3]
because s[2:3] was defined and used in the same instruction, ending up with
SaveExecInst inside OtherUseInsts.
Note that the test case also exposes an unrelated bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98028
Reviewers: tstellarAMD, arsenm
Subscribers: kzhuravl, wdng, yaxunl, llvm-commits, tony-tye
Differential Revision: https://reviews.llvm.org/D25306
llvm-svn: 283528
2016-10-07 16:40:14 +08:00
|
|
|
}
|
2016-09-29 09:44:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!SaveExecInst)
|
|
|
|
continue;
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Insert save exec op: " << *SaveExecInst << '\n');
|
2016-09-29 09:44:16 +08:00
|
|
|
|
|
|
|
MachineOperand &Src0 = SaveExecInst->getOperand(1);
|
|
|
|
MachineOperand &Src1 = SaveExecInst->getOperand(2);
|
|
|
|
|
|
|
|
MachineOperand *OtherOp = nullptr;
|
|
|
|
|
|
|
|
if (Src0.isReg() && Src0.getReg() == CopyFromExec) {
|
|
|
|
OtherOp = &Src1;
|
|
|
|
} else if (Src1.isReg() && Src1.getReg() == CopyFromExec) {
|
|
|
|
if (!SaveExecInst->isCommutable())
|
|
|
|
break;
|
|
|
|
|
|
|
|
OtherOp = &Src0;
|
|
|
|
} else
|
|
|
|
llvm_unreachable("unexpected");
|
|
|
|
|
|
|
|
CopyFromExecInst->eraseFromParent();
|
|
|
|
|
|
|
|
auto InsPt = SaveExecInst->getIterator();
|
|
|
|
const DebugLoc &DL = SaveExecInst->getDebugLoc();
|
|
|
|
|
|
|
|
BuildMI(MBB, InsPt, DL, TII->get(getSaveExecOp(SaveExecInst->getOpcode())),
|
|
|
|
CopyFromExec)
|
|
|
|
.addReg(OtherOp->getReg());
|
|
|
|
SaveExecInst->eraseFromParent();
|
|
|
|
|
|
|
|
CopyToExecInst->eraseFromParent();
|
|
|
|
|
|
|
|
for (MachineInstr *OtherInst : OtherUseInsts) {
|
|
|
|
OtherInst->substituteRegister(CopyToExec, AMDGPU::EXEC,
|
[MachineOperand][Target] MachineOperand::isRenamable semantics changes
Summary:
Add a target option AllowRegisterRenaming that is used to opt in to
post-register-allocation renaming of registers. This is set to 0 by
default, which causes the hasExtraSrcRegAllocReq/hasExtraDstRegAllocReq
fields of all opcodes to be set to 1, causing
MachineOperand::isRenamable to always return false.
Set the AllowRegisterRenaming flag to 1 for all in-tree targets that
have lit tests that were effected by enabling COPY forwarding in
MachineCopyPropagation (AArch64, AMDGPU, ARM, Hexagon, Mips, PowerPC,
RISCV, Sparc, SystemZ and X86).
Add some more comments describing the semantics of the
MachineOperand::isRenamable function and how it is set and maintained.
Change isRenamable to check the operand's opcode
hasExtraSrcRegAllocReq/hasExtraDstRegAllocReq bit directly instead of
relying on it being consistently reflected in the IsRenamable bit
setting.
Clear the IsRenamable bit when changing an operand's register value.
Remove target code that was clearing the IsRenamable bit when changing
registers/opcodes now that this is done conservatively by default.
Change setting of hasExtraSrcRegAllocReq in AMDGPU target to be done in
one place covering all opcodes that have constant pipe read limit
restrictions.
Reviewers: qcolombet, MatzeB
Subscribers: aemerson, arsenm, jyknight, mcrosier, sdardis, nhaehnle, javed.absar, tpr, arichardson, kristof.beyls, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, niosHD, escha, nemanjai, llvm-commits
Differential Revision: https://reviews.llvm.org/D43042
llvm-svn: 325931
2018-02-24 02:25:08 +08:00
|
|
|
AMDGPU::NoSubRegister, *TRI);
|
2016-09-29 09:44:16 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
}
|