2019-10-29 02:39:45 +08:00
|
|
|
; RUN: llc < %s -mtriple=aarch64-pc-windows-msvc | FileCheck %s
|
|
|
|
|
; Control Flow Guard is currently only available on Windows
|
|
|
|
|
|
|
|
|
|
; Test that Control Flow Guard checks are correctly added when required.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
declare i32 @target_func()
|
|
|
|
|
|
|
|
|
|
|
Add support for __declspec(guard(nocf))
Summary:
Avoid using the `nocf_check` attribute with Control Flow Guard. Instead, use a
new `"guard_nocf"` function attribute to indicate that checks should not be
added on indirect calls within that function. Add support for
`__declspec(guard(nocf))` following the same syntax as MSVC.
Reviewers: rnk, dmajor, pcc, hans, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: aaron.ballman, tomrittervg, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D72167
2020-01-10 19:08:18 +08:00
|
|
|
; Test that Control Flow Guard checks are not added on calls with the "guard_nocf" attribute.
|
|
|
|
|
define i32 @func_guard_nocf() {
|
2019-10-29 02:39:45 +08:00
|
|
|
entry:
|
|
|
|
|
%func_ptr = alloca i32 ()*, align 8
|
|
|
|
|
store i32 ()* @target_func, i32 ()** %func_ptr, align 8
|
|
|
|
|
%0 = load i32 ()*, i32 ()** %func_ptr, align 8
|
Add support for __declspec(guard(nocf))
Summary:
Avoid using the `nocf_check` attribute with Control Flow Guard. Instead, use a
new `"guard_nocf"` function attribute to indicate that checks should not be
added on indirect calls within that function. Add support for
`__declspec(guard(nocf))` following the same syntax as MSVC.
Reviewers: rnk, dmajor, pcc, hans, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: aaron.ballman, tomrittervg, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D72167
2020-01-10 19:08:18 +08:00
|
|
|
%1 = call i32 %0() #0
|
2019-10-29 02:39:45 +08:00
|
|
|
ret i32 %1
|
|
|
|
|
|
Add support for __declspec(guard(nocf))
Summary:
Avoid using the `nocf_check` attribute with Control Flow Guard. Instead, use a
new `"guard_nocf"` function attribute to indicate that checks should not be
added on indirect calls within that function. Add support for
`__declspec(guard(nocf))` following the same syntax as MSVC.
Reviewers: rnk, dmajor, pcc, hans, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: aaron.ballman, tomrittervg, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D72167
2020-01-10 19:08:18 +08:00
|
|
|
; CHECK-LABEL: func_guard_nocf
|
2019-10-29 02:39:45 +08:00
|
|
|
; CHECK: adrp x8, target_func
|
|
|
|
|
; CHECK: add x8, x8, target_func
|
|
|
|
|
; CHECK-NOT: __guard_check_icall_fptr
|
|
|
|
|
; CHECK: blr x8
|
|
|
|
|
}
|
Add support for __declspec(guard(nocf))
Summary:
Avoid using the `nocf_check` attribute with Control Flow Guard. Instead, use a
new `"guard_nocf"` function attribute to indicate that checks should not be
added on indirect calls within that function. Add support for
`__declspec(guard(nocf))` following the same syntax as MSVC.
Reviewers: rnk, dmajor, pcc, hans, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: aaron.ballman, tomrittervg, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D72167
2020-01-10 19:08:18 +08:00
|
|
|
attributes #0 = { "guard_nocf" }
|
2019-10-29 02:39:45 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
; Test that Control Flow Guard checks are added even at -O0.
|
|
|
|
|
define i32 @func_optnone_cf() #1 {
|
|
|
|
|
entry:
|
|
|
|
|
%func_ptr = alloca i32 ()*, align 8
|
|
|
|
|
store i32 ()* @target_func, i32 ()** %func_ptr, align 8
|
|
|
|
|
%0 = load i32 ()*, i32 ()** %func_ptr, align 8
|
|
|
|
|
%1 = call i32 %0()
|
|
|
|
|
ret i32 %1
|
|
|
|
|
|
|
|
|
|
; The call to __guard_check_icall_fptr should come immediately before the call to the target function.
|
|
|
|
|
; CHECK-LABEL: func_optnone_cf
|
|
|
|
|
; CHECK: adrp x8, target_func
|
|
|
|
|
; CHECK: add x8, x8, target_func
|
[FastISel] Flush local value map on ever instruction
Local values are constants or addresses that can't be folded into
the instruction that uses them. FastISel materializes these in a
"local value" area that always dominates the current insertion
point, to try to avoid materializing these values more than once
(per block).
https://reviews.llvm.org/D43093 added code to sink these local
value instructions to their first use, which has two beneficial
effects. One, it is likely to avoid some unnecessary spills and
reloads; two, it allows us to attach the debug location of the
user to the local value instruction. The latter effect can
improve the debugging experience for debuggers with a "set next
statement" feature, such as the Visual Studio debugger and PS4
debugger, because instructions to set up constants for a given
statement will be associated with the appropriate source line.
There are also some constants (primarily addresses) that could be
produced by no-op casts or GEP instructions; the main difference
from "local value" instructions is that these are values from
separate IR instructions, and therefore could have multiple users
across multiple basic blocks. D43093 avoided sinking these, even
though they were emitted to the same "local value" area as the
other instructions. The patch comment for D43093 states:
Local values may also be used by no-op casts, which adds the
register to the RegFixups table. Without reversing the RegFixups
map direction, we don't have enough information to sink these
instructions.
This patch undoes most of D43093, and instead flushes the local
value map after(*) every IR instruction, using that instruction's
debug location. This avoids sometimes incorrect locations used
previously, and emits instructions in a more natural order.
This does mean materialized values are not re-used across IR
instruction boundaries; however, only about 5% of those values
were reused in an experimental self-build of clang.
(*) Actually, just prior to the next instruction. It seems like
it would be cleaner the other way, but I was having trouble
getting that to work.
Differential Revision: https://reviews.llvm.org/D91734
2020-11-19 05:27:14 +08:00
|
|
|
; CHECK: adrp x9, __guard_check_icall_fptr
|
|
|
|
|
; CHECK: add x9, x9, __guard_check_icall_fptr
|
2019-10-29 02:39:45 +08:00
|
|
|
; CHECK: ldr x9, [x9]
|
|
|
|
|
; CHECK: mov x15, x8
|
|
|
|
|
; CHECK: blr x9
|
|
|
|
|
; CHECK-NEXT: blr x8
|
|
|
|
|
}
|
|
|
|
|
attributes #1 = { noinline optnone }
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
; Test that Control Flow Guard checks are correctly added in optimized code (common case).
|
|
|
|
|
define i32 @func_cf() {
|
|
|
|
|
entry:
|
|
|
|
|
%func_ptr = alloca i32 ()*, align 8
|
|
|
|
|
store i32 ()* @target_func, i32 ()** %func_ptr, align 8
|
|
|
|
|
%0 = load i32 ()*, i32 ()** %func_ptr, align 8
|
|
|
|
|
%1 = call i32 %0()
|
|
|
|
|
ret i32 %1
|
|
|
|
|
|
|
|
|
|
; The call to __guard_check_icall_fptr should come immediately before the call to the target function.
|
|
|
|
|
; CHECK-LABEL: func_cf
|
|
|
|
|
; CHECK: adrp x8, __guard_check_icall_fptr
|
|
|
|
|
; CHECK: ldr x9, [x8, __guard_check_icall_fptr]
|
|
|
|
|
; CHECK: adrp x8, target_func
|
|
|
|
|
; CHECK: add x8, x8, target_func
|
|
|
|
|
; CHECK: mov x15, x8
|
|
|
|
|
; CHECK: blr x9
|
|
|
|
|
; CHECK-NEXT: blr x8
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
; Test that Control Flow Guard checks are correctly added on invoke instructions.
|
|
|
|
|
define i32 @func_cf_invoke() personality i8* bitcast (void ()* @h to i8*) {
|
|
|
|
|
entry:
|
|
|
|
|
%0 = alloca i32, align 4
|
|
|
|
|
%func_ptr = alloca i32 ()*, align 8
|
|
|
|
|
store i32 ()* @target_func, i32 ()** %func_ptr, align 8
|
|
|
|
|
%1 = load i32 ()*, i32 ()** %func_ptr, align 8
|
|
|
|
|
%2 = invoke i32 %1()
|
|
|
|
|
to label %invoke.cont unwind label %lpad
|
|
|
|
|
invoke.cont: ; preds = %entry
|
|
|
|
|
ret i32 %2
|
|
|
|
|
|
|
|
|
|
lpad: ; preds = %entry
|
|
|
|
|
%tmp = landingpad { i8*, i32 }
|
|
|
|
|
catch i8* null
|
|
|
|
|
ret i32 -1
|
|
|
|
|
|
|
|
|
|
; The call to __guard_check_icall_fptr should come immediately before the call to the target function.
|
|
|
|
|
; CHECK-LABEL: func_cf_invoke
|
|
|
|
|
; CHECK: adrp x8, __guard_check_icall_fptr
|
|
|
|
|
; CHECK: ldr x9, [x8, __guard_check_icall_fptr]
|
|
|
|
|
; CHECK: adrp x8, target_func
|
|
|
|
|
; CHECK: add x8, x8, target_func
|
|
|
|
|
; CHECK: mov x15, x8
|
|
|
|
|
; CHECK: blr x9
|
|
|
|
|
; CHECK-NEXT: .Ltmp0:
|
|
|
|
|
; CHECK-NEXT: blr x8
|
|
|
|
|
; CHECK: ; %invoke.cont
|
|
|
|
|
; CHECK: ; %lpad
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
declare void @h()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
; Test that longjmp targets have public labels and are included in the .gljmp section.
|
|
|
|
|
%struct._SETJMP_FLOAT128 = type { [2 x i64] }
|
|
|
|
|
@buf1 = internal global [16 x %struct._SETJMP_FLOAT128] zeroinitializer, align 16
|
|
|
|
|
|
|
|
|
|
define i32 @func_cf_setjmp() {
|
|
|
|
|
%1 = alloca i32, align 4
|
|
|
|
|
%2 = alloca i32, align 4
|
|
|
|
|
store i32 0, i32* %1, align 4
|
|
|
|
|
store i32 -1, i32* %2, align 4
|
|
|
|
|
%3 = call i8* @llvm.frameaddress(i32 0)
|
|
|
|
|
%4 = call i32 @_setjmp(i8* bitcast ([16 x %struct._SETJMP_FLOAT128]* @buf1 to i8*), i8* %3) #2
|
|
|
|
|
|
|
|
|
|
; CHECK-LABEL: func_cf_setjmp
|
|
|
|
|
; CHECK: bl _setjmp
|
|
|
|
|
; CHECK-NEXT: $cfgsj_func_cf_setjmp0:
|
|
|
|
|
|
|
|
|
|
%5 = call i8* @llvm.frameaddress(i32 0)
|
|
|
|
|
%6 = call i32 @_setjmp(i8* bitcast ([16 x %struct._SETJMP_FLOAT128]* @buf1 to i8*), i8* %5) #3
|
|
|
|
|
|
|
|
|
|
; CHECK: bl _setjmp
|
|
|
|
|
; CHECK-NEXT: $cfgsj_func_cf_setjmp1:
|
|
|
|
|
|
|
|
|
|
store i32 1, i32* %2, align 4
|
|
|
|
|
%7 = load i32, i32* %2, align 4
|
|
|
|
|
ret i32 %7
|
|
|
|
|
|
|
|
|
|
; CHECK: .section .gljmp$y,"dr"
|
|
|
|
|
; CHECK-NEXT: .symidx $cfgsj_func_cf_setjmp0
|
|
|
|
|
; CHECK-NEXT: .symidx $cfgsj_func_cf_setjmp1
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
declare i8* @llvm.frameaddress(i32)
|
|
|
|
|
|
|
|
|
|
; Function Attrs: returns_twice
|
|
|
|
|
declare dso_local i32 @_setjmp(i8*, i8*) #2
|
|
|
|
|
|
|
|
|
|
attributes #2 = { returns_twice }
|
|
|
|
|
attributes #3 = { returns_twice }
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
!llvm.module.flags = !{!0}
|
|
|
|
|
!0 = !{i32 2, !"cfguard", i32 2}
|