[mips] Pick the right variant of DINS upfront and enable target instruction verification
This patch complements D16810 "[mips] Make isel select the correct DEXT variant
up front.". Now ISel picks the right variant of DINS, so now there is no need
to replace DINS with the appropriate variant during
MipsMCCodeEmitter::encodeInstruction().
This patch also enables target specific instruction verification for ins, dins,
dinsm, dinsu, ext, dext, dextm, dextu. These instructions have constraints that
are checked when generating MipsISD::Ins and MipsISD::Ext nodes, but these
constraints are not checked during instruction selection. Adding machine
verification should catch outstanding cases.
Finally, correct a bug that instruction verification uncovered, where the
position operand of a DINSU generated during lowering was being silently
and accidently corrected to the correct value.
Reviewers: slthakur
Differential Revision: https://reviews.llvm.org/D34809
llvm-svn: 313254
2017-09-14 18:58:00 +08:00
|
|
|
# RUN: not llc -march=mips64 -mcpu=mips64r2 -start-after=expand-isel-pseudos -stop-after=expand-isel-pseudos \
|
|
|
|
|
# RUN: -verify-machineinstrs %s -o - 2>&1 | FileCheck %s
|
|
|
|
|
|
|
|
|
|
# CHECK: Size operand is out of range!
|
|
|
|
|
|
2017-12-18 20:30:34 +08:00
|
|
|
# Check that the machine verifier checks the size operand is in range 2..64
|
[mips] Pick the right variant of DINS upfront and enable target instruction verification
This patch complements D16810 "[mips] Make isel select the correct DEXT variant
up front.". Now ISel picks the right variant of DINS, so now there is no need
to replace DINS with the appropriate variant during
MipsMCCodeEmitter::encodeInstruction().
This patch also enables target specific instruction verification for ins, dins,
dinsm, dinsu, ext, dext, dextm, dextu. These instructions have constraints that
are checked when generating MipsISD::Ins and MipsISD::Ext nodes, but these
constraints are not checked during instruction selection. Adding machine
verification should catch outstanding cases.
Finally, correct a bug that instruction verification uncovered, where the
position operand of a DINSU generated during lowering was being silently
and accidently corrected to the correct value.
Reviewers: slthakur
Differential Revision: https://reviews.llvm.org/D34809
llvm-svn: 313254
2017-09-14 18:58:00 +08:00
|
|
|
---
|
|
|
|
|
name: dinsm
|
|
|
|
|
alignment: 3
|
|
|
|
|
exposesReturnsTwice: false
|
|
|
|
|
legalized: false
|
|
|
|
|
regBankSelected: false
|
|
|
|
|
selected: false
|
|
|
|
|
tracksRegLiveness: true
|
|
|
|
|
registers:
|
|
|
|
|
- { id: 0, class: gpr64, preferred-register: '' }
|
|
|
|
|
- { id: 1, class: gpr64, preferred-register: '' }
|
|
|
|
|
liveins:
|
|
|
|
|
- { reg: '%a0_64', virtual-reg: '%0' }
|
|
|
|
|
frameInfo:
|
|
|
|
|
isFrameAddressTaken: false
|
|
|
|
|
isReturnAddressTaken: false
|
|
|
|
|
hasStackMap: false
|
|
|
|
|
hasPatchPoint: false
|
|
|
|
|
stackSize: 0
|
|
|
|
|
offsetAdjustment: 0
|
|
|
|
|
maxAlignment: 1
|
|
|
|
|
adjustsStack: false
|
|
|
|
|
hasCalls: false
|
|
|
|
|
stackProtector: ''
|
|
|
|
|
maxCallFrameSize: 4294967295
|
|
|
|
|
hasOpaqueSPAdjustment: false
|
|
|
|
|
hasVAStart: false
|
|
|
|
|
hasMustTailInVarArgFunc: false
|
|
|
|
|
savePoint: ''
|
|
|
|
|
restorePoint: ''
|
|
|
|
|
fixedStack:
|
|
|
|
|
stack:
|
|
|
|
|
constants:
|
|
|
|
|
body: |
|
|
|
|
|
bb.0.entry:
|
|
|
|
|
liveins: %a0_64
|
|
|
|
|
|
|
|
|
|
%0 = COPY %a0_64
|
|
|
|
|
%1 = DINSM %0, 31, 67
|
|
|
|
|
%v0_64 = COPY %1
|
|
|
|
|
RetRA implicit %v0_64
|
|
|
|
|
|
|
|
|
|
...
|
