maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Transforms/CodeExtractor/unreachable-block.ll

37 lines
823 B
LLVM
Raw Normal View History

[PartialInliner] Fix crash when inlining functions with unreachable blocks. CodeExtractor looks up the dominator node corresponding to return blocks when splitting them. If one of these blocks is unreachable, there's no node in the Dom and CodeExtractor crashes because it doesn't check for domtree node validity. In theory, we could add just a check for skipping null DTNodes in `splitReturnBlock` but the fix I propose here is slightly different. To the best of my knowledge, unreachable blocks are irrelevant for the algorithm, therefore we can just skip them when building the candidate set in the constructor. Differential Revision: https://reviews.llvm.org/D32335 llvm-svn: 300946
2017-04-21 12:25:00 +08:00
; RUN: opt -S -partial-inliner %s | FileCheck %s
; CHECK-LABEL: define void @dipsy(
; CHECK-NEXT: call void @tinkywinky.1_ontrue()
; CHECK-NEXT: call void @patatuccio()
; CHECK-NEXT: ret void
; CHECK-NEXT: }
; CHECK-LABEL: define internal void @tinkywinky.1_ontrue() {
; CHECK-NEXT: newFuncRoot:
; CHECK-NEXT: br label %ontrue
[PartialInlining]: Improve partial inlining to handle complex conditions Differential Revision: http://reviews.llvm.org/D32249 llvm-svn: 301561
2017-04-28 00:34:00 +08:00
; CHECK: onfalse{{.*}}:
[PartialInliner] Fix crash when inlining functions with unreachable blocks. CodeExtractor looks up the dominator node corresponding to return blocks when splitting them. If one of these blocks is unreachable, there's no node in the Dom and CodeExtractor crashes because it doesn't check for domtree node validity. In theory, we could add just a check for skipping null DTNodes in `splitReturnBlock` but the fix I propose here is slightly different. To the best of my knowledge, unreachable blocks are irrelevant for the algorithm, therefore we can just skip them when building the candidate set in the constructor. Differential Revision: https://reviews.llvm.org/D32335 llvm-svn: 300946
2017-04-21 12:25:00 +08:00
; CHECK-NEXT: ret void
; CHECK: ontrue:
; CHECK-NEXT: call void @patatino()
[PartialInlining]: Improve partial inlining to handle complex conditions Differential Revision: http://reviews.llvm.org/D32249 llvm-svn: 301561
2017-04-28 00:34:00 +08:00
; CHECK-NEXT: br label %onfalse{{.*}}
[PartialInliner] Fix crash when inlining functions with unreachable blocks. CodeExtractor looks up the dominator node corresponding to return blocks when splitting them. If one of these blocks is unreachable, there's no node in the Dom and CodeExtractor crashes because it doesn't check for domtree node validity. In theory, we could add just a check for skipping null DTNodes in `splitReturnBlock` but the fix I propose here is slightly different. To the best of my knowledge, unreachable blocks are irrelevant for the algorithm, therefore we can just skip them when building the candidate set in the constructor. Differential Revision: https://reviews.llvm.org/D32335 llvm-svn: 300946
2017-04-21 12:25:00 +08:00
; CHECK-NEXT: }
declare void @patatino()
declare void @patatuccio()
define fastcc void @tinkywinky() {
br i1 true, label %ontrue, label %onfalse
ontrue:
call void @patatino()
br label %onfalse
onfalse:
call void @patatuccio()
ret void
cantreachme:
ret void
}
define void @dipsy() {
call fastcc void @tinkywinky()
ret void
}