2009-11-09 14:52:44 +08:00
|
|
|
//=== FixedAddressChecker.cpp - Fixed address usage checker ----*- C++ -*--===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2009-11-09 14:52:44 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This files defines FixedAddressChecker, a builtin checker that checks for
|
|
|
|
// assignment of a fixed address to a pointer.
|
|
|
|
// This check corresponds to CWE-587.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
[analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend
ClangCheckerRegistry is a very non-obvious, poorly documented, weird concept.
It derives from CheckerRegistry, and is placed in lib/StaticAnalyzer/Frontend,
whereas it's base is located in lib/StaticAnalyzer/Core. It was, from what I can
imagine, used to circumvent the problem that the registry functions of the
checkers are located in the clangStaticAnalyzerCheckers library, but that
library depends on clangStaticAnalyzerCore. However, clangStaticAnalyzerFrontend
depends on both of those libraries.
One can make the observation however, that CheckerRegistry has no place in Core,
it isn't used there at all! The only place where it is used is Frontend, which
is where it ultimately belongs.
This move implies that since
include/clang/StaticAnalyzer/Checkers/ClangCheckers.h only contained a single function:
class CheckerRegistry;
void registerBuiltinCheckers(CheckerRegistry ®istry);
it had to re purposed, as CheckerRegistry is no longer available to
clangStaticAnalyzerCheckers. It was renamed to BuiltinCheckerRegistration.h,
which actually describes it a lot better -- it does not contain the registration
functions for checkers, but only those generated by the tblgen files.
Differential Revision: https://reviews.llvm.org/D54436
llvm-svn: 349275
2018-12-16 00:23:51 +08:00
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
2011-03-01 09:16:21 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
2011-02-18 05:39:17 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
2011-02-23 09:05:36 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
2009-11-09 14:52:44 +08:00
|
|
|
|
|
|
|
using namespace clang;
|
2010-12-23 15:20:52 +08:00
|
|
|
using namespace ento;
|
2009-11-09 14:52:44 +08:00
|
|
|
|
|
|
|
namespace {
|
2015-09-08 11:50:52 +08:00
|
|
|
class FixedAddressChecker
|
2011-03-01 09:16:21 +08:00
|
|
|
: public Checker< check::PreStmt<BinaryOperator> > {
|
2014-03-08 04:03:18 +08:00
|
|
|
mutable std::unique_ptr<BuiltinBug> BT;
|
2011-02-23 09:05:36 +08:00
|
|
|
|
2009-11-09 14:52:44 +08:00
|
|
|
public:
|
2011-02-23 09:05:36 +08:00
|
|
|
void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
|
2009-11-09 14:52:44 +08:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2011-02-23 09:05:36 +08:00
|
|
|
void FixedAddressChecker::checkPreStmt(const BinaryOperator *B,
|
|
|
|
CheckerContext &C) const {
|
2009-11-09 14:52:44 +08:00
|
|
|
// Using a fixed address is not portable because that address will probably
|
|
|
|
// not be valid in all environments or platforms.
|
|
|
|
|
2010-08-25 19:45:40 +08:00
|
|
|
if (B->getOpcode() != BO_Assign)
|
2009-11-09 14:52:44 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
QualType T = B->getType();
|
|
|
|
if (!T->isPointerType())
|
|
|
|
return;
|
|
|
|
|
2018-01-18 04:27:29 +08:00
|
|
|
SVal RV = C.getSVal(B->getRHS());
|
2009-11-09 14:52:44 +08:00
|
|
|
|
|
|
|
if (!RV.isConstant() || RV.isZeroConstant())
|
|
|
|
return;
|
|
|
|
|
2015-09-17 06:03:05 +08:00
|
|
|
if (ExplodedNode *N = C.generateNonFatalErrorNode()) {
|
2009-11-09 14:52:44 +08:00
|
|
|
if (!BT)
|
2014-02-12 05:49:21 +08:00
|
|
|
BT.reset(
|
|
|
|
new BuiltinBug(this, "Use fixed address",
|
|
|
|
"Using a fixed address is not portable because that "
|
|
|
|
"address will probably not be valid in all "
|
|
|
|
"environments or platforms."));
|
2015-06-23 21:15:32 +08:00
|
|
|
auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), N);
|
2009-11-09 14:52:44 +08:00
|
|
|
R->addRange(B->getRHS()->getSourceRange());
|
2015-06-23 21:15:32 +08:00
|
|
|
C.emitReport(std::move(R));
|
2009-11-09 14:52:44 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-02-18 05:39:17 +08:00
|
|
|
void ento::registerFixedAddressChecker(CheckerManager &mgr) {
|
2011-02-23 09:05:36 +08:00
|
|
|
mgr.registerChecker<FixedAddressChecker>();
|
2011-02-18 05:39:17 +08:00
|
|
|
}
|